From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EA14C64ED6 for ; Wed, 1 Mar 2023 18:40:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 087386B0073; Wed, 1 Mar 2023 13:40:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0378E6B0074; Wed, 1 Mar 2023 13:40:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E40FA6B0075; Wed, 1 Mar 2023 13:40:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D1BDB6B0073 for ; Wed, 1 Mar 2023 13:40:19 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 818D280B25 for ; Wed, 1 Mar 2023 18:40:19 +0000 (UTC) X-FDA: 80521194558.14.87EFEF5 Received: from mail-yw1-f169.google.com (mail-yw1-f169.google.com [209.85.128.169]) by imf08.hostedemail.com (Postfix) with ESMTP id B0D44160024 for ; Wed, 1 Mar 2023 18:40:17 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=COdiTXCT; spf=pass (imf08.hostedemail.com: domain of surenb@google.com designates 209.85.128.169 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677696017; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0VNgf/r1TnHipquaSqm1nBgcfCj1sznNvb3fMKCfdzk=; b=iCS6in0GuUr4GKH6q436g1YrPOv83cyCV8Snhaue+LDP5RZTdnqb7hnQJ999WScRd8hDot Xt6u3yndfSFuB3HzFzipCGFUozm8p0cFMuNRfNvJ12flmer+CFOybfufWy/Dnv4xqTTJDj IOinoIXfdemqjzRu55RkTtupfMM5pZ8= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=COdiTXCT; spf=pass (imf08.hostedemail.com: domain of surenb@google.com designates 209.85.128.169 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677696017; a=rsa-sha256; cv=none; b=Ig5EsD2zoEHtQ9S9I4B9/4Vo/JBrY8a47dh8ECCJ9FFXJU0OaMAevVjWYeLf6TN5baWnNf b1ECOn1vfIa5AzGN9Xo1ETnj40QS9TLss4jTWbv2We8CkQ86g57Mmb75BIG0cyAd68WNc6 H+d37IqgR0wBbXqXCQ7oVTP+Ee+62Y4= Received: by mail-yw1-f169.google.com with SMTP id 00721157ae682-53916ab0c6bso381098967b3.7 for ; Wed, 01 Mar 2023 10:40:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1677696017; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=0VNgf/r1TnHipquaSqm1nBgcfCj1sznNvb3fMKCfdzk=; b=COdiTXCTNt65uxq2qiDXYzfPtnXK1e4ui6Q+vUpUn8iwglyQFGsBmRbIApA3qffQE9 CWYk1Ea125YBWTqc9drTxqJWMMhBNLfJXyUfM2xFbiIvYFEM8NTWo9EcvoXpGPLzmDQu N5dJ7eEJRPWkmZEu0Tcd2cXRavT48kX3cTotQhqznDkkzebA1Rnh8bfLFbV/Ijl9DptM toDwFGvlYoQWsqC5klnDfy25CN+wNfIOdeX3fxh97zq3LMzUERHqE5kkSCysr/KxuYPP DneIapDgvV0LtVULE9BmwlCaPnwjpOvSGRHXO7IsZMo4f/eRMa/2ZuD3czVvUo4ScYMC lBIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677696017; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0VNgf/r1TnHipquaSqm1nBgcfCj1sznNvb3fMKCfdzk=; b=PS28sgT4Rf/CBnFpaFb3xdi2mX5PPYkCEAllgqTzfE6iYOLicxbi4n4hgiUSshwuLU b/fgH0F7YldlRXkgrANaSm8ywQz3BKeMdBaT7joqXq/F72JTZCDeZeZrwL/95Ci3/TfQ W2RX/jWz4lqNd7xISHv0O9YZsVkQDcxdW/PIpz6O+ioezdmBNiYbnQ4I6QK07Z4/tImZ 4oxgGjnpQPvXjtEISwjpmlaCHyxnOUWOa7KkHEHDIZulzYl5aAwjq3FYCb2ENCRb17Dx 5AbRm+lFh2FO+gdR3Z2u2pu7o6T0qBP889v1NIRwSkT/RdBkpE0lEDcNAGOB4E07yPPR QTsg== X-Gm-Message-State: AO0yUKUFY4iCwZthy4yU9Tf6P0TqgVEMuLEvHpZl2f9kHfMAvwAKuGRb MqnKhopXjPbC8bjZtfWTJ3WXzAMjqU7RMADt9/V0xA== X-Google-Smtp-Source: AK7set917PtkuTxnpZfLzH1CxVeaDGB1+cZ2cTzi1+wqXN1JwkwDK1ULzLkfsF5xRlj0xmQuZW3wtq/Msi8QimPbukM= X-Received: by 2002:a05:690c:f0d:b0:52e:e8b1:d51e with SMTP id dc13-20020a05690c0f0d00b0052ee8b1d51emr7425595ywb.1.1677696016742; Wed, 01 Mar 2023 10:40:16 -0800 (PST) MIME-Version: 1.0 References: <20230301014651.1370939-1-surenb@google.com> In-Reply-To: From: Suren Baghdasaryan Date: Wed, 1 Mar 2023 10:40:05 -0800 Message-ID: Subject: Re: [PATCH 1/1] cgroup: limit cgroup psi file writes to processes with CAP_SYS_RESOURCE To: Michal Hocko Cc: tj@kernel.org, hannes@cmpxchg.org, lizefan.x@bytedance.com, peterz@infradead.org, johunt@akamai.com, quic_sudaraja@quicinc.com, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: B0D44160024 X-Rspam-User: X-Stat-Signature: bs8be95x1senjk3tcgpoassgoz6tp1wb X-HE-Tag: 1677696017-800122 X-HE-Meta: U2FsdGVkX1/t2+AxBod2scrl9Cp9x9GzRULpijzTiu0fVIFQFhekncn6owIxfdHpuhPmb0vrERWGtlbFTGw8vhcInlFges0VXGKp0mdn5Ux+iZm33DH/+3gq3sjACxQPGou2Wc2p3C0I5TNEo9F/6g4ux2dHjhUmMA9UVXWLzLiISasAImdoaih/domW6hzc4bu8xnQHmrxK8TW/vR+aWAFuDC8pmlpCbmdiYtMy5Qi4GUolBW7fxe6LjRWO4jLEa8NtKSZgZbaHc8X68VNUDxioqE2oH6zH+gj3MJ+sns3YMX4eEVI8YhAUTbSa7z3ywZZKmomooeb7+T7yBcc3d7nuHpUbR+7mIA5m1sWyHCpFp7Vy0ahwd2X08OjVeeGNoppBGmQw7s9+SG+V2mn/pjn+GkXYmucy7X0FN3iOPrlYOF+demA38eO7C5a3ryJqBH1iLH0hOlkk9W8NlZMtX0SUdfq1h6ksauueCv4zHtk6ipi9Ind/rbyrMyA8uXpkLYV5OghlC1iDF8Js2ATry+z7mxrAyW2u8ZPMg6rjy2pmBgyuqC0F2n1x53h9QXa+uTL1dSUh9yot4ZluEPe9mJ6z+n3kDdG/EXJ2slAGwPWJ3ythCJVB99ZHe4I1Z859vODlCraM9KVD7Pk54fYR8f/GrRuG7CrDrPbx4WS716cwsDxi5NDNRaQAXFcNYAsj7ZsEXxleCuwvZ1WuJzvR7pCpnJ2ZxN3qONkRGc/zYITYdrc/3r/khmYedrSMlNCMWiZtkovvgutEmWZ77y0jVslA8vi/4lQvpkqX/f9mHL/d5kOX8TsRE1zQeKyZ6IjZoMNnXx0f6dypWDF54ktsB+6A4jZ0OCHWZkhRIMGKqYXOK9PpeW1RR7FPquZT+5z35SpCcoYR7tHGtnys8tk/sG/J8rvyvyW50fzqutvKEmIU7OBA3FK17+3iZch6qnRP9UXPdlAsRjUYq+DdcZL BdysYkeC kvX2IobH8xD6fG7mUoffDHmjY4Eu8gd9FaschDga8rhgNbbIJMN+7JT9RSaJ63TYYfUtlxGuC2hFVzDl/Q2BsceP5LKDfVaB58dMCYi3QReQ94pvUp1IeTceZ24Q9TamSMvi1i8LqcxyS+6Akzr6rFdQjxCqXzYOXmAypSv4IBuqqmpC0jXljjxO7XDqQ+doo2+KTc/rkxzeTfi7Yh6jo2w/ZT/9RK/Vg5a9FRh5CcATI1hlxQACbp57oidMcHZXEdkkuVRMe6qLQp6G6ERpoVzfBskw7amqKSLYG91oIChOKSoA7C2r6S1R9FzLhdisVLi//gHVKzzFDpbKir7mhVLiVwq1/NG0+GwNI X-Bogosity: Ham, tests=bogofilter, spamicity=0.061975, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 1, 2023 at 10:35=E2=80=AFAM Michal Hocko wrot= e: > > On Wed 01-03-23 10:05:36, Suren Baghdasaryan wrote: > [...] > > Yes but hopefully my argument about keeping this and min period > > patches separate is reasonable? > > I am not questioning that. The practical advantage to squash the two > changes is that in case of the CAP_SYS_RESOURCE you do not have to > explicitly think about reverting the min constrain as well. I do not > think reverting one without the other is good. Ok, I'm fine with having both changes in the same patch. Will post v2 later today. Thanks! > > -- > Michal Hocko > SUSE Labs