From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0954C27C76 for ; Wed, 25 Jan 2023 19:22:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3A5AF6B0074; Wed, 25 Jan 2023 14:22:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2EBE56B0072; Wed, 25 Jan 2023 14:22:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 053C96B0078; Wed, 25 Jan 2023 14:22:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id DC0696B0072 for ; Wed, 25 Jan 2023 14:22:52 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id B292B80DE8 for ; Wed, 25 Jan 2023 19:22:52 +0000 (UTC) X-FDA: 80394293784.21.E1B737C Received: from mail-yw1-f179.google.com (mail-yw1-f179.google.com [209.85.128.179]) by imf05.hostedemail.com (Postfix) with ESMTP id E76B7100019 for ; Wed, 25 Jan 2023 19:22:50 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=hXTUs83q; spf=pass (imf05.hostedemail.com: domain of surenb@google.com designates 209.85.128.179 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674674571; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PCnMypYs8jymH6Ufuva+9r/69Y/DZs8kYxwQEYrzQFk=; b=OcidbCWGoIatXBG7PmEfVpayTXAhm+2MEKE4Tk2fGEcgLGOIEuuu1u/g09bJLkx7Kx3ucb W3Xn100KPyAIOggCcms3efwNsSXIVw8BN9kfPEXtqMvm3aEkCqIs8cCJuZU+0Mhge4VcPX wRiUg8wQARn8Jtd3LCgzZD2Fjwg3ptU= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=hXTUs83q; spf=pass (imf05.hostedemail.com: domain of surenb@google.com designates 209.85.128.179 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674674571; a=rsa-sha256; cv=none; b=8MTGa2d418DZyNFcb83KJBezBZJNm+DBiDRCCQ04DeSKbGPx3Wl12TPB7b+OpAlEF1W3WE +73XNArB2eqPLscf/LHD9922mXs3NbXwXcVLKyhT9zxUkeRpNB+5aCryfqd0/aAXyRG81v s/xAcp3FSmgDUTRt8wQ1Hdzkasbxxm4= Received: by mail-yw1-f179.google.com with SMTP id 00721157ae682-4c131bede4bso278071357b3.5 for ; Wed, 25 Jan 2023 11:22:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=PCnMypYs8jymH6Ufuva+9r/69Y/DZs8kYxwQEYrzQFk=; b=hXTUs83qvSMCw0sqrewtph/1zyRGQA8EwV9VOqASoIhN1O27YlTeLHvU30LwpkaPKE 6ZtbduOBpeU0Mk6yScQyxHGjdOZ8W8NbAK7HCSbKR2qQVwpslpoP2Mqh8DnM60UrkSEV Fy/rJx/xAj6ReR1yQheSDvUeiLsUOZe36GsXUe+/pA5dp4+pot+ScO1k5jhTafZOkoJo vEjMe7B3/0BupSIQn5CSlkYjolaKBFMYB73xyId061H8p1ZYZbkvvK9SPdZltanRDpUl vOuM+M/xFo7tmOP85pcv8h038+SVqlBqYWxO3Lgun0O5W06va+PJHK2pFsHgrhvmIiGL lvow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PCnMypYs8jymH6Ufuva+9r/69Y/DZs8kYxwQEYrzQFk=; b=vYE3OJeOzClJsedyHCqe65Zaa8RVrwEIG6dRslfCcJH1hzT2qlZQYiuGeCUsJa8PrM LP+GsXSX57NCmSA8uQ5yCzso5L9RltnlPniHmUeGDaHziBsalhmhgTqFboirpZ2bPGsO 9Bt1or3IQlnMW40i0QRojIXzoacW9sqTVRiThItxpYWxdbAxKsBJD9KsTo2VdFDpuxvk 9FnWxZlmnPJiHTqlCqfTYzqa1yJ4z3MqyxW6BWpf171DKc7XfH7GR6tgSrp1powg60Xe tDpGykxfcpDc0Uy8Bh/Ymu4k3tjJvDWmAqB+ju75R7FtoP+I8TRzcQAyuP63ltlhqIB/ G3yg== X-Gm-Message-State: AO0yUKUSKyNzqR42E1CMU6SvkbWL9VPkxK7/Auomebc5pKYK4IstANzu mhqmyUpi80qsOuLKvyFUL1WIpbLADBqKI3O8GHC/bA== X-Google-Smtp-Source: AK7set/Rj29H3r8vHaYccCmp943Un+QyMRF/w8dcRdt99GFw8apI+/L+5tSmXBTsBLdlTBniti7hA8kyFbpjr3H10kc= X-Received: by 2002:a0d:d456:0:b0:507:26dc:ebd with SMTP id w83-20020a0dd456000000b0050726dc0ebdmr298632ywd.455.1674674569763; Wed, 25 Jan 2023 11:22:49 -0800 (PST) MIME-Version: 1.0 References: <20230125083851.27759-1-surenb@google.com> <20230125083851.27759-2-surenb@google.com> In-Reply-To: From: Suren Baghdasaryan Date: Wed, 25 Jan 2023 11:22:38 -0800 Message-ID: Subject: Re: [PATCH v2 1/6] mm: introduce vma->vm_flags modifier functions To: Matthew Wilcox Cc: akpm@linux-foundation.org, michel@lespinasse.org, jglisse@google.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@techsingularity.net, dave@stgolabs.net, liam.howlett@oracle.com, peterz@infradead.org, ldufour@linux.ibm.com, paulmck@kernel.org, luto@kernel.org, songliubraving@fb.com, peterx@redhat.com, david@redhat.com, dhowells@redhat.com, hughd@google.com, bigeasy@linutronix.de, kent.overstreet@linux.dev, punit.agrawal@bytedance.com, lstoakes@gmail.com, peterjung1337@gmail.com, rientjes@google.com, axelrasmussen@google.com, joelaf@google.com, minchan@google.com, jannh@google.com, shakeelb@google.com, tatashin@google.com, edumazet@google.com, gthelen@google.com, gurua@google.com, arjunroy@google.com, soheil@google.com, hughlynch@google.com, leewalsh@google.com, posk@google.com, will@kernel.org, aneesh.kumar@linux.ibm.com, npiggin@gmail.com, chenhuacai@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, richard@nod.at, anton.ivanov@cambridgegreys.com, johannes@sipsolutions.net, qianweili@huawei.com, wangzhou1@hisilicon.com, herbert@gondor.apana.org.au, davem@davemloft.net, vkoul@kernel.org, airlied@gmail.com, daniel@ffwll.ch, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, l.stach@pengutronix.de, krzysztof.kozlowski@linaro.org, patrik.r.jakobsson@gmail.com, matthias.bgg@gmail.com, robdclark@gmail.com, quic_abhinavk@quicinc.com, dmitry.baryshkov@linaro.org, tomba@kernel.org, hjc@rock-chips.com, heiko@sntech.de, ray.huang@amd.com, kraxel@redhat.com, sre@kernel.org, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, tfiga@chromium.org, m.szyprowski@samsung.com, mchehab@kernel.org, dimitri.sivanich@hpe.com, zhangfei.gao@linaro.org, jejb@linux.ibm.com, martin.petersen@oracle.com, dgilbert@interlog.com, hdegoede@redhat.com, mst@redhat.com, jasowang@redhat.com, alex.williamson@redhat.com, deller@gmx.de, jayalk@intworks.biz, viro@zeniv.linux.org.uk, nico@fluxnic.net, xiang@kernel.org, chao@kernel.org, tytso@mit.edu, adilger.kernel@dilger.ca, miklos@szeredi.hu, mike.kravetz@oracle.com, muchun.song@linux.dev, bhe@redhat.com, andrii@kernel.org, yoshfuji@linux-ipv6.org, dsahern@kernel.org, kuba@kernel.org, pabeni@redhat.com, perex@perex.cz, tiwai@suse.com, haojian.zhuang@gmail.com, robert.jarzmik@free.fr, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org, linux-kernel@vger.kernel.org, linux-graphics-maintainer@vmware.com, linux-ia64@vger.kernel.org, linux-arch@vger.kernel.org, loongarch@lists.linux.dev, kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-sgx@vger.kernel.org, linux-um@lists.infradead.org, linux-acpi@vger.kernel.org, linux-crypto@vger.kernel.org, nvdimm@lists.linux.dev, dmaengine@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org, virtualization@lists.linux-foundation.org, xen-devel@lists.xenproject.org, linux-stm32@st-md-mailman.stormreply.com, linux-rdma@vger.kernel.org, linux-media@vger.kernel.org, linux-accelerators@lists.ozlabs.org, sparclinux@vger.kernel.org, linux-scsi@vger.kernel.org, linux-staging@lists.linux.dev, target-devel@vger.kernel.org, linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, devel@lists.orangefs.org, kexec@lists.infradead.org, linux-xfs@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, kasan-dev@googlegroups.com, selinux@vger.kernel.org, alsa-devel@alsa-project.org, kernel-team@android.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: E76B7100019 X-Stat-Signature: 8t6tih6ue13xsxy3ujsjos7tqa38t4eu X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1674674570-515061 X-HE-Meta: U2FsdGVkX1/uaGwzk8FVrTjXO2lkfZPH4RU2y0EoZVM45Win6KP91TfXYuEbiVIh3iFsZFViT2UcBzatY8xVT/ysrxvEen3tMVwZDufxfEnu7CRbXaOK7jVOMaBJ0RQGT9mOz9+kSIK7p3jROmQGVGEI2lpoY+357P6KOuNf3d2PNwnsiFOVe6jodCY+86hsya97wR11zAWfUedK1IUmp/XlTj2FoBnlSBkZBAzi2bAklr7DeRhNt2yoFu+0h+AqRbNTHHxfge1M6BIGNWb7jjXJUlaV8uqmedqqWQEibcTh7e0g7D6dp5yoV8h4YtR39PvXCbCKu/TVEy+S76GOG9HZdBgqT6WOG0ar5Ci3tMVrmoLAxgM2DMT1F328XEKao7II0L6sWwST/GAUlnM7CSd//MM/5yrasPQ44mnqZQRCIlXV0t0P4ALZaan7JSIu+I3XzrOYayXC5MaXSRjcFXaFXiMkht4KSw4TvUKmQKCrpY6hC/sToqEQbufN6r4BxRVRDttlkid6QTby99tnMEkELFkxDvqY6a9WPHDtfCALfVfFfabanwnmQOnVB/Hv9ukGx9yjMgGTXjjGQLFv8ZOY0txLjyGz2Jl+/AqYPJMrziln+uh3aWnDCTyL2hQWts/2qqV/b+bWoPWQMS0pSEqQF15VZQIzQzL7rvLCzQJWO3IIacOPeR5obDdyj7yazyaVuXSqrjd0hI5fUU3sV6z4DhvVMCR09wuq1sHVht+emuPlyp4Eko1t/EiTSKMC3PwXz4gdp6l0DdVNnRCjgr79A7RAnUfpZqs0sel3RQjq+z8DQpLSC0ZlnZSLev1Y08//cS5gFqgLmMcgFa9Ag1GiS18ZvNHse05qX6eRr3eV2i9nh5REd+NHnMu00anypXo1MheFnlcDpUGXS7Fl0szGM2VfSVgMAy5ZvmViUfZAO7lUYiFSrMR3xDvLGlTcRm8wGoanyCXpWc5NWVa yfeHLzvF x9UYbr41doLpnGreBJyS3+ENuxP/2X9krwnE1ghgTe3EAx2YJIgimIX0T2ITc86hkBDx5Tnc5OmUsLhBCrFaCNrudcU4PnO+cmGGyJjU1wCUVn8rLgDT3NQn2X/Zz7LZ04QeNDYe/os9UPdMQpwUbUXCLwgPgaL72HOKp5mElenMa6lj7VoFrbTw9emwMY4/MIcDLD8iVeVlcLT5bSXcQpS5t05qM8dFmK5uPh/TZCSz3aG8uDfJJJDHlLNKewYmN/M+LJDdHC3yqAEZYY819Y0bi9tmEOJqO+ks0qnVyn655+nPq4sxEPJ+0WSr4qAl7YZKIWEHEyCyOAW2XlXJpzUylJVcneeOUjl65ZJWeQX4Uiv4QwquAhbaiz5zeA0zf0bEAmXDUA6vdcvjm2XYSDaRDECjktK13J9rNwHj5h7GWx4NvDhtCA63ZBqtKhBW51U8SmW74252ZykNGr0hE8lFKpFFaW2YKMcTE73oYVwH4kyzKdbSdcz/80IseoIgvdAEI8wHb7WUaA5N/1Y3B+kydNDVXr+dcTdWhYuU4lDZAdwxZl/iUA6x0x0yWt3lXArdsGR5kvL1gK9M57WW4lthK6KtX47wuviI163t07MM7AC3BqBJh7quQ4oGraaHQBG+cttMz05qrGUmx2UNLVsTf0drmz6G22t7CiwPuneQ74EWBjoq+4e6V5veohZI/T1tZjlxAI6pj62pmsnpkJegUXEpWYdVwfWqRjR5GX6YinaN2ivje1em5DAwM7ONagqMQAFXi26bIk8AI4eR1XKY14L3ciL++8A43ndNTqN6lF3PIc0xMLtbf4r3ep7O37uIZ5wj9J6JrqUiQNtBf+c7qISJ8SQSR2UIBlFJ+a/h+j0Z5lOQjKiBdT8dLCb09pNvPwF+nhoobeK2q+UAVF+zzDoxuWo5I3HkwUX02cRKZlZniUJY582hB/va+vUbfUGYc10lNf/HciB3bzJlMAjxSRh+e XIpBhPBA gm9irnzsjvf5auaARIZm26Fw8AWDIJ+Y15eTwfKE/N0xuCvLE7LHULP1loRSgfa7huYL772EbyCmCE3V7SuYckjzBx6lXybIZTs5pFB9RxIRlZEKcicKMbjXrA4600IuAGylk3yqhpClEeiIrl+INCAkWaGeFznXmkJzlI/wckhpsyMih883EVWGDIphloPJngEbsAXsqDOLvSNIBV/U9uDM/OQL/2yO7DUi5v63xpsEvmAjSvyUbtqJ/xpOUumA015cTkdji/OT7r+h2dhZgzd5D3QmKdx70JgGZuajPzae2/ZviTwvXz7H1pEGXe2LAr2ZAFai4bJSMhV25JyM3vCTTo8rFEE2reZbeH8Zuf25HOym61Q11WL6/VX6Jc2yC32aS2ocfg/TpC5mBedgg7PkvvHj+gWKbmNXZMmBCzJYo/0omxuC92CWbBRtwXAxhbhmc+bejgaIL72n+lf2eo81IGVQ8RPekbrtA8g0+UkicYZEaz8YJqRBV2owIKNG4x8Pdphj8hP1LqcNjWJPxaUUE20dB6Tjj8dd3nPCMZUnmuGjcxT7DtEX6Nb/UX/SmReNHbBaiF7SlXy/DKr4RVLUV//4F59pf4ObeAdLsRN38ku+9zY4xyHrPhifuiKkH6KhysCFh1uViHhZBwVxaZ4mj1IiMfcOJgxKgQdOA8RyBemf8lcJ1rP1r7l4+oUbPaltTTw2I65qp7Biz7dpNF3tusjRuG8cMRD+JGgKN9ddVoDB5jYgwctN8pkTH8xJQYMqXHW1OTyGfbZRM8/hWUWSQ3OcjbG9/YuHEZ5Msyju/kkStK6L5wN3FA2VJrBoWsULBWTpiQa56cfHuHvU6jrvReJRdxRrIjE2bxmpxMT+TVlzatTKRUCzmjAmbqrNUUBe529fJKdQqjbYGlqciF4PUpGz6w+ehi8TBHheA4KKj1wXNUK1Y83WbQZsH/BVYPuIqo00AC+gSGHAGvqotoLwF2t9V XPeUURo5 zXW6FN2JFDDX0upRtE4sB0T/WrMsTnRtQnIleWa8e3w3wwCFf1yTaI0/DBphkGiZWRIP6TjP2H13VdT8EgEIkSk+cdWNAGYQJk++dmAIZ+ZA+uWcA1962MU6Ld5f7he/SmPNoSxpILprb79K5pNCE0Q3Da5oznGwYoowQtuJDfaE1QiyhMJB8Ifl3yWU5d2Fr/StdPIsSi/yecKLKlWJ+B4ZA6KMIK9NDdmUy+p+zjhQ0tORfCECJCrqpNB6WpTnU9FcDB8vZ00StYVkz5zMFjXRqFVkMvmONkRC2t3UCgOhxc62RID1Zu1cZDjlXgZA42lSrs75nqoSvtsgR8IdaBQpi1k5eDLhtxLeM3ovLQel5gRQdn1h7zhluk8ZslbIXRhNfmao4r6zPE2ShU+2L3wtBneUXwebPPn2jXVYWu21i2Cu9Hzs8dH0WFfP1ujk9/1lQUThhjZYS6ypqZE8KkWA4WiN4Y0jNODT80+5NTTZWfNYO37u60bCM/i00wWWRjEzLgoDyntU+vwalEL5LB6LkLL+SqoNVLu7eqQxiHORnHFVEVQpiMruqKqRT+5cW34uHCEwjgKCw1Y03GiCEJG1k8zrlvJou3kixFyb032zBdTRFvf1y/B7lpe1D9bjFhK97jAzuUDEv6D8noo67A8exSIG5xjnOWgF1/4Z05RCCskFCjMiVxkqO8NqM7kN47pDONHXD6oYQ4XLpt99voMotwh79K0/uOtrAnvSPEmdpzMrGtx1299PV9mlzTRlQH06i2hmTktxRpKVN5ZwALZxO6R+eL2N92EpYWVuR+oi0RdfMFSGd9TGO/C45E/8nUPoHzkEylNxhFCNB4IGLuKU+se1S0ae0bECrC4q1lpOIjyFZgLG0ydjexC1u7QBC4z4f4drzVw9NbWeNtn6knfnsuYxOCqLx/ElsV9ElJrnHHED5L7Qu8QwS8FPNNL3NriXuWizXWmNRiduUaifutvcP8oVP Ja7Zz3GS sUzeOwrZvJTWC9kO84TbuMatLd975hj5SMSPCJalqqhJONPZg8HUt77eC79HYbrFT1ztzBDfnrfJhU4mfXfFNf+OqPLUycUhPXgERPSdF03Jju0PGUzRPVA6it/3pjjVCZWbhi7O6ZVrzygNqIZqWl3p63Zo6LT3o2boarB7rLz5rkGZLf4Uw/Vq4WEwz3WYU8hPuudR3tCRqyZc/4yLtkb2oTMCm9zp/Ec33bf/07JsSbeQf6ffxI9V2ZtyPMVVpbZ/rH4HpyNLbA877sIpVU//KZSf/ZbcBMy7BhysFj7S4awg2e419o/bH8swTArdpd/7VlLqhtj+Z4fI5SGFO0O2HJIr0IsUWhn6/V1RGCERkVTqQTswygCYDGDA8L5S47YbsXs7YDdqtXZJv40HH/prwAjxfkRp7bCM+dpWcru5P3ccXagjT3UzqxN7cZwvG+jxGYsEPHCSgSynwJchRl+69stbuZAvIsmotyMYDFSen1pgxujqYVlCi2JU2jC5wiDn9EFZKK+g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jan 25, 2023 at 10:33 AM Matthew Wilcox wrote: > > On Wed, Jan 25, 2023 at 12:38:46AM -0800, Suren Baghdasaryan wrote: > > +/* Use when VMA is not part of the VMA tree and needs no locking */ > > +static inline void init_vm_flags(struct vm_area_struct *vma, > > + unsigned long flags) > > +{ > > + vma->vm_flags = flags; > > vm_flags are supposed to have type vm_flags_t. That's not been > fully realised yet, but perhaps we could avoid making it worse? > > > pgprot_t vm_page_prot; > > - unsigned long vm_flags; /* Flags, see mm.h. */ > > + > > + /* > > + * Flags, see mm.h. > > + * WARNING! Do not modify directly. > > + * Use {init|reset|set|clear|mod}_vm_flags() functions instead. > > + */ > > + unsigned long vm_flags; > > Including changing this line to vm_flags_t Good point. Will make the change. Thanks!