From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 626DDC54E58 for ; Tue, 26 Mar 2024 06:23:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D25D16B0093; Tue, 26 Mar 2024 02:23:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CAEB46B0096; Tue, 26 Mar 2024 02:23:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B27DF6B0098; Tue, 26 Mar 2024 02:23:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 9FA776B0093 for ; Tue, 26 Mar 2024 02:23:39 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 62D0EA091C for ; Tue, 26 Mar 2024 06:23:39 +0000 (UTC) X-FDA: 81938198958.16.398EDFB Received: from mail-yb1-f180.google.com (mail-yb1-f180.google.com [209.85.219.180]) by imf05.hostedemail.com (Postfix) with ESMTP id 98D59100003 for ; Tue, 26 Mar 2024 06:23:37 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=3ffZ6XpU; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf05.hostedemail.com: domain of surenb@google.com designates 209.85.219.180 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711434217; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hY2WNNA6khj/wLxlBTVDg0e/YVgDEc7zpROxMWd3xhs=; b=c1X25zOpLcHTrcITa5pXJhD167doSzffcjw6bqQcmDWsp6jc+hoW7trlllUtfhNRnOlHoB x8RsJgoQbyaN7+Ga8cDs3BAnV/NQNMNjsEDDtzmcqLRIEqgz37EDFilnwkAWF0sLL1XqiT ScM99nOVGss5hKcO7e6rKMuhSkVerPk= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=3ffZ6XpU; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf05.hostedemail.com: domain of surenb@google.com designates 209.85.219.180 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711434217; a=rsa-sha256; cv=none; b=RorH9ANDL1GfsDjqLodT76FXdjFJRjLGxBoWdTF+veoUjAr8s6qK0TSaBMksXWlJcQbowt PrM7xuO9M4OxVqWwaCTfSD9KxpY1yGtzaA8nS/ad9LjKF9BZpKYK7KrItQ9GbylIJrxFpl 6aGDDF57fYzfCTgZxE4FYakhhK3Alyk= Received: by mail-yb1-f180.google.com with SMTP id 3f1490d57ef6-dbed0710c74so4269238276.1 for ; Mon, 25 Mar 2024 23:23:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1711434216; x=1712039016; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=hY2WNNA6khj/wLxlBTVDg0e/YVgDEc7zpROxMWd3xhs=; b=3ffZ6XpUetP9gOveV97JbFpRuWLhucVDCXmuB6DTUuXhB6wbE70KfIAnrgUWrO/E6z wsgh+hIHyCX6vxwYAJx3+WRfFtWoTX7jxzGMeQySQm9N3WtBOHlXoAqQILtE40pt4a55 S1FFLROKheek3faHGPx+VqYKV2gMvGwapsYFG2NZb6ReSQ0QsWaC3rSHjin6R5uMe8+4 Aj/x6y4ql+jElkRV9aETEqPbalXP2EEdDgMwlrOj05JXHVb9zwFkfl1yfnzGicOZ/2MM wcPjkQTepd/yJOgXUc941mB2dqUQ8dK9J1X6VJXH1QuWi4A5hucgQ0KveRuK4wq35hEc nErw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711434216; x=1712039016; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hY2WNNA6khj/wLxlBTVDg0e/YVgDEc7zpROxMWd3xhs=; b=QwnWgG0tgTu2WEebOhSMUMY7IaNVEs3mpRQmWtj30yJ90hALa7Bv0XwsoXM4uscpqN f2DL8r9kvyfdz4xHRq8DG73pfRfieSSUjXYcdgZCnYcsP3sq7vwcYCpA1LZbIO3JhnCc zzTMylPDhN6qCiw+PjfOkuSGl68cyEnZvndVGMal9Ih3cfTtfAIpIiUJ0eOsfu4uyQ+Z wF6pPaX+OXnIpNAcHMG0S6XmZZeOH936LyQUdgkBg86jicOU9wL/tyttRs8fh6fplANB gWB6h74M8Xffl+b+w3nM24KDtCFUGwFQSuUMQY7ZfFEPHBvH9VUQwMchlw6vSqRCSWdE /Wcg== X-Forwarded-Encrypted: i=1; AJvYcCXqI4pdan3eeZQwXvpPeQVI5CtcVukjIVBGYTNuS7z4xYh/T25DIEgQxIinANBkU3Cy5VaZi6+H0NL205xnjUX8tB0= X-Gm-Message-State: AOJu0Yyz1inIbj6tn8PH81plSjCbgUkPprTnQ3GY4vAUnZHWJYDHn7At 3FXl4ZXum6/K671b0+xH+zBIr2qku/hu0EU57VeISa8Mw4a424SnCH6SJHOgd5t/7Bbivm/1HWV 8xKqKAKNQjM5ub9TNJs+KJhnInOMBPEnEP+hH X-Google-Smtp-Source: AGHT+IG0Gky/CBeJB0rm/0hu0j5w1H7Rs/NYjEm4sYKK7iwNm6xWETNlnSAhCMgOK//6yiQJTSFCTE29ikghtZ8wfEk= X-Received: by 2002:a05:6902:4d3:b0:dc6:d457:ac92 with SMTP id v19-20020a05690204d300b00dc6d457ac92mr7166050ybs.31.1711434216382; Mon, 25 Mar 2024 23:23:36 -0700 (PDT) MIME-Version: 1.0 References: <20240321163705.3067592-1-surenb@google.com> <20240321163705.3067592-15-surenb@google.com> In-Reply-To: From: Suren Baghdasaryan Date: Mon, 25 Mar 2024 23:23:25 -0700 Message-ID: Subject: Re: [PATCH v6 14/37] lib: introduce support for page allocation tagging To: Matthew Wilcox Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, liam.howlett@oracle.com, penguin-kernel@i-love.sakura.ne.jp, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, jhubbard@nvidia.com, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, songmuchun@bytedance.com, jbaron@akamai.com, aliceryhl@google.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: cqpsg5fqk9eju6u885dppsbp73d51jht X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 98D59100003 X-HE-Tag: 1711434217-272387 X-HE-Meta: U2FsdGVkX1+CuXX58dhUc7k1OgKqgJRZIPJl6AV9rpDpuzV3KxG/IxhFnZRtTDPgDuBZ/W52J2yUrXaWdpYII6oa67hNl3mDqLdWzTIHpUpG10IdRy4kqoYQ/GZsy16ogdxSBpo7Ke5BhPxWEsATTsSShS2Eba6x43VNwzJhqt7rtv724zTAl8eyOpmPW8h0+f57nazhduZGE8CNePkzqdRvCRFGK2UG0flufqi6ZaPYyz8LZnjRae1Vwv+KkZzFwnCkc99sIrq/E4fxTtnkibOKg+IDzDIBD71JQu4sNq5gwCmqhphq2mY5GXQRmbpvJanPBHG+sKFzbUnDeGlMS0GO659VYwZQ9cd8yThqV9iOPU7gxU9L0tYZKT04ppqOUtdniEa82/1fYw67m0GFKZDulgT45gHuUguVJcy/7VLOhIbz/4eBBlCnpbVCEHYMgPOSdzvlD8KYOKSUER0HgG5uBoV9fZKFeTmiVmNT74dBlJc+tBnyGlAW7xkTb7A9E/QN4nk/+YxV89yWTD0KVToNUtUs2ggthXWnOlxrp+MqdL889Y1OIPpnjoOSt5yWeoyZeFJIkauXh/9KUOnmH8j2IgqwU+JdjMitYdllRqNMptzihD7hAf+BqbuS/pebTMTnVctmC0aN/ukmRpBYfJUim9rdCsZbiBYNrpGTBdf6UcdN9mUUjunZzBZ4yB+tDg0+zOLbQaJWwk5V70icq8MfN307MlFxIVEMwCkmjS6KM0klh02QW1bGXIMcVFo2mcnPDdnFJ8g7v7fNhYcEsJtZKvFF7BBM1wyGlL1pU2+1jQmfbJd461Xc+POtPVtVQj9Q4TiebO4B6sB1CF7DZDWMskXlVyw8ggYYe5rSg4JvDk1vyGThFMrDi9CfOMGI0ELA4sBw08JWyRz+w20tT2fxtljo226BIgyZcxY8d/Gsi9vmeDhGfinGV69hJ3nfwQRw61dFxbGpV2kZPpI gQ0eKSFF Kx8XIOeLRhRW6XEisRpAteZq6NrMWmIXmbUojYdgJNJnOxgc/29EWN600the9Xn4a4JXwOWsHrk//g1JaIujpFub7qoQPYzmQlDoiAd1JzoHKdNntaMm9NjRljNyeX8kkayb6d7nII+PTe2YfhMlTH9D4ihjcSbm9tn20WnFHbGGFwPzeHKVMVQDbz00//pPo/iHarmI8jsuTwsq8+I4Y7RKxIqX684++U6HY8v61/QVxlS+QoQ/OCJyeibegcZMkLWIXImCW2hAOCXStkJbuDFpjIZSLX25oIsnNFpyxKksHAantUXhhvdr8Oz8wN+2FUL8zo+abpPqwoQD788hB65VuPC9+JaLQcQrVO7zyHj3zNzw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Mar 25, 2024 at 8:12=E2=80=AFPM Matthew Wilcox wrote: > > On Thu, Mar 21, 2024 at 09:36:36AM -0700, Suren Baghdasaryan wrote: > > +++ b/include/linux/pgalloc_tag.h > > @@ -0,0 +1,78 @@ > > +/* SPDX-License-Identifier: GPL-2.0 */ > > +/* > > + * page allocation tagging > > + */ > > +#ifndef _LINUX_PGALLOC_TAG_H > > +#define _LINUX_PGALLOC_TAG_H > > + > > +#include > > + > > +#ifdef CONFIG_MEM_ALLOC_PROFILING > > + > > +#include > > + > > +extern struct page_ext_operations page_alloc_tagging_ops; > > +extern struct page_ext *page_ext_get(struct page *page); > > +extern void page_ext_put(struct page_ext *page_ext); > > Why are you duplicating theses two declarations? > > I just deleted them locally and don't see any build problems. tested wit= h > x86-64 defconfig (full build), allnoconfig full build and allmodconfig > mm/ and fs/ (nobody has time to build allmodconfig drivers/) Ah, good eye! We probably didn't include page_ext.h before and then when we did I missed removing these declarations. I'll post a fixup. Thanks!