From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25357C46CD3 for ; Tue, 26 Dec 2023 22:12:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F04086B0081; Tue, 26 Dec 2023 17:12:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EB2B46B0082; Tue, 26 Dec 2023 17:12:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D53EA6B0085; Tue, 26 Dec 2023 17:12:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id BECE46B0081 for ; Tue, 26 Dec 2023 17:12:26 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 94389160662 for ; Tue, 26 Dec 2023 22:12:26 +0000 (UTC) X-FDA: 81610369092.15.907ACFA Received: from mail-yw1-f170.google.com (mail-yw1-f170.google.com [209.85.128.170]) by imf12.hostedemail.com (Postfix) with ESMTP id E177B4000C for ; Tue, 26 Dec 2023 22:12:23 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=1s+XD49S; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf12.hostedemail.com: domain of surenb@google.com designates 209.85.128.170 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703628743; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qGyOmo1LInXd6cBCtzQtdu/T4kUyPwlVjT3/bkZ4u7M=; b=Xxw+rgmLAMitzmrUo9K914jtLWAN3M8Ndp1UWsBcnPn2nTdm7IsG7rQSl2p2w8YS0cjH+R e6RLg4ZsvpXRsx5gy44u0PH2YGMfTU6RQM4eh5/GJ3pcsCYAWPw7EMkHi6nfHQwtA/dSQf BO2E3zIzaeRHk0qYCcPUjXGkb6NtwoE= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=1s+XD49S; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf12.hostedemail.com: domain of surenb@google.com designates 209.85.128.170 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703628743; a=rsa-sha256; cv=none; b=CkxB4lhWWziYUOfHUUPsOMp67GFM+PG8NggEHTkL9RYcIQPuME2ihfrPHq3kwuV8CvnSCZ r3TbtoqoLThEn/IRx7QQsz8kZI5da5/rGhri82MjhwWsVxCj5T+Oxa04A/6pWKg/oQnZ7r H8iV6xrvgJKAA1OxCN8yVpT/lHbmSQA= Received: by mail-yw1-f170.google.com with SMTP id 00721157ae682-5edf47b3113so4850057b3.2 for ; Tue, 26 Dec 2023 14:12:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1703628743; x=1704233543; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=qGyOmo1LInXd6cBCtzQtdu/T4kUyPwlVjT3/bkZ4u7M=; b=1s+XD49S5XiaE86L91GNEpYNix6hy0WL7cUopcRKFwvtnDx7AJ0o4f6cK/H/+qDKdk 0pGyNPYqpXXmx27Zb856il58VQmK3/RMMA4hmyu6oyJ8Ba4h+ppl2By5VsJN9fue4YxQ poMJL9UIu76EnHaCdHuKHu/O/ygJKiWAaOtpphHvgtk8sMpk3w9M59zVC2waeIyY+GE4 zMc7VbTbfw65AdjpU3RiW5NAfsgCpBtTBhQ1Q1e+e4EIdA+xsv0nmQKeSAnnJtabXNVX ln8NR632vDuKhMkH8xQYqYLywp/Y+t3eXZgzK15RirWRzWeGTKwBLo/Jw749i5GWb2sd 4wdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703628743; x=1704233543; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qGyOmo1LInXd6cBCtzQtdu/T4kUyPwlVjT3/bkZ4u7M=; b=O1gjm2lmbYPw+5Fy6Xtf9En1Lt4j+B+IE5pzexTSzNzTf+XPq3pOMgt01YGc0/XIxt E2ZUIjtWd3flybvS7TBoMbXIOr2+Eg7HpWMy2mbav9cSNS9c1t06pCxR/WGC7LvNyl0z 8nmDLwxnixW6O6lJsL5d4655M6yOcncMvy7belqAsQuK4Pi/LL00f8VOqZFn2B2GGF8s 0XV7wJ/6IEpqzRBMmmpEpw6ceC4M01hM4XrX3EITWQA9rsVqLSIi+3vNuqG5ofhDHiWQ n5vAaCmK+9SbFdNAQ5vvH4KGmRK82A1q9cMdPieUcHn4/vvnkD8GQcPZyhSndpdbgmJf NlcA== X-Gm-Message-State: AOJu0YwNhYyY7JzBX2datFYhMjkHfV8rYTsvgRQbpiPRVy5F/I8V9SpK oAkNjv1PT5ZXMs5rb0M0nSlRSX8Xz6MCDsm2VIQLhEoDfM1J X-Google-Smtp-Source: AGHT+IGpz2ZfdldDfyT/4SNCJK9n8IBWb3Jlm4kIXOPC7FxTomeK+3k4wRMA/Ntvl+efxqzmOUQ64ZcE9Xg+kSGFCPM= X-Received: by 2002:a05:690c:243:b0:5ed:9207:341d with SMTP id ba3-20020a05690c024300b005ed9207341dmr924990ywb.8.1703628742827; Tue, 26 Dec 2023 14:12:22 -0800 (PST) MIME-Version: 1.0 References: <20231222102255.56993-1-ryncsn@gmail.com> <20231222102255.56993-4-ryncsn@gmail.com> In-Reply-To: From: Suren Baghdasaryan Date: Tue, 26 Dec 2023 14:12:09 -0800 Message-ID: Subject: Re: [PATCH 3/3] mm, lru_gen: try to prefetch next page when canning LRU To: Matthew Wilcox Cc: Yu Zhao , Kairui Song , linux-mm@kvack.org, Andrew Morton , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: E177B4000C X-Stat-Signature: 5m85cumx4hk7m4rqcxancn4qfdqupscw X-HE-Tag: 1703628743-627382 X-HE-Meta: U2FsdGVkX1+GGBDrkNJbphlt1qt3LbOtWSfMUgS+juG9JjGrX4GxqWBWDSO7Uexbvyn0nLJKZKMt8jvk4AehgISUbEc/muFh3gtjxJYJugxsLGmK7HfDBNbHjQbiZ/y5EoeWJ9x001joy3imVz4Glllj3B14PtZUxH/NPjk3lKGBLu77r0olH9+ipnlV529zclpAN77KSRVbFEThPOFn/DD1X60t8tKLmCqhMY2MLXGFLMXnyFLctR9CcFHHSsjFQ8iJ9oFRnu89GYN/x5vYWEjxhNbUcqE7TlRxL68TZNin1sIT6r1AKRph6UV5YcI0ju/ugqyD12ONIP5wKXuREIydGj3tadSFYOhDIYmMjk5SFj3As2vZOCl0sVWBUz6g9blwMp48CKOgDyYDQwh+4iElDpzAVS0XewmLsgQWR0cy7BOyuLIWVjh9bZa/6RrBOTokes3Nf71X07GGLw17nR0tOSuI7HRrucjlfelhOUPs6h+jVkkmcl0+IVMB46k8y2ADpuJTuR4sKZJtfL3zp+TPAPUAh6+k5dEqbnAShkkuQ6pqHeU349opoOa7/V4FsBI3Mz6HqVz8G/NA32bQTSFb+xniVFrMqnFVW1vq9u2Y0uP7nz49mrE1VPaIJPty4pWhLfJ4uCPljGJGBCzbzU6VdzzNUpE/7JRnAMP1uLw3SA2dr8BWgcWiCHqk+GzqOw/9Sz2grjYU08aThqr9DSEge57I94rApYYXlHblUuUkxrnb6/J9fJjksEvtpQkMAt891npULND+iED3AB7lQxlL+5K+KcOj5/krIWdVaLYsglj5aT5ccvcwxoyHEpbwv2vXBKbjd6xev2d1lY/xJCXvG+I3YyFZnLlYtMTtQsMbQtz+ibY6kbm/faSgkr3uAvAlJ06ZfCJ9cRPl+UAj9TN0SePBr6u6qvaaoAMxE0wwY7gcVClpyHWFRuDg9GsZTG3uTEODiY2K/dcV0Ls ET4EDhYb dlF7P5aJ5Fmkz/00cIJhkyJgUsLREO2E82Z+qLY9mw+dPOW6l6C6oaulFGQXXacvt6oNeE9jspumNGwtUokfkattJCbDQLcnTQzFAGTeFD27YlwPnN7Zt+8Sd/bLcLZuJ+Z5z2lDQLIQg3GjMQV8DTOMghQ9293DxfuFEo1lAkVU7j/DVqXNSwFJ255ZxtBiVAyN3yxdjMudM/JmN/QDKhp9r9+zq96ZNu0TK9xRrgmeuWw1I8fjoFmQo2e8mYZ8zspHrnd6CkRpLcFX4I7KeXDs9nGbtFxWP8VmBg8TUzkdJoN3ODBotRENWccBWa/pbhhLZ35lPRq+a+AvPtrVGBJqUOjZ7uelUH8fvQvDoZ9EqFJOzggCcai/yVnG6Hh20elIwMHJOgndXjgG+mTAF1v1+jnFfnFysF3qo X-Bogosity: Ham, tests=bogofilter, spamicity=0.000020, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Dec 25, 2023 at 7:42=E2=80=AFAM Matthew Wilcox wrote: > > On Sun, Dec 24, 2023 at 11:41:31PM -0700, Yu Zhao wrote: > > On Fri, Dec 22, 2023 at 3:24=E2=80=AFAM Kairui Song = wrote: > > > > > > From: Kairui Song > > > > > > Prefetch for inactive/active LRU have been long exiting, apply the sa= me > > > optimization for MGLRU. > > > > I seriously doubt that prefetch helps in this case. > > > > Willy, any thoughts on this? Thanks. > > It _might_ ... highly depends on microarchitecture. My experience is > that it offers more benefit on AMD than on Intel, but that experience > is several generations out of date and it may just not be applicable to > modern AMD. > > It's probably more effective on ARM Cortex A cores than on ARM Cortex X > cores ... maybe we can get someone from Android (Suren?) to do some > testing? Android is quite noisy and I'm afraid a small improvement like this would not be distinguishable from noise unless it's much more pronounced. I'll take a stab but don't hold your breath.