From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7C88C43217 for ; Thu, 1 Dec 2022 19:51:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CEF946B0071; Thu, 1 Dec 2022 14:51:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C9FCA6B0073; Thu, 1 Dec 2022 14:51:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B67066B0074; Thu, 1 Dec 2022 14:51:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A41546B0071 for ; Thu, 1 Dec 2022 14:51:24 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 7AF82C11EC for ; Thu, 1 Dec 2022 19:51:24 +0000 (UTC) X-FDA: 80194781688.30.1F0D9B5 Received: from mail-yw1-f174.google.com (mail-yw1-f174.google.com [209.85.128.174]) by imf13.hostedemail.com (Postfix) with ESMTP id 095012000C for ; Thu, 1 Dec 2022 19:51:23 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=bEtqLuo2; spf=pass (imf13.hostedemail.com: domain of surenb@google.com designates 209.85.128.174 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669924284; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=N+cxU5tsQZIeB8MEm8lyamTViU2V0IWkgm7seDl4PV8=; b=DSPAqov4QGLG07urx3T6VyWOgfalN9IfgW5MXPbKn1B2+92Qb51thqUiJuhDuBsqzt57q/ 0n2sDRHhC/c5eqY+QG3eBccRcw3+LIGFIdPThNpAzTrVM7WHPJ6yPyrApJxv0vMsAHXnAF NIMuGHVxhaxeUIksiEvomvIZs7WLq/o= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=bEtqLuo2; spf=pass (imf13.hostedemail.com: domain of surenb@google.com designates 209.85.128.174 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669924284; a=rsa-sha256; cv=none; b=ZHfFy9wpQneSP7n2W1MlodNsoaGXRucs+Xs2JI8VbN2vYJbIT6D5/U+1iVnUP4pq4K2C9z Ksf4T5i1toT2gtCchmJUoVvZkpA6J4d+iFxl8RTKkK68HATqYhBlDuciLmu+B9u3KieEjt rYh/9fkw8V9N4FkxaoxMsFVYmX/epIw= Received: by mail-yw1-f174.google.com with SMTP id 00721157ae682-3b48b139b46so27986897b3.12 for ; Thu, 01 Dec 2022 11:51:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=N+cxU5tsQZIeB8MEm8lyamTViU2V0IWkgm7seDl4PV8=; b=bEtqLuo2hAFMWMbuZ6x+99JPoTYgfQ0an+IKqqGdbPbpfAbIR8M6UsYf8t1tLPEGc8 QKj8hUopQ2Lt+uCBQVfegJBGoYVezN9oNx6DP19lh3nYS2pnU1zlAv2mftHYhKvXWYv8 snHwu7ppgcfAyFzBYXJJS/fAM1lfz7HLPY6YNKDzzo9GcnjIPJPj0CbwYfg+lH3PLmA1 2RO+Mm97uTLOYXBC6sFThq5rGTh13Ncc4o2nEWXhxw8O17rc8GK7acVWJpMzVFZF/9LF M41792Jl/65v7D9DiK+0OGbrUNcgrY17A07Hd6jZkT2A142Mk5BCqjqETb71uBkiUF2D xmNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=N+cxU5tsQZIeB8MEm8lyamTViU2V0IWkgm7seDl4PV8=; b=lD1dWOfbcoSLoRXa5BT5nZaW6MIPsSNpkFBC+WoCzh1gTaOVEzj1haP/uXtFXLGvqh lRsitSzWlvDLA59feGCGZTDFrEI6xi4RgjVKQHvxtEoPSbqqCIqrsQJeKGYgoknIxnzN So5ErDJnIkvLJZB/4kluQi579Ba6VfmDKogxb050O73Ib/f4ff9B413AYQBDwb/1567J HRgajdvJ0DnNsnX9FVzk0xQQIBKjkoCY9REXhC01jTDhl+6/wkWeCw363buhsbnwIOcY 8Uw2gvlSaQFp3AXO7uIBRxLdFWHwRpmE+Q6QUTE6vUpxHYCb7VEhpGfzYRtFGfAlGjw9 aA6Q== X-Gm-Message-State: ANoB5plh0WuAMpwcitYCqhLKAqWDTTNfIMddc42eD52rrEEyka+K83ai olEUx5npwRyxojNmgIc9d4ZuaauwQ4RfNgR+/Ytfsw== X-Google-Smtp-Source: AA0mqf6CFQG1T7aehU9tXBhngYcgvwsjV64sfIIfE74DyYk+KSdOmNl6FBcLUM1qwHBsaZm/BpdBYo5m9sWQjchAILQ= X-Received: by 2002:a81:104f:0:b0:3d2:b057:9925 with SMTP id 76-20020a81104f000000b003d2b0579925mr11779662ywq.455.1669924282992; Thu, 01 Dec 2022 11:51:22 -0800 (PST) MIME-Version: 1.0 References: <1667971116-12900-1-git-send-email-quic_pkondeti@quicinc.com> <20221130151739.a7771037aa83ff536ac2edd5@linux-foundation.org> <20221201030045.GB3980@hu-pkondeti-hyd.qualcomm.com> In-Reply-To: <20221201030045.GB3980@hu-pkondeti-hyd.qualcomm.com> From: Suren Baghdasaryan Date: Thu, 1 Dec 2022 11:51:12 -0800 Message-ID: Subject: Re: [PATCH] mm/madvise: fix madvise_pageout for private file mappings To: Pavan Kondeti Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Minchan Kim , Charan Teja Kalla , Prakash Gupta , Divyanand Rangu Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 095012000C X-Stat-Signature: e6sdn3ebdotc4ye8b9jn1sbhqgiw9tdm X-Rspam-User: X-Spamd-Result: default: False [4.81 / 9.00]; SORBS_IRL_BL(3.00)[209.85.128.174:from]; SUSPICIOUS_RECIPS(1.50)[]; SUBJECT_HAS_UNDERSCORES(1.00)[]; BAYES_HAM(-0.79)[84.59%]; BAD_REP_POLICIES(0.10)[]; MIME_GOOD(-0.10)[text/plain]; RCVD_NO_TLS_LAST(0.10)[]; RCPT_COUNT_SEVEN(0.00)[8]; FROM_EQ_ENVFROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; MIME_TRACE(0.00)[0:+]; DMARC_POLICY_ALLOW(0.00)[google.com,reject]; TO_MATCH_ENVRCPT_SOME(0.00)[]; ARC_SIGNED(0.00)[hostedemail.com:s=arc-20220608:i=1]; FROM_HAS_DN(0.00)[]; R_DKIM_ALLOW(0.00)[google.com:s=20210112]; DKIM_TRACE(0.00)[google.com:+]; TO_DN_SOME(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[linux-mm@kvack.org]; R_SPF_ALLOW(0.00)[+ip4:209.85.128.0/17]; ARC_NA(0.00)[] X-HE-Tag: 1669924283-178430 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 30, 2022 at 7:00 PM Pavan Kondeti wrote: > > On Wed, Nov 30, 2022 at 03:17:39PM -0800, Andrew Morton wrote: > > > > On Wed, 9 Nov 2022 10:48:36 +0530 Pavankumar Kondeti wrote: > > > > > When MADV_PAGEOUT is called on a private file mapping VMA region, > > > we bail out early if the process is neither owner nor write capable > > > of the file. However, this VMA may have both private/shared clean > > > pages and private dirty pages. The opportunity of paging out the > > > private dirty pages (Anon pages) is missed. Fix this by caching > > > the file access check and use it later along with PageAnon() during > > > page walk. > > > > > > We observe ~10% improvement in zram usage, thus leaving more available > > > memory on a 4GB RAM system running Android. > > > > > > > Could we please have some reviewer input on this? > > > > Thanks. > > > > Thanks Andrew for the reminder. Fyi, this patch has been included in Android > Generic Kernel Image (5.10 and 5.15 kernels) as we have seen good savings on > Android. It would make a difference on a low memory android devices. > > Suren/Minchan, > > Can you please do the needful? Yeah, I saw this patch before and it makes sense to me. When discussing it with Minchan one concern was that if the vma has no private dirty pages then we will be wasting cpu cycles scanning it. However I guess it's the choice of the userspace process to call madvise() on such mappings and risk wasting some cycles... > > Thanks, > Pavan