From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFB47C77B75 for ; Tue, 18 Apr 2023 16:46:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1F0E48E0002; Tue, 18 Apr 2023 12:46:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1A14F8E0001; Tue, 18 Apr 2023 12:46:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0417A8E0002; Tue, 18 Apr 2023 12:46:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id E475A8E0001 for ; Tue, 18 Apr 2023 12:46:08 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id A3375403DC for ; Tue, 18 Apr 2023 16:46:08 +0000 (UTC) X-FDA: 80695089216.27.AE0E54A Received: from mail-yw1-f169.google.com (mail-yw1-f169.google.com [209.85.128.169]) by imf03.hostedemail.com (Postfix) with ESMTP id B316D20017 for ; Tue, 18 Apr 2023 16:46:05 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=loJ4tD9i; spf=pass (imf03.hostedemail.com: domain of surenb@google.com designates 209.85.128.169 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681836365; a=rsa-sha256; cv=none; b=fjvFP+zx2K3zmZtjay5wyBLH9F+bEYcs6QaFmELBx3jZmQXfRhVZghDGMYcX6MkhkjoCA8 HA57OuJGAVTw3kUwM/swxo7mPKLmO+elQ9RSJOGqrA14vWz39I9Su9ok8306wcnxqtvfCd 4ofL6r/YneeCqvmOZWA0JiMYhPCs3Y0= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=loJ4tD9i; spf=pass (imf03.hostedemail.com: domain of surenb@google.com designates 209.85.128.169 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681836365; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yZRNuvpYmPgzgb9JaiuV4RW67h1IFb6pBTSO2dSAGgo=; b=wovbJTurcaSoODvw0Wfh3vVq4P/sWuL1ilk1WN4X7iD2VOJVYQPjDAFV9H5lbt9kf2fl+p LLFqAav7VLqdFv3bFmce9g/XKSOays1+ZZfIE3wx/tFVw+di64eCDsqZJRwP1Qqwha/Ug+ NfQLKTOTUIwSy5npSfX6bKT6y9I/IBk= Received: by mail-yw1-f169.google.com with SMTP id 00721157ae682-54ee0b73e08so468348007b3.0 for ; Tue, 18 Apr 2023 09:46:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1681836365; x=1684428365; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=yZRNuvpYmPgzgb9JaiuV4RW67h1IFb6pBTSO2dSAGgo=; b=loJ4tD9iiALqUaEHCxhFD8la/Ru1P2vdaO01NY952pB9j7EY1MsStuiIpdNY2xyAkW wL7q/GWJewpwMcjGkha03Id+jx2b9ZtYwazICqiRcN77gaQfx04hN6mHP2m1zrjuICeU YTfylyXSbMyvInRKZqOvfP/CaebhW3mumg1mTEANRaIXsvXhArUCd6qTPHiLEywTfUVY VMFiDFD4MvAXmIU5um1e4Pr+qWAoRuhVgNBTPNyc4w7rlYFYm8Yb+0mIFOrKfutyXsSL eiy9Onsd77b+w9C5WwW649m4U/md9JSf5BstPb91liW/a0aKnkAOTnjW6vMZEBGbQUSU nBNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681836365; x=1684428365; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yZRNuvpYmPgzgb9JaiuV4RW67h1IFb6pBTSO2dSAGgo=; b=FCzl1RYlv6ClPiccmHxqAx/3Bh91eoaJ1EpPouhnFsq+atfplUlWTewqjHG1gjZhBp WniUS/hYg1a7AdrwnWfT7tA87YMpo8hVez2mVxt2Sfb+xGenOOMEsPHFatN11z8HsymH TGl7spET2OjkjcdSYIOYY3j+NbP4bTTeMBn8sugAQhw7O+B3G7vTnw2870VCm3Xn4tCA 8ex9v0jzAVmWExFQC63TuT4zxe+REBA//R4f9lU006B0L0fYSuiuiD82F/pDGNMcNKX1 zejKldemxJjSyKyIEfWYBkIhZeu5WSEDLI2VYJ8jyaUdTwN2WPyZOOsomk0AM8rSM4AF gYfg== X-Gm-Message-State: AAQBX9cigr6BL4LDbFfmODhSbmdzz3A0HlHLRNuBm2WYg7LGUg9z7w1m RWhmbLkmX4kYDuMXqL9VfsLYMP+IYWrcWrV6RnAYFg== X-Google-Smtp-Source: AKy350YCN/tqF7xIynM64BgwzU0KY90HxtWs+ncREDH+yXnMl7ZR4q58AvQ8wuLAlA6V2PT6J9UGrOIExj7k0egOkfA= X-Received: by 2002:a81:af08:0:b0:54f:9e1b:971c with SMTP id n8-20020a81af08000000b0054f9e1b971cmr305886ywh.1.1681836363269; Tue, 18 Apr 2023 09:46:03 -0700 (PDT) MIME-Version: 1.0 References: <20230415000818.1955007-1-surenb@google.com> In-Reply-To: From: Suren Baghdasaryan Date: Tue, 18 Apr 2023 09:45:52 -0700 Message-ID: Subject: Re: [PATCH v2 1/1] mm: do not increment pgfault stats when page fault handler retries To: Peter Xu Cc: Matthew Wilcox , akpm@linux-foundation.org, hannes@cmpxchg.org, mhocko@suse.com, josef@toxicpanda.com, jack@suse.cz, ldufour@linux.ibm.com, laurent.dufour@fr.ibm.com, michel@lespinasse.org, liam.howlett@oracle.com, jglisse@google.com, vbabka@suse.cz, minchan@google.com, dave@stgolabs.net, punit.agrawal@bytedance.com, lstoakes@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@android.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: B316D20017 X-Rspamd-Server: rspam01 X-Stat-Signature: higtaq3ac6kj3wwzbm3azsdcbb4i9tjt X-HE-Tag: 1681836365-314157 X-HE-Meta: U2FsdGVkX1944GnW/pNgZ3cwmG9KvAAWUy7S3PlTL01LjVczcDmIsRCBhKoSfMqQRylM1SkB84Ghichr6hteFknDIykPjLz6zBErDOGMDaWb6+xxet+mfHdmh598dYpH8K7JJe2iM9LDvIrBhBecL/Cp3/mLiecOVbLg9VkXuHYtGG3B7VBviRr3qD1xFqcmOX+VqAnTgroI7Qth1YR7ATsVLF1Dc+msDtOc5bPR+bac5scdgQrnxEDWV6shCwm3oHWZM76v5a3PGr/zq+aCwoF6zzVjUWS5H2KWxm29/7w84QSs85/FPcP67bLcnwI3wpBXdIQPDJscCL84qaw1Mi4XiKezz19AeDABZDb/0MzgFfRVM99iFSfVXmlACdNmr9FSFSiVOPZYo9eFsKQHr6qMybVuwXhDcF0sKaCkccy90iUySDjorLB7IHaQ7XRLHjn06KCYD5AgkZo1kS9aDK/B0cu3n48oNEyGZSOkcg19vdvrr8VfWsZEdaeHDpFu6p4xunUoAeiM5KJGj1QJzXbqCWRspAhIOjjdXG/T3FuIhm4rO9d2LqmKaVOB8Z7ANDRO6UbnZIy1afjel6m/n6Dk7hIsMpgjrb99Ty9p/CT78lVMmR0UAZKEBq9T8wN+724YjjOq4st4dADAXbSDessIZpZPzpfwoUF5dD2BufHjpOqxgcg1wM4w36DM7Y7gN9RJfwb/6BajLpMg/y6/QXd3kpwNKg73DcyQCC6PQYH2/aPn8Sj1aIPgprOBvL8tuz6LPvQlinIDVtf8sSQKHznkwY0tqKsDg0VEZqZnHAEj55mGS8eigDNKwZ9h2vCgNn8lxx2OaFqmAVBg8nW1tQbRZ6rZ4031oUYAjMRK9/iwrMGUYGASUv/aOuiXScKmarcib1pmMpZAK80rkEhLfpBR/DnHYxPOKU/i9qThfUZWCyWSqr6Z0xQ67sgi26fZoZE6W1p853L+4GhwUIV E6uq+Zuu cmJ4APxKMnAueAMifjsBlRde0a66k+QdvWAP0LIR/ezfAoBVvw379V4SN8MGhqHdqdbWyX5Y8DZG7b5Gs5rjjp978829HbUNRvUYLAB+HFqVCCF/2q5JGDyoNKr3rvFDWbKuMQ8n0e1FjHgFguPucbOGT2EXbhgWlS793/DoSGZRiEu54090yhc3mPx+/dNrYUiuFNhqU0B7l7mtGOX1wR9NKM45byjWJubXTNxTGiHWoQyivZiSqU0IHii/T2/9sTi2EaYBF4Iaco7o= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 18, 2023 at 8:48=E2=80=AFAM Peter Xu wrote: > > On Tue, Apr 18, 2023 at 04:32:27PM +0100, Matthew Wilcox wrote: > > ... when we called clone()? A thread by definition has a reference to > > its own mm. > > Ah yes.. thanks! re: I also had a quick look on do_exit() but I also didn't see where do we e.g. wait for all the threads to stop before recycles a mm. We recycle mm after all refcounts are dropped in the exit path: do_exit exit_mm mmput(if !mm->mm_users) mmdrop(if !mm->mm_count) free_mm > > -- > Peter Xu >