From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B70EAC2D0CD for ; Wed, 21 May 2025 16:03:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 405136B0085; Wed, 21 May 2025 12:03:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3DD7F6B0089; Wed, 21 May 2025 12:03:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2F2FA6B0092; Wed, 21 May 2025 12:03:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 0FDBD6B0085 for ; Wed, 21 May 2025 12:03:10 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id ACF1480AC8 for ; Wed, 21 May 2025 16:03:09 +0000 (UTC) X-FDA: 83467384098.21.5DE94F6 Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com [209.85.160.176]) by imf13.hostedemail.com (Postfix) with ESMTP id B758020020 for ; Wed, 21 May 2025 16:03:07 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=ZnJKf9mu; spf=pass (imf13.hostedemail.com: domain of surenb@google.com designates 209.85.160.176 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747843387; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Vap2Fmp/jup7NN2/6dTRhAYx6PUX7E7GIsmSa7sRMi8=; b=o2Ii4+uiI8vvdpoqSP/KWn7+m9hsBabk1mTmJJjopdo4XGhMr6qHzZUecFCGUBExsoSpoH 87+wykHeMtHNeb82nX59tCO1xrH2ylRW0pzeCGAVkmnudO8SZxpygjn9uVyFx99U7f7o4A vDd+sn2FOAav5cIBXjrnwCN05qr8kIw= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=ZnJKf9mu; spf=pass (imf13.hostedemail.com: domain of surenb@google.com designates 209.85.160.176 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747843387; a=rsa-sha256; cv=none; b=YJkKB2biVqpS1ovndQjQ8DDQyv1SwJ9J9nJ1k93Gg155VqciJIpj+6KGwsQJWBZesDkADC 77PxQfBpmiTj0EBnv3Kr7MyOsA4R0048sEoo3I8Af+jzCneUvl3G1YUdCmN0rSj/Lg6si0 loR3Q+3punsgkPpWNCNZnBbBd53MN0E= Received: by mail-qt1-f176.google.com with SMTP id d75a77b69052e-4774611d40bso1192701cf.0 for ; Wed, 21 May 2025 09:03:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1747843387; x=1748448187; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Vap2Fmp/jup7NN2/6dTRhAYx6PUX7E7GIsmSa7sRMi8=; b=ZnJKf9muyNyc9PH1UcSU2PEFznZPvcgEQv3PBV118gFjgeJHOCLj1a7FMnbR0vkPJI gc+8IcLdL+YFF3a/l2QG20y8PYRMaRhcs0qGTIcvn9t2Reh07QuHZrN/4v6kbESn8HuL Vvm1okd6L78wwJ7zWTRNOSalYKmujG0Z6wcRhE9jJL1CMmhi3zpdxjdMcEdhtrdC6cNz GuBJcS9ZvMzvJw2X+WSz6BXpvnyjvwdqdK5OI2T6duaD5rBW/TZDIu5R1oZNYQABqCaV esn+0sogqt0NkSZu48c4CAOlZ0gcVUBtSs95CRD9glIoS6aoMiWc5YjxV2GymYHlcd/7 ixEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747843387; x=1748448187; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Vap2Fmp/jup7NN2/6dTRhAYx6PUX7E7GIsmSa7sRMi8=; b=YJEr/NnaARQ3UVD2NrQU6qlCo0bOoxVMxOwqLjFNb5JgrMR5Qj40w5eD72j6n5rYC6 eqE55d2ZuwqlFeGfk7cV6zFZ5zr2JFY6fvt4fXWpFZCOugES2o4TlTkTZI6jWid+LjJn gZ6+/2B3rXDN2fp5tXCBsct0bbm8fgSbFYx0hMJcojrHGyWIlXHSBYOdAKJFJVhHU8yF Y7znA7wn1lFO1IJJed/5QFipuh0v/erN85uiP5rzlavyhaOg0pwZUTe98qFsHpaSbryC GhczaP6g3ywCJWfE8nVeaLO/gskkPTqlWk3TGEqrK77lB12q6JTTE8mzMehIPtXRuLHn uymQ== X-Forwarded-Encrypted: i=1; AJvYcCVgAxpp5ljCtMX0buTZ96DNpitJ9xgYDIlETF7J+CCOOOyxqyW6LsJJy8pkuqolbGPDAwbMgkec1A==@kvack.org X-Gm-Message-State: AOJu0YxO+BfPVI2AItzE4vlnKSjAgi0qfYBQ2QJTXpSdYISVTE5hOoI4 /oC7sj5+M+jjAE9kKSgk1kGyQbVRy5df8nIChp/uHwUazFD7TX2mkrUWeUkyEt9i8IHGXEugeiO ZpjVBY6UQQkr4wppk31wWnHFRW6Nr9hl1lHXHm9IB X-Gm-Gg: ASbGncsVzqWBsVx7FqhIvFO772RJ+iK4uMbVCRxZB2+Lmkh4LyDm0015+7aKmvvFosh CzyNz3ultDrkh1yDVb16TxKelGBmo+pON6LbnZ8ev4QJ0kIj515MzOkbjRuA9Ifu5bPXn30WXwI rTO4bp9Mvn+zPbMB6NXEgYgs4UNMOPZo+REKmxC8q7JollxzOy4prP/YQFS14hDCaq+O6vXWpvf bnr3y1zl20g X-Google-Smtp-Source: AGHT+IFC8a5TXdX0qE1svILjR510sIlYvhF6hDRbDWibNGaSaoJrbmftu3GRHLkFT+HvyYn1OHcdW3MbY8Nto1AcWok= X-Received: by 2002:a05:622a:28c:b0:47e:b278:2e07 with SMTP id d75a77b69052e-49595c5da5bmr15670171cf.20.1747843386476; Wed, 21 May 2025 09:03:06 -0700 (PDT) MIME-Version: 1.0 References: <20250521142521.3033264-1-usamaarif642@gmail.com> In-Reply-To: <20250521142521.3033264-1-usamaarif642@gmail.com> From: Suren Baghdasaryan Date: Wed, 21 May 2025 09:02:54 -0700 X-Gm-Features: AX0GCFvCyckIBVk8R4I8PhbM_DdMu4qHvhXwrSomWLj3BYkkVkexsCZcenpHFPg Message-ID: Subject: Re: [PATCH] mm: slub: do not warn when allocating slab obj extensions fails To: Usama Arif Cc: Andrew Morton , hannes@cmpxchg.org, shakeel.butt@linux.dev, vlad.wing@gmail.com, linux-mm@kvack.org, kent.overstreet@linux.dev, cl@gentwo.org, rientjes@google.com, vbabka@suse.cz, roman.gushchin@linux.dev, harry.yoo@oracle.com, linux-kernel@vger.kernel.org, kernel-team@meta.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: B758020020 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: jn7asmhx3ef13yfrzj1hyryyjmzwmsey X-HE-Tag: 1747843387-327680 X-HE-Meta: U2FsdGVkX19xXocz99V30XsQrK1VPy08hEE+zTRIZu4beeEe24OTfHZbQstlS3U6WKlMI51fsPIvpu9TCFRPv1tdySWrRp9+g671Sgjy2JKyuzSV/p/AobO73wFBD5v/uH+brhMzqhFFqv+EGKR5L0tpI3P57w/lQ6ERT9Xr9n42yXMF+1OQyBQZp1Lww228GjzcdYiD+5uw2/fMb7l9Rhy+QwS9ipS/D6oE008UxKQEHy2EV2DgapiGu6Wu+wu2mgSDn9ikizcKIjsapj54gMkm2zHVO18RAGSYgYzQ34PD0kaW7xw5S66qj6n9Kv2TUSnTHwtCZCB0rzPva85LAP98/IeHdO48wjLsWI6tb0WzcFO/9qZrDNaS5lDLAglJ4qSVjTvuCboM90wKGeibacH7WjsvCggAle+v5XVFnEu53n4etlIrx9DFhkp+PPF7TBUOeydaC0oUHoCYZEpgM6sq20sbxOy1Hiu+LDjXtVeFvXnWyR1R9d9/4Ex683s8SI7ZYImSiFqLC/92j0yFYPFoXOzAHHD5sdviUztZSSnxDGMFmtrV/teI/7WAH1XpDn9isCJGPMqElOgHhDM4pMwi23IofFSHd/66ed3hl9huis1pFF8NzKfWEwNTZfqlHu4IR7PrTEc7WQg1y/fbLWbUNc0mZgBoDn1vF114C1FuojvhknIHtEavHtyLDmrKYIi99XhMEAdqkrGZKyetSAsTv3r9DQgCa72AXPcr+PbqkXCRIDxydvbNyRUdRe/AwCQHtwmjE4XLFvZVPPtKOJp4pA/TKbwPEzC+0hABHch9+yAjoOXAjrK99cW3ODmGqOHgBxs878dlBR73K7AKu4oqxUvubPiJ7ZTJFTYkikMxZK4jaaQ8lMsPEUe46kBYez2Q791q+X4DCUvncKC82Ddnah0v9/6h+q3MzYv0V4aua11EkdWq0BLAEADw/kqsrtrEUU6v7NFlj1slhx1 si83U3mK 9u79A8lfGuxHurE/pra80AMABiIlhvAlEGgdr/+HBgRSzorGUVEgq1qPo1cy4s0fL3phYc40jwmoPv5sPKDOxEieKpXtctlTi+K4Yh6dWKkJn8yiZ+KZWuy/vrbKzYQY26fZi+cLpiYntcL713h6R31mq4UsyBkgnTiB3CgfZgCvwZrxykXSKwTZmCpVBiafbyZLBYfpGrs+ZS3cTSyVza2f4DN3HlJ2aFp1AL8V7L8berIbWkVxFSw/Yd5it/ShlwCFEYWJuJ5YIRJ/07qNBa26UGOnC8fdMu17IErxy0J1s4jt8kqEFC+i9YQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, May 21, 2025 at 7:25=E2=80=AFAM Usama Arif = wrote: > > In memory bound systems, a large number of warnings for failing this > allocation repeatedly may mask any real issues in the system > during memory pressure being reported in dmesg. Failing this > allocation is not indicative of a bug, so remove the warning. > > Signed-off-by: Usama Arif > Reported-by: Vlad Poenaru > Closes: https://lore.kernel.org/all/17fab2d6-5a74-4573-bcc3-b75951508f0a@= gmail.com/ > --- > v1 -> v2: > - remove the warning completely. We will have a way in the > future to indicate that the mem alloc profile is inaccurate. > --- > mm/slub.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/mm/slub.c b/mm/slub.c > index dc9e729e1d26..06ab9a558b73 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -2102,9 +2102,7 @@ prepare_slab_obj_exts_hook(struct kmem_cache *s, gf= p_t flags, void *p) > > slab =3D virt_to_slab(p); > if (!slab_obj_exts(slab) && > - WARN(alloc_slab_obj_exts(slab, s, flags, false), > - "%s, %s: Failed to create slab extension vector!\n", > - __func__, s->name)) > + alloc_slab_obj_exts(slab, s, flags, false)) I thought we agreed to having pr_warn_once() here. Did I miss something? > return NULL; > > return slab_obj_exts(slab) + obj_to_index(s, slab, p); > -- > 2.47.1 >