From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAB1CC77B78 for ; Wed, 3 May 2023 15:24:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 474FB6B0072; Wed, 3 May 2023 11:24:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 424736B007B; Wed, 3 May 2023 11:24:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 313946B007E; Wed, 3 May 2023 11:24:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from mail-yw1-f174.google.com (mail-yw1-f174.google.com [209.85.128.174]) by kanga.kvack.org (Postfix) with ESMTP id 120366B0072 for ; Wed, 3 May 2023 11:24:32 -0400 (EDT) Received: by mail-yw1-f174.google.com with SMTP id 00721157ae682-559f1819c5dso65558107b3.0 for ; Wed, 03 May 2023 08:24:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1683127471; x=1685719471; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=3u3xUQKsQtY5MjJU7KWdFVlKdUwGfS6WMFqIdWoJCIo=; b=unFkvF+6wudO45usQ0U6AfJIfqhGP+H5/IVYvEVNkvB69qXh+JOZzYWL6W8iypwR8u WXtxZSQf4t68zEHXsPc28NiwHPUvvwS/M344xQ3tBObhdP7U9FItGEykPkPqu+eEbFFp okusA4UwcrZWf8Z51Zm29/RE04pDrtNIp/vD2aJp+XpBdU2UkRkKKny9uq/isdNkl+oO Skjuy9Oo1eMbcdvkjUdB3P7K+oZHaS/9IHtfkJQayp0An2kmfxp7oACjbZtN8XRdwT2w lxjzvHFT+zOFmdZqKIHE6BDxnTC8QY7tAueSdS/QBzC33/doZv3G/USW3EuK7WLdlbGW qF+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683127471; x=1685719471; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3u3xUQKsQtY5MjJU7KWdFVlKdUwGfS6WMFqIdWoJCIo=; b=dlKp8G7rwXFUgw4WChbjoVH0PaN4+JafTn7c2AWd6a1S0T5gnSJC1WIT2NXE7GM4PD rm/Lytxr1acxoiYa2NFTLm9N1LSVFderQ4zpcNT5WMX+U6helXqmJpvui6HqI0LUGCGo AJWysdoPJnnlQ2fnS3VZq7AaKphKCrJqVkH4G+d6uSsIrbIEIrHxTCw4L1Rk0NrxrlNS H3+1Jng9JLTyKzB7BkwqD0wj3VGxadAb2qMKXnDy9H1HdHrYO9UbWW88fH+WTdwhjp5c yKqKx5OF4wpB09mE8Drl02qIjZ+PB4Ca5ZK0NKVajGjFJEkPYM8LDsJJE2iIpnfSUis2 PHCQ== X-Gm-Message-State: AC+VfDwqVq+G2Wy+Im03A4QeStCiLYBw4CB9ATjbXC39C/XhKarzJnlZ VHpEPA8EwYkIqIQ2JG12VHsund/PHKWYwTEmJtaoQg== X-Google-Smtp-Source: ACHHUZ4QRO+chfCfz5/jv+a2xol9xihN+1wt+nUNWo6jdaruLvTBoFlz5eyhSEYcB7ZOQZ60IsdoPkHuL2yRnd5FS3c= X-Received: by 2002:a0d:e296:0:b0:55a:4109:7f5a with SMTP id l144-20020a0de296000000b0055a41097f5amr11315408ywe.12.1683127470672; Wed, 03 May 2023 08:24:30 -0700 (PDT) MIME-Version: 1.0 References: <20230501165450.15352-1-surenb@google.com> <20230501165450.15352-36-surenb@google.com> In-Reply-To: From: Suren Baghdasaryan Date: Wed, 3 May 2023 08:24:19 -0700 Message-ID: Subject: Re: [PATCH 35/40] lib: implement context capture support for tagged allocations To: Michal Hocko Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, ldufour@linux.ibm.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, May 3, 2023 at 12:39=E2=80=AFAM Michal Hocko wrot= e: > > On Mon 01-05-23 09:54:45, Suren Baghdasaryan wrote: > [...] > > +struct codetag_ctx *alloc_tag_create_ctx(struct alloc_tag *tag, size_t= size) > > +{ > > + struct alloc_call_ctx *ac_ctx; > > + > > + /* TODO: use a dedicated kmem_cache */ > > + ac_ctx =3D kmalloc(sizeof(struct alloc_call_ctx), GFP_KERNEL); > > You cannot really use GFP_KERNEL here. This is post_alloc_hook path and > that has its own gfp context. I missed that. Would it be appropriate to use the gfp_flags parameter of post_alloc_hook() here? > -- > Michal Hocko > SUSE Labs