From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC076C5AD49 for ; Mon, 2 Jun 2025 20:14:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1AEC16B032A; Mon, 2 Jun 2025 16:14:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 15F466B032C; Mon, 2 Jun 2025 16:14:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 076C56B032D; Mon, 2 Jun 2025 16:14:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id DCFB16B032A for ; Mon, 2 Jun 2025 16:14:45 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 834631612C5 for ; Mon, 2 Jun 2025 20:14:45 +0000 (UTC) X-FDA: 83511563730.13.A081C4E Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) by imf07.hostedemail.com (Postfix) with ESMTP id AF19240011 for ; Mon, 2 Jun 2025 20:14:43 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=BsEARLUi; spf=pass (imf07.hostedemail.com: domain of surenb@google.com designates 209.85.160.180 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748895283; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OwQnFbUo1N2mHM92qaWb3kQKZuFrMPSfsPxvdB2R+/M=; b=rtZ9C8MCF0bPVYE5jb0xdg1BIJzaj/gPQpoRto72GApLHjMh/brzmOXlTSnEBP2vjZHJxo lzO9OivzDIk08G7s0uCNhEIKhlovodbMKbgp484VIuApYlCWqfL08oG34UbrV8IEfMcpU2 H6WsKXw0mR61ZeUJOFz7dvE24zNvXlE= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=BsEARLUi; spf=pass (imf07.hostedemail.com: domain of surenb@google.com designates 209.85.160.180 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748895283; a=rsa-sha256; cv=none; b=eLFiCKlbxM+w4ZakB192OgLa8a3L7I2gFRCxPal++aL4G3s0xHRjRHnNmQtQitTcQJNkLg xESkvirV1w0PcXTJ26ESEq6h+fA5Og3g9RxyCrXtdmjGtmWgIADz4tkoq1+PL7rPceFAzU m25BLG7OKGk9Q2waE27Kx3TVvXQ4zKQ= Received: by mail-qt1-f180.google.com with SMTP id d75a77b69052e-47e9fea29easo23351cf.1 for ; Mon, 02 Jun 2025 13:14:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1748895283; x=1749500083; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=OwQnFbUo1N2mHM92qaWb3kQKZuFrMPSfsPxvdB2R+/M=; b=BsEARLUiMRHW8AB5YHGxvhpbiATuHM7bZct8sNW9YHEtfDXJkMsvCRTWGwUOAWoKF1 299mtAC6CsZAPEy6j3n9N0dKCzI8EowkTszFeUoMtN9seRaUbD5r9D03IUaoVWe6l3WV pX6tXt/7Ei2FhSPChhIX8XE3f9xLvkClzudljUUJ2ubes4E1w5ijtKxoEpNIlyi9CJIc 9Fr2yrfQoz0SNdpkA2VvuLRLfvpNq3yFzdBliCQFoWgk2+uxninaT2125HSWwP2GMjaC 9ZwrKEAnWplxm6ifaGbOAI/xhXQLKlt5rxfxoK9eqVyKWCw67S1+nps4faZQAyq0SSkq R7BQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748895283; x=1749500083; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OwQnFbUo1N2mHM92qaWb3kQKZuFrMPSfsPxvdB2R+/M=; b=kaF5Dn747lDbod8/sZxrEB9GhNN+wZO++bgTc8waVGX4b3xkLVw7v8ONWryqFK02ZA R7SwBfid0yYuR823ONpcU7Yf+Q2py1mIio/b19r85RPYs9ZjS4tFzzi8W68+yUu78jYf B/hqjNeoYeC2LbCOk1d2TzWhTZsWAftn2rTei46wP7BvNZ+UlR0ylwjfiCv8yiiva4Vj Epcgg9KvJRsWRkcFpbaEw88lhp3Y8MGhf34R0k/l14wSS2pOJoOuYfrUEkJCLAFoDcSq ZHxr37BKohTywRKoXdfwc5mVZ0tiTlLyEqv4T0RvjAStm4LoENNJwYZGEjNUCPmwspWX rp0w== X-Forwarded-Encrypted: i=1; AJvYcCXh3chvVmOdCKwYcaHRkJ1lAKo2nCRJ6FkoO9p4la9O8OEAWloNCcDoZBl6lFhqPQIL+SsBhAyopw==@kvack.org X-Gm-Message-State: AOJu0YwxsXR0C6tBleNqxvQ5uWjqncgndysrcImTexm+wqhhfHQDT/m2 TAI28vX3NZjVEcPORwQm/guxygzPzQxACPnKCyOFZxOCfOFntRThxsVraM7CXhrXLS/tgvz/h7z DkmBQQ9J+CVBfIp42GbG9cPsq3qiD8uRXM82a4L5ZUwrZARcokwVVCNa3t7o= X-Gm-Gg: ASbGnctCzUQOW1zqaJippsKntJP/fuYB4+GegEZ5yThyZIIAMdvDMKKzPnXRa2CTC+0 QwbVMkbXgUpXo4zO88Cmpy+bV4AdcNVlaBXVJawlzA5ozUw205ExsTI9rSZHjTAHmnQ1N564MTd dUk1dhLlp0Tk7iCQLDXbcF5utraJMpOsE/l+zNKn1f3g== X-Google-Smtp-Source: AGHT+IHS1Xuh/mkhShSbemTOHzwc83Ro0NQEj5tcsy8NUaxxy70g0c+O2S/bgtb7kh2vhk9V7euCmgoqvOscgREDl08= X-Received: by 2002:a05:622a:5a8c:b0:494:b06f:7495 with SMTP id d75a77b69052e-4a599c0b392mr801471cf.24.1748895282492; Mon, 02 Jun 2025 13:14:42 -0700 (PDT) MIME-Version: 1.0 References: <20250523165240.1477006-1-usamaarif642@gmail.com> In-Reply-To: From: Suren Baghdasaryan Date: Mon, 2 Jun 2025 13:14:30 -0700 X-Gm-Features: AX0GCFsx49DltDxH36HyfGFlzyg2a8nzrdGMMurlo83ISlyHoByff7f22IoWlCI Message-ID: Subject: Re: [PATCH v3] mm: slub: only warn once when allocating slab obj extensions fails To: Harry Yoo Cc: Usama Arif , Andrew Morton , hannes@cmpxchg.org, shakeel.butt@linux.dev, vlad.wing@gmail.com, linux-mm@kvack.org, kent.overstreet@linux.dev, cl@gentwo.org, rientjes@google.com, vbabka@suse.cz, roman.gushchin@linux.dev, linux-kernel@vger.kernel.org, kernel-team@meta.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: AF19240011 X-Stat-Signature: yqr5wpofqkr4znbd6397oxi5okn13746 X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1748895283-801 X-HE-Meta: U2FsdGVkX1/g8wofYiGbYNTPcNJQ4zNCpJ4EZEsA10aNApDjfytmCgzEMEVx18Dh48IxTyKWGdOwiEBsuhWXgwm0yaaab6ID2QpNU9HpvHnnjhHB5+aBvAsf770QXZvsvAaYtaV7i5MgoHmpbhrHWN/W3uinV/YLQWw0tz8FGPInPt/zo25/rHK285lr91ZnGgOE8XnKmAnH4k97YD8Ht4HNs24/oJd+xQRvLxdjTnwiAPrKwXTIApaN82Ax6eSfEbxz3XHFx0jmubYxT9dq48Pa+c+jH3Bvd4SLAxgoHnqtJYbwTschG0jBik5mU3HvwWYzLsDSZT9zmwAlnfI5WwM/Z8RG++kgLjbwmUCQU8hstTvRxYGsVvUbS14Y3JSD3zYstKQ4U0Oymp+4KAxc1fQmaNxfVx+hVISRxYO5/KWkAxKwchdN3hsXiJ/pLYHBK1LpSzA5UR1+ubBd9IrrLqk3a3cLbJ5xVuZCSCDiD6q2+FhtlDpTY8wUFL1vss6ay0wVeFfIN41JD2rMZwPyyl0iat7qgGSnQZ43kQwQ3dmqiIOn2rhm0mF02kJh6zqybBXeet9zQbg5YjQ++LFpwU7rFkZP1dCbflfrNJQwtvnAXMmXkGf5xowe0tnqF5En6zdp2BKdE6M8MXRjsNrmu8wq5zYIOGrf1UeJ0j+Kx3ji3yrYEGfPrVtl8jhD1aXPS/DFQAzc0pjUyDDnl9tfnH/LMbLMufMBRTTpgb+OyCSMDtOXUYwTVmcGNyNf/Yz9KIKjhR9KMLvs06PJpeM1k79N4q4Hf7JTgti9uLwvWWQvN9pZo7e2XudeGB10UYtUAlIZrIDStrz0EAm4nhn0oeZPyYUXX43ks/Q2TK4zJG/2mnt2ntznUyJErkPk+JB5+gaHhKcqJ/dEONQUBi8XUgsXKzsa+vWJsbwlsl5N1/RPaohOAgxdeD0ZIaG9xcMfFmwveRXU/5FvmuPTVGX 9brUQKYJ q23k2KIGvJXBLB6wriJtnCSBzUE2XngTYvnrx7nXPl+aD0XHGX6z0OlY2UPrPurJ6yCUuN0jxASBF+0xrl82tAwSRHCBHNAem7SryJwypLknRw37MXVf0vHw449pM1paY38cKZQlzmZqkaFMrpwulmfZRpnj2qNsqRtZv+uvTHDb6Mw9/KYreQgQmix97SGsgFCMdYHfaclsQYVl20Qr/oCL3dHrFIHIZqMDYatCtp+0rcVn1lJFtmp2+8/7N7dwxxHbdGysu+IWVIAxwewzwa5UCH/nlnaTqNNvUsgtiiAYzyCG7sZWEiDxPn032XFePLyFiskG+Rb0Sv9+tMOksCLhV3nTZ0yte7vCYo1GB8jqXArg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, May 26, 2025 at 3:05=E2=80=AFAM Harry Yoo wr= ote: > > On Fri, May 23, 2025 at 05:52:40PM +0100, Usama Arif wrote: > > In memory bound systems, a large number of warnings for failing this > > allocation repeatedly may mask any real issues in the system > > during memory pressure being reported in dmesg. Change this to > > warning only once. > > > > Signed-off-by: Usama Arif > > Reported-by: Vlad Poenaru > > Closes: https://urldefense.com/v3/__https://lore.kernel.org/all/17fab2d= 6-5a74-4573-bcc3-b75951508f0a@gmail.com/__;!!ACWV5N9M2RV99hQ!Nv5xX_X4cBQR_H= UDO6qfamxI0GEW1eFRCpPj29lANRashIUJDrEWAjU7vlys76FH0voShW07CjpDkzSST46Irg$ > > --- > > Acked-by: Harry Yoo Acked-by: Suren Baghdasaryan > > > v2 -> v3: > > - Put warning back, but only warn once with pr_warn_once. > > v1 -> v2: > > - remove the warning completely. We will have a way in the > > future to indicate that the mem alloc profile is inaccurate. > > --- > > mm/slub.c | 8 +++++--- > > 1 file changed, 5 insertions(+), 3 deletions(-) > > > > diff --git a/mm/slub.c b/mm/slub.c > > index dc9e729e1d26..36d7c43a6f2a 100644 > > --- a/mm/slub.c > > +++ b/mm/slub.c > > @@ -2102,10 +2102,12 @@ prepare_slab_obj_exts_hook(struct kmem_cache *s= , gfp_t flags, void *p) > > > > slab =3D virt_to_slab(p); > > if (!slab_obj_exts(slab) && > > - WARN(alloc_slab_obj_exts(slab, s, flags, false), > > - "%s, %s: Failed to create slab extension vector!\n", > > - __func__, s->name)) > > + alloc_slab_obj_exts(slab, s, flags, false)) { > > + pr_warn_once("%s, %s: Failed to create slab extension vec= tor!\n", > > + __func__, s->name); > > return NULL; > > + } > > + > > > > return slab_obj_exts(slab) + obj_to_index(s, slab, p); > > } > > -- > > 2.47.1 > > > > -- > Cheers, > Harry / Hyeonggon