From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C027C48260 for ; Fri, 16 Feb 2024 17:04:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1DE5B8D0009; Fri, 16 Feb 2024 12:04:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 18E698D0002; Fri, 16 Feb 2024 12:04:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 006FA8D0009; Fri, 16 Feb 2024 12:04:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id E35508D0002 for ; Fri, 16 Feb 2024 12:04:24 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id A62B6A04F8 for ; Fri, 16 Feb 2024 17:04:24 +0000 (UTC) X-FDA: 81798290448.10.391C270 Received: from mail-yb1-f172.google.com (mail-yb1-f172.google.com [209.85.219.172]) by imf29.hostedemail.com (Postfix) with ESMTP id 6C6EF12002D for ; Fri, 16 Feb 2024 17:04:21 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=ljqPWAEP; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf29.hostedemail.com: domain of surenb@google.com designates 209.85.219.172 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708103061; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AONf6Rwt70Y/InxvAsZm9qasH+QAXmnPb6exgsQbAn0=; b=TTufAp8yn6FAV/Fxrd4yKpxdqToVFeob8/mASn1qp6Y9mj3es1xLl0Ek5e+rhamCGXnH5M 014ZuUGM8lXlfqsBV4RtsfR64cxNVuA8q7v9eApPasixR5FDJfo/Gd36TpaklUZhrYLG6Q NB1Jv+63JKJbx99BvxT0g73rcoRphW8= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=ljqPWAEP; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf29.hostedemail.com: domain of surenb@google.com designates 209.85.219.172 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708103061; a=rsa-sha256; cv=none; b=bwHME/MJ6gnf+3CRTXYTmwL9qnV5fkfWCq7aqMKIPesFr970jiqaKhQL+aO/99d0baU7QO Qtg0fLTVqZISkP6f3kYGTlCtW5RuA978j2lipU6iI8+AoUBDYvt7sznXv4SQ76b6SkB+2+ oZMw0Wl5LECg6oVADtQTk4TQnR5kZZY= Received: by mail-yb1-f172.google.com with SMTP id 3f1490d57ef6-dc236729a2bso2067448276.0 for ; Fri, 16 Feb 2024 09:04:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1708103060; x=1708707860; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=AONf6Rwt70Y/InxvAsZm9qasH+QAXmnPb6exgsQbAn0=; b=ljqPWAEPzmra61fuOhhhFlLXi8FDWfDZ7u4khNOHIVgGPW70kVRY2qCJGy+8k+PKtr UJdzQ6PilLjZcCJkZHlU56nr4W2MHxKhwKfH9QMKABOHOXGC7efMXQTCrpwr/QNarAOR HFh7zuCNYQ85VPNSVLEzfBgOQgtpFCFS0lQEz7a8CkIxvNXAZMIW+5J1grxaEsd9yXWc UUI75Ece8GmHmJJs43cK4Ninavi4+UlzRcQMdn2OuUbmq45f+qhfM7Ts8YQxwx1HvKML wKCBX+IFiGhq+h1iJE53akQC9uX7zzkwFmdfpTAwwT+aViu28SqkZAhLbL/gBBZ749x4 ri6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708103060; x=1708707860; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AONf6Rwt70Y/InxvAsZm9qasH+QAXmnPb6exgsQbAn0=; b=JwgV2JHuwDfLQgDSPNvG2apN33NlE5VmkIw5Gv1aM5egagElGgHQMFsoOZ7dkiC53j 2XPWmrmiVaOlgF+viBDGZ/BZg8VvdY8RlMzki41sZPbZKDRFvqmh+i4+OHm9Bkw0v/tv zO9Ck4cFTDB8BVPyZTjTwWVZ0DObT6wpybg45S4U7bP10Dlf9M42qDqXRQV02zlFWtFN 88EbA79D0o6nN13fZ44Ro8TQLmpgMliDon1i7tMkH/qhddUvgVJIEK7Oc2EchaABVyEM DFfYXu3ONGM4DHD8GkZ5eS22vWjqIfCOS0rcITIaLL6AJeDS5ZLeRxOGM0nsO2D71QqM KqVw== X-Forwarded-Encrypted: i=1; AJvYcCX7q7c02pQQukoo1NBRx7wqdsmmbQTw+OnCYipIxkxaJ5C6s4S/JeCaQ9qNNm4m+FLXzr6LQt4b0fgSHIHvIU+pGZk= X-Gm-Message-State: AOJu0YwZGlk19ja5g7dVDFF21YPgnMjvJ4Hd5c0QeRdqy0NMjFSVzE5A y4nkN0W4bnm91/M16lxRp9G+yc+NhiZcjWtovv/CWlWj93iqBrh8lmn1uk4+stygdjQCau6OBFl KC9+Vzrtee1/NvHV26HRbFglSAjx9DpVKfhwE X-Google-Smtp-Source: AGHT+IFKsCqKFJOqQT8bKrODn1/sGXg8SwbGnvmT7NLpaIG7hZMAXzI7k8uueS2KJuQc/CnCvGizvtw3FBEC6oUeP1g= X-Received: by 2002:a81:71d6:0:b0:604:a75:4274 with SMTP id m205-20020a8171d6000000b006040a754274mr4969437ywc.51.1708103060160; Fri, 16 Feb 2024 09:04:20 -0800 (PST) MIME-Version: 1.0 References: <20240212213922.783301-1-surenb@google.com> <20240212213922.783301-21-surenb@google.com> In-Reply-To: From: Suren Baghdasaryan Date: Fri, 16 Feb 2024 09:04:06 -0800 Message-ID: Subject: Re: [PATCH v3 20/35] lib: add codetag reference into slabobj_ext To: Vlastimil Babka Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, mhocko@suse.com, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 6C6EF12002D X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 46zpawi9wepqiymm1k8uxqcybbadna7z X-HE-Tag: 1708103061-190173 X-HE-Meta: U2FsdGVkX1/neYAfmontOaLpPay5Zl3MwPNL533EA/ely7kmAeuI+4k6MY0ls6O9Zlz7km1m4+wP80qRymkJamWUenIbvoUKd/Hq/AtaPOjtZgYsm6BhADX/cTEJgNfaSzdBjYMU+7BYOe8uULwKalGPfRilNvHbrM7bqJyZFdy0m31+mEsphpW7MVm5UUOpiqPjUAY62VfLf4JIhS1Uor5hWwmkviDgslL3vxe1UD91IUovSkbmoZzIZBGQ0ChocX+kfR3zULUi0Qr4kQqYbbQvj465pWNjTqhyb8CmsQAX4YWMShUsEkUX0cSOp/HeU6XLMSCX70VaXalvdHd2WRfpHRTXOW2TLTNZ+gNewYAHVkpAlkZ7gQj+lfc6yUKC0f0KfDTJ+2Z37aSKCbf2VzgdpkCixYQJJG6EMlKhFHJCly3OjSm9F91dGjwk93NI9yeRmePTVYEyj8WRl4Pz5zojM1KRpBgChBavUgM8RATjcGj981Iv9outsFQRGya+ns+QxheH9aqO90/dJcJjuQUnzKMYJA7izT13uadiyPne4mmefxhj3p3yhzoWCeh0vJLCopfcd5rk0I0B0fwVv5YH+zIgg3KZHtfAsTUCx3y7QDW5xT0UyVRL+uDnnyMHE+G8/55hnHIGX+H0gTpG0IyHbE2j6+JMmn52i1H0TyiO/HAhHhva0vhZ4Gd0nKfMqraBL3/uiUcwVvHKshjW3fqAnYuHAzMCn4XatlrbLumCRmT5nyQh6fo8aXuUdis+OSXEPfN9LqUhkmx5sSEU5pObyrZ5UQKM3I4ikVVccA3Dn8gGi+iYuYQctWO/yzd1TwjqEIDceSoKHgS2FrpYfyt8uxkWPc7c2Vbr7HLh7WeqsDgVDvovkfdgMI6DRW4M3VzrMcctm/6uENna+hi4VACG+P8dXnarNiDvkcWxCtrWkr2+A0DSDU75Gpo7xo91B98RbWRpFGIABiCmhnr e3QNhpqs geJl6hYB27TsiIAdP11UZrTDWBGcXSWhiNqfK6WiTwtInJvW4JWLSmD1DcRkY3os9Mn+1NG9Eml/CQ0zwJoKUPrh55LshKm6jXBYCgmhvR87LO++Gou/vBJlwSwjuUJumX0OZsjRWFbJEDhh3BsqE0PPFv89i1Kgb5A7uZUXvO6kuOTQCVm4DmjoWvZ/gik3QCzVSo/lAKcMexHhvIQiGw3n4+sqf5rJBqCulEzFyAtnHQ9zgMEJme9vaD7Z1HCpSAngJ81gPNX3XqNdhU4ge5lSViOEVQaCScimHIbjWjGCU025JwqY2zi/ZsU+EHymYs9UGbWlS8bbpELzxzRmW09mAK265xpDW4idRtcWjKWuCzd94YmTE/oU4T2mHFTfFg6cAw7/PyEREczMUvuNqCyRmrg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Feb 16, 2024 at 7:36=E2=80=AFAM Vlastimil Babka wr= ote: > > On 2/12/24 22:39, Suren Baghdasaryan wrote: > > To store code tag for every slab object, a codetag reference is embedde= d > > into slabobj_ext when CONFIG_MEM_ALLOC_PROFILING=3Dy. > > > > Signed-off-by: Suren Baghdasaryan > > Co-developed-by: Kent Overstreet > > Signed-off-by: Kent Overstreet > > --- > > include/linux/memcontrol.h | 5 +++++ > > lib/Kconfig.debug | 1 + > > mm/slab.h | 4 ++++ > > 3 files changed, 10 insertions(+) > > > > diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h > > index f3584e98b640..2b010316016c 100644 > > --- a/include/linux/memcontrol.h > > +++ b/include/linux/memcontrol.h > > @@ -1653,7 +1653,12 @@ unsigned long mem_cgroup_soft_limit_reclaim(pg_d= ata_t *pgdat, int order, > > * if MEMCG_DATA_OBJEXTS is set. > > */ > > struct slabobj_ext { > > +#ifdef CONFIG_MEMCG_KMEM > > struct obj_cgroup *objcg; > > +#endif > > +#ifdef CONFIG_MEM_ALLOC_PROFILING > > + union codetag_ref ref; > > +#endif > > } __aligned(8); > > So this means that compiling with CONFIG_MEM_ALLOC_PROFILING will increas= e > the memory overhead of arrays allocated for CONFIG_MEMCG_KMEM, even if > allocation profiling itself is not enabled in runtime? Similar concern to > the unconditional page_ext usage, that this would hinder enabling in a > general distro kernel. > > The unused field overhead would be smaller than currently page_ext, but > getting rid of it when alloc profiling is not enabled would be more work > than introducing an early boot param for the page_ext case. Could be howe= ver > solved similarly to how page_ext is populated dynamically at runtime. > Hopefully it wouldn't add noticeable cpu overhead. Yes, slabobj_ext overhead is much smaller than page_ext one but still considerable and it would be harder to eliminate. Boot-time resizing of the extension object might be doable but that again would be quite complex and better be done as a separate patchset. This is lower on my TODO list than page_ext ones since the overhead is order of magnitude smaller. > > > static inline void __inc_lruvec_kmem_state(void *p, enum node_stat_ite= m idx) > > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug > > index 7bbdb0ddb011..9ecfcdb54417 100644 > > --- a/lib/Kconfig.debug > > +++ b/lib/Kconfig.debug > > @@ -979,6 +979,7 @@ config MEM_ALLOC_PROFILING > > depends on !DEBUG_FORCE_WEAK_PER_CPU > > select CODE_TAGGING > > select PAGE_EXTENSION > > + select SLAB_OBJ_EXT > > help > > Track allocation source code and record total allocation size > > initiated at that code location. The mechanism can be used to t= rack > > diff --git a/mm/slab.h b/mm/slab.h > > index 77cf7474fe46..224a4b2305fb 100644 > > --- a/mm/slab.h > > +++ b/mm/slab.h > > @@ -569,6 +569,10 @@ int alloc_slab_obj_exts(struct slab *slab, struct = kmem_cache *s, > > > > static inline bool need_slab_obj_ext(void) > > { > > +#ifdef CONFIG_MEM_ALLOC_PROFILING > > + if (mem_alloc_profiling_enabled()) > > + return true; > > +#endif > > /* > > * CONFIG_MEMCG_KMEM creates vector of obj_cgroup objects conditi= onally > > * inside memcg_slab_post_alloc_hook. No other users for now. >