From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41619C52D7B for ; Tue, 13 Aug 2024 15:18:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D28EF6B009E; Tue, 13 Aug 2024 11:18:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CD8FD6B009F; Tue, 13 Aug 2024 11:18:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BA0D06B00A0; Tue, 13 Aug 2024 11:18:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 9CAA66B009E for ; Tue, 13 Aug 2024 11:18:42 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 09F98C0853 for ; Tue, 13 Aug 2024 15:18:42 +0000 (UTC) X-FDA: 82447579284.18.F35C2F8 Received: from mail-yw1-f177.google.com (mail-yw1-f177.google.com [209.85.128.177]) by imf30.hostedemail.com (Postfix) with ESMTP id 48F0D80023 for ; Tue, 13 Aug 2024 15:18:40 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=OTSvUbJ5; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf30.hostedemail.com: domain of surenb@google.com designates 209.85.128.177 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723562241; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=orcsmtL/8cZEhUN0C11+6AWr3aA646WIhi/b8LGiqsY=; b=Yxa2/4Xc6dRbZ3Mvvzw65fqDIdockBjD3U3LgtyfuRcj6PPN4s1XUfD9edMkEKz2cdgVLC U6mU1NwgDnYsvnoIMKJn5yvfa8gUp9YgT8AHHf+aogROWFpB7MInMTA/QOIm40sxUmHwjN VDo+jqXdrZY17dWqIHUEL8qNaACaeDg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723562241; a=rsa-sha256; cv=none; b=tMf5HJOLMPgSvFBMwDlis3FjNaQxTDVWoLukajSUwyfctKXJid50S1VYO+ZaVa7G1NHM8+ bmGwrLYkxfDaTmqq03Pm0VjDizgVVnc1sgm8vqRA/2RO8WRwqM71njUTSpxgLNhvKVQmLP KjJbpJS3t0XjOWxE7FIw9KAHrekYlcA= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=OTSvUbJ5; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf30.hostedemail.com: domain of surenb@google.com designates 209.85.128.177 as permitted sender) smtp.mailfrom=surenb@google.com Received: by mail-yw1-f177.google.com with SMTP id 00721157ae682-66acac24443so55979977b3.1 for ; Tue, 13 Aug 2024 08:18:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1723562319; x=1724167119; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=orcsmtL/8cZEhUN0C11+6AWr3aA646WIhi/b8LGiqsY=; b=OTSvUbJ5gJlQ4X2niZYUZuD0hwg2b6d+UKiOFYABOhZyTYsW+aMiNnBoNhhydLFeyw 4Qqac0qhbdUmcUGC2d+TzrZ138PdwsoMSCyf7+gkx+tks6/yiy9a3/mN0+gxAOUKoAs2 WAwm74fc4nolIvAnXXnhThLn5hWfYxCV766Jlbn1PDc8HOOiD32QCF0m3f4VkO53EoRe /w0Xr8dw61qeAmq94laLZXfLxfO0npcC9q7caCth58gzX7/y2wPtTTmmUQltJ8CofAuw YNFhS3RukRY/yC3v/ojZ7nyZ3roD49ULH02VjiWjMU0X9YeE3NLUYdDIx3bxDDknLiy2 WmfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723562319; x=1724167119; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=orcsmtL/8cZEhUN0C11+6AWr3aA646WIhi/b8LGiqsY=; b=vfEnOM9ZgYoGk9U5PSE6Ed9DCt8GRcj+eWX2yov6uq/X5V9saJi0sGJQgjBoKqznZk +7ijDRopQa96GOZ0X/dIYQLNFUcFi5xWGAsRVj0HDSTv4qhHLObSWgaeSdzAoLAgz7kK xi3ZHwsnHJ8xvO2DpnffV8U1FMcKyPwctGRxJ8n+gPBiGqVIyUTrbUIAkVj/fQMdIrNY kFZcuYVKy+5oeIlyDr4cNBvYg8RoN0g/Hc/eHAfidMr0EFpu7bKYzsdbGmTwzRoJHmqY lpRxHKAzDeL8hm5pDIAV2j4YjsUuGLTiNbBPYaK5v4LdSBlrzyb6GKxZNUD1aRjBHHwC TplA== X-Forwarded-Encrypted: i=1; AJvYcCXvxHvxHxT7Fs4GbbvpQfGo0ZmnDqHFiyRgfdkmIhh13w3XKqGVeRs3j9zoZUkAbrYx/pyVVdWZIP1Fwq+vmHww7Ws= X-Gm-Message-State: AOJu0YwQgNq/y2qo7FDx7U3Di02zlIyRiOhrVIWOfQOJMYlHZGIukoA3 z2xZj/1T9MUXm1CzCXOmWCtlKOVqFL+tPC/JwRqs2Ei3Xf9yLOF0WVm3PaoI2Y6Gus368gUPgeh k1p9ySavvCWupdgvrvkUuI5ZB3kW0HJttBxnT X-Google-Smtp-Source: AGHT+IGJoMp1feg1oGb2ZdcYiOSno19Nh1KQI24Vgz8RgE0LN3DGPO7716w962lCozndyaBR4SE5D1AmZRzVRSaqFaQ= X-Received: by 2002:a05:6902:c08:b0:e0b:e2e2:8a87 with SMTP id 3f1490d57ef6-e113ceef41dmr4661079276.34.1723562318817; Tue, 13 Aug 2024 08:18:38 -0700 (PDT) MIME-Version: 1.0 References: <20240812192428.151825-1-surenb@google.com> <471af0a8-92fc-4fe0-85e4-193d713d4e57@redhat.com> In-Reply-To: From: Suren Baghdasaryan Date: Tue, 13 Aug 2024 08:18:25 -0700 Message-ID: Subject: Re: [PATCH v2 1/1] alloc_tag: mark pages reserved during CMA activation as not tagged To: David Hildenbrand Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, vbabka@suse.cz, pasha.tatashin@soleen.com, souravpanda@google.com, keescook@chromium.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 48F0D80023 X-Stat-Signature: wyspz8ud7itixg5wd3g5i79xsauit97z X-Rspam-User: X-HE-Tag: 1723562320-559480 X-HE-Meta: U2FsdGVkX1+0FHgyefqmy8WS/KvF+QaUuKI4Z7mIM767Dn/HtPQLdoLvtABCDUckvfJQNvN4cdg62I5lOzWVgt3uLYpISfQ7XIt43VtJr+ZwzE7aKEtgW4iW7N4D+LJVPs4mVUPNAchFiLnPAA8aDQqXSc0v8CrI0YL8KzmSK62xgNyDA7mVjfPkuxHRFZc2WekJP1VUjsNsTdLDKiScdFdvNdSnNYdk2n1NrIGjCKv2oOeAb+7dGu37vWEobjiNuhGNcsk3uL5XyOl/JhvwLrMgmX8Voc59CUYrbmpKdPrHqSR7P/moDNQn1vmXMuuKsKr+G+GTPylei6tbM2CTffzkBmWKTEe0eN0g8aXRsvks6gEwYtOZ+08Yey3jgOZATUv8K3yIifWt2Kn0d20WdpUy0OC7+F1npiCT1UmZAeEpfdq0ye94wgNJqibNNq0wsHspYpXFveFZ15kVOgtzkrSb4cVm+9W4i3m3oYFgxO0wyiIVS4+fTrZGFakwDBM0Do+kRdTaydCfk5dQqJULpD4XxjoGnkVcicmWWM3ik0LgAMMgjJD9r1cV/rRuKutKyD6x5ToxN4CSfJ/zPNa1YnReY0pik0y522u9Wk//nLwo8rLpx3VZwuNtcNP2g0EjKdv2vU03NmnAX3pnCxASMXcYo0qgaHjtVP3fc3Km7fn+CmocZLNSDZA6HqsCaPlThV5b+SF4iZdyihmeRIbd6LvHuC1i5nZSxaBQge3JHLLFmK85eOohNRXGJFSMwiUjTRRJxxBZLsppgSI1fTKkgudUO58nkLCkCxXedJc9afQMbBQARtwNiXr/XsHilkYGxoLA2ggW7HqLKldJTnFjqyutLarpiHsJp4TgrD0az/tI936y0+jh2FXE3Oiaam+ZJLsX+zQ2/8IxYMn2odzYXdLJFKsb/UW0oW9DWdKR2fSs6UT7DK79hRRokjQCqbgLXbpFHHlWow7rAEb8HZO yJE+lpsJ tsMwxsaEYZ7n8QxkYAvfrp2tvpIahVog42EpPx3PkWlZF5aUoTpA86XLdn1uOeuu7i8aqf9LYHdyMe4wRu3oC/IvNVqA/fIdfGXKZ7jzD511DZx7uh4Jzp9hbp3Sz0nVIil9uO5uvKhBsy9W+jGapiCqm3s214BpRHoqTaoxOSe6doYpKjZPQ65scvXtpf6BPw58PK5jSvBpctk780/BULTNkXcjZOcmWNSL64zWbNksc1Y5jv9sjfEVIXQMbHfDv792aZf/+E1tcVlzIkz4pcujke5A4tGQfWxZMOXTIrrq8nm6m5GsD/d9oKz8QGkLzK+fQ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000006, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Aug 13, 2024 at 7:27=E2=80=AFAM Suren Baghdasaryan wrote: > > On Tue, Aug 13, 2024 at 2:25=E2=80=AFAM David Hildenbrand wrote: > > > > On 12.08.24 21:24, Suren Baghdasaryan wrote: > > > During CMA activation, pages in CMA area are prepared and then freed > > > without being allocated. This triggers warnings when memory allocatio= n > > > debug config (CONFIG_MEM_ALLOC_PROFILING_DEBUG) is enabled. Fix this > > > by marking these pages not tagged before freeing them. > > > > > > Fixes: d224eb0287fb ("codetag: debug: mark codetags for reserved page= s as empty") > > > Signed-off-by: Suren Baghdasaryan > > > Cc: stable@vger.kernel.org # v6.10 > > > --- > > > changes since v1 [1] > > > - Added Fixes tag > > > - CC'ed stable > > > > > > [1] https://lore.kernel.org/all/20240812184455.86580-1-surenb@google.= com/ > > > > > > mm/mm_init.c | 10 ++++++++++ > > > 1 file changed, 10 insertions(+) > > > > > > diff --git a/mm/mm_init.c b/mm/mm_init.c > > > index 75c3bd42799b..ec9324653ad9 100644 > > > --- a/mm/mm_init.c > > > +++ b/mm/mm_init.c > > > @@ -2245,6 +2245,16 @@ void __init init_cma_reserved_pageblock(struct= page *page) > > > > > > set_pageblock_migratetype(page, MIGRATE_CMA); > > > set_page_refcounted(page); > > > + > > > + /* pages were reserved and not allocated */ > > > + if (mem_alloc_profiling_enabled()) { > > > + union codetag_ref *ref =3D get_page_tag_ref(page); > > > + > > > + if (ref) { > > > + set_codetag_empty(ref); > > > + put_page_tag_ref(ref); > > > + } > > > + } > > > > Should we have a helper like clear_page_tag_ref() that wraps this? > > With this one we have 3 instances of this sequence, so it makes sense > to have a helper. I'm going to send a v3 with 2 patches - one > introducing clear_page_tag_ref() and the next one adding this > instance. > Thanks for the suggestion, David! v3 posted at https://lore.kernel.org/all/20240813150758.855881-1-surenb@goo= gle.com/ > > > > > -- > > Cheers, > > > > David / dhildenb > >