From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0682BC38142 for ; Wed, 18 Jan 2023 02:01:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 614296B0071; Tue, 17 Jan 2023 21:01:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5C4366B0072; Tue, 17 Jan 2023 21:01:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 48BB86B0074; Tue, 17 Jan 2023 21:01:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 38C9E6B0071 for ; Tue, 17 Jan 2023 21:01:15 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 029231602AC for ; Wed, 18 Jan 2023 02:01:14 +0000 (UTC) X-FDA: 80366267310.07.228900A Received: from mail-yw1-f173.google.com (mail-yw1-f173.google.com [209.85.128.173]) by imf06.hostedemail.com (Postfix) with ESMTP id 5D4F3180023 for ; Wed, 18 Jan 2023 02:01:13 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=k9nZqbAy; spf=pass (imf06.hostedemail.com: domain of surenb@google.com designates 209.85.128.173 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674007273; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4E07Mrlokbjok8NyF8LoBrAZNQWCs1UWN04ZvvsKt1E=; b=ZExUqJPgjdQyWlb3b8/VmdVnL6WKpj7miDn2FzwtS3KKGV8uoQxMcWgkvwjUUD01wI/ou4 iN3wOvZD1Sr7xtsdBh7JfwZiKTnv9t4XDHk73hKjiZ1mb/dJZNj8iHaYuTqcKIBAHEMR6X jeb3UNfU3QPLp06AmnBqd3RteAwyiZ0= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=k9nZqbAy; spf=pass (imf06.hostedemail.com: domain of surenb@google.com designates 209.85.128.173 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674007273; a=rsa-sha256; cv=none; b=3DWS6vhtTVcRt/VZegT8+cTzbJDTiUgvK3xpqJNAVX1xf5AZPdL71XaxIz6Y37QBioep1B K/1Ec1+lQGuyXPA7ViPYBLc9Hl0kApMi+CChUtV6EjKfRQMdlg046ZkNFTbElZQfjQVSS4 jmVBud3McHWo4hyMjkgsGlTamGxGQJc= Received: by mail-yw1-f173.google.com with SMTP id 00721157ae682-4e4a6af2d99so129731057b3.4 for ; Tue, 17 Jan 2023 18:01:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=4E07Mrlokbjok8NyF8LoBrAZNQWCs1UWN04ZvvsKt1E=; b=k9nZqbAy6zimnKuDQP5Wi59ksf9yl4aqdPitA84ns9UlmkktReAp9H08OJzyEbCc9J jlDJGMFtUt+DQUFCjpFjACsoOm7c2T8Ko3BIWmNfotQIa4DTLkedyccK3mJJ5Ty52tU7 Pjqt7Q630XACChklgKzdcQGHFItj196tBjXccVmZpdBJCyn6CNLYisPTgri5QyuUVR+7 dmUvvZbw8Qidf7u0joBcNRjhlVUuqFpoLv2ThdeXP2UpNCfOLsBXBlqXHkBQXH0g/JiS Ag8FlCGONB7nFbeNMrZ59yFKtUHJpRow7tNRX5eRbp7wzA9oeEkB6FFhJC81J/OTedMt 9Sfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4E07Mrlokbjok8NyF8LoBrAZNQWCs1UWN04ZvvsKt1E=; b=2SJlNSAgDXxdTtLseIzceHdorApLqz7fLup1dxQZh1gviv9eJO9GKXx4Pmb86yM9jP t+Rl0THWUzanEbNks7pItep5VtvMDEVtqjYVHRweUWTFH5ttgLtoGvPQESyYnTBe3bAY 2mc3jsg7eEB+K9nPuh1sSwidXdUOKl/BkWZIN23uVg/rVTidEuZN0258bQUAG+aanXPv 9ALl9D9xtGOetbHBJynQbnsZn4yvE+8HYALgFtW5ncfMTS5Hdja42uh3d3O393OdEVys Si+SopTG+r6G0VaRjMJ0A47hQzSa1wVP/Y55+r38cqUI5T45R6RbeMhyvpa3HUNpG6AY pfcQ== X-Gm-Message-State: AFqh2koS1DCKaVIwcrVAFjqdAxlvTstapyH3OkvcBQoAGNVs8FtfoldR dk61CeAAsFm9moYbzpAjdQg6SXF3z47AUDb/TZV3lw== X-Google-Smtp-Source: AMrXdXsZWeD7TD1LZKXqm18TxRLwIraaKkRGisl2ohrjniYmFM7Qtmaw6wJy/oQcDtGLbtaO2lGyLeazDPZnc+XZmGs= X-Received: by 2002:a81:1d2:0:b0:433:f1c0:3f1c with SMTP id 201-20020a8101d2000000b00433f1c03f1cmr704506ywb.438.1674007272153; Tue, 17 Jan 2023 18:01:12 -0800 (PST) MIME-Version: 1.0 References: <20230109205336.3665937-1-surenb@google.com> <20230109205336.3665937-18-surenb@google.com> In-Reply-To: From: Suren Baghdasaryan Date: Tue, 17 Jan 2023 18:01:01 -0800 Message-ID: Subject: Re: [PATCH 17/41] mm/mmap: move VMA locking before anon_vma_lock_write call To: Michal Hocko Cc: akpm@linux-foundation.org, michel@lespinasse.org, jglisse@google.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@techsingularity.net, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, peterz@infradead.org, ldufour@linux.ibm.com, laurent.dufour@fr.ibm.com, paulmck@kernel.org, luto@kernel.org, songliubraving@fb.com, peterx@redhat.com, david@redhat.com, dhowells@redhat.com, hughd@google.com, bigeasy@linutronix.de, kent.overstreet@linux.dev, punit.agrawal@bytedance.com, lstoakes@gmail.com, peterjung1337@gmail.com, rientjes@google.com, axelrasmussen@google.com, joelaf@google.com, minchan@google.com, jannh@google.com, shakeelb@google.com, tatashin@google.com, edumazet@google.com, gthelen@google.com, gurua@google.com, arjunroy@google.com, soheil@google.com, hughlynch@google.com, leewalsh@google.com, posk@google.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 5D4F3180023 X-Stat-Signature: juxhfmsydcof67mr3wkufqrbxgogytqc X-HE-Tag: 1674007273-915690 X-HE-Meta: U2FsdGVkX1/9fOl5MVHDsuZ1443LC4KE5gZhueQ3VRkaqOSHj5q7cijSsKuwQZO72AqDDULFvImFNj39c/PYlDI5YP6PCVMYl3FZCMMmtd2a7AVyT94+VBHp7rVY0WlUGKe4hcOgSq4DL7ulDOlDuvvPs6DYGbbbUpfcfMJC8bfeARaf4XOryf4501m5XAhZB3LNBDER/1ti8ATn0fQjsQmSI2XVKSDk6F26pHxcrUJBGV0udn7aW+5QwknsZAyg0coQjV5eg6FU3ENdpBlUFtW6g7Epvy5R8UkoPmP18rMbEjoVWcactS99G+xdwekbExKHElQa+d4E3j6zt9uVBsuGOH4kbGePrncq2mMsKD8eVqVylX6xGQw1DPTOifj9r3H9YKOzH+HtXKNiW+JQZdXlOxwlEn19urrZ99+I5RVTb73jSPhlsFFw3LkcFi/UYKghJeQuhY2Rv0jA/2yo5sPA++RAxPUVZkXx5zgMYrdIc+bQhWxAceLb8+HvU4V4VJWi7UFWbClb8f3Hb60XX2kFSSmqOAlzterEDZTnw2pJ3mt+N0NuCm7L6sh6t80vHQToD89p0J5sBsm2XRCQPTsEhL/Xad12iNcQWQBRw1UQnargWQXEB4/AWMgEIpogEnGW1eBPCNwnpcQzgSoC1MMAwBpDQoqIOE9Ucw805iWdjhr0shp8sI6HV5bAGYKS802uleKqOgw+5ErRE4yol2Jw/mDqJp4Nr9y6zCWUEgXpPletlAoCh4wx707QfFwrOhxmE7dN7wRc2s3QQfi41IF7y2M/qV7Nsxk5UHm+GRfRIjbGlcPyAxfp93A5K9iFxwzCkKwvfiMzb9c5np0Cf8YXAFeShl3maKuDvbBmGxA61gVw3HweZXExS3Qq38Yelt4WaBJShOwb4UL22Z6FfS6LjlNhzjQRlUZCp3SJDib58nwxZQ37V6ao4TCMy6/DmhgkyRdsGnl/aYetQjN vLfzd10w cmOuqao2sAmNbP05th5c/1U39ou5fhnHp3idqy1Xt5QBSpFUkjKPBOnEXhg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.009344, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 17, 2023 at 7:16 AM Michal Hocko wrote: > > On Mon 09-01-23 12:53:12, Suren Baghdasaryan wrote: > > Move VMA flag modification (which now implies VMA locking) before > > anon_vma_lock_write to match the locking order of page fault handler. > > Does this changelog assumes per vma locking in the #PF? Hmm, you are right. Page fault handlers do not use per-vma locks yet but the changelog already talks about that. Maybe I should change it to simply: ``` Move VMA flag modification (which now implies VMA locking) before vma_adjust_trans_huge() to ensure the modifications are done after VMA has been locked. ``` Is that better? > > -- > Michal Hocko > SUSE Labs