From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B2B7C4829E for ; Tue, 13 Feb 2024 02:20:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C14796B0080; Mon, 12 Feb 2024 21:20:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B9DEC6B0081; Mon, 12 Feb 2024 21:20:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A17616B0082; Mon, 12 Feb 2024 21:20:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 8BE766B0080 for ; Mon, 12 Feb 2024 21:20:28 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 5860C1202D8 for ; Tue, 13 Feb 2024 02:20:28 +0000 (UTC) X-FDA: 81785176536.16.CE8F98F Received: from mail-yb1-f171.google.com (mail-yb1-f171.google.com [209.85.219.171]) by imf17.hostedemail.com (Postfix) with ESMTP id 992A740019 for ; Tue, 13 Feb 2024 02:20:26 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="ZFfT/Ye4"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf17.hostedemail.com: domain of surenb@google.com designates 209.85.219.171 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707790826; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=S9sbRuvYiarABejv+1FZRtHjtyC1exllh7yCDkk639Q=; b=s0ZmTqP4TPSR00AYZ3txmeGDsU4OnRK4jN3/O+d3MYkNfMFOn3pL6S9q1SriAHDwbq0lTE REYaJ2O/AbJjvV+uoMyn0WGy7DsFzpwHWOKYYXR0w6jfxOlkYEHkvdP94ezUj0rGr2ykoz ukb0k3oZsSRfYrXHgq+qPegtCnhKTTs= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="ZFfT/Ye4"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf17.hostedemail.com: domain of surenb@google.com designates 209.85.219.171 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707790826; a=rsa-sha256; cv=none; b=V88jR4evcRI2fyh7Dc/cDssD8L9O6WPHK8q5ucPfgmP7eahBrY+GWysgnY0nHLhRXTX5uD d0usGzlhDwQJmHtlX2aMwJPMEvJQNHHnSL+H8/ni/eVXUwxmnrhSMviAmh1adRPUFbf5W5 yilIsrvf1NvqRKY+KAd/bqwSWPcigSw= Received: by mail-yb1-f171.google.com with SMTP id 3f1490d57ef6-dc6cbe1ac75so3118319276.1 for ; Mon, 12 Feb 2024 18:20:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1707790825; x=1708395625; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=S9sbRuvYiarABejv+1FZRtHjtyC1exllh7yCDkk639Q=; b=ZFfT/Ye46X6tbRpuR6YIiYJPAEdCp887fof0utzmq/B+cpidr2LQnyqUCjS97j5djd KotGRKwX261p/9Xi1CGPnTIOr8yFhf3afGb32D0BSkED/5mopGY8u1ADuX/MzLgpNQA4 2mRG23AUBJjGyyRrvhjgnqcrs+qPrbQqS8lFsoNIZ86t0U5cfl6FUHlM/nSQrwakV4Bd WB9NnDOWZ9bXuKqOyEwXyTf2rj6zYKpvoLM04ERvsI35i0FrN8PVfItBkvpamCIig9UO 1ymnfjLLun3b4q0RCQWv0iTljkIk+2Q1yw+wZihu9RCzJNG0yXYR9fxRneB81mO2n9js mcJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707790825; x=1708395625; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=S9sbRuvYiarABejv+1FZRtHjtyC1exllh7yCDkk639Q=; b=CRx/t5WFoPJUzTIJqg9YA6CLhPt6D/oaAaIYnvZL/spBORlJBCp79s6Cwl9musEtqu NCETexDX4LAstpEWTY2tm/xivd0OvBz+67eBi7FC4/LIL767Di8YBuQjw7Ze+WYe4bjt tmupcas6ar4MPy3fsXY4mqkQGYtbHHgXz7iXrIi9l3TyyFWPza5V3OQlW5chfcmOGfim edyWitK5yO4k//RQETYa8VzO9rzfvpRKb28sLhS6aw3yVUKbMDKBp7lDcQzKxsvfolIY OIiVhepMioabwGJVMdjbjThzpn6eurZdpjFt5YVHMC5taSqmQFb9IBBqVlRrsIlQD987 f36Q== X-Gm-Message-State: AOJu0YzZqXMKvQ6UkkWhDtWnMD4DKksi5ixo8QGpI+aReNrDTgjBFk7K km0diHT+gT16fyPmmyzTH3cu3oIbtT+RbcPpp42+7eVQ8W3vWHY5sgjFalTzKVyAY3y9qejB9oR w5h5cpKEEJj+iXqc+adF/X8xP7G6jpOD/mqrI X-Google-Smtp-Source: AGHT+IF7VIKyAprzsQj97Z263Qoier3okujGUFo7m34RyS9jjnxf5dSV3vlCD/UI6jUXKLUqELRXLl2excxB7HnDSlw= X-Received: by 2002:a25:df91:0:b0:dc6:de93:7929 with SMTP id w139-20020a25df91000000b00dc6de937929mr863370ybg.26.1707790825358; Mon, 12 Feb 2024 18:20:25 -0800 (PST) MIME-Version: 1.0 References: <20240212213922.783301-1-surenb@google.com> <20240212213922.783301-6-surenb@google.com> <202402121413.94791C74D5@keescook> In-Reply-To: <202402121413.94791C74D5@keescook> From: Suren Baghdasaryan Date: Mon, 12 Feb 2024 18:20:13 -0800 Message-ID: Subject: Re: [PATCH v3 05/35] mm: introduce slabobj_ext to support slab object extensions To: Kees Cook Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 992A740019 X-Stat-Signature: 63meqxbkh664fez4389z8fewpye7a65q X-Rspam-User: X-HE-Tag: 1707790826-689101 X-HE-Meta: U2FsdGVkX1+ELqbacpFRXd8oTI4KDC6MTR+VygVDFjDgJwkCFPL2uFWR2/51VhvFRr3ytbGB6DEvVXqd5FuUg1rNZBZ5D8hpniulc+Rngyupl/e3BZ02us6pcB8mIMMOH9EMLPt5Eb5IoXxROMPpjhGc8lenPOGT7zgpA0YCjFKT0FCeF1r2rNLw2e/I0+Plw8jVACN4nXnWjHF4TfqL9ElWU+PUx+PkAg3OFN5xuqZMVV/g4w+yYUSVmuV4IUCyt5dWykWaEiUYAIau5Cmg1YqypGjqwTNXkC5SP1CtsZrn+LRNNe59ogF2PK3HKUHELqFNowfq7G+G4/cHXFjK46zeb6Mr6coa8HMnIxIk8gGjZVcFgs7Cp2746+9Xou1Vra7HP6xloFBLzW9GCV4AWX5ANMHJxtWZWGVH6axv1NWn+dsil7fq/6ACNhZ1bKiZZbOPxGOsdNLgd/k8RMRETwlWR7Dw+TNnHtw5znwS3fdrer6SmyAEqHSJC3uKLzvRzY+e3dL38DdnYDQDGjD+cKNvEXXaI2qj5gBReuxjzGGWKXaJmogRdtf3dwVIc75/DJ5sC9RMc7nqRCgimaI7BldEdtiaAnNZ6bbbqFkebo+ki/KMXL7DgRssXFMA/vzaLt3J32JlHnFSua4rmL2gsXMgrKjyxaraglTzfOi+fl1L8gOTnMrk3zTIJBNuaHfjggiq8cwAxSQqpce3Bk4TVgxJulXeBAtf+TP33pxmL8NKhP6xAk9c2699TmhLV1fs7TrzEQu+YOLE1Zspa4wL1qVgJHMNnpouv1RY/O51ZPId4aC0CEDjpO2w5jZv3Gfs352G6VhrMDaKTCS8Nk/ZAYH3UcyqL+4EXa0Now1KkCOwb4cU3KxPRww0CLugbOHV/VECoP1cZLrd4NC2X35FgrFDM5t5d8+TFikOklT6/uTMkFc410XgV/cr5H6tfiG3P3NL7xX4L30IL3AmX9s tGh5QKka J8nmN5vMLT+RKKm1gdpOQ2cJ4Hk+U8Ajx1A9jjHYNBYybk+suhZWbPdBiWfhZdcCBHm0oad+yj4Tvkx4vqXVrTy5jZv6XXC61rI+FAwjR4LiI7SWkzcUwaGJP4VxqzD4DQjPbs8E7UvPm/jM4/jo8YiJZKY9EBCu6eCODVhukXroXD3aKtUw9qk5k3HsmQvmTsx3BLM69uc3cq4PIEVpi1Bb90XD/H7fYiHz4U3m2zRNBChQxoR1B0c5djMeTHMSu1+K9SrAW313sRrpuVF8rzkP5PzqPQEmYBQ/RsIDWP0c+oo3Y9ji11tN15e6R8ewNQuNesWP5zlyjqNEKamokJKBsv1pZSHA8h1qGPi77qi2Ujf3Hi5gBCqQv8c8GGERBkCRQ/Pq4ra/+QaKfNng1KwvYE3Rugye2LtKuAh0T9ydX8Cw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 12, 2024 at 2:14=E2=80=AFPM Kees Cook w= rote: > > On Mon, Feb 12, 2024 at 01:38:51PM -0800, Suren Baghdasaryan wrote: > > Currently slab pages can store only vectors of obj_cgroup pointers in > > page->memcg_data. Introduce slabobj_ext structure to allow more data > > to be stored for each slab object. Wrap obj_cgroup into slabobj_ext > > to support current functionality while allowing to extend slabobj_ext > > in the future. > > > > Signed-off-by: Suren Baghdasaryan > > It looks like this doesn't change which buckets GFP_KERNEL_ACCOUNT comes > out of, is that correct? I'd love it if we didn't have separate buckets > so GFP_KERNEL and GFP_KERNEL_ACCOUNT came from the same pools (so that > the randomized pools would cover GFP_KERNEL_ACCOUNT ...) This should not affect KMEM accounting in any way. We are simply changing the vector of obj_cgroup objects to hold complex objects which can contain more fields in addition to the original obj_cgroup (in our case it's the codetag reference). Unless I misunderstood your question? > > Regardless: > > Reviewed-by: Kees Cook > > -- > Kees Cook