From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90E21C71148 for ; Fri, 13 Jun 2025 19:21:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1C28E6B0092; Fri, 13 Jun 2025 15:21:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1737E6B0093; Fri, 13 Jun 2025 15:21:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 062F16B0095; Fri, 13 Jun 2025 15:21:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DA0656B0092 for ; Fri, 13 Jun 2025 15:21:46 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 3E66F5E3EE for ; Fri, 13 Jun 2025 19:21:46 +0000 (UTC) X-FDA: 83551347012.24.3A0FCD4 Received: from mail-qt1-f172.google.com (mail-qt1-f172.google.com [209.85.160.172]) by imf03.hostedemail.com (Postfix) with ESMTP id 5856620008 for ; Fri, 13 Jun 2025 19:21:44 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=W8Z0CP33; spf=pass (imf03.hostedemail.com: domain of surenb@google.com designates 209.85.160.172 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749842504; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SwsnYZZ63LvvlkMeoABDBQxLgrkaQY4fLJ1Enbyh2EY=; b=puuQs2nbN4Svsc3Xckx+eBEDwDlaRteLn/7xNKDghidMvsQhCcEVQpzep7/oNTO/poXa6Q vS60bYkUjzIqn1a4AfDhsSP9wd0VExfnsM+PNgFDzw0OXLyJMK65sNNRsXDAsQxJ2kE8hs gVfZqDm8egaXTfmPhojEvbxESvaV26M= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=W8Z0CP33; spf=pass (imf03.hostedemail.com: domain of surenb@google.com designates 209.85.160.172 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749842504; a=rsa-sha256; cv=none; b=d/dg3ow2xbd9C+BeDYWeXd+rAvgmXQMroTLs7nUDm+AHqlJEud3NznDsz6clne+BNmn2mR ooF4zp1+OjzebGQBrNGdLdeJe4oJSkjr1y3Ff6j2mZ7NTpSlfI9+2VSItCYKDvVh9rhaCn M/noqR1Oz8hnSsUg3q4HPXN+PZGRRu0= Received: by mail-qt1-f172.google.com with SMTP id d75a77b69052e-47e9fea29easo72681cf.1 for ; Fri, 13 Jun 2025 12:21:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1749842503; x=1750447303; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=SwsnYZZ63LvvlkMeoABDBQxLgrkaQY4fLJ1Enbyh2EY=; b=W8Z0CP33BjEAj0YguS0t4GnAvXorYJI5VV/K1YyUkrvZXUDn5/u9XS3TqaP3eUwxEu pI3K2Ux0WsWXhNNbIS6gXRSxV9THgDYKbOe/5+qhyNV74MNsMpFg4u++qEkv5KAkqmDh MDzj7oJwm9Tcxablv+ZrRS++kbsVGhyHxCczKyxfh+S3WabLz3wY9gkCZRmApPfsR9xw 57p+AWXTcMlGpiBhvlU32nWvwnQlWgmDMO7mPlR3kYk6YN6vj0T5uw7hFT/JMVtjkd4V IxpFwXEa+q5RAw0wlofJXc790LmjG+QyyvHIkqyrWRO+0zMMxPKoR/+84br2g6auTkRX KFfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749842503; x=1750447303; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SwsnYZZ63LvvlkMeoABDBQxLgrkaQY4fLJ1Enbyh2EY=; b=XnE6WHEOkRpKfCZfMu4aXpDTn5oet2u/6M+Myoygyk9/nmQnDxkUgHYkBQJsEY4ZTH VFBC+cuuF1Pb17HKaRUOnQCwjk+mZGBT3a3qlXK5xgUWjOC+o7Uei6khJwBaRJHenx05 HF2jVqqzXS5G8sfzc2maBgLdRfhQ4vMB2XTFEpQkTKFdPQu8uWI4zB5FdxclVm+5s4RJ 35JHQ+BnMWof/mbb1gEm1P8oTw8VE0ey7nXQt8Xx1IcZF0OZIaQo7dECWXl0Bm1+c0rR jDR2zma9nU6CB2PzOoYv3EQrNto6uMpoQq2NwXbPaEor8HmEV/dH6DGrIE6+Nt1XLov3 YeQQ== X-Forwarded-Encrypted: i=1; AJvYcCUhciCQVGUJpacZGmUr2kI1lkMbtoukdn5Y87m0ek0UjlQWzPMIC51jteZTDbdayk7Yzx7eLvbFbg==@kvack.org X-Gm-Message-State: AOJu0Yw7mr9VDjr7HcRlLz7TL7b712haKq1ioZd1nCu1DlmXFjrGSMSb 20JO8MdUeIR3UFBE+VaFH3EaKGO/l1LYbPKbojYtelszrWi/m0LACTWvBvjh/8fae9+aCv4YHD2 ZWhLsxYj2v+Se4lMfPPT5ZPW4JPfTKwWpiuY4wTgE X-Gm-Gg: ASbGncvOEIrGezO0rk3VlO6N6fKvKoQHMYjaI4BXXMqdOiozlFp4mE3EK57YXoZiv00 9ysVEJBhT+S4j6VQtZCzH9iLxTt4vqGh3nuIAo8/lftgtmU6vEmsHdNQwigTOCghjVkfhWGy6BD GQS5X5jqzAoveNzU6dA85Qu6SqN9Ddka6eScseG5H9iA== X-Google-Smtp-Source: AGHT+IEO+7tih5cXcAlJg0Vw2/Sois18XRurWIS2/frgQdC8+3vTxmNKORl6AWRcNFb2EewoNPpA6PIVNKd9BEEx0hI= X-Received: by 2002:ac8:5883:0:b0:47b:840:7f5b with SMTP id d75a77b69052e-4a73c763a87mr516731cf.29.1749842503097; Fri, 13 Jun 2025 12:21:43 -0700 (PDT) MIME-Version: 1.0 References: <099651f46b0b57f6c7890a64608dc7ca44df7764.1749779391.git.gehao@kylinos.cn> In-Reply-To: <099651f46b0b57f6c7890a64608dc7ca44df7764.1749779391.git.gehao@kylinos.cn> From: Suren Baghdasaryan Date: Fri, 13 Jun 2025 12:21:32 -0700 X-Gm-Features: AX0GCFu-OOwfRLFxcwNjR_GNWx_Buv2sRyKB524WUep1Vz9r7UOBtNhv2b7PdpU Message-ID: Subject: Re: [PATCH v2 3/3] mm/alloc_tag: add the CONFIG_ARCH_NEEDS_WEAK_PER_CPU macro when statically defining the percpu variable _shared_alloc_tag To: Hao Ge Cc: Andrew Morton , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Richard Henderson , Matt Turner , Dennis Zhou , Tejun Heo , Christoph Lameter , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Kent Overstreet , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linux-s390@vger.kernel.org, Hao Ge Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 5856620008 X-Rspamd-Server: rspam07 X-Stat-Signature: yqhx7jw8eh4k88qkwewgw7u3eoi9hq8q X-Rspam-User: X-HE-Tag: 1749842504-75650 X-HE-Meta: U2FsdGVkX18de0UEKlUOMDXb69mXnIMkK5nG0M0mHYFIHJzQt5immmeRaWbyDeRG5amaisUEoiktsmRYo73M0Y0BrklRf3eca2yVZ/x8B26Hq6YUQ0rIz3MjsDn/m1x6dr6oanAtQyv0yUsrCquVAnNgy/ShH1SkqR2AZCV6bpmOz+ozkJL1BKOOm8YWofcdSkGCXUY/Sz5ukNga5idFFjF3QhW6IAU4zrehHEjuJ8hvb51zkxBgvyt1nQm1TfQI2KcTfGSWrFMDLwAq8ZI/JDBlEhC50uxIVG5tx35xeG+lHno0VG6YcthJqN7PTLZ4XIxd+02dZLbDQrRkf2aDNw9Ilp09T2LnSdem2Dy6lGVEv3uO9/xeUJ8g4fq2xrwa8pmgkEMQBUdWlq9Q74Qw1GWgmKttHEcS65bRqfPubkJqR8H+jCHpqr9dkiWf/dgyZgrNELZ5ICkK8uVYZlqVmAso4VZWDOWj9fb5CT5xYNEfE69PNtqCwxRDHgHEeS6J0EKR3uLqI4IYuHsry8zJboW+t9qSwaWZjHQhYOGs/S0MJqUPUm7Rk9miPuFGrJjzrM1Yn4Gt221UuFQ8E63CKyHp7j2/mJ+WnwyKtPjNf+kTAsHQmB3lYYAEa3IuAo52DHZKZ5PrV4TjXjVDDVJMKVObCLlmao7hnK72XCKQ7k2W7s8bgMMIaxjRKBn4Ry3OafkqGYzDyC6Q71a6d+p+Hr1kEfub12CzE9BbhxCXS1WgtGuBhTNbJt7Xouksd9JYm8KqSkJ+Ds6woTeC5lQ72b/Lhv9kRchz6cKGf3iqLYEmkPWv1Nx1DZY3JjjEmwpE4aKuBEYvE5zmBug8BaEouLeo+e6AWfyzpilQTUxI6+2VZmhkaUzsd5LTsnujPaIxiOFxDas6A4ykMBr0KHv2hhP2aH7CeVEZuxH8i3/AKxkSgMM3x61ZpjfkY4SBnRzEmRRUK6bqdI34XoT9xWL Dabb0ghi WRWTUNDNM0h0GOPRZOWlt0CPk63uXIwH5yh2yejtPSTYcAFQLHfkOacP8DSBlcPMGZNs24xqMugmC/dhKHYqAlY0Y+tKiRaDM6ynu0ouGJG2CnQD+25f7g5iRVRvT3+p1T28/wsjprgBV/Fcao2kOQlUkV3qf0s0ySsHaCD6u3sGcDcxvPQN/n2EkTUw6GX0TUTiuBI+hKM1Es2y03tiDRsRIk8AIY6wk6vmkMIrExInRBYn3S+nfPAi8ICAyezmsMfmJYqYsCoIod4A= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jun 12, 2025 at 8:06=E2=80=AFPM Hao Ge wrote: > > From: Hao Ge > > Recently discovered this entry while checking kallsyms on ARM64: > ffff800083e509c0 D _shared_alloc_tag > > If CONFIG_ARCH_NEEDS_WEAK_PER_CPU is not defined(it is only defined for > s390 and alpha architectures),there's no need to statically define > the percpu variable _shared_alloc_tag. As the number of CPUs > increases,the wasted memory will grow correspondingly. I don't think this patch needs all this background. Just say that _shared_alloc_tag is not used when CONFIG_ARCH_NEEDS_WEAK_PER_CPU=3Dn, so you want to compile it out. > > Enclose the definition of _shared_alloc_tag within the > CONFIG_ARCH_NEEDS_WEAK_PER_CPU condition. > > Suggested-by: Suren Baghdasaryan > Signed-off-by: Hao Ge > --- > lib/alloc_tag.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/lib/alloc_tag.c b/lib/alloc_tag.c > index c7f602fa7b23..14fd66f26e42 100644 > --- a/lib/alloc_tag.c > +++ b/lib/alloc_tag.c > @@ -24,8 +24,10 @@ static bool mem_profiling_support; > > static struct codetag_type *alloc_tag_cttype; > > +#ifdef CONFIG_ARCH_NEEDS_WEAK_PER_CPU > DEFINE_PER_CPU(struct alloc_tag_counters, _shared_alloc_tag); > EXPORT_SYMBOL(_shared_alloc_tag); > +#endif > > DEFINE_STATIC_KEY_MAYBE(CONFIG_MEM_ALLOC_PROFILING_ENABLED_BY_DEFAULT, > mem_alloc_profiling_key); > -- > 2.25.1 >