From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68ED7EB64DA for ; Wed, 12 Jul 2023 15:42:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0320F6B007B; Wed, 12 Jul 2023 11:42:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F24746B007D; Wed, 12 Jul 2023 11:42:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DECAB6B007E; Wed, 12 Jul 2023 11:42:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id CB2EC6B007B for ; Wed, 12 Jul 2023 11:42:46 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id DFBD7802CA for ; Wed, 12 Jul 2023 15:42:44 +0000 (UTC) X-FDA: 81003377448.29.4405C50 Received: from mail-yb1-f179.google.com (mail-yb1-f179.google.com [209.85.219.179]) by imf15.hostedemail.com (Postfix) with ESMTP id 132CEA000F for ; Wed, 12 Jul 2023 15:42:42 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=aympKxMC; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf15.hostedemail.com: domain of surenb@google.com designates 209.85.219.179 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689176563; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gUL2tuQT4LDMSyGCmE5DUm73sFH8hgopCFiyhokXDqE=; b=MmH0CUfM1OGC+aAbtQoaUANCIVvvUpzFAjyTQg6hScAhoW0eF3Ls3qg2mGOmAJMK4ubp18 OEYzyUVpvVl+B4K+7UyTJnXMZi6hXz3ZMvdNgXc+68GVUaboVM8fVI3rw+hHMtNRtLdFsk wBRZ89mmSbDPKgXW41smqnzyF/kVlf8= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=aympKxMC; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf15.hostedemail.com: domain of surenb@google.com designates 209.85.219.179 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689176563; a=rsa-sha256; cv=none; b=7O+SIfWBeQ301bn12c3/jgn6YZls9vSz3FlqT9jIWTV22DS5TyLIqVaYiyfRVBprhvfYmB T41w7UtGKFYro1xBy7VbtdE+NEc5JDXSsqdHIT7UqWnu/YHjDbSAtZP80qUjP5bdcZOj6r eXF9ktByZocFGphtfujCHyZ6sAo9Odc= Received: by mail-yb1-f179.google.com with SMTP id 3f1490d57ef6-cada5e4e3f6so17368276.3 for ; Wed, 12 Jul 2023 08:42:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1689176562; x=1691768562; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=gUL2tuQT4LDMSyGCmE5DUm73sFH8hgopCFiyhokXDqE=; b=aympKxMCKJJWQs2qcETyDLGgrTgFaxN5lIrL4tFtXGgTObNYqFSirlmJaC3SRCX9l3 VdeB3TdjH87hWxS3F66/eAvxQqA+1OKQQ+laEk3pDJoYLmCw8priHSkxlI467H0Xa8WB 1LLzOCmmmj1W0bH5vSL+DB89PhYh15Iyz7wk3EzQkopFtgqNO3EE6m3caxGGBNqAxVeZ CBkVzZoJMYxXu43/HcwpzVwzMQe4DjJGnx5HYAhyyYWUHGzS2kE1P7OaHneaTIJfQ7qN f6HadRAJjAdIcdNLACj2xOuV1TkEoZQ82Ca5TTEIXQz3R5GJrBVPV1v/+g/UldCsweok EsvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689176562; x=1691768562; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gUL2tuQT4LDMSyGCmE5DUm73sFH8hgopCFiyhokXDqE=; b=lAEPQPYGd/ji39O2AkSfJ2//vKFDxrAW/GxU52hFxOOeOy645i3huCpti1VT1UP120 Wg0hnie4NGbP1aRtR1JkSiYssq4rtbbj4OGyQs0YO1RyzIbj3GkrX5Wfv1+JF4x0iYoD 8Fzoa5I5xnydPWI1/6G7x8cZU7G6GZh2UVxIQZmqdpKVZu2JcgBe1GVEXp5UVFsB6Wk1 EZ3CYF5ASkXQ4TCMYzF9l/z2XDtI9I0wENWN7hSXl14rRLLNxVj9nJHacaZmeyD1pSGl zjvcLbAzD6JZDN2wJaR47Lm8hRlMC8IKh4hmpCe/42poz3S3GE1RrQo2NhHy5cDxfmkN PKIw== X-Gm-Message-State: ABy/qLZF7dcHMMHhu99o+6im8+5jYOUHUWrD67FJymeXCwXD61hhSrcy MfrUOeFL4QztdCvY2FdRyxGoB2EXs7F54j3fuZsqhDgqfOWIiRCfjzs= X-Google-Smtp-Source: APBJJlGLF0Syq6kYB12+rtMdBmY0PYibVnmy+O+4M0A4iWD3P5JA5cmt+z+bS8fJ+7QLMoG/mWqat367t8ERtF7+yQc= X-Received: by 2002:a25:810f:0:b0:c62:9634:d39 with SMTP id o15-20020a25810f000000b00c6296340d39mr17051632ybk.52.1689176561911; Wed, 12 Jul 2023 08:42:41 -0700 (PDT) MIME-Version: 1.0 References: <20230712022620.3yytbdh24b7i4zrn@revolver> <20230712153050.gm57uee23ykm3srk@revolver> In-Reply-To: <20230712153050.gm57uee23ykm3srk@revolver> From: Suren Baghdasaryan Date: Wed, 12 Jul 2023 08:42:28 -0700 Message-ID: Subject: Re: lockdep issue with per-vma locking To: "Liam R. Howlett" , Suren Baghdasaryan , linux-mm@kvack.org, willy@infradead.org, Laurent Dufour , Michel Lespinasse , Jerome Glisse , Vlastimil Babka , "Paul E. McKenney" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 132CEA000F X-Stat-Signature: nrzj43uerb51wiyxh3gkzt6rd43w7g6b X-Rspam-User: X-HE-Tag: 1689176562-22562 X-HE-Meta: U2FsdGVkX1+lwht9pFSL7evQApsj41/gyiwTwSbew8ykGarSrBp0qTQvEhMAblBKJ/WZUTm+E7gQ99iplrzPd0gUr2QYFxke9aGNx3gLQ32YJdAFKOVA8SZdiNi9rcqr6EdPGJKRHXyFW/ufo85EfRgGoTloLDQlKUcp6wuR1MaLWTwN1YWrZTgtJEKtjIr+ZlnpKHAJamSZYqxGd0UdrJhkG3pLAeuRqm3YNxZzUoSPRGzmiB4kRVFGO5QPJzwBqeMstEhPFPFo9+wZapErDS+TDhdnlyzHvaT9qQMLEERFrHdBFaX9V4KSoUqMs+gRM7W/EzbvYMDsvegWxKnoHLDwKxQjVn0gyCozkDDtsd3iEYuDWazkcTK8v8QVM1Y8QCtih2thpsCW9XMlvVwj4JqRHn4vhFhmyXVfBsgt6xwOJtTNeaO1rJEPsEO4o/S9Z8ohbwa3Paq66JDhFb6XQIaiD6JcXpN5knQ0cj9GVxzDdLjUIn5SU87psuX8BX7HIsoDDYgdN8yE+yw9eIu4Dz4CEfkYtyHPwtk+Nf94xHT1EDSx9dv1CijdoBXFW+RrRLzbUe1AvG8kbtxOx8ULf+xOI/ehsRcLyB9BBF98PD4wjJJaxuuYAGBAD5iUO3AmULs9DduOyk946Ok5+9EUarQI4wRwfzeDl5P4QEsSEBGOjW0BPoKzWnprKMLd3EgjltH64SUHCfS15PZclrCaENeMjSHHONdvQyMZriLKzzKUTjXXpPN3QZyO3NVv3LOOww9fRDDjoIfzErAja6CshO9UjWNFMLGwnq7gD/7wfMGVlU30+qwBkJCxDtUsskkfcWDC0TFkOtJSsj9r03fdGTVw4B7GIHYmpWyCV093g2fg4NaBrvD7/KwrIKpY8mdsiJat/C+uboFjG02EVHrtohST0ILLUFcN8jr3iz9v0/sy+mUL9hBSTKT2rFj9ScpyULahn6mh8ZyD+s2OQ4Q Sfj7Yo96 EkGKFUI4edAGgZcDUqkZOmom9wGNUNTSdb9Hhtf+I2vXZK/cfaDJtdAFKnuiMBeZqhkWGsDhV+iVfHmOK+JSnMkMEyXo1FsKDVNqj4VHWxUz9k2VQWvkvskmyvERD+XDc/+foh29/FvTRIOQECWYI5a/sB0rTDQTZDhsJowFq8m6s9GjcaHq2dpvrz3IMxoH8uwJZlEY/fSRvhD5QlZrXJIkQTa+cR6x1Kbptor0ff4xWp204f0w7AUnreN+8yZTViZCqnVmjrfZVtfCyJzb7vhemuR6UUBSpoZ8gsqe1y+PZNFh0GkAQD9GZQMgg/FMCDhuQNEEeZIl93Sc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jul 12, 2023 at 8:30=E2=80=AFAM Liam R. Howlett wrote: > > * Suren Baghdasaryan [230712 11:15]: > > On Tue, Jul 11, 2023 at 7:26=E2=80=AFPM Liam R. Howlett wrote: > > > > > > Suren, > > > > > > When running kselftest mm, I believe I've come across a lockdep issue > > > with the per-vma locking pagefault: > > > > > > [ 226.105499] WARNING: CPU: 1 PID: 1907 at include/linux/mmap_lock.h= :71 handle_userfault+0x34d/0xff0 > > > [ 226.106517] Modules linked in: > > > [ 226.107060] CPU: 1 PID: 1907 Comm: uffd-unit-tests Not tainted 6.5= .0-rc1+ #636 > > > [ 226.108099] Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BI= OS 1.16.0-debian-1.16.0-5 04/01/2014 > > > [ 226.109626] RIP: 0010:handle_userfault+0x34d/0xff0 > > > [ 226.113056] Code: 00 48 85 c0 0f 85 d4 fe ff ff 4c 89 f7 e8 bb 58 = ea ff 0f 0b 31 f6 49 8d be a0 01 00 00 e8 0b 8b 53 01 85 c0 0f 85 00 fe ff = ff <0f> 0b e9 f9 fd ff ff 49 8d be a0 01 00 00 be ff ff ff ff e8 eb 8a > > > [ 226.115798] RSP: 0000:ffff888113a8fbf0 EFLAGS: 00010246 > > > [ 226.116570] RAX: 0000000000000000 RBX: ffff888113a8fdc8 RCX: 00000= 00000000001 > > > [ 226.117630] RDX: 0000000000000000 RSI: ffffffff97a70220 RDI: fffff= fff97c316e0 > > > [ 226.118654] RBP: ffff88811de7c1e0 R08: 0000000000000000 R09: ffffe= d1022991400 > > > [ 226.119508] R10: ffff888114c8a003 R11: 0000000000000000 R12: 00000= 00000000200 > > > [ 226.120471] R13: ffff88811de7c1f0 R14: ffff888106ebec00 R15: 00000= 00000001000 > > > [ 226.121521] FS: 00007f226ec0f740(0000) GS:ffff88836f280000(0000) = knlGS:0000000000000000 > > > [ 226.122543] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > > > [ 226.123242] CR2: 00007f226ac0f028 CR3: 00000001088a4001 CR4: 00000= 00000370ee0 > > > [ 226.124075] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 00000= 00000000000 > > > [ 226.125073] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 00000= 00000000400 > > > [ 226.126308] Call Trace: > > > [ 226.127473] > > > [ 226.128001] ? __warn+0x9c/0x1f0 > > > [ 226.129005] ? handle_userfault+0x34d/0xff0 > > > [ 226.129940] ? report_bug+0x1f2/0x220 > > > [ 226.130700] ? handle_bug+0x3c/0x70 > > > [ 226.131234] ? exc_invalid_op+0x13/0x40 > > > [ 226.131827] ? asm_exc_invalid_op+0x16/0x20 > > > [ 226.132516] ? handle_userfault+0x34d/0xff0 > > > [ 226.133193] ? __pfx_do_raw_spin_lock+0x10/0x10 > > > [ 226.133862] ? find_held_lock+0x83/0xa0 > > > [ 226.134602] ? do_anonymous_page+0x81f/0x870 > > > [ 226.135314] ? __pfx_handle_userfault+0x10/0x10 > > > [ 226.136226] ? __pte_offset_map_lock+0xd4/0x160 > > > [ 226.136958] ? do_raw_spin_unlock+0x92/0xf0 > > > [ 226.137547] ? preempt_count_sub+0xf/0xc0 > > > [ 226.138011] ? _raw_spin_unlock+0x24/0x40 > > > [ 226.138594] ? do_anonymous_page+0x81f/0x870 > > > [ 226.139239] __handle_mm_fault+0x40a/0x470 > > > [ 226.139749] ? __pfx___handle_mm_fault+0x10/0x10 > > > [ 226.140516] handle_mm_fault+0xe9/0x270 > > > [ 226.141015] do_user_addr_fault+0x1a9/0x810 > > > [ 226.141638] exc_page_fault+0x58/0xe0 > > > [ 226.142101] asm_exc_page_fault+0x22/0x30 > > > [ 226.142713] RIP: 0033:0x561107c4967e > > > [ 226.143391] Code: 48 89 85 18 ff ff ff e9 e2 00 00 00 48 8b 15 49 = a0 00 00 48 8b 05 2a a0 00 00 48 0f af 45 f8 48 83 c0 2f 48 01 d0 48 83 e0 = f8 <48> 8b 00 48 89 45 c8 48 8b 05 54 a0 00 00 48 8b 55 f8 48 c1 e2 03 > > > [ 226.145946] RSP: 002b:00007ffee4f22120 EFLAGS: 00010206 > > > [ 226.146745] RAX: 00007f226ac0f028 RBX: 00007ffee4f22448 RCX: 00007= f226eca1bb4 > > > [ 226.147912] RDX: 00007f226ac0f000 RSI: 0000000000000001 RDI: 00000= 00000000000 > > > [ 226.149093] RBP: 00007ffee4f22220 R08: 0000000000000000 R09: 00000= 00000000000 > > > [ 226.150218] R10: 0000000000000008 R11: 0000000000000246 R12: 00000= 00000000000 > > > [ 226.151313] R13: 00007ffee4f22458 R14: 0000561107c52dd8 R15: 00007= f226ee34020 > > > [ 226.152464] > > > [ 226.152802] irq event stamp: 3177751 > > > [ 226.153348] hardirqs last enabled at (3177761): [] __up_console_sem+0x59/0x80 > > > [ 226.154679] hardirqs last disabled at (3177772): [] __up_console_sem+0x3e/0x80 > > > [ 226.155998] softirqs last enabled at (3177676): [] irq_exit_rcu+0x94/0xf0 > > > [ 226.157364] softirqs last disabled at (3177667): [] irq_exit_rcu+0x94/0xf0 > > > [ 226.158721] ---[ end trace 0000000000000000 ]--- > > > > > > > > > CONFIG_PER_VMA_LOCK calls handle_mm_fault() in mm/memory.c > > > handle_mm_fault() may have an outdated comment, depending on what "mm > > > semaphore" means: > > > > > > * By the time we get here, we already hold the mm semaphore > > > > > > __handle_mm_fault+0x40a/0x470: > > > do_pte_missing at mm/memory.c:3672 > > > (inlined by) handle_pte_fault at mm/memory.c:4955 > > > (inlined by) __handle_mm_fault at mm/memory.c:5095 > > > > > > handle_userfault+0x34d/0xff0: > > > mmap_assert_write_locked at include/linux/mmap_lock.h:71 > > > (inlined by) __is_vma_write_locked at include/linux/mm.h:673 > > > (inlined by) vma_assert_locked at include/linux/mm.h:714 > > > (inlined by) assert_fault_locked at include/linux/mm.h:747 > > > (inlined by) handle_userfault at fs/userfaultfd.c:440 > > > > > > It looks like vma_assert_locked() is causing a problem if the mmap wr= ite > > > lock is not held in write mode. > > > > > > It looks to be an easy fix of checking the mmap_lock is held in write > > > mode in every other call location BUT the vma_assert_locked() path? > > > > Thanks Liam! Yes, the fix is indeed very simple. I missed the fact > > that __is_vma_write_locked() generates an assertion, which should > > probably be changed. I believe the same assertion is found by syzbot > > here: https://lore.kernel.org/all/0000000000002db68f05ffb791bc@google.c= om/#t > > Yeah, looks the same. Sorry for the noise. Not at all! I wouldn't look for it if you did not report :) Thanks! > > > I'll post a fix shortly. > > BTW, this is happening only in mm-unstable, right? > > Well, I tested it only in mm-unstable.. > > It came up while i was testing an unrelated fix for another kselftest:mm > that I broke. > > > Thanks, > Liam