From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AA5EC46CD4 for ; Sat, 30 Dec 2023 03:00:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F3A5C6B0136; Fri, 29 Dec 2023 22:00:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EE9956B0137; Fri, 29 Dec 2023 22:00:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D8AB26B0138; Fri, 29 Dec 2023 22:00:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C70756B0136 for ; Fri, 29 Dec 2023 22:00:10 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id A1F5B1C0FFB for ; Sat, 30 Dec 2023 03:00:10 +0000 (UTC) X-FDA: 81621980580.22.4965913 Received: from mail-il1-f169.google.com (mail-il1-f169.google.com [209.85.166.169]) by imf27.hostedemail.com (Postfix) with ESMTP id DC94F40006 for ; Sat, 30 Dec 2023 03:00:08 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=pULdnl+g; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf27.hostedemail.com: domain of surenb@google.com designates 209.85.166.169 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703905208; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TAZ5ajf3MkVnFkC6sywbs4Pf+xQBE5WGQ//t20vsfwU=; b=qxdHs362wi1HAUcZXB0ALZ+eT6Td49G16h+jdKDU1eZppjOcz5O9Qv92rXzxDvWpRj3SZD lmEyBlz41uzX6fE1FIsQrK9Q3lFpDmaEm+C+KKqBH14hlKBXEIeQqjOJQ7lIC8CrucNfO3 1TvaB354wABr5ayt7fi19C6XXBlpxy0= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=pULdnl+g; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf27.hostedemail.com: domain of surenb@google.com designates 209.85.166.169 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703905208; a=rsa-sha256; cv=none; b=XeRtkooJ3skgT42gcDIuQeO3Kq2QHhVlu5SS2Xg2iy5S/Y3a9nyics6JQdgO1FyYoFPvQU zGITF0Rl5i4OvIZKisvYS6og+ZM6jw1DxTkQ/RllU7UReurn8oXPe/6qU37FLcWo/cFN3i bH+6m0Fo0PS4W+5O9CvxrkSx/KRz+tQ= Received: by mail-il1-f169.google.com with SMTP id e9e14a558f8ab-35fcea0ac1aso36418485ab.1 for ; Fri, 29 Dec 2023 19:00:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1703905208; x=1704510008; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=TAZ5ajf3MkVnFkC6sywbs4Pf+xQBE5WGQ//t20vsfwU=; b=pULdnl+gY2TiSNdnMvZ3TRtWDovoLvmyEoLjoEcGcMrmkqAfvTx5gbyIb8fkke/IzS 1q3dwJ4dy2oTkM4vJQlB5tEhTfQPLF1HZ+0HCODOq3PcuWJKFObMt0XHsSXoxx6c38Yv D63nEcqJNNJwJYexOXmcsqCBx56thGSoL5As4XSNV9531v8C2NOpPfqpho0BtIBqabeK zXKJmmsscchDbhKx3ZV5tq/LgNh7Dqbk9kcMaF2ymnUIN7t6/zHnc6BWpCnPLzDw9km1 dlS+vP3jJtO2RX5oNIxzigpY/qvr+D/mwK7GwNToulwoRlr3N/1559yQX/JBa1VW8qju HwnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703905208; x=1704510008; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TAZ5ajf3MkVnFkC6sywbs4Pf+xQBE5WGQ//t20vsfwU=; b=sIywoChdGuPAHSaGBthWBEF7H1f0nujeprPEr2Y4Ez8Mir4WARiCMngScYNkwY4IdX 3AkvXdFONMEs+qZVURKSRN1bTE3G0Kua39uEN2yXVg9BPAEmp04sn/3Um8dAR6GiYDqy GLg699ngQ6D04k/nGqdxN0A+jODIT6mTEBIBK4X0IxxiSTLiVvULwqpITkzHWcZWG1E0 YhjTa+k1NepTqT4FzqN/sgTz1jG2kGUEZiCImwgV7H229AsLttW0XHFuVAr+05Gd2HEo CYiTYYQS+ZBC+rCw5ZFPA6Mc7qhmZ23I7tcXCuk2beKVMxWNEuyKwypALclqhr9FzH6h nIeg== X-Gm-Message-State: AOJu0YwyA4SYOp15MAyPhjcYcwN+qE24K8TjwxMOFUWNMLhOJF4efRqn zwDwtjBIEZXgCLSEWmnHDzvJYZWNp03MXFTwEbq81kVLCVrf X-Google-Smtp-Source: AGHT+IGNgtZ3iUb7oRokQhbYD5WD4BXce8diJEX3rvWdVxJ9n3DFkx5GXlipFyhxrY5aAuvH3DMNwWD60PTYpeW0ius= X-Received: by 2002:a05:6e02:2492:b0:35f:f00b:e697 with SMTP id bt18-20020a056e02249200b0035ff00be697mr10506299ilb.83.1703905207798; Fri, 29 Dec 2023 19:00:07 -0800 (PST) MIME-Version: 1.0 References: <20231230025636.2477429-1-surenb@google.com> In-Reply-To: <20231230025636.2477429-1-surenb@google.com> From: Suren Baghdasaryan Date: Fri, 29 Dec 2023 18:59:54 -0800 Message-ID: Subject: Re: [PATCH 1/2] selftests/mm: add separate UFFDIO_MOVE test for PMD splitting To: akpm@linux-foundation.org Cc: viro@zeniv.linux.org.uk, brauner@kernel.org, shuah@kernel.org, aarcange@redhat.com, lokeshgidra@google.com, peterx@redhat.com, david@redhat.com, ryan.roberts@arm.com, hughd@google.com, mhocko@suse.com, axelrasmussen@google.com, rppt@kernel.org, willy@infradead.org, Liam.Howlett@oracle.com, jannh@google.com, zhangpeng362@huawei.com, bgeffon@google.com, kaleshsingh@google.com, ngeoffray@google.com, jdduke@google.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: DC94F40006 X-Stat-Signature: wxe8rkjsuwfstcufxmnkfc9beapwzc6i X-Rspam-User: X-HE-Tag: 1703905208-578129 X-HE-Meta: U2FsdGVkX1+JgpL1ZtjYBDb9bCD70QnV14bGihhVzM2z4fEiWElyI9tvhx9BzQ4c6CBO6rNs0NZ/44zKdGMF6Mi7J1L4pW9R3lkCb23cJTkQcC9KE5OWiKquY3scd0mMEFfrGO3+yzZzBxuFK7daQEgOWASSwzeMQRXEjj4l54Yga0btwDo8D18JdmNYSuzsQq+WAYiHOAG0YTUUuKrqEYq9HV74oxDJ3yX6QDBm4YlTOTn4sQWvlYZQ4N9H4gMhwrIbvgl2AMTjmR8jRYbY+B/6GyDOowrdnd2iDq8rLyijQD0l7QRM+qrcG+hQAUSKxAB7t/2HDfjW2J6Fp1fSn2uFnTkgbEy1MzfKoUa7V/ig3dDTFiOPVOFAgqkjSwcgT59FPenLS6JFBH2nbin+OJHpieQTY3ePBPAP/F5qxQxe4ZP9Uih0b6cUr9+Wt6QzpekIOjqf0OLDMbu25WU+w4oHU08eHtVqGAcf2oHZd7qEvdS+jJbMwq3Lj6tHVef5VMa/4AxzeQTZW7hS6dfXeWQvmZkxGKX9GkWYwQFyH42Aw9HxCpwxQxdpTLprmRoc0VVGo7n/JweioW5zHcWOfOzYrSLQq8IkVg8Dqo0JkGAMTizpWHeJkZKhsUknP3Cswy/ky5g4FJlHzncKXxhK4o6cdTfr2bcKDxob8PpVdUMKVmg9Ty/nwOs+g09QfOeIhEnUMBZIBtCZh3SPFZ4tTFB5Vl7e2H1+uQPI4tAW3GBDutG04FEiH+WOZRrn3+m9646Wfs5MqjfNzYcS9jHZP3QCAcaihztHlEDn4burAyDmRdQXPNpejiWSnsP8cPTbyqawhtIRxhO3ooV8wmJqniwgHfHn+GTXNRxgarhnDArgFgN87cBIWYqmKY70jzIJYGo9lzYM2G5c0hAkHF7AT5ImUL95cfVX9C/+sdIp23bfFNCWjB4OgSRdPn0fhFXu311/pHZzyruyDuFvqWC abANFqAl cg9JYDVTDF/LvVH6nhX5BBos6IPlXgVeRWpVBQjwvuz0CRmJkhEdrTFWvz9/MxHRnFm5xnjbY8aYyD9HGIbBqREnB9apKLiEXHNmyYD619tfpCmVX4fCwJZ4NJpgxe8y0bKmNiNYHSYkWmXQ1FC2g8dLIIutX3fCcjTg9Rl45jaoLA1VMm24NTjcnkFo6apWnA4RwhU4Q1Ir7OWU6WpFWRpjd9FjmYvU2FcivTKONS1kxzzIj/5Pj6zmrmhgf+1QHHbZfHq+Pl4tkh1lU99mlwA/i5EHPxJqJpQ80E3phaogm0l0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Sorry, I screwed up when sending it out. It's not [1/2], it's supposed to be a stand-alone patch. IOW, don't expect a [2/2] followup :) On Fri, Dec 29, 2023 at 6:56=E2=80=AFPM Suren Baghdasaryan wrote: > > Add a test for UFFDIO_MOVE ioctl operating on a hugepage which has to > be split because destination is marked with MADV_NOHUGEPAGE. With this > we cover all 3 cases: normal page move, hugepage move, hugepage splitting > before move. > > Signed-off-by: Suren Baghdasaryan > --- > Patch applies over mm-unstable. > > tools/testing/selftests/mm/uffd-unit-tests.c | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/tools/testing/selftests/mm/uffd-unit-tests.c b/tools/testing= /selftests/mm/uffd-unit-tests.c > index d8091523c2df..cce90a10515a 100644 > --- a/tools/testing/selftests/mm/uffd-unit-tests.c > +++ b/tools/testing/selftests/mm/uffd-unit-tests.c > @@ -1199,6 +1199,16 @@ static void uffd_move_test(uffd_test_args_t *targs= ) > > static void uffd_move_pmd_test(uffd_test_args_t *targs) > { > + if (madvise(area_dst, nr_pages * page_size, MADV_HUGEPAGE)) > + err("madvise(MADV_HUGEPAGE) failure"); > + uffd_move_test_common(targs, read_pmd_pagesize(), > + uffd_move_pmd_handle_fault); > +} > + > +static void uffd_move_pmd_split_test(uffd_test_args_t *targs) > +{ > + if (madvise(area_dst, nr_pages * page_size, MADV_NOHUGEPAGE)) > + err("madvise(MADV_NOHUGEPAGE) failure"); > uffd_move_test_common(targs, read_pmd_pagesize(), > uffd_move_pmd_handle_fault); > } > @@ -1330,6 +1340,13 @@ uffd_test_case_t uffd_tests[] =3D { > .uffd_feature_required =3D UFFD_FEATURE_MOVE, > .test_case_ops =3D &uffd_move_test_pmd_case_ops, > }, > + { > + .name =3D "move-pmd-split", > + .uffd_fn =3D uffd_move_pmd_split_test, > + .mem_targets =3D MEM_ANON, > + .uffd_feature_required =3D UFFD_FEATURE_MOVE, > + .test_case_ops =3D &uffd_move_test_pmd_case_ops, > + }, > { > .name =3D "wp-fork", > .uffd_fn =3D uffd_wp_fork_test, > -- > 2.34.1 >