From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A849C04FFE for ; Tue, 14 May 2024 16:33:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A540A8D002F; Tue, 14 May 2024 12:33:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9DCEA8D000D; Tue, 14 May 2024 12:33:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 87FDE8D002F; Tue, 14 May 2024 12:33:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 695338D000D for ; Tue, 14 May 2024 12:33:48 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 26CDD121320 for ; Tue, 14 May 2024 16:33:48 +0000 (UTC) X-FDA: 82117547736.04.6C301B8 Received: from mail-yb1-f175.google.com (mail-yb1-f175.google.com [209.85.219.175]) by imf27.hostedemail.com (Postfix) with ESMTP id 4339340018 for ; Tue, 14 May 2024 16:33:46 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=m2lwoszQ; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf27.hostedemail.com: domain of surenb@google.com designates 209.85.219.175 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715704426; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nv1f0KwnCkLw87/jdn7pXfBoRVPGPnbjvCSHZ433+XE=; b=FFp7+ghVM2DXvTten1UIQSkbw+YN2vFbx+HXenGJMgpGbucb+SkFYcxQhdD/mrb8jiCKlE CEr2YaOsKRaNVr7+1TeLEsQ0RBzK9cTAeX0HA9Rti3SxRepQBbj7MKBQJmOiDFroxVvJD6 o25uXlDenwMI1Qn/2G7KQhXV0LjbzDI= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=m2lwoszQ; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf27.hostedemail.com: domain of surenb@google.com designates 209.85.219.175 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715704426; a=rsa-sha256; cv=none; b=ZxOFC8BAgBkrZ9IK1YjbdtMQyACu9l9zBnWKUdJFODR47y/ofj3MkG+tBXrM/RjFFlBeUp /yh6FiMXI9yMfX4ek7w4sOXs6gk/MaClu9lSh/vMPh7JjwgminW5b0NXWOIjfAdYAMscQZ KUjszQlgRVXXPMsJGD5aOChVnU2F4yk= Received: by mail-yb1-f175.google.com with SMTP id 3f1490d57ef6-dc236729a2bso5777654276.0 for ; Tue, 14 May 2024 09:33:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1715704425; x=1716309225; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=nv1f0KwnCkLw87/jdn7pXfBoRVPGPnbjvCSHZ433+XE=; b=m2lwoszQcK3WLQlB/Z6JxQuYVZ8YBvG+RW/tn8MY4yfpw+Xs0ft4nLLtR9yPJTj7zz AkuCdZW2IqzrqSf4K0mSU7llygydobVWWIWAb3g6vW/FTuUlRVhstlb6GjAPBsyxuenM Dggqdyj6lUCkma4md1m2BxBXLP8gwYbH81H/5IdCrEJ+7m1mbPIekK2VtWozK6Ryjn+m Ec5QQvZaURQqC4mhDiYTjFokL6XHXFmCVLCMyImfw7OE/U0CxvU8xMbn0DWS3geIftqB umn+7+yBwE3ajYDZqkGKam/p6FefsghQ60gPnbyGKAvk1Uf6Dam/7zomJVnaXm9PO4rA auYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715704425; x=1716309225; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nv1f0KwnCkLw87/jdn7pXfBoRVPGPnbjvCSHZ433+XE=; b=irLKIzo/7Uf1aAD3690BBrtTU1uWTPy1gGKZPiBXVuUAScpxoaTWxZtCVWOWozzJNH 9xLZCKVggahAExrZZdm33QQ1gZcD59d1Atsd2fSdGwBMYpqhwVO5mQGmwOJ1hcqKZyqC tS9o95Pa7fqNSFnFGcWLbAyeWURbiuIUT8iV9yZsZsCgL//Nun2ehO1Kn3o2qRRyGuBH FWge2K2E4YSdAsz/V3e5aaz7VgLswPVvTjIkKMljPFvLMMOHGu9OKi5WlhpW8BBOsS/0 igQ050mTA7K7ou+PwSvFTK139hDAONKrxtOFSyqREHEFyCvUTlt6InJFe7W1NUfGRdGW F+tg== X-Forwarded-Encrypted: i=1; AJvYcCXIYR1G4CN3inpbO/8nwiuXrs1Hcyp/zr9CK65Cfpu7+R3wAs2jSSy/7bVN8oPcJjX8foOKh8rH7D0vRq6A4mclEII= X-Gm-Message-State: AOJu0Yxs1v2xfULj1G3fMENjI6QG6ABLhzg41ghJXH64xTgAlAtRS6ok vI0H0ygmtlPNZjmEiJB0fvWgJsTps+PPvPNi5p9XOoJwzsJHY438BFesvWQ1rbkI/UUvg8Jwosx 853lALYKZOO2WLBWXeWTFdRNtfqQG7Q3zVgD1 X-Google-Smtp-Source: AGHT+IFXAhCGaHN00zLb69EIyY6q0TTwNMCUOErAVF3O54yE63mv0vw48TLat8wi/llUL4sBRr0HPLAvGtQ1nDzkffU= X-Received: by 2002:a25:b283:0:b0:dcb:b072:82d5 with SMTP id 3f1490d57ef6-dee4f39c9bamr12638368276.64.1715704425109; Tue, 14 May 2024 09:33:45 -0700 (PDT) MIME-Version: 1.0 References: <20240514153532.3622371-1-surenb@google.com> In-Reply-To: From: Suren Baghdasaryan Date: Tue, 14 May 2024 09:33:32 -0700 Message-ID: Subject: Re: [PATCH 1/1] lib: add version into /proc/allocinfo output To: Pasha Tatashin Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, vbabka@suse.cz, keescook@chromium.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4339340018 X-Stat-Signature: 6pxb4itm1jy17f6k1frmxnnp1k7mtbpk X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1715704426-642613 X-HE-Meta: U2FsdGVkX19dQ4PQAAoQDIvjQjSSE+VfXcThbFneM+ga24CbZjZaGrKolFPyq+OCgQIGSRDLiYl2Gl27Ah3tI7bnQuOO936RUgq0pEnCxlBSXiFywnPNJMM9livUuZiBR6tgGF4ZI2OgYIGPRxol1dFmQbRBs5B+rJuMFUaUd9Ar9MWYnPLqryADTs+P+78eiim2slrS7JQMx+8zlJkEQ/rxN5jQVmtuG5QbjuaJ+xBI92e/SVj4uuK5UoL+MOPyPFHRY+Odpemm3eiVFk1WcE9LarsLoXLHB8Y9LRz8Cy63uOx118pbWHvBb/dSki/C/XTvZLaPGLOYG7OQDU6T5uJ3xhrrWZuFLRCDigYVFGltyRiopqrQ9pyutOpaq7eGgFcbTGvnnZuUVd8TOVUWbBhi6uGqXhUVT++4UbGEB7kjL//U9PxiR0VdpeGWBYnGcCm3K/FKTXnI3WC5M2pqdlPHHOwjG8Uu2RzIMkDxB5/7qHNKxpiCExJ/JE6ScnxfgzTtgYh5+QZPHKkgpb7vQwylD2V9wFCQzoaZ3megWIiB4qwMLF4pa6yBOAlebSVVvpbVWyBdFIpcZpjAok0ZIWJ6Qs4JhslqWpKhOORyNQLeW8DwZ2dEtIbtOQcbTDYOyH3U1BEltSwDxN+7WMaW2xPZq1XOnqh4r2HQ9EKrEO4Qtm7RkkvvwnuBbuHfWHGpEwuU/UQa+S1T9b9mBF718XogQYeXtYBhcs7RjiKy+ZO7YLrvbDmNw3UZRNmUVNzoUCSpWo14ydT1A4CaKanOlUcN6aFLnzh8CYz2vBNKjvw4uF7fuK0tgnFxqKD3GOWdD/Qm4LGfN+66FVWg8vWgjphsRvyr/wD2NBUmU2SkvlvM+ZXnx0/C87LzWUyb0bGhbULzcYBGMY74+n1JZy87xuv6LeIECeMD+HxOiCB7tQjTzKrdhhSgl+A7uJj8DlTViyT047kgsxG962DUSTw LOvqJSqQ HSynz08903sjI/cisKZ2L6OMK4+slTt8aK4CZLvS5nQlv2JLTShMp/7XuY1nG/JdCznu5u2sMbcdyPXORbXD+R51V2dBWZAGPi5DVU8BgCmNZyUEBCrelnWZLs32H5oSLEuJYLQwZW+lFQxrWNLVtJqCWQ03Cb5G5mxe15azqHJNqy9vGlG3dCDxZWFFFKzFLXJtAZesH7eEiUWfAvysU09O1X0O2qY+6Y9tuku2Zeh98fo5GLe/BDBbz4Iaesbx4h03Hq5MC9YDSYt9rmv9/SOi1tC4VVKQji2rbkoe/gzkpGdLOgouX0sRm6XJTqmBsxKR9qjFOvipsF8GsjRwG+lnerK1U0QQ4wn+PYwj3g5QdARM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000031, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 14, 2024 at 8:56=E2=80=AFAM Pasha Tatashin wrote: > > On Tue, May 14, 2024 at 9:35=E2=80=AFAM Suren Baghdasaryan wrote: > > > > Add version string at the beginning of /proc/allocinfo to allow later > > format changes. Exampe output: > > > > > head /proc/allocinfo > > allocinfo - version: 1.0 > > 0 0 init/main.c:1314 func:do_initcalls > > 0 0 init/do_mounts.c:353 func:mount_nodev_root > > 0 0 init/do_mounts.c:187 func:mount_root_generic > > 0 0 init/do_mounts.c:158 func:do_mount_root > > 0 0 init/initramfs.c:493 func:unpack_to_rootfs > > 0 0 init/initramfs.c:492 func:unpack_to_rootfs > > 0 0 init/initramfs.c:491 func:unpack_to_rootfs > > 512 1 arch/x86/events/rapl.c:681 func:init_rapl_pmus > > 128 1 arch/x86/events/rapl.c:571 func:rapl_cpu_online > > It would be also useful to add a header line: > > $ head /proc/allocinfo > allocinfo - version: 1.0 > # > 0 0 init/main.c:1314 func:do_initcalls > 0 0 init/do_mounts.c:353 func:mount_nodev_root > 0 0 init/do_mounts.c:187 func:mount_root_generic > 0 0 init/do_mounts.c:158 func:do_mount_root > ... > > This would be the same as in /proc/slabinfo: > $ sudo head /proc/slabinfo > slabinfo - version: 2.1 > # name > : tunables : > slabdata > pid_3 2730 2730 192 42 2 : tunables 0 0 > 0 : slabdata 65 65 0 > .. Thanks! Addressed in v2: https://lore.kernel.org/all/20240514163128.3662251-1-surenb@google.com/ > > Pasha