From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE65BC54E76 for ; Tue, 17 Jan 2023 18:55:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 68F176B0072; Tue, 17 Jan 2023 13:55:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 618076B0073; Tue, 17 Jan 2023 13:55:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 491AC6B0074; Tue, 17 Jan 2023 13:55:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 358356B0072 for ; Tue, 17 Jan 2023 13:55:48 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 0292312057F for ; Tue, 17 Jan 2023 18:55:47 +0000 (UTC) X-FDA: 80365195176.24.E45F613 Received: from mail-yb1-f178.google.com (mail-yb1-f178.google.com [209.85.219.178]) by imf27.hostedemail.com (Postfix) with ESMTP id 53A0940019 for ; Tue, 17 Jan 2023 18:55:46 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=Mt+sJp5d; spf=pass (imf27.hostedemail.com: domain of surenb@google.com designates 209.85.219.178 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673981746; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Hjk26ZZoZCfL6kjko8l/pSHnRgndFb4Mk147LRzA91E=; b=7bZmSNGrJcAkc7JvLNB6XUZVQH+1nUBe7fKrAtZFoEK+zwjevnxyqY29rt+Bb3g81Ytrcm RfrQOK0OysA+iMwCFXvh0LnGJ4NPrAWoVNNkBQlrz73EQSbThBDeqY64w6vco+irZcKTh5 eZhZojlqL5449H9hQi7/T5zoz2jyDcw= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=Mt+sJp5d; spf=pass (imf27.hostedemail.com: domain of surenb@google.com designates 209.85.219.178 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673981746; a=rsa-sha256; cv=none; b=q8CfohPqxEXtAlBa9pL1ZCugUmkiknVLAU3uhKP0t0CYL3MmrqAthJVKmn150DetIuDnJz 9DbaBRNkl4T9OZGzZZwXsyyL4zvpnsicj0eoozafKZxGQjxiI70VLxfnNy1wkb3Lvp4InZ Vrw3wfZJx5kAnA2JORrNyOJkg6CGN9s= Received: by mail-yb1-f178.google.com with SMTP id o75so35287885yba.2 for ; Tue, 17 Jan 2023 10:55:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Hjk26ZZoZCfL6kjko8l/pSHnRgndFb4Mk147LRzA91E=; b=Mt+sJp5dwuIsL+Ko5cT1XtmvNX0+vXcya9w3KxCAGiP5wEFud5o530HskF9og8ZMkd ljvA9NKCih7KjYskMBb5clv4araVsgVH8bivehaUbVs1zXmC/Q33zJ2WQgBH8wLEh0Ww LO52zNPDud7WwXKOiScqFdlxb/HA84LcUefakhGKNdWzRjfSLYoc+FzRvi5aIbasr4/1 iGt43X07P5GiJPZJVy/5QSn6qq+xCbFLi962ogszxOLly8aqpiMkM3flx1tsWJ3TC+lM JwJqwtVwEAaEziK1WoW3RHASnzImrfdF+niEuev4vFd01otF7C+PJQGmm/v884HYR4zi v9EQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Hjk26ZZoZCfL6kjko8l/pSHnRgndFb4Mk147LRzA91E=; b=2Cnk9AWvmtQ+elQf5eT3Je67n6eu3txzSSbVt4e+LP5OBbYIwOF4AaNpr1W1ffoFyn JavZ/eKe1/FTnqzwXYwI14jnBU/ZyJqK+YWuSYBp64nKRD4R6/wCB3Y7mAMzw6rCaSve /+Gsafpj+F55u44yb/gI+UaT3UBL5T0eQwhQzRTRupddLy8lvuj3EBr/tfAw38da8fMn GDLCWrYqxACH9sqsnkXQ0dGCDVaMBrOKqdb0psnJRfV5ichvsQ5FyMMmxGMQeulQ78bk ys0/YYo92OvoI2iAJVD3VUEl0ajdDeahh3ubvoikEq87JJvdKL2Hjg58NhHzMo0FkxVW vN4Q== X-Gm-Message-State: AFqh2kpi6luI0qdHphG8ADfzfTMhCiVPE/zFpJX4IXaium0bFZfaMaBO aettO8hIy96x8b9Gculv10UXuNejhx6nbEoCULYoPA== X-Google-Smtp-Source: AMrXdXsB68dzuUro7SI9IrfjHxCTvw8eBu3xk1m8gxflhvDRkqqF3qc7tx3EmnQTV75nr092zIYy1Q+gFJMC6cvTzv8= X-Received: by 2002:a5b:cc8:0:b0:7ba:78b1:9fcc with SMTP id e8-20020a5b0cc8000000b007ba78b19fccmr507280ybr.593.1673981745113; Tue, 17 Jan 2023 10:55:45 -0800 (PST) MIME-Version: 1.0 References: <20230109205336.3665937-1-surenb@google.com> <20230109205336.3665937-42-surenb@google.com> In-Reply-To: From: Suren Baghdasaryan Date: Tue, 17 Jan 2023 10:55:33 -0800 Message-ID: Subject: Re: [PATCH 41/41] mm: replace rw_semaphore with atomic_t in vma_lock To: Matthew Wilcox Cc: Jann Horn , akpm@linux-foundation.org, michel@lespinasse.org, jglisse@google.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@techsingularity.net, dave@stgolabs.net, liam.howlett@oracle.com, peterz@infradead.org, ldufour@linux.ibm.com, laurent.dufour@fr.ibm.com, paulmck@kernel.org, luto@kernel.org, songliubraving@fb.com, peterx@redhat.com, david@redhat.com, dhowells@redhat.com, hughd@google.com, bigeasy@linutronix.de, kent.overstreet@linux.dev, punit.agrawal@bytedance.com, lstoakes@gmail.com, peterjung1337@gmail.com, rientjes@google.com, axelrasmussen@google.com, joelaf@google.com, minchan@google.com, shakeelb@google.com, tatashin@google.com, edumazet@google.com, gthelen@google.com, gurua@google.com, arjunroy@google.com, soheil@google.com, hughlynch@google.com, leewalsh@google.com, posk@google.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 53A0940019 X-Stat-Signature: shpx7sqe3wmb5a9k9fgusz7gtmg38e11 X-HE-Tag: 1673981746-608493 X-HE-Meta: U2FsdGVkX18t49YZLOtW9eu/FQqcJsF6lw58NaWNilxBPvIXOoCcSqYrngmB+RJBelFoPGFtsnTRu1NKzr7g5rJYe5nn70hs41K1eXEIfGfpnanqlGDa/z/goCkUPm0RTXO+WePLjFzu6f1WYTD30Z0JsI5LD+TNyUefQqYW2lNwPzqOxwx0So9RmmEIZYDXUeukJ09VGm/xl7TvfUTw+kLXzmhCI4boDoUmwEAM1srAu5ZAcqbDVhmx50bgW9RcYMzSvbzlVrpmOEQYKEXJk+AC0dpL6MNFjalNypkFsbvYmfc7rhT7pybqDDpgq6eVkGIKmN0cnfVYb5A5ozFNEujIf1MlDKtix4/QCRtuhPDkPoWXXm1RcnS+Z4wUDrzAWwbb4C+hX1BPaKjQLh9LBP6sBQTKqN3lQTZjbZVHWoU1CgrOe/s9rQSgBDb7fJZ1IBdoXiafRXiaHswVldcx7PMZt/vij5neqUJz7gLqDK8e78ThSz4M5aYTuPHxeZSLXzkdruQyix1rbBxxVcYumvyZ6+JIulswJxrhnapKfc96L8oMy7tUwk7ENHuHzShn6kaS/WyEoNbDeGbM5ZgJpoZb/oFhnzZI5awfS0r00x7IH1IzH0g73wwa+RRbvS/Y3O7w3tlgjTcCP4rvu4ro8G7DWV8HZQuBDI77rygQ8x3ZUgWHV23TysnziLobgt+k8Tz+UCDwJnlmLa9sCcoQvy6Qdw7u3POXnJYPxJqCCIxqRofwlaIuYkGtfsVpnz06R/SkuY7gjglNKjpxrf8IKSoK3ydAVQClidThWNjB61EywjGYxehG9WV97RRnXKuJeavqhZffii4ZLO0EDggUWwOP4Bbqkdo/3Kmffuyg1gAGJwpJdm1wHvAtLz/5VQe8xYzOJnPc1zaI8MXe7ejBhZE1VKdoMor2mYK7Wk2rvYEVVGADxTAXx+IgVlfY0AhreHhhyYKgJWiziOUQsY2 VsteQTQ5 JbIaSpkHH0h1wVtFViw/kOlpXwhL+N2cIJuX0QiVAC8wrXcpRSkCOQ7yGag== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 17, 2023 at 10:47 AM Matthew Wilcox wrote: > > On Tue, Jan 17, 2023 at 10:36:42AM -0800, Suren Baghdasaryan wrote: > > On Tue, Jan 17, 2023 at 10:31 AM Matthew Wilcox wrote: > > > > > > On Tue, Jan 17, 2023 at 10:26:32AM -0800, Suren Baghdasaryan wrote: > > > > On Tue, Jan 17, 2023 at 10:12 AM Jann Horn wrote: > > > > > > > > > > On Mon, Jan 9, 2023 at 9:55 PM Suren Baghdasaryan wrote: > > > > > > rw_semaphore is a sizable structure of 40 bytes and consumes > > > > > > considerable space for each vm_area_struct. However vma_lock has > > > > > > two important specifics which can be used to replace rw_semaphore > > > > > > with a simpler structure: > > > > > [...] > > > > > > static inline void vma_read_unlock(struct vm_area_struct *vma) > > > > > > { > > > > > > - up_read(&vma->vm_lock->lock); > > > > > > + if (atomic_dec_and_test(&vma->vm_lock->count)) > > > > > > + wake_up(&vma->vm_mm->vma_writer_wait); > > > > > > } > > > > > > > > > > I haven't properly reviewed this, but this bit looks like a > > > > > use-after-free because you're accessing the vma after dropping your > > > > > reference on it. You'd have to first look up the vma->vm_mm, then do > > > > > the atomic_dec_and_test(), and afterwards do the wake_up() without > > > > > touching the vma. Or alternatively wrap the whole thing in an RCU > > > > > read-side critical section if the VMA is freed with RCU delay. > > > > > > > > vm_lock->count does not control the lifetime of the VMA, it's a > > > > counter of how many readers took the lock or it's negative if the lock > > > > is write-locked. > > > > > > Yes, but ... > > > > > > Task A: > > > atomic_dec_and_test(&vma->vm_lock->count) > > > Task B: > > > munmap() > > > write lock > > > free VMA > > > synchronize_rcu() > > > VMA is really freed > > > wake_up(&vma->vm_mm->vma_writer_wait); > > > > > > ... vma is freed. > > > > > > Now, I think this doesn't occur. I'm pretty sure that every caller of > > > vma_read_unlock() is holding the RCU read lock. But maybe we should > > > have that assertion? > > > > Yep, that's what this patch is doing > > https://lore.kernel.org/all/20230109205336.3665937-27-surenb@google.com/ > > by calling vma_assert_no_reader() from __vm_area_free(). > > That's not enough though. Task A still has a pointer to vma after it > has called atomic_dec_and_test(), even after vma has been freed by > Task B, and before Task A dereferences vma->vm_mm. Ah, I see your point now. I guess I'll have to store vma->vm_mm in a local variable and call mmgrab() before atomic_dec_and_test(), then use it in wake_up() and call mmdrop(). Is that what you are thinking?