From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31224C433FE for ; Tue, 5 Oct 2021 21:31:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D605A614C8 for ; Tue, 5 Oct 2021 21:31:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D605A614C8 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 742B96B006C; Tue, 5 Oct 2021 17:31:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6F19E6B0071; Tue, 5 Oct 2021 17:31:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5BA176B0073; Tue, 5 Oct 2021 17:31:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0163.hostedemail.com [216.40.44.163]) by kanga.kvack.org (Postfix) with ESMTP id 4E9E56B006C for ; Tue, 5 Oct 2021 17:31:01 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 10BA731EB0 for ; Tue, 5 Oct 2021 21:31:01 +0000 (UTC) X-FDA: 78663679122.30.A5F3B9C Received: from mail-yb1-f179.google.com (mail-yb1-f179.google.com [209.85.219.179]) by imf07.hostedemail.com (Postfix) with ESMTP id C592C1001C83 for ; Tue, 5 Oct 2021 21:31:00 +0000 (UTC) Received: by mail-yb1-f179.google.com with SMTP id i84so724298ybc.12 for ; Tue, 05 Oct 2021 14:31:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=zFd2aEpAbN0UaxYqSieP1eT57btxJ5r4/ig5AwZ56hU=; b=A6cMmH6kIYNw3BTgbMB7RjNRiWzfr4Rx+YvMM2U6bgd5BP75qsOkQ6RxR6rUGfz+vB rfjOyFzG3JmZ01R24GvvhBKUBeF8C9WDST11Re/o14/bDrTbnLwSx3TU8/IfuS0OJVCx JhkIvBFZUFQdKcFvScBgAjAjd1//rDxbW0JYsEyatBB36ofJDPAwd1syR0+pPemucCzv dA3hDlf0O2JOHdYfJ0fccJlwurmUscamj4c6tlh87z41jjaba51DOA7GXPYJKHXrTXdM +UOty4XjTFa3eyRZg8LEgrxJb2GOqgQw/UedY2Bnb+zW7nu3QBeUWf/h2tvMUUEuY6OI pQxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=zFd2aEpAbN0UaxYqSieP1eT57btxJ5r4/ig5AwZ56hU=; b=BpfCmRNDLfpfUkYVmAs/fGj4/6y9mqgnhPGlkSbIWwuwZFBoCskx3Lfdw1P/RKQfJy Z+Ni9eXQhcrLgHZjB0Y5d3/uMdvD7IXNiUBc6cEEWA8K2McH/Hgk5sr+DtnqRvHK5dpE IwGZCq66f8QpTqFSpQR1yv12cZZJMB16X8m8p87b2xT3iPjFHgNcK0EtdNhvm2K5PkKe WkANevDDSH3tjqNJKDkRNMXT1eJZyJZ14scklEjkNOO0HPPesL/Oq3yvR8oR4rinupXW 3vZ0K6X3XLrXFEcse6YV5e+oHwYDfx9F9SBJMSPqHK2hO/FuJBoC/sttunMZ/+12AvqV rB5Q== X-Gm-Message-State: AOAM533W367JxbuI3UG/Iq0ebS+CDTohCj7lGo5VN6A20UcFco2FK+YD fh+ENkxtYkabuwT0r5cTgs9WD/m7ienX8HryVpQXSA== X-Google-Smtp-Source: ABdhPJxIZnTZN87HdH/jKt8pzHjywbGdk+rQNE5ijTKlFRuji90ahdhfsDtTCVCgO9/p/VxoanNZP2pPH0+zMb7LRGQ= X-Received: by 2002:a25:3:: with SMTP id 3mr24887463yba.418.1633469459834; Tue, 05 Oct 2021 14:30:59 -0700 (PDT) MIME-Version: 1.0 References: <20211001205657.815551-1-surenb@google.com> <5358242.RVGM2oBbkg@devpool47> <20211005210003.v3zgqhefn5j65gig@revolver> In-Reply-To: <20211005210003.v3zgqhefn5j65gig@revolver> From: Suren Baghdasaryan Date: Tue, 5 Oct 2021 14:30:48 -0700 Message-ID: Subject: Re: [PATCH v10 1/3] mm: rearrange madvise code to allow for reuse To: Liam Howlett Cc: Rolf Eike Beer , Andrew Morton , Colin Cross , Sumit Semwal , Michal Hocko , Dave Hansen , Kees Cook , Matthew Wilcox , "Kirill A . Shutemov" , Vlastimil Babka , Johannes Weiner , Jonathan Corbet , Al Viro , Randy Dunlap , Kalesh Singh , Peter Xu , "rppt@kernel.org" , Peter Zijlstra , Catalin Marinas , "vincenzo.frascino@arm.com" , =?UTF-8?B?Q2hpbndlbiBDaGFuZyAo5by16Yym5paHKQ==?= , Axel Rasmussen , Andrea Arcangeli , Jann Horn , "apopple@nvidia.com" , John Hubbard , Yu Zhao , Will Deacon , "fenghua.yu@intel.com" , "thunder.leizhen@huawei.com" , Hugh Dickins , "feng.tang@intel.com" , Jason Gunthorpe , Roman Gushchin , Thomas Gleixner , "krisman@collabora.com" , Chris Hyser , Peter Collingbourne , "Eric W. Biederman" , Jens Axboe , "legion@kernel.org" , Cyrill Gorcunov , Pavel Machek , Muchun Song , Viresh Kumar , Thomas Cedeno , "sashal@kernel.org" , "cxfcosmos@gmail.com" , LKML , "linux-fsdevel@vger.kernel.org" , "linux-doc@vger.kernel.org" , linux-mm , kernel-team , Pekka Enberg , Ingo Molnar , Oleg Nesterov , Jan Glauber , John Stultz , Rob Landley , Cyrill Gorcunov , "Serge E. Hallyn" , David Rientjes , Mel Gorman , Shaohua Li , Minchan Kim , Rasmus Villemoes Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: C592C1001C83 X-Stat-Signature: dkrubrshatitqarmysiuoazmpjdi1zpu Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=A6cMmH6k; spf=pass (imf07.hostedemail.com: domain of surenb@google.com designates 209.85.219.179 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com X-HE-Tag: 1633469460-50027 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Oct 5, 2021 at 2:00 PM Liam Howlett wrote= : > > * Suren Baghdasaryan [211004 12:18]: > > On Mon, Oct 4, 2021 at 12:03 AM Rolf Eike Beer wrote: > > > > > > > --- a/mm/madvise.c > > > > +++ b/mm/madvise.c > > > > @@ -63,76 +63,20 @@ static int madvise_need_mmap_write(int behavior= ) > > > > } > > > > > > > > /* > > > > - * We can potentially split a vm area into separate > > > > - * areas, each area with its own behavior. > > > > + * Update the vm_flags on regiion of a vma, splitting it or mergin= g it as > > > ^^ > > > > Thanks! Will fix in the next version. > > Since you'll be respinning for this comment, can you please point out > that the split will keep the VMA as [vma->vm_start, new_end)? That is, > __split_vma() is passed 0 for new_below. It might prove useful since > the code is being reused. Hmm. There are two cases here: if (start !=3D vma->vm_start) { ... error =3D __split_vma(mm, vma, start, 1); } and if (end !=3D vma->vm_end) { ... error =3D __split_vma(mm, vma, end, 0); } so, I don't think such a comment would be completely correct, no? > > Thanks, > Liam > > > > > > > > > Eike > > > -- > > > Rolf Eike Beer, emlix GmbH, http://www.emlix.com > > > Fon +49 551 30664-0, Fax +49 551 30664-11 > > > Gothaer Platz 3, 37083 G=C3=B6ttingen, Germany > > > Sitz der Gesellschaft: G=C3=B6ttingen, Amtsgericht G=C3=B6ttingen HR = B 3160 > > > Gesch=C3=A4ftsf=C3=BChrung: Heike Jordan, Dr. Uwe Kracke =E2=80=93 Us= t-IdNr.: DE 205 198 055 > > > > > > emlix - smart embedded open source > > > > > > -- > > > To unsubscribe from this group and stop receiving emails from it, sen= d an email to kernel-team+unsubscribe@android.com. > >