From: Suren Baghdasaryan <surenb@google.com>
To: "Vlastimil Babka (SUSE)" <vbabka@kernel.org>
Cc: akpm@linux-foundation.org, vbabka@suse.cz, harry.yoo@oracle.com,
00107082@163.com, cl@gentwo.org, rientjes@google.com,
roman.gushchin@linux.dev, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/1] mm/slab: mark alloc tags empty for sheaves allocated with __GFP_NO_OBJ_EXT
Date: Thu, 26 Feb 2026 07:52:19 -0800 [thread overview]
Message-ID: <CAJuCfpG_nu+sx7BZsKqKR+iznDmoRaFtRrNYgzV+0iXeVDK4Nw@mail.gmail.com> (raw)
In-Reply-To: <042fceca-f2ba-4656-87d0-89676cdd435c@kernel.org>
On Thu, Feb 26, 2026 at 1:40 AM Vlastimil Babka (SUSE)
<vbabka@kernel.org> wrote:
>
> On 2/25/26 22:28, Suren Baghdasaryan wrote:
> > On Wed, Feb 25, 2026 at 9:23 PM Vlastimil Babka <vbabka@suse.com> wrote:
> >>
> >> On 2/25/26 8:08 PM, Suren Baghdasaryan wrote:
> >> > On Wed, Feb 25, 2026 at 4:34 PM Suren Baghdasaryan <surenb@google.com> wrote:
> >> >>
> >> >> alloc_empty_sheaf() allocates sheaves from SLAB_KMALLOC caches using
> >> >> __GFP_NO_OBJ_EXT to avoid recursion, however it does not mark their
> >> >> allocation tags empty before freeing, which results in a warning when
> >> >> CONFIG_MEM_ALLOC_PROFILING_DEBUG is set. Fix this by marking allocation
> >> >> tags for such sheaves as empty.
> >> >>
> >> >
> >> > I think this should also have:
> >> >
> >> > Fixes: 4c0a17e28340 ("slab: prevent recursive kmalloc() in alloc_empty_sheaf()")
> >> >
> >> > and CC to stable for inclusion into 6.19.
> >> > Andrew, Vlastimil, should I post another version CC'ing stable or you
> >> > can add that line and forward to stable?
> >>
> >> I will add it. Note, they don't care about getting an actual email, but
> >> seeing the Cc: line in the mainline commit.
> >
> > Perfect! Thank you. Let me know if anything else is needed on my end.
>
> I tried to cherry-pick it to 6.19 stable and there were conflicts so I
> think it's easier to just remove the Cc stable. Instead I updated the
> changelog/trailer to contain:
>
> The problem was technically introduced in commit 4c0a17e28340 but only
> becomes possible to hit with commit 913ffd3a1bf5.
Ack. Thanks!
>
> Fixes: 4c0a17e28340 ("slab: prevent recursive kmalloc() in alloc_empty_sheaf()")
> Fixes: 913ffd3a1bf5 ("slab: handle kmalloc sheaves bootstrap")
> Reported-by: David Wang <00107082@163.com>
> ...
>
> Added to slab/for-next-fixes, thanks!
>
> >>
> >> >> Reported-by: David Wang <00107082@163.com>
> >> >> Closes: https://lore.kernel.org/all/20260223155128.3849-1-00107082@163.com/
> >> >> Analyzed-by: Harry Yoo <harry.yoo@oracle.com>
> >> >> Signed-off-by: Suren Baghdasaryan <surenb@google.com>
> >> >> Reviewed-by: Harry Yoo <harry.yoo@oracle.com>
> >> >> Tested-by: Harry Yoo <harry.yoo@oracle.com>
> >> >> Tested-by: David Wang <00107082@163.com>
prev parent reply other threads:[~2026-02-26 15:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-25 16:34 Suren Baghdasaryan
2026-02-25 19:08 ` Suren Baghdasaryan
2026-02-25 21:23 ` Vlastimil Babka
2026-02-25 21:28 ` Suren Baghdasaryan
2026-02-26 9:40 ` Vlastimil Babka (SUSE)
2026-02-26 15:52 ` Suren Baghdasaryan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJuCfpG_nu+sx7BZsKqKR+iznDmoRaFtRrNYgzV+0iXeVDK4Nw@mail.gmail.com \
--to=surenb@google.com \
--cc=00107082@163.com \
--cc=akpm@linux-foundation.org \
--cc=cl@gentwo.org \
--cc=harry.yoo@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=vbabka@kernel.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox