From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D5DDC5478C for ; Mon, 26 Feb 2024 17:12:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B3FCE440187; Mon, 26 Feb 2024 12:12:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AC94A44017F; Mon, 26 Feb 2024 12:12:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 96A10440187; Mon, 26 Feb 2024 12:12:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 8345244017F for ; Mon, 26 Feb 2024 12:12:02 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 444ABA0BBE for ; Mon, 26 Feb 2024 17:12:02 +0000 (UTC) X-FDA: 81834597684.11.4B0E652 Received: from mail-yb1-f176.google.com (mail-yb1-f176.google.com [209.85.219.176]) by imf06.hostedemail.com (Postfix) with ESMTP id 879CD180003 for ; Mon, 26 Feb 2024 17:12:00 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="D6ND/U+O"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf06.hostedemail.com: domain of surenb@google.com designates 209.85.219.176 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708967520; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Chynr1L1b/d5TcYFCNc4RvKn+tu9v2QwhIq+NAH+cTo=; b=ArZJq7+K3hqMWpjNt/Z/Cz7T1CCzj0A76MrXRL541PZnu6WiUv51QKzkmY4sqit9v6nCcK 3IEbYWkHTADwn3fzjd1REHTD4ENIWHRcvTCdXqtSASqPQGkSmdn4vgYMhvSYRejEuNEkWi AovpSCIwkPpzRte1Tel9UPgn5HzPKcI= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="D6ND/U+O"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf06.hostedemail.com: domain of surenb@google.com designates 209.85.219.176 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708967520; a=rsa-sha256; cv=none; b=uyOSjovBVegDd29LfE7uNaHXSSw+KpvFRJZaGUZYWB4oJvWvciPo+7uRKy+CUiSgLbMwq0 StNB/EemEpMIf/YOEDtY3AxWyDdkTQhJqlofkUXV6Rup3FtghqMel03hJD+Gj1ouLYKcHA dS7Z2giYuJadrVQPSS/rrbkS/bqgcpc= Received: by mail-yb1-f176.google.com with SMTP id 3f1490d57ef6-dc6d8bd612dso3249805276.1 for ; Mon, 26 Feb 2024 09:12:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1708967519; x=1709572319; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Chynr1L1b/d5TcYFCNc4RvKn+tu9v2QwhIq+NAH+cTo=; b=D6ND/U+OnuZf18FK48AeIPloyya03waolHCnWf9vXgKj3PzVgxS9KreZJtSZVibbw8 3C55Fl/Fn8XRRNzdTTQjitKpnJyPr4SHTX90nwX76TGI9OYkFimuSbftaWZBDdp7VSrO VPJ7UkXgZZLy7Bfe/RhAOeXoDoB/gxNHMN2m1fql2RjUEMzRGo0TMkhDTfIj3KBnzIeJ dGvuKR1PU19E6X7BWisLAhmgeKWEEuGz7RT+Y9s/Rp5zuE3MBkXrDLr6fP0X+VlksZLG ZFl/hjdTHVZ7X9TKRD0t7XRU3kcX+wFDMWE/4s6KzqCd4+Y+lphgGr9FxiGN0gmBdTtI hM4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708967519; x=1709572319; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Chynr1L1b/d5TcYFCNc4RvKn+tu9v2QwhIq+NAH+cTo=; b=Yjc/rErKYkccsOBSbhG6XAOMIyDfidabrrd+UtL9nxz90Y97soNGdyDQYMlxmpOwH3 PMV2YPejRLO2UZcmaWkVlPMpHWHl3L4HW0Om1Zne+YxalIhekjTh7a9qvyi0Wi//5tJP wGL98JMpAtnbHf4BbjHuNJaNo6ZUeLAarr/gBHQQ7j+3KkhKNhGBYV1fC9na231WHAKQ pmS9yjq/wLYsu9p2H7nXkiAUNvOJEbTtgsdTxltw1m3V5DBsiNmmjN8N3sr8nHj5CYJX +l8xSqhv2lHSimkB4KtUzlZhCYIhRYzcd6TEaOvZSKN5aGwfIUPHNVXwlr8EG1KKShsM RhFQ== X-Forwarded-Encrypted: i=1; AJvYcCUejWB7PBN5OMpOkM9Qux7IWhr17FeGXTgeO0pMBX8P8pxoNYk8wGaVtt8l4L7fQhgCWEqhtyhBdO5/hWaSpRD5zCs= X-Gm-Message-State: AOJu0YxOj/N7uPTtYV8U4xwgqLpnOGmFnKB/fJ/2/oeGyfKFgX8gXFG8 aIlw5SB8edvmcgHqw9NEXPe9j9AP5NIKEQCs6RX9neySxsNaWFE7mz8+ifVX8xftBOE3iYGz+L8 UIjNDN5nBlY2iQSO4h4+qgYz0ix5qnx8Gd2mf X-Google-Smtp-Source: AGHT+IFIvCWhsm/t6u8M8LFQ9aoCdr7tXSqiWENlQfptKH682IaVJyWTqKPlBpDf+9Q2OFcqiRYx3fgZnfrpOzBGyTM= X-Received: by 2002:a25:acd2:0:b0:dcc:2caa:578b with SMTP id x18-20020a25acd2000000b00dcc2caa578bmr5024557ybd.40.1708967519035; Mon, 26 Feb 2024 09:11:59 -0800 (PST) MIME-Version: 1.0 References: <20240221194052.927623-1-surenb@google.com> <20240221194052.927623-16-surenb@google.com> In-Reply-To: From: Suren Baghdasaryan Date: Mon, 26 Feb 2024 09:11:45 -0800 Message-ID: Subject: Re: [PATCH v4 15/36] lib: introduce support for page allocation tagging To: Vlastimil Babka Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, mhocko@suse.com, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, penguin-kernel@i-love.sakura.ne.jp, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: dmy3msshtspxtbmtmkxsbj4gr7rgjmyt X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 879CD180003 X-HE-Tag: 1708967520-34919 X-HE-Meta: U2FsdGVkX19TGGs+uFs1/M/Hcg6Tf99fXuKNkLkyow0Y/lc/0I4BVuI4IRbOuxWCbt2xaakk3gliHiNDi+ANGXavCL4U8xx41po7KUhVxDY223tsE/rMuuKL7dZtCdPtmuw1Zm4Lv5BEdIbItjcxZS/v3FbXjPAQ+s1WBBTYdIRbqFO5/YUEupFZaPB/clwBtq0QYTOO6o0oSIo5NY8x65TjaeTqG+JrPauKjT3g4y305I8/nj9SKZiwQhfob6U1ea/0FqyFBB4vR2/TG+Lkj3BR2Zm08swnApHeWKW1blptSvDgajYE5SIxWNLdD2YlAxrm5GC3YtJv1y1/DkaXy0itTIutPxx/xlwyg6hDjvGuDijN/HwNCWKAeYgo2L7OJCSZDgpc1VXSa7jRplcJCI1B4nFda2cQo8Z4z14mK/8TFg7NpQIl9ModhnsRzsdwxTid8Lqg0CnTHXYN6dJXNFzGxGiJPTbYfAEJ2YwWH5C+yLvOE1M0aFVNDfYqxoCmOkKpvsUVDR9WsbmTV9VZVriS5fu5NCnEU+Jp5e3PMMQjfWhFBNihlt++J8Vtt5Jw1Kjtr7BFCZSvp24QjR2VhHYC5QX2DnhsSi5L9mGLrk8MzeiRvQb6BMcytZnQXZ877zmMWkGhzBMiFvzZWvyyTa2Me0lDQEi46HEOoztGFLNykEzKdsTf/9ua5zc/4ilcQS8qe5omS3nx7YZpwWz6wnpKnXTaM0J5i5Pf2cepiSETJ8stM6RtHaJr/ptPrbGLcfgoea8InKznO6EetvWv91ik4XSc5dw1JkFj09PMv3nUsgPRACN9reZHXe/WWm9YuAb9M8qkCU8A/8mOy6LlUAJYEbdsgY5IrSSGIgL90KLcTFcWfSqWHu+CdUPTwFj0zOHlORu1ZS/3nG2eVuGZwnH124ONOd00vW+9FJtufxXEwdPEADaVFbwUZCiUuaUH1jYM5BozwMbuKgrMYvQ JKFkpdys M6zFxk6EntwgEYLJi4Tqn784vc4XCqilL+UoJAEkc+BakGpsE47+0MZdTYqJYjnd+9xLa X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 26, 2024 at 9:07=E2=80=AFAM Vlastimil Babka wr= ote: > > On 2/21/24 20:40, Suren Baghdasaryan wrote: > > Introduce helper functions to easily instrument page allocators by > > storing a pointer to the allocation tag associated with the code that > > allocated the page in a page_ext field. > > > > Signed-off-by: Suren Baghdasaryan > > Co-developed-by: Kent Overstreet > > Signed-off-by: Kent Overstreet > > The static key usage seems fine now. Even if the page_ext overhead is sti= ll > always paid when compiled in, you mention in the cover letter there's a p= lan > for boot-time toggle later, so Yes, I already have a simple patch for that to be included in the next revision: https://github.com/torvalds/linux/commit/7ca367e80232345f471b77b3= ea71cf82faf50954 > > Reviewed-by: Vlastimil Babka Thanks! > >