From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5D5AC48BF6 for ; Mon, 19 Feb 2024 01:05:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 489026B0075; Sun, 18 Feb 2024 20:05:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 439F66B0078; Sun, 18 Feb 2024 20:05:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2D9FB8D0002; Sun, 18 Feb 2024 20:05:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 1AE436B0075 for ; Sun, 18 Feb 2024 20:05:11 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id B79B31C013A for ; Mon, 19 Feb 2024 01:05:10 +0000 (UTC) X-FDA: 81806759580.21.094249E Received: from mail-yb1-f174.google.com (mail-yb1-f174.google.com [209.85.219.174]) by imf18.hostedemail.com (Postfix) with ESMTP id F0E2D1C001A for ; Mon, 19 Feb 2024 01:05:08 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=FnTkJWKs; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf18.hostedemail.com: domain of surenb@google.com designates 209.85.219.174 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708304709; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mIDaOHUmOnFQVc3Wwg+6+LPaeJ2ta81+Eqz5TMzPBys=; b=yivwZfwEaIIzQvlZrNL+OFHVbNymbH8A6VxQTw0Rt+yltoSiq6Putu/7oiBL2x0lCU6o/+ 8UnzpOmVcmUZghOmYYYCemK1X7YeZNKE417p687GCrLcGzJ8X56FRGM1rmdL/5nxUFSw9t hOX6i4uNsTTmBEvua4vx0yx6gmT6rsM= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=FnTkJWKs; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf18.hostedemail.com: domain of surenb@google.com designates 209.85.219.174 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708304709; a=rsa-sha256; cv=none; b=aF9X4c7vGiKa/lJGg+WUD4GjDASOq+8KZmHo+dyPqPcmCx/o3wxeuDvHCJCDgOHZSyKJ9J 0gGmy7pn6uuzbdPH5So6X7miwUBcBVxHJjIfwKVDMm4kNMYOANLbTB33NPExxeWQNVEUaK /5LZ1ewkjbnVgjx9uzlhgif+YK05Rhg= Received: by mail-yb1-f174.google.com with SMTP id 3f1490d57ef6-dc238cb1b17so3543794276.0 for ; Sun, 18 Feb 2024 17:05:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1708304708; x=1708909508; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=mIDaOHUmOnFQVc3Wwg+6+LPaeJ2ta81+Eqz5TMzPBys=; b=FnTkJWKsaEfSKiBSfzAHeLhb/c6jhU2HS/LS6avtSCI4xpF8wZfZvMjcyuq8gY9PO6 9WQbp6qrRQXV0DBXU9JG74nOPMnBLnb5CafHAeYDrlmpSfjNlpmIgJQDPasiWKuQtaCO w8FRaelVGlIm9kwGlXY+JSakqjn/8O4dyI7CgPi5gdc/qbr3TDSBru80R7HnTkBFVwDS y9/isbBEFXsie5Hdwp3zDcpE2osFJrtynx5e096KHF9oTvqUUfZ1ENbURJKdKuDVaFj7 82n4YlhV42RXr1zPTbUnxI+NNZtW2YQq6gLF87Fwb10CwrG8z2nOzjhOUmTYLtgqq7/+ o21g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708304708; x=1708909508; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mIDaOHUmOnFQVc3Wwg+6+LPaeJ2ta81+Eqz5TMzPBys=; b=HGMjcIGYV80MFNujjYgZS9L8t18p5BQr9YWgcW44GBVsY6wQlMQzASkjDrBBdjj2tt X940RanMERPuZX3MvQPYCCSdDyrF+ipgvF9QoVObQ32HTNLYYfRHqMFJyzGW9Lzsu+PQ ZgoUF8Z8PmD4CkN/ETM6p/CDBwFE6Kq2g+i6N+cKO+rursX1YR+PmjTzJR5ZuY5PdroD gJ0kUfkZ/H1JirRDLlz2a/j+nrRBy4mwhrws6lnPzz+3OMeZX0gyJDISf0D+irfxbdoM vzetK7gor9/KqM9iaqNd8u13n8aXKzyjGHI2VPAP/K/MHCoigXMVgq+9zM58h493lJ26 S6tw== X-Forwarded-Encrypted: i=1; AJvYcCUyPPwzXfyYAm36Tj6rRPw82RoRcdpq8+RVy+LopFe+Vr6xW4i6AVadEgbYoCvXoCBjwnlJ4JWz83v/nSmTco6afc8= X-Gm-Message-State: AOJu0YwZMs2JyyyxmZcbgWVSaUD/bHttOmL3Evp9Gi7s6tUxcSaj5RN5 uEMMJZVxoq8zY/YTPzJQ9HPnzLkXXVDRICQ1RsuP5y8cxrFkGHwRdfGtCXnb+qqVnEmcwSY8yCh VbiNyROFTkXahmsKQTExfmCrFqddLcuJPL3Sv X-Google-Smtp-Source: AGHT+IFAFF6IWWYhF0S9T//EmmWIuYGcDfDoGsA7me1Exr/qYPq0aAoDdEWC37Tru9GNL3XObftohrbEHommrFTiK+w= X-Received: by 2002:a5b:b43:0:b0:dcc:eb38:199c with SMTP id b3-20020a5b0b43000000b00dcceb38199cmr10258615ybr.56.1708304707680; Sun, 18 Feb 2024 17:05:07 -0800 (PST) MIME-Version: 1.0 References: <20240212213922.783301-1-surenb@google.com> <20240212213922.783301-33-surenb@google.com> In-Reply-To: From: Suren Baghdasaryan Date: Mon, 19 Feb 2024 01:04:54 +0000 Message-ID: Subject: Re: [PATCH v3 32/35] codetag: debug: skip objext checking when it's for objext itself To: Vlastimil Babka Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, mhocko@suse.com, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: xew3ks3hy4z18nntyasjoptwn8z1pusw X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: F0E2D1C001A X-HE-Tag: 1708304708-658225 X-HE-Meta: U2FsdGVkX1/7pN1fx+ypbSyhOkTZu6bKDLWMK3fUGkacbsaCY6VDBWtBvitMbQppqXsh3N9qijZnz7Kmf4sow1bz4stMznrgGSyXOSTM9pRCxXKKcUdpmfed/yCn7LWo5wHKoeGpqgKPA0WaQfypmYGfCTfzefZCO0ooVdGH+ASw8L7JYbqAOSTwneR2c1QnaMfM8SQhMF8pE/Vq4iz/vlAM/3/zpm46VGafm7DYLbNuoJR4rFGEWMfECYAMQ7NKak00piNH34QIBrAZk7NvpqTgs/Cnia/Mok9WpaH/7mVa0u4RQp3SM3X/1exmZN3jzqxKanEayDqfrseMDgwE6yow8MFEQuQO0Bc7K6tGJygphKVtxZqef6VdDnyO83r22r8N2OkKPGhw6FpH489FgHwcti7VoTWG+UqzscUXnoX1yl613GeisGGx4iukVcOVYn9swgYQRVF5oyA5y6e5iT7xEQF8rogtl00zg8sx3D2NN7whITVDmBMc25L+08uTJiESf13lUMxUAivwHphnDIFZoxQmugF2vREtnyFDz84hUy473/LbeBdVYiSnEPoB7xyqf23pqdgy0OsZVTcoMMZY9aznfiJYWNtALGhM7KeMQlwJRIt0uP1vRdV/lwD9xx0aFHygkLnAkmeyQevtlFnYHZ8MaTkxSYvmuVEusCWlbVQ3cgasSW02I0HkswQDQfhWKY0m+8WJH60wyt/WvEQ0W3PW2i2m0iITZadGIHq7CJYnA8vKSSEWXR0NB/gEWy9PvBKi8OlSlqh3hHCqAVt4KI+O5OrYtq917A6kZxgdtfQ2FZ5f29zRey1x/hZXQpI6mXklFj+Iv1WdRSBQBGSjKQwC3+jFbIFtw0UPkPyl0zYvzPcOhFOklv5AQupjzXEdTUIpXRfrqPHcYYDFbfqlXLm9Hd2kNOC5ZnXdHLS4PYuC3Roi97nQwKVsNDS/dik6n5nGEx8tAhYaWku nLyFfAH5 A8c1UGEiPySIogA151Zicq1M+8Fz10x3VsoBj1waNac63FIurtc7rBZ+KVKp2h5plywW4GxkpoWtN37Bjja+Lmbuw+fPmIrx5xmWMZXjiT1ZIiR4aZUDQKp1E7qKltDQrdGF6ktYFu17d52w17fdAuTuHvdaUuiKievhugTSFXWO53CQhb/jKB53roxcIlV82ldfC1oBAMWcpZe5WV6g3sIC80PcRTJQwvwSJDmq5jU9HtTeh/Di8N9Ak1hGZYfc0htzrWqsC9lcdyPwunpXTEqmwHSkloZos+me7ekNbl6kBIFWwSunypgbAZN/KSgVO6OAa X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Feb 16, 2024 at 6:39=E2=80=AFPM Vlastimil Babka wr= ote: > > On 2/12/24 22:39, Suren Baghdasaryan wrote: > > objext objects are created with __GFP_NO_OBJ_EXT flag and therefore hav= e > > no corresponding objext themselves (otherwise we would get an infinite > > recursion). When freeing these objects their codetag will be empty and > > when CONFIG_MEM_ALLOC_PROFILING_DEBUG is enabled this will lead to fals= e > > warnings. Introduce CODETAG_EMPTY special codetag value to mark > > allocations which intentionally lack codetag to avoid these warnings. > > Set objext codetags to CODETAG_EMPTY before freeing to indicate that > > the codetag is expected to be empty. > > > > Signed-off-by: Suren Baghdasaryan > > --- > > include/linux/alloc_tag.h | 26 ++++++++++++++++++++++++++ > > mm/slab.h | 25 +++++++++++++++++++++++++ > > mm/slab_common.c | 1 + > > mm/slub.c | 8 ++++++++ > > 4 files changed, 60 insertions(+) > > > > diff --git a/include/linux/alloc_tag.h b/include/linux/alloc_tag.h > > index 0a5973c4ad77..1f3207097b03 100644 > > ... > > > index c4bd0d5348cb..cf332a839bf4 100644 > > --- a/mm/slab.h > > +++ b/mm/slab.h > > @@ -567,6 +567,31 @@ static inline struct slabobj_ext *slab_obj_exts(st= ruct slab *slab) > > int alloc_slab_obj_exts(struct slab *slab, struct kmem_cache *s, > > gfp_t gfp, bool new_slab); > > > > + > > +#ifdef CONFIG_MEM_ALLOC_PROFILING_DEBUG > > + > > +static inline void mark_objexts_empty(struct slabobj_ext *obj_exts) > > +{ > > + struct slabobj_ext *slab_exts; > > + struct slab *obj_exts_slab; > > + > > + obj_exts_slab =3D virt_to_slab(obj_exts); > > + slab_exts =3D slab_obj_exts(obj_exts_slab); > > + if (slab_exts) { > > + unsigned int offs =3D obj_to_index(obj_exts_slab->slab_ca= che, > > + obj_exts_slab, obj_exts)= ; > > + /* codetag should be NULL */ > > + WARN_ON(slab_exts[offs].ref.ct); > > + set_codetag_empty(&slab_exts[offs].ref); > > + } > > +} > > + > > +#else /* CONFIG_MEM_ALLOC_PROFILING_DEBUG */ > > + > > +static inline void mark_objexts_empty(struct slabobj_ext *obj_exts) {} > > + > > +#endif /* CONFIG_MEM_ALLOC_PROFILING_DEBUG */ > > + > > I assume with alloc_slab_obj_exts() moved to slub.c, mark_objexts_empty() > could move there too. No, I think mark_objexts_empty() belongs here. This patch introduced the function and uses it. Makes sense to me to keep it all together. > > > static inline bool need_slab_obj_ext(void) > > { > > #ifdef CONFIG_MEM_ALLOC_PROFILING > > diff --git a/mm/slab_common.c b/mm/slab_common.c > > index 21b0b9e9cd9e..d5f75d04ced2 100644 > > --- a/mm/slab_common.c > > +++ b/mm/slab_common.c > > @@ -242,6 +242,7 @@ int alloc_slab_obj_exts(struct slab *slab, struct k= mem_cache *s, > > * assign slabobj_exts in parallel. In this case the exis= ting > > * objcg vector should be reused. > > */ > > + mark_objexts_empty(vec); > > kfree(vec); > > return 0; > > } > > diff --git a/mm/slub.c b/mm/slub.c > > index 4d480784942e..1136ff18b4fe 100644 > > --- a/mm/slub.c > > +++ b/mm/slub.c > > @@ -1890,6 +1890,14 @@ static inline void free_slab_obj_exts(struct sla= b *slab) > > if (!obj_exts) > > return; > > > > + /* > > + * obj_exts was created with __GFP_NO_OBJ_EXT flag, therefore its > > + * corresponding extension will be NULL. alloc_tag_sub() will thr= ow a > > + * warning if slab has extensions but the extension of an object = is > > + * NULL, therefore replace NULL with CODETAG_EMPTY to indicate th= at > > + * the extension for obj_exts is expected to be NULL. > > + */ > > + mark_objexts_empty(obj_exts); > > kfree(obj_exts); > > slab->obj_exts =3D 0; > > } >