From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A2F1EB64DA for ; Wed, 5 Jul 2023 17:22:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B51528D0005; Wed, 5 Jul 2023 13:22:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B28758D0001; Wed, 5 Jul 2023 13:22:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A17158D0005; Wed, 5 Jul 2023 13:22:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 907C48D0001 for ; Wed, 5 Jul 2023 13:22:41 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 1F45BC04F5 for ; Wed, 5 Jul 2023 17:22:41 +0000 (UTC) X-FDA: 80978227722.17.FB692DC Received: from mail-yb1-f174.google.com (mail-yb1-f174.google.com [209.85.219.174]) by imf23.hostedemail.com (Postfix) with ESMTP id 3B18E140018 for ; Wed, 5 Jul 2023 17:22:39 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=Vwr0HKpp; spf=pass (imf23.hostedemail.com: domain of surenb@google.com designates 209.85.219.174 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688577759; a=rsa-sha256; cv=none; b=VVvLVguMSBSsVvSg0IXdIflFurV0K7ASK3gxv/yJUQhRdgq5CykzUbp1Yx3c8gdWaB2mkZ H4HSBFBssJX6R8ekBUqIF51tFt0Jb11FI9DbwQjZebNgMU5AfQqrAPtQZ25iFcv/ouiruk mrRyEqzmYsXz+BJmUeCrBxGGkCQkTJE= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=Vwr0HKpp; spf=pass (imf23.hostedemail.com: domain of surenb@google.com designates 209.85.219.174 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688577759; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=P6Tk2ql2z3k8hI6gx082bWriam5zLDXexsywXgjVlB4=; b=dOo8jruLA36WW17JONn+BGKTRMKKFfQ4LOfUM/yxVglaDX6ohHOjjwkzER8HA2nVPkZTs1 F0nm4yoL/gSch22mauhUxe8xh46tL+aMDxqkuihQAzhQKBU20+qv4GZl57wv/XrIjkLVWu avBEQwIH6REJze5WFi+mz5n6f0+b52E= Received: by mail-yb1-f174.google.com with SMTP id 3f1490d57ef6-bd77424c886so8210981276.0 for ; Wed, 05 Jul 2023 10:22:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1688577758; x=1691169758; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=P6Tk2ql2z3k8hI6gx082bWriam5zLDXexsywXgjVlB4=; b=Vwr0HKppn8I7Y48ogyG7iPT2wYGMyZgOMj2odgQD6TWHNk+4wNp0qzgiv4/AM1diks Ctnd+ZWxUYwa8Fy7wrhYYZq15ti771Mtd5owNQnjOutUFhf92TzjYyCc7oi8xbJcJiuv bAzvuvn66zIm+FCZ+7FU20Sdymyv0HtTX9gdnYqKpCnSe8IUw/0GK6AQQ+9gs3KW3xku XRdo9cbI5ljud3WQ6ITvbubiQVIeSL7BmyJ0sWrfPr9/rgFIXTiiUb1U2OfaaegxgXxV gnLyWSpPhIkKagpxNXBPQQobtrj3nqaZjDAQ/X8zPK0zqtWTxOvXZ+yqBbKHcGmbrV6u SGig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688577758; x=1691169758; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=P6Tk2ql2z3k8hI6gx082bWriam5zLDXexsywXgjVlB4=; b=IP1PsGRbYpeAuLJ/SbkLC7KQQKgotV4vlF/hU5+VMkRtuuQMmRBQF9ji+E7aEDzz2+ i0EMyF/6ikgew4/yjVtNPIqHK2Zw3JOu9LdOmn5W2Zm1hFoVgZWXWIBBZY9a7DSjWfTh MrswxT+4ZoVrBv4oDyy0uoUT8+TVaUQsiQPQaCqTy/MDaxOvT1zbuGzFjLcBJjKt7zzR Gm6ajK8rebWTHSUYg6N5GHAG3rcZvZo9rJWoTtxDO1qbQDr6wUu3cOW9YQ6g1pdE4gCS X/QmJe2iyKYJrQN4D0z5krqodqbpAblUi3qEqZELKcgNBx+ysj6Sff/Gta1X7Xpo/YR/ 2EqQ== X-Gm-Message-State: ABy/qLYH/AikG04aB/6oB6ccGZ0ElQeAC7Kz/sCUxvSLgTxzmcvkTjHX RKRP7M+bIkAw8zuBg6wJHY8WOyW0pi0nelCv+G42mw== X-Google-Smtp-Source: APBJJlEzexLn8Gnsj86NrWI8WO/vdjL9jBS1mJI+nuZ2OzXLXobm03US7gnI6v9c7ePfC7tBcWU3w5mlyqIWysOpxiw= X-Received: by 2002:a25:d488:0:b0:c4c:dbee:4915 with SMTP id m130-20020a25d488000000b00c4cdbee4915mr13592561ybf.9.1688577758189; Wed, 05 Jul 2023 10:22:38 -0700 (PDT) MIME-Version: 1.0 References: <20230705171213.2843068-1-surenb@google.com> <20230705171213.2843068-3-surenb@google.com> <3cdaa7d4-1293-3806-05ce-6b7fc4382458@redhat.com> In-Reply-To: <3cdaa7d4-1293-3806-05ce-6b7fc4382458@redhat.com> From: Suren Baghdasaryan Date: Wed, 5 Jul 2023 10:22:27 -0700 Message-ID: Subject: Re: [PATCH v3 2/2] mm: disable CONFIG_PER_VMA_LOCK until its fixed To: David Hildenbrand Cc: akpm@linux-foundation.org, jirislaby@kernel.org, jacobly.alt@gmail.com, holger@applied-asynchrony.com, hdegoede@redhat.com, michel@lespinasse.org, jglisse@google.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@techsingularity.net, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, peterz@infradead.org, ldufour@linux.ibm.com, paulmck@kernel.org, mingo@redhat.com, will@kernel.org, luto@kernel.org, songliubraving@fb.com, peterx@redhat.com, dhowells@redhat.com, hughd@google.com, bigeasy@linutronix.de, kent.overstreet@linux.dev, punit.agrawal@bytedance.com, lstoakes@gmail.com, peterjung1337@gmail.com, rientjes@google.com, chriscli@google.com, axelrasmussen@google.com, joelaf@google.com, minchan@google.com, rppt@kernel.org, jannh@google.com, shakeelb@google.com, tatashin@google.com, edumazet@google.com, gthelen@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 3B18E140018 X-Stat-Signature: z87qy3esprgtfatkt7ugy8kh6kqwt47x X-Rspam-User: X-HE-Tag: 1688577759-889176 X-HE-Meta: U2FsdGVkX1/2KTGp976AbEtmREBrt5dEijHNDDna2vUOWJJr58HCOwE2IfUaF9zSsNCVxzkRORb0SXu+Q25mu9iBZIr6nRxqkm12DR17FlPBpDDluIFCLX21HkMKDE/sbAILu/SmKsPop8RiD98TPlAmKagi6sRQzdyzMxMzAqPR+VIMMMc4tmsZDeocGJu45kwXXC9bJfUgTdHajtikMipBR+fxFcmIcw+rJ6LlRDhJauNnaK5aWdwLs2dc9Bdnw/lIhtydJzDrGpCAvCfyft6d1rXgn07a/B+5txfKBOrxdXSY2ZIOloJfB4DlC3jXi0gi9J4h1KCImqY5F56DRPCPl04nKsVT89hCmCuxOWdrkHsMZkIHt8fGk/SQW7kwFTsOS7zgR5QggFWzqScqwAWQF2El1S35pn6TevYEoW2fne/RrIodWVTY5D5R8LdNEu6Y3UDfIaKxn6No0tnUIuGGA8DrelqJHQ+Mywe5tfUb46MuXcGfM29gsQvJjPRQp3MbpzBB681gicNgknGp6hBzKqdotKu0iz+6CwEYUhR/0jnTfcjAOf6oiyP8rqLiXmWGuM3Kf8jn7jTTemrEiwyOJJRAQB/sryJ4fTEue2xsOZvlvyBmPlx3X5k3r2hAwZNhTwiOry73MPOzpGcRR8ZTrSAmeOudPR207iwhc6uXcH29mMXxiWwrCgxbxA8eaaH10lAjWt8iHTGMpvSoKMMtuDzsO8aJuezLDbWFIiQLa4DKl+JdMXNeUF3BozHzxOBvgE8qLuvPIMW2eWX92gaj82m3cDV14ntUzUVvMFpaeBeaCfjBxhvJT2WK1v0Uau8NZmZuuKLLk5UR1CLhrEdU70FqFzBQysTYwNMMp4sQVhVbt6LRH595eZkMrMx1DQJ0xXjPK76v7pSzwLq/3vvNWmb7sm9naez4YmmzRQSI43+KyimAj37gfEyupr5WiwOETkU0HQITfvzWf5k rY2bfSTb K/qOW4nRXIjpMm3D2VcIQvqSLcIxO6Y8VF6HswhFHnv/gj1jtuTD52Cj66GQqJdoinBaMHpl41yviRo30Zvlwqh/6+6uVFCzprj0k3CL+OLijx255QQfuqAwk6ubIQTL1W8LBHgYP8YUDNRx6Zu+qe9gBkioK6Rnwmd/9dsK8VKFyG+PYj/6OogVSPf0yQsD10PmZmHgwQOWNoKYgoTfKtWXJa/JgfAZiH3h9EjFGnHI4/KWtmJeo5EeEVAot9aGszvWfM2VlToj3F82jqDYmCFBhe1y7Eu6YI2m2hpv4U/W6Dp+cIYGgR/pDkcM1pkCCNhgnUXss6RLssq/xreDf1m3VVbHWNm/l9SMPWWWe6ugg5mGrpL42TpxPwDEe1r7uu4HzFwgE8hUVekaGWHAFO2RZzz4MPzmBdHfTev1mpKQ0wvo7JvxSYjERgUEOgq53+CDsCjWVPVPQIBEXlx+DOwp/6wZSxyyxovpr X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jul 5, 2023 at 10:16=E2=80=AFAM David Hildenbrand wrote: > > On 05.07.23 19:12, Suren Baghdasaryan wrote: > > A memory corruption was reported in [1] with bisection pointing to the > > patch [2] enabling per-VMA locks for x86. > > Disable per-VMA locks config to prevent this issue while the problem is > > being investigated. This is expected to be a temporary measure. > > > > [1] https://bugzilla.kernel.org/show_bug.cgi?id=3D217624 > > [2] https://lore.kernel.org/all/20230227173632.3292573-30-surenb@google= .com > > > > Reported-by: Jiri Slaby > > Closes: https://lore.kernel.org/all/dbdef34c-3a07-5951-e1ae-e9c6e3cdf51= b@kernel.org/ > > Reported-by: Jacob Young > > Closes: https://bugzilla.kernel.org/show_bug.cgi?id=3D217624 > > Fixes: 0bff0aaea03e ("x86/mm: try VMA lock-based page fault handling fi= rst") > > Cc: stable@vger.kernel.org > > Signed-off-by: Suren Baghdasaryan > > --- > > mm/Kconfig | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/mm/Kconfig b/mm/Kconfig > > index 09130434e30d..0abc6c71dd89 100644 > > --- a/mm/Kconfig > > +++ b/mm/Kconfig > > @@ -1224,8 +1224,9 @@ config ARCH_SUPPORTS_PER_VMA_LOCK > > def_bool n > > > > config PER_VMA_LOCK > > - def_bool y > > + bool "Enable per-vma locking during page fault handling." > > depends on ARCH_SUPPORTS_PER_VMA_LOCK && MMU && SMP > > + depends on BROKEN > > help > > Allow per-vma locking during page fault handling. > > > Do we have any testing results (that don't reveal other issues :) ) for > patch #1? Not sure if we really want to mark it broken if patch #1 fixes > the issue. I tested the fix using the only reproducer provided in the reports plus kernel compilation and my fork stress test. All looked good and stable but I don't know if other reports had the same issue or something different. I think the urgency to disable the feature stems from the timeline being very close to when distributions will start using the 6.4 stable kernel version. > > -- > Cheers, > > David / dhildenb >