From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B5A7EB64DD for ; Wed, 5 Jul 2023 18:09:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D60B38D0002; Wed, 5 Jul 2023 14:09:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D10FB8D0001; Wed, 5 Jul 2023 14:09:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BD8288D0002; Wed, 5 Jul 2023 14:09:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id AC4BD8D0001 for ; Wed, 5 Jul 2023 14:09:47 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 342E780BED for ; Wed, 5 Jul 2023 18:09:47 +0000 (UTC) X-FDA: 80978346414.03.55B30AC Received: from mail-yw1-f173.google.com (mail-yw1-f173.google.com [209.85.128.173]) by imf09.hostedemail.com (Postfix) with ESMTP id 47B6A140010 for ; Wed, 5 Jul 2023 18:09:45 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=zyh3IZqQ; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf09.hostedemail.com: domain of surenb@google.com designates 209.85.128.173 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688580585; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vqtIzGaVFOpXMYPUl5WSw8mMx6YorPxKDA1JIgHkc1I=; b=KN+U8xcMLK8xMCrkSPibyFgrkXY74npC4UwLuz/Ox5xIhx76jovUR9Y1OYed3H7EkIc8u0 ThKSxt82VkdoHwr8w1+SyQ66dcLYsJCOG0Pu/oEpHU0kIg4xHUGLfI1KDJSq98Y3VLn7u0 8OfR8LKfHCjxL024h9e10zmkn2pB1QE= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=zyh3IZqQ; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf09.hostedemail.com: domain of surenb@google.com designates 209.85.128.173 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688580585; a=rsa-sha256; cv=none; b=JUd4g0PNMaKKS2hxn7Z1x7FHzgP1vM97MQGnh889d31WfslNO1IOrSRXe/Vr5X0pXduNj6 +kgytD2Pf+OietRkjgkAKG/gGTu2m5TQcdyASNa2R11J+5rLhti0hM/NK/aLXV3Vr93kyM LTCV077+AqVJyjWJU0og8kHlIuROAQ0= Received: by mail-yw1-f173.google.com with SMTP id 00721157ae682-579efc32377so48707577b3.1 for ; Wed, 05 Jul 2023 11:09:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1688580584; x=1691172584; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=vqtIzGaVFOpXMYPUl5WSw8mMx6YorPxKDA1JIgHkc1I=; b=zyh3IZqQ+kfBulotXhA2VdnvqrskivIdQ7QCn4ZFrxXXlOeDI/LF1j8gqy3p5TeZH8 amVPkyTLjx4TE3D2aIff9NNayDZ2X6TILonhNNrkvpPxcQ5HQeiJ8crGhMe6uM7cmTyq k0q/ezzj9IPqghkFyP6e6Ji4waAMrcUUn/JIXWITL/Y3hV+PHuIziquhrJr0FZ2XQN+/ oh4Bpc4rx71Kr2SvPNdPDZGqBaufGk5YdVmh074qBK8Kqrqqap4AdCW/qV7iqZYQPZEY DontwsPK+JEmHy5XeYj48Rwc/EZUDmow9CCed4swbtxyGuXtStCkgnuixUV2qDnWUgAY 9uhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688580584; x=1691172584; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vqtIzGaVFOpXMYPUl5WSw8mMx6YorPxKDA1JIgHkc1I=; b=QmXmkeVmz/yc34yAScEyR8FtzssNNTlxm6rdRIJp2xcgqWU3p8y5T5TaVbVuzBf6/T kSYnWF+iQZvkj9K29fZ1/2HGzEQ+FAb/027hFNCsC1T9l6Cx5Gk15kjH4ZFMTpjJidlO 5Au0BZX29fVPI/9sSenis1Dng4QbM4zNZ2VDFRe+Wm1X+0eZPo/pqy+2JK/en+kcgtNn grjBrF821MTbDoKvk517IC5CbQdHTOVbddgPEyg89Lm4Z/k4bFLFEfcqVt021IG8x/94 02YdOq8/B8jeOazAJILQLajSihIY11QbB+j++tZv/cxRpndWiQaJ/IJYl6mMGg4+XMY8 3Wqg== X-Gm-Message-State: ABy/qLZltLdb8ykvImGD83OBox3dGXJPXAPfURX1i/FKqBt/mI1m2RD4 mRsoWY37V6Y5Ru5HgmekxSrnKh0BOaXbR4uPfzQeDw== X-Google-Smtp-Source: APBJJlG9oqJDpPwWw/Z1xXQvA1VxDd0mdwRL341XkKBoNONj9tMIWiDmDQv5f61Uo93QwDdmjgkM/uJxbAdHXfuP6xs= X-Received: by 2002:a25:e714:0:b0:c61:e9b6:82a5 with SMTP id e20-20020a25e714000000b00c61e9b682a5mr2592409ybh.39.1688580583893; Wed, 05 Jul 2023 11:09:43 -0700 (PDT) MIME-Version: 1.0 References: <20230705171213.2843068-1-surenb@google.com> <20230705171213.2843068-3-surenb@google.com> <3cdaa7d4-1293-3806-05ce-6b7fc4382458@redhat.com> In-Reply-To: From: Suren Baghdasaryan Date: Wed, 5 Jul 2023 11:09:32 -0700 Message-ID: Subject: Re: [PATCH v3 2/2] mm: disable CONFIG_PER_VMA_LOCK until its fixed To: David Hildenbrand Cc: akpm@linux-foundation.org, jirislaby@kernel.org, jacobly.alt@gmail.com, holger@applied-asynchrony.com, hdegoede@redhat.com, michel@lespinasse.org, jglisse@google.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@techsingularity.net, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, peterz@infradead.org, ldufour@linux.ibm.com, paulmck@kernel.org, mingo@redhat.com, will@kernel.org, luto@kernel.org, songliubraving@fb.com, peterx@redhat.com, dhowells@redhat.com, hughd@google.com, bigeasy@linutronix.de, kent.overstreet@linux.dev, punit.agrawal@bytedance.com, lstoakes@gmail.com, peterjung1337@gmail.com, rientjes@google.com, chriscli@google.com, axelrasmussen@google.com, joelaf@google.com, minchan@google.com, rppt@kernel.org, jannh@google.com, shakeelb@google.com, tatashin@google.com, edumazet@google.com, gthelen@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 47B6A140010 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: og8naxtb3uq8ymcp8o9ywxk5apn74p7k X-HE-Tag: 1688580585-336598 X-HE-Meta: U2FsdGVkX1+DXFrJftBp5jlH4bP7cRf4uv/r+ckt0fqG1dx+bcEhIkhaogkV4obWBbyeZo9m3HnFXBJS+abxsNrpWf+Bm/e7wynuu3O8Pm4kBspAWnoxEyPh20+hpSnbEezMxGxnsPZV197VHzsxehSTRvFX7xduvhZtGk4AhJTyV+jva2XFCnwJI0NTKZLTMRhpXuxWaIJ3H9a+3kbIBp1Y8tO8kYT/759mcU6jh4dH2Beiq+JJOncA9yZht4JBh/sDuNoP8KiTa/wKYwkC4rieRrAMmGuuvEWpToqj1Vk3rGmUex9Tu7d9+qudKHbj4c+dhN29JQ62i6G94NqUpWZmg1dLVsH1anieUTk34A9d7oOgv19hhlGiQnrYGb3KQxJhJs/aEHsd5KnuFN6k08C3n1FQ4WPb6TJBg62EtWTAFT3q4g7dt2afPYufCJjLqwhu2hpj5sJfkr1sgKDDeRh0Hjkj1noqVFa3xJbNvr0fXprA3oVDX00gej7o/t4tvUbv8TevNCm7nduzgXguWjB+1iA/ev2Hv9AVeci7udT7ykU/0GrtKW7gu7UOqZD2TVV3qmlvAuOpBYl84972DfK67PC+6lSzKRizHGuoRlcQMkBafcGsiRU4OkSL9n5G3M9o2xJugW0dqHXu++xzEWTBlZqqOGn4JV5UpOT7dd7LqG09nWxVKXHYKzI7BHCLRXEx0Cbe2YDVtRIAwKK3NoQvRlVaVxVJYYiqVEo8hz0bdQECdX5AVOWXJ3IMnmF483Yk97OPI55+1qm/08C4IzctwP7b3ZrveWvP0JeeMBnzi13LpD3PUHgWuENlCo5SSdqnIWeW12upkPCqahaXqW95EsUqg08teeCesxXa8YIeWVumRPYmhYl3TcL2PFdFODXA0XIGHyFvF7XcvhCGsBAAXBAatzG33Av1dxWm3JUpCC59fXYlI91r6Og3BGhoH1C9ixKmB3toMJHSzlY C45oyzhD DpOqBii+m8UL+WoI8sn/B7dZowfc+C4CXMjkhU2DwDGBvROewyrA/xH9ASJymD8uH1ygxaEamoyULSytkjLhRAnfG2S+jeJ0c46ISoqdiV4wzw8t9Pz+n9l5iy5bcvWYZQh2Qe56cPVX8fVFCmqziMcZjn5ZU8mfp+HUQkWhr9NkZOhnSkYS/Vd4BqV9qdYcyzc3omChIwu3j8U7gUeSojcnOJ5bty8beMgFXlk6QpIoNbCenOWmSoDiW6O7+e82phLE4P47OS15AnpaFXXCiwOXgjil0Snpwhiopaih4gcSODXWFBolqT5xtaPW1tQIymmzn7c6SJ9UuVDUOGM0xrSdDlHC4YXIP95myGRCa5banYywuLkPGmVrsBpRc4xcmLzzlaGUweORHaI18ytCZ7A3suWUHpmyiSlImBXDTBbQGZwhJHvktmFeMJiA3RK3J35U9TbPDAK8rx8E6tPwT9PH/24aZVL55xvzwgTGoHMEAxw1laiaVHIl7RwgGn8yko1j5t5VPtGemaENAL1M6mjZgsA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jul 5, 2023 at 10:24=E2=80=AFAM David Hildenbrand wrote: > > On 05.07.23 19:22, Suren Baghdasaryan wrote: > > On Wed, Jul 5, 2023 at 10:16=E2=80=AFAM David Hildenbrand wrote: > >> > >> On 05.07.23 19:12, Suren Baghdasaryan wrote: > >>> A memory corruption was reported in [1] with bisection pointing to th= e > >>> patch [2] enabling per-VMA locks for x86. > >>> Disable per-VMA locks config to prevent this issue while the problem = is > >>> being investigated. This is expected to be a temporary measure. > >>> > >>> [1] https://bugzilla.kernel.org/show_bug.cgi?id=3D217624 > >>> [2] https://lore.kernel.org/all/20230227173632.3292573-30-surenb@goog= le.com > >>> > >>> Reported-by: Jiri Slaby > >>> Closes: https://lore.kernel.org/all/dbdef34c-3a07-5951-e1ae-e9c6e3cdf= 51b@kernel.org/ > >>> Reported-by: Jacob Young > >>> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=3D217624 > >>> Fixes: 0bff0aaea03e ("x86/mm: try VMA lock-based page fault handling = first") > >>> Cc: stable@vger.kernel.org > >>> Signed-off-by: Suren Baghdasaryan > >>> --- > >>> mm/Kconfig | 3 ++- > >>> 1 file changed, 2 insertions(+), 1 deletion(-) > >>> > >>> diff --git a/mm/Kconfig b/mm/Kconfig > >>> index 09130434e30d..0abc6c71dd89 100644 > >>> --- a/mm/Kconfig > >>> +++ b/mm/Kconfig > >>> @@ -1224,8 +1224,9 @@ config ARCH_SUPPORTS_PER_VMA_LOCK > >>> def_bool n > >>> > >>> config PER_VMA_LOCK > >>> - def_bool y > >>> + bool "Enable per-vma locking during page fault handling." > >>> depends on ARCH_SUPPORTS_PER_VMA_LOCK && MMU && SMP > >>> + depends on BROKEN > >>> help > >>> Allow per-vma locking during page fault handling. > >>> > >> Do we have any testing results (that don't reveal other issues :) ) fo= r > >> patch #1? Not sure if we really want to mark it broken if patch #1 fix= es > >> the issue. > > > > I tested the fix using the only reproducer provided in the reports > > plus kernel compilation and my fork stress test. All looked good and > > stable but I don't know if other reports had the same issue or > > something different. > > Can you point me at the other reports, so I can quickly scan them? by Jacob Young: https://bugzilla.kernel.org/show_bug.cgi?id=3D217624 by Jiri Slaby: https://lore.kernel.org/all/dbdef34c-3a07-5951-e1ae-e9c6e3cd= f51b@kernel.org/ by Holger Hoffst=C3=A4tte: https://lore.kernel.org/all/b198d649-f4bf-b971-31d0-e8433ec2a34c@applied-as= ynchrony.com/ only saying that Firefox started crashing after upgrading to 6.4.1 > > -- > Cheers, > > David / dhildenb >