From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BA2EC02180 for ; Wed, 15 Jan 2025 03:15:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 962CD6B0083; Tue, 14 Jan 2025 22:15:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 912646B0085; Tue, 14 Jan 2025 22:15:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 78BDD6B0088; Tue, 14 Jan 2025 22:15:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 58AFD6B0083 for ; Tue, 14 Jan 2025 22:15:19 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id F2A0980F3B for ; Wed, 15 Jan 2025 03:15:18 +0000 (UTC) X-FDA: 83008220316.10.C563355 Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com [209.85.160.176]) by imf22.hostedemail.com (Postfix) with ESMTP id 1409FC0006 for ; Wed, 15 Jan 2025 03:15:16 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=NFNTlAYk; spf=pass (imf22.hostedemail.com: domain of surenb@google.com designates 209.85.160.176 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736910917; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vmAQV/kXBFPzrcuQeLJpFKBUoh3gZth+A/qAse1ch+g=; b=4NQUa8GvhjbkegbFC3a4mdfB7aVRDHobsAidV0SgdtHp/lh9igQbyTB2238NksiaN4Kj7F 87H553Nf2p+NXXEd4cBiZ3qM7QqbadEuEsxYEy6uVchn47pFuBXxpEdgR+4xWTVKsyoefJ x9MlPeDA39zHhPgaGNDp2uMzWDFtd4Y= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736910917; a=rsa-sha256; cv=none; b=Cglg+dJ+6X686H6ZS+SpJNnPyxm63qtRVtp2EYpis3EssmDG9/AMsfvm2kTp7qanvOjW8m 6MwSgVX7jPMtXe48Y5X7fbmdcGZhLhhk/Broyz9r4MK+wx0vfxbGRGVa4mhSGZbJ3BRz+G zZ9UWtTNc4DtxCRtfSDZN2mu3DdxAVY= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=NFNTlAYk; spf=pass (imf22.hostedemail.com: domain of surenb@google.com designates 209.85.160.176 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-qt1-f176.google.com with SMTP id d75a77b69052e-467abce2ef9so416961cf.0 for ; Tue, 14 Jan 2025 19:15:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1736910916; x=1737515716; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=vmAQV/kXBFPzrcuQeLJpFKBUoh3gZth+A/qAse1ch+g=; b=NFNTlAYkaqQe7XqNnp5+P5dg25LtwZQ4cqjS129Xscw2ICsGa6ofvJjsJ7IbIreiH0 0Jf4UF25NLmaULRNt9S54C04i/c4fzEeuNAnvJLRPB5cbbpSeGMXVtt/qTEnJ4KPAxW8 axEaXsAwje8bZKF9xTqjVoTw79Bcx5f4rAli6nTfSCkv+BsvWRSyW9te6uc2ZDtxD7bP EWQwKeCEeFnRuSaGC+D+QGqEtA3ZQz9kqfuveeGfE+MBGPb+oLGaphH1SA2a4yetSCFC 59GYWW0LpM9NnYnq+bQoOTGVKLzotg196yvfZ+3s26l2vd2QV/TZVSFs+yYKQfvnhpt2 6P+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736910916; x=1737515716; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vmAQV/kXBFPzrcuQeLJpFKBUoh3gZth+A/qAse1ch+g=; b=HhVenp+NN3CXxYYVL020vr/Z8OpvCFoHkGulb9mMwxwHmj4dN/VLb6Pb0kURhqAT40 BULBbYVXHQDNlr7e5I0Pt7kg0bIZ7EclXIV8MGdLzArS7pX6I3rXNejt6VuSaScrKEdo PlNwxq4AO40rqKkRzdMHLOZGdLcnSajv7RsdDSpqwikfeRaSehsjaR3ScZ4b+sGByphx TBWUTSf8eyww8i/3ZI5ThPeeYtsM50Bjv5Pf9w5j6qQHJHs5vO4o52SNOauAoEAo+Kvp yT6LRMC4FJXCSzOHje6e/aGC7EE+eHRUYee4WtCjHHhKLMvoDEAIWXqoeaWRf83koow8 c9GQ== X-Forwarded-Encrypted: i=1; AJvYcCUqtLsx9IBYtPxb221VUo06g7L57idXd8Gbkw/6zph8Fyl1OCeKKlVwnn0rlk4fujjF596Okj0MiA==@kvack.org X-Gm-Message-State: AOJu0YzUPxxJriiaUteGzpLlhCWwC6gjbNlljvk5o66iaBOvQUDXBM4S E9OMgh+4CZpG16infzuS6uSipBDwGCNVu5X5J66yJc6QiJCT+pAoojqCoTOmQLSdct451IhmYm7 7vtaL3z+Vf2YVLqHib3085bfJAXkskMyCT6Fs X-Gm-Gg: ASbGnct1P7NOsoOMNqaOm1iTynFc7DpeemIkrA35+F3tRtvkzMRtCLFz4aZnIv43ucT d4w+mj2ZIZ+3EROasOyP0hHKzLnIk1BRjKc53aQ== X-Google-Smtp-Source: AGHT+IFUq7khit4IshjKxsTfppPDsBGejlIWyYntQVqEZyXIv7dkxNwfI0t7k2XD2Vg8ilZfX/a29yDt5iEFtdtqdq8= X-Received: by 2002:ac8:5a0b:0:b0:466:8887:6751 with SMTP id d75a77b69052e-46df7007443mr952211cf.23.1736910915924; Tue, 14 Jan 2025 19:15:15 -0800 (PST) MIME-Version: 1.0 References: <20250111042604.3230628-1-surenb@google.com> <20250111042604.3230628-17-surenb@google.com> <20250115022703.hqbqdqawvqgrfgxb@master> In-Reply-To: <20250115022703.hqbqdqawvqgrfgxb@master> From: Suren Baghdasaryan Date: Tue, 14 Jan 2025 19:15:05 -0800 X-Gm-Features: AbW1kvblMdf3P0PmLn0hIrav26JNs6MH0HDLjLfWEr_ZsqUy-mVZmHxwdhWblp0 Message-ID: Subject: Re: [PATCH v9 16/17] mm: make vma cache SLAB_TYPESAFE_BY_RCU To: Wei Yang Cc: akpm@linux-foundation.org, peterz@infradead.org, willy@infradead.org, liam.howlett@oracle.com, lorenzo.stoakes@oracle.com, david.laight.linux@gmail.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mjguzik@gmail.com, oliver.sang@intel.com, mgorman@techsingularity.net, david@redhat.com, peterx@redhat.com, oleg@redhat.com, dave@stgolabs.net, paulmck@kernel.org, brauner@kernel.org, dhowells@redhat.com, hdanton@sina.com, hughd@google.com, lokeshgidra@google.com, minchan@google.com, jannh@google.com, shakeel.butt@linux.dev, souravpanda@google.com, pasha.tatashin@soleen.com, klarasmodin@gmail.com, corbet@lwn.net, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@android.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 1409FC0006 X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: 858ozm61rkoeeci1dk9ytptswdjz7y9i X-HE-Tag: 1736910916-343 X-HE-Meta: U2FsdGVkX1/Zd4efmCGvnCn9y05vWUB1NKp0LJ5R2XFrJUUd9HCishSU/f2o/raqtufSLRhPV8SXbDsy1xuV/TuE+xLjo6FhCWS7KCQ/IL7GQvPRiPd3T0F98h3zMX2pecuU0sa5SUbtd92DWrn5S1aVJI+m34fyjgOamgZ1JvIitQIs4FaEzMQhLS63VNUUfFyUlfcAreEqV+gOKNyTtYVr0g38VICqyww1QB581EOW9rUoIs+OLM/ZlUP/ABUqm1plI5jyZ78fN5uKBvcSXXKvYiPOcVOP71429JebRtb7+oQbNUNAdT03nKnCH3HXf4pfrE9wIrVOI4+Jikoc9mSggQQ+xSkSu0fF9y64hhScP3m4lBCRxS3s34T9A0T5QzUsuSav+RY9MoT/nqrjWeJjvEc5BN/OIq0lawBPDrELGIuIIbBy0m6xPNZB0syE75q9Mcs1DjNjwgCud8P2k8nMkCjNAsPi+8ASsqQ3fSWrBE/xTauJZWWHIs5eE4TATx8RKNgoIFNfv2bEY9LQ0lfjABYtC32Mg+o5kJnD+63ktlZMv38BdFRdeBWzgUlAjjkE3qWa32oCehkFxy5oiOm8BEgSbGghj78eYuLq25wj5KrEsb6P4JQTnKIC2UpN8JqmDyxId22Dcgt/Dw8eP2FbQq4StWkAfoPxH7qtBOnG9G6hhJp6egGllIki83kGqAeY3QaD1kAoGaEsM4VN5OHCchHhKJTe7DXV0yQt68o/ff475RlI8Q2mS3zZ183Re12VYvYFa9tmb60V18d2Tl/XACLOv4d6GvefyPrazQAAOvFLIm89Jep1weIXEyLHz5PCCSwmoNg15cbth1NSaW2LGSsus0DLdHD8xvIIXijo/KKvucKlx33SZyPwyR9xoPOLxeHh+b3rzXZib1vIfe2L2NVHDXuuHYhgy5R7ZIEz221g0fABPlQvXDf0VCQJ1Bm0uTONVfFz5bfhNdE uN+ChC5A F2dbLQE4L9M/xAbtAWAMrmfiPK8wBsug/s/B5MiIJMItlqY4vvcgiRTzvsFGTlkLHkxf8JNOZMXmAnoEeAbDXovc2BGnaHQtiwdyXzNtev58+Jf27otODk+/9MwvP+yV1xNeAH6eJBELFbwOoknA5HIOeTGPE9KN37zG7KOfOfCU7tP0l+MGMaX+AuK/WlOIuLlbOSaRGugMmxOc4EmqA4qeGoCNpxRGSaghH1l2z/LeACiQzB0s5zusfZI3TqPA0vKEHFKB/UaK2U3nK3cFp7foxBmp1i2maTKrXHiRyXy8ZlDaPojYH8aw8BYXFLAal2PdjZ67YMLbhilK9+gfA4S3FIA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jan 14, 2025 at 6:27=E2=80=AFPM Wei Yang wrote: > > On Fri, Jan 10, 2025 at 08:26:03PM -0800, Suren Baghdasaryan wrote: > > >diff --git a/kernel/fork.c b/kernel/fork.c > >index 9d9275783cf8..151b40627c14 100644 > >--- a/kernel/fork.c > >+++ b/kernel/fork.c > >@@ -449,6 +449,42 @@ struct vm_area_struct *vm_area_alloc(struct mm_stru= ct *mm) > > return vma; > > } > > > >+static void vm_area_init_from(const struct vm_area_struct *src, > >+ struct vm_area_struct *dest) > >+{ > >+ dest->vm_mm =3D src->vm_mm; > >+ dest->vm_ops =3D src->vm_ops; > >+ dest->vm_start =3D src->vm_start; > >+ dest->vm_end =3D src->vm_end; > >+ dest->anon_vma =3D src->anon_vma; > >+ dest->vm_pgoff =3D src->vm_pgoff; > >+ dest->vm_file =3D src->vm_file; > >+ dest->vm_private_data =3D src->vm_private_data; > >+ vm_flags_init(dest, src->vm_flags); > >+ memcpy(&dest->vm_page_prot, &src->vm_page_prot, > >+ sizeof(dest->vm_page_prot)); > >+ /* > >+ * src->shared.rb may be modified concurrently when called from > >+ * dup_mmap(), but the clone will reinitialize it. > >+ */ > >+ data_race(memcpy(&dest->shared, &src->shared, sizeof(dest->shared= ))); > >+ memcpy(&dest->vm_userfaultfd_ctx, &src->vm_userfaultfd_ctx, > >+ sizeof(dest->vm_userfaultfd_ctx)); > >+#ifdef CONFIG_ANON_VMA_NAME > >+ dest->anon_name =3D src->anon_name; > >+#endif > >+#ifdef CONFIG_SWAP > >+ memcpy(&dest->swap_readahead_info, &src->swap_readahead_info, > >+ sizeof(dest->swap_readahead_info)); > >+#endif > >+#ifndef CONFIG_MMU > >+ dest->vm_region =3D src->vm_region; > >+#endif > >+#ifdef CONFIG_NUMA > >+ dest->vm_policy =3D src->vm_policy; > >+#endif > >+} > > Would this be difficult to maintain? We should make sure not miss or over= write > anything. Yeah, it is less maintainable than a simple memcpy() but I did not find a better alternative. I added a warning above the struct vm_area_struct definition to update this function every time we change that structure. Not sure if there is anything else I can do to help with this. > > -- > Wei Yang > Help you, Help me