From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39E16ECAAA1 for ; Fri, 9 Sep 2022 16:11:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BE2766B0071; Fri, 9 Sep 2022 12:11:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B69A06B0072; Fri, 9 Sep 2022 12:11:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9E39B6B0073; Fri, 9 Sep 2022 12:11:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 8A17B6B0071 for ; Fri, 9 Sep 2022 12:11:14 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 61FDC120C91 for ; Fri, 9 Sep 2022 16:11:14 +0000 (UTC) X-FDA: 79893036468.11.3297768 Received: from mail-yw1-f172.google.com (mail-yw1-f172.google.com [209.85.128.172]) by imf26.hostedemail.com (Postfix) with ESMTP id 0DE6214009F for ; Fri, 9 Sep 2022 16:11:13 +0000 (UTC) Received: by mail-yw1-f172.google.com with SMTP id 00721157ae682-333a4a5d495so24398097b3.10 for ; Fri, 09 Sep 2022 09:11:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date; bh=H8x/XM6uf9GNJ3IYrM179zXxz1ytCDaEsM8slNACmxA=; b=bm1FOIwt0xPcS44lKFw20V/2FDGaluKQMr5RC/lv3kNt2CPd2qLKAgKO08lxAtII6u PqklGnQVjl04fCksXY7P6fDFkNnDl8WYpxKvWT4cYx3ZkcilSVu+h2Aa6BrXe55muS1Q agwNdalHUuz0PeBqka58ITIOXvnpT9SNeecbgghP1pdGggGAydoTvqHCpmNM9m0z/Ypb fWpqtc3wWWhY39E/EicXhVnsQm904qYgi9g1ZHZrJV15Rdnfrn7Ug3poT5uJ1TyVxIrs O9pd33EAGvLIIFPhsJ7pXSeH1VXZczvL3gB1yaSelr3tpJ7jNqnRpd0+Oyvi9CJLfpKx kbSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date; bh=H8x/XM6uf9GNJ3IYrM179zXxz1ytCDaEsM8slNACmxA=; b=y40PVc+0tkJOSCHosJEKSzPtzh28IsamfB6fAW5besBSKUEYj59QRdxrTIu26Kw56L HSjGSqy1VadDkqU9msMxxxsw01mpmITVrMvRXK0cN9n00Nvd72DxMlwdpsHY4nXlJnlt YNeG/iZ+QG94GWsE5esP97+gY8CHhCJNb+dAsgLUu64Nn0Y65ZgJZlvMcnVyYrSBXf0g FxWdQMU6dzBVdKv5sVutU09KTDS0ve0m31T91iJipCsiKyaoeRWjydtLonQCwYuEuWce 4QK/Gx/4eCzokjBMw/5HxBY+NWA1VjgalX083/9ESqmYYM6USRKU3G5VMTXWPMJlpkP1 31qw== X-Gm-Message-State: ACgBeo1AZkbXL64HEIpiq1scnkjZcQjMO2o3xCiYS0E1RWJ0TQ1TC807 TvKIqFieHInxw7gp85nhalIQfctBAdzaP4J4IiYIZA== X-Google-Smtp-Source: AA6agR5l3NZBiyBjZVBHRaW8gCnmEWnPaAr7lbOsOW2FwXMOgi2wrQrtA9QsGncMTjIGt3R0HYfTWoumi/nvScrttCI= X-Received: by 2002:a0d:f904:0:b0:345:4639:8253 with SMTP id j4-20020a0df904000000b0034546398253mr12696848ywf.438.1662739873041; Fri, 09 Sep 2022 09:11:13 -0700 (PDT) MIME-Version: 1.0 References: <20220901173516.702122-1-surenb@google.com> <20220901173516.702122-21-surenb@google.com> <54df2224-feca-52ed-567b-a82bb9d711da@linux.ibm.com> In-Reply-To: <54df2224-feca-52ed-567b-a82bb9d711da@linux.ibm.com> From: Suren Baghdasaryan Date: Fri, 9 Sep 2022 09:11:02 -0700 Message-ID: Subject: Re: [RFC PATCH RESEND 20/28] mm: introduce per-VMA lock statistics To: Laurent Dufour Cc: akpm@linux-foundation.org, michel@lespinasse.org, jglisse@google.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, peterz@infradead.org, laurent.dufour@fr.ibm.com, paulmck@kernel.org, luto@kernel.org, songliubraving@fb.com, peterx@redhat.com, david@redhat.com, dhowells@redhat.com, hughd@google.com, bigeasy@linutronix.de, kent.overstreet@linux.dev, rientjes@google.com, axelrasmussen@google.com, joelaf@google.com, minchan@google.com, kernel-team@android.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662739874; a=rsa-sha256; cv=none; b=HDfigsyhzTi5UhUl73LuyEaoYHopfmlicfSIMoTtXNGFOKLVAsewsJoYbQI2o6cFjMruI6 E689hubcZD+iXfMUTJ2xhQ5mfwLj8i/IspTegAi8B5dXEbgYOexMblxwThKQkhD9HKRS5K IlAULkHw2qItcPobR0zJXX8kFnJTWys= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=bm1FOIwt; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf26.hostedemail.com: domain of surenb@google.com designates 209.85.128.172 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662739874; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=H8x/XM6uf9GNJ3IYrM179zXxz1ytCDaEsM8slNACmxA=; b=mIMlkP/t3OokoEgGVK1R2ni/7AF4GVoE83iW9RYjkg1hJPeOZnTvIoqvNOeRYPc0VZ8OOm 9rU/J09rUhs8WUM/iAl0jZEFgardySByAHepiQhy75Y+GoWU8y4OpSRrWb88gyVaGFDDMc PWtC7UVyYHOtV24OE9idCHTAa0U6uQA= Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=bm1FOIwt; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf26.hostedemail.com: domain of surenb@google.com designates 209.85.128.172 as permitted sender) smtp.mailfrom=surenb@google.com X-Rspam-User: X-Rspamd-Queue-Id: 0DE6214009F X-Rspamd-Server: rspam11 X-Stat-Signature: 38omba6insickknxsrd9tnsc9wysyh3g X-HE-Tag: 1662739873-745581 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 9, 2022 at 7:29 AM Laurent Dufour wrote= : > > Le 01/09/2022 =C3=A0 19:35, Suren Baghdasaryan a =C3=A9crit : > > Add a new CONFIG_PER_VMA_LOCK_STATS config option to dump extra > > statistics about handling page fault under VMA lock. > > > > Why not making this a default when per VMA lock are enabled? Good idea. If no objections I'll make that change. > > > Signed-off-by: Suren Baghdasaryan > > --- > > include/linux/vm_event_item.h | 6 ++++++ > > include/linux/vmstat.h | 6 ++++++ > > mm/Kconfig.debug | 8 ++++++++ > > mm/vmstat.c | 6 ++++++ > > 4 files changed, 26 insertions(+) > > > > diff --git a/include/linux/vm_event_item.h b/include/linux/vm_event_ite= m.h > > index f3fc36cd2276..a325783ed05d 100644 > > --- a/include/linux/vm_event_item.h > > +++ b/include/linux/vm_event_item.h > > @@ -150,6 +150,12 @@ enum vm_event_item { PGPGIN, PGPGOUT, PSWPIN, PSWP= OUT, > > #ifdef CONFIG_X86 > > DIRECT_MAP_LEVEL2_SPLIT, > > DIRECT_MAP_LEVEL3_SPLIT, > > +#endif > > +#ifdef CONFIG_PER_VMA_LOCK_STATS > > + VMA_LOCK_SUCCESS, > > + VMA_LOCK_ABORT, > > + VMA_LOCK_RETRY, > > + VMA_LOCK_MISS, > > #endif > > NR_VM_EVENT_ITEMS > > }; > > diff --git a/include/linux/vmstat.h b/include/linux/vmstat.h > > index bfe38869498d..0c2611899cfc 100644 > > --- a/include/linux/vmstat.h > > +++ b/include/linux/vmstat.h > > @@ -131,6 +131,12 @@ static inline void vm_events_fold_cpu(int cpu) > > #define count_vm_vmacache_event(x) do {} while (0) > > #endif > > > > +#ifdef CONFIG_PER_VMA_LOCK_STATS > > +#define count_vm_vma_lock_event(x) count_vm_event(x) > > +#else > > +#define count_vm_vma_lock_event(x) do {} while (0) > > +#endif > > + > > #define __count_zid_vm_events(item, zid, delta) \ > > __count_vm_events(item##_NORMAL - ZONE_NORMAL + zid, delta) > > > > diff --git a/mm/Kconfig.debug b/mm/Kconfig.debug > > index ce8dded36de9..075642763a03 100644 > > --- a/mm/Kconfig.debug > > +++ b/mm/Kconfig.debug > > @@ -207,3 +207,11 @@ config PTDUMP_DEBUGFS > > kernel. > > > > If in doubt, say N. > > + > > + > > +config PER_VMA_LOCK_STATS > > + bool "Statistics for per-vma locks" > > + depends on PER_VMA_LOCK > > + help > > + Statistics for per-vma locks. > > + If in doubt, say N. > > diff --git a/mm/vmstat.c b/mm/vmstat.c > > index 90af9a8572f5..3f3804c846a6 100644 > > --- a/mm/vmstat.c > > +++ b/mm/vmstat.c > > @@ -1411,6 +1411,12 @@ const char * const vmstat_text[] =3D { > > "direct_map_level2_splits", > > "direct_map_level3_splits", > > #endif > > +#ifdef CONFIG_PER_VMA_LOCK_STATS > > + "vma_lock_success", > > + "vma_lock_abort", > > + "vma_lock_retry", > > + "vma_lock_miss", > > +#endif > > #endif /* CONFIG_VM_EVENT_COUNTERS || CONFIG_MEMCG */ > > }; > > #endif /* CONFIG_PROC_FS || CONFIG_SYSFS || CONFIG_NUMA || CONFIG_MEMC= G */ >