From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8E04EB64D9 for ; Fri, 7 Jul 2023 04:40:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 639438D0003; Fri, 7 Jul 2023 00:40:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5E9278D0001; Fri, 7 Jul 2023 00:40:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4B1BB8D0003; Fri, 7 Jul 2023 00:40:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 3C77A8D0001 for ; Fri, 7 Jul 2023 00:40:15 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 031D0A0305 for ; Fri, 7 Jul 2023 04:40:14 +0000 (UTC) X-FDA: 80983563990.24.F1BCC9A Received: from mail-yb1-f171.google.com (mail-yb1-f171.google.com [209.85.219.171]) by imf12.hostedemail.com (Postfix) with ESMTP id 010D640004 for ; Fri, 7 Jul 2023 04:40:12 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=BR1rcfAU; spf=pass (imf12.hostedemail.com: domain of surenb@google.com designates 209.85.219.171 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688704813; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HZOU+zLXw1mQ6SDS7zN49DoqViS6UrU9gYgGTVT9O7Y=; b=eSvdaiogG0OLnwBpE4EgX/SXS13yuv5WckV1RiU5mVRnw2WaudAzA3SUZETFIIwy0n1grw JpzuomsmrJnTH9OvCoMmJ+IoTvQ1uW3cCsRS3vv0dTY4Hp29tWco1wFTgG7BlbHdtGfO/q L2voc3zRzEDd+DmAPGC7SwrxRn5BkS8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688704813; a=rsa-sha256; cv=none; b=VQd0uif623AS4wLhqbPOqNPwPtvbZL8S51QK3idPctKPHZkD4FlbtguFtYZp6ixMzJ3ds3 sq53SAz/S1zzeySLCr1f2/9v8fKaV7SHk2Qq9jtmtZpkCXE/m3IOcvyHdpH3YMdWXWOsVW h+9FMN1QOvWXTJwADYbIAu6MGOYqb4Y= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=BR1rcfAU; spf=pass (imf12.hostedemail.com: domain of surenb@google.com designates 209.85.219.171 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-yb1-f171.google.com with SMTP id 3f1490d57ef6-c6cad6a3998so475241276.3 for ; Thu, 06 Jul 2023 21:40:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1688704812; x=1691296812; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=HZOU+zLXw1mQ6SDS7zN49DoqViS6UrU9gYgGTVT9O7Y=; b=BR1rcfAUkvGbsRuUjQWx1U7y/ybrSDDvIg6JUdC1kDhk2f3B+tuaC51+bW4P6wLshq ySMoBRjWMvA5AS2Vcr4sYW+x+XNv3bgf/55ZLvN6FmgXTMRZ5gvJvJcxtbOhymcRw8tb diX3p7J/Gg/HnZ5HBS0L4/zY4tX7G/fgu9SUDxsNwx13D0R+WZRfL8cM04Jd3K7xUk+d Pv2Qt1canmEosoJ3yY15tPoPbAEeIIsMG9c7PH6VOA0qt/FHVrN0Hx3OuOJcoDn1G8NW uoKh4imf1EpnSJXW9KS6CHy0rvTkSYnmSxo5tiCj3zl14227FKOToUqzIWVbSHE7cgQR AVvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688704812; x=1691296812; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HZOU+zLXw1mQ6SDS7zN49DoqViS6UrU9gYgGTVT9O7Y=; b=EF3cUXWREIw7m9iijCUGSDwY6HSOy/U5O+522zgbfdL6KcBqUCRtUnXOF8ku1aUMDG inIM4E808OhwK2z1CT7D/k3+guwJK16trbAra5HtI4ErJ7iB62skWc+e9F3c0SRiWJgK Ygh5lMcEgBWvtB2J8IKYpUC8cxCKD3mJxzvTLgn31m3kN38xY7edYQBn/muQBNx9IsgE glFBlwyHPKnhhUOLiOySK4x5hJNnMPLxpAEkz0gJZSUeEczAFWaXKENynJbU1yRy+Wkz eytv4Q8j4kGOk5GGhoiHTA7OrKgBvU1AgIUnouwz5HGf9emnRxO+C9qtfy4/oa6z4M5N TUpQ== X-Gm-Message-State: ABy/qLZ3TvhcEeO2Hgfnfl/CPnFfdsSM6lp7P6u4qDe7H6ROPb0bXpfQ Q9PZ2SRpk9s9pAtOELt5eu4vkjREu8vhlppqYVMDIg== X-Google-Smtp-Source: APBJJlEKmPiat7YBHmDo/qMvfo2VOS2gBlCtZdI2TsdqdR8SBJv369KOGN+WW308mqz+KYC582REum/0DFZgTg8eHNs= X-Received: by 2002:a25:b944:0:b0:c40:e589:7c09 with SMTP id s4-20020a25b944000000b00c40e5897c09mr3204128ybm.26.1688704811751; Thu, 06 Jul 2023 21:40:11 -0700 (PDT) MIME-Version: 1.0 References: <20230227173632.3292573-1-surenb@google.com> <20230227173632.3292573-30-surenb@google.com> <9a8d788c-b8ba-1b8a-fd79-0e25b1b60bed@kernel.org> <2f150512-e460-a9ae-65db-39dc54fe99d6@kernel.org> <04e701fc-2fd8-c4db-73d9-c86d4103641b@applied-asynchrony.com> <63dfddae-732c-5efe-648b-6ea622f2e64d@applied-asynchrony.com> In-Reply-To: From: Suren Baghdasaryan Date: Thu, 6 Jul 2023 21:40:00 -0700 Message-ID: Subject: Re: [PATCH v4 29/33] x86/mm: try VMA lock-based page fault handling first To: =?UTF-8?Q?Holger_Hoffst=C3=A4tte?= Cc: Jiri Slaby , akpm@linux-foundation.org, michel@lespinasse.org, jglisse@google.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@techsingularity.net, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, peterz@infradead.org, ldufour@linux.ibm.com, paulmck@kernel.org, mingo@redhat.com, will@kernel.org, luto@kernel.org, songliubraving@fb.com, peterx@redhat.com, david@redhat.com, dhowells@redhat.com, hughd@google.com, bigeasy@linutronix.de, kent.overstreet@linux.dev, punit.agrawal@bytedance.com, lstoakes@gmail.com, peterjung1337@gmail.com, rientjes@google.com, chriscli@google.com, axelrasmussen@google.com, joelaf@google.com, minchan@google.com, rppt@kernel.org, jannh@google.com, shakeelb@google.com, tatashin@google.com, edumazet@google.com, gthelen@google.com, linux-mm Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 010D640004 X-Rspam-User: X-Stat-Signature: ztgm378oorxbhc68rbxaerig8nadw7qm X-Rspamd-Server: rspam03 X-HE-Tag: 1688704812-360612 X-HE-Meta: U2FsdGVkX18PWCKXaZvknPcCOm4i2MjrYc1Slgl+7HHSixTjHYIxcbwcl6U3K+NXSyXzB7uoyyGH/1bmBmZkS/PkELADQX/k7WqFVqpMUzaNJIpke6u0quzi/bBrqAN+5+T9DmaFg9OXavZ6tZ7UOwTALflyxgRcdbtQwkLGKLqMMPjNYMASqdxHar44acxfL0Q27xO7KxcaFq2iMNrydpMH+vUoER7nVMegcFj6Yir8UmHPFDx7Vv6Ok80bJOmggODFtX02ZInXd5mS05UeWd8XytBNSUVclyyo48SdrQN1zpXv65c6emotEqwsPHLgFbIRhPU7uW6ej3Z8B4tYHsfj0LVOvOy8vKRzcw1XY+8SwlhP6H0Lg7v8OdX2ZgGBjxBt5oLK1FyB89FTEtec/Umb+G09unVvQ9pye44+Icf/oEv8ZRT2GyE4WRs9RI6poRH+l4mo563M6A8/0Xk3WYhS5x/jiJyTAfTzQH4ID4ogGtxa4Nbw80/+zp/BdL/ICtMEkeAR84SriIn9TmftvQo/GWcT6tfXCZY14MayDfolGhXNmTnKvAPaZvTfEPGHBIfxC3pJWRPXdI3E3xvPSGLIy5lduWNhaFWAjAJP+7qBniZsGukm1buJ9ixpdmS2RBLzy2mdE2fcWbfhMl8L3kaOLy2HytDROghXD1ASXd+FKHBUfI6eH9C4bDxuJ7eZu4nw9zaycA/jZ32HWJL3UIqRkZLHKeUpU9Vaoodkxm6ZXXE2ptuWMl1yhAEwCjPVh0BevInYbWSyvZB2yjKLDtr7xKr9RVxSAr3hPjs/Kp/owipkdzO0EREBrQwVVFSA7K2ccov1m4r6LF+RKZkx/e4pO0N6GJEfug5PSjQRcisG8VJ9p6c6Xbo+ya0PLrA9/VewwiVbbAH+MDU4trNqcIUX3zpqZIIde6/y+gsc+UwvbQIVRHtUvOS449uu1JzZF317w4t/N4NFnMoujgS vIJjK4a9 KKaOD83YOMxm0XB8ZD7+688vV0UyFppbAdltedjy8bZSPWVrxbMhIk4LFOj5MnNIpvI/sfqPaPJW0U9hKTboaMtpp1VyJ1uPnRkxQ7On0K0Mv7MHKME/Eg5MdZpXUHYc5pKfWXhhiE7aDIsTP8YY62JRoWXTeA+5AHcXA1FrKGfuMAPeOysEIqIzcBgblBz89nZRFWjR39G2mfw62ws4UV7MbRhZo16u8/2KiHNaWqdjQdsFG+Tu4H7lDM72w+LHyqgrF3lNwj/NVfY6rFl6BN7gTAowCgfv817aRGUf8X7ZwY5fGCTVIK38N4ZCDhzp8P5ci6Gh27lZgYtwNRP+eypQ8o9jDGT9R/uW9hLbgHJR+MR4FWPR6075v8Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 6, 2023 at 7:23=E2=80=AFPM Suren Baghdasaryan wrote: > > On Thu, Jul 6, 2023 at 9:11=E2=80=AFAM Suren Baghdasaryan wrote: > > > > On Thu, Jul 6, 2023 at 7:27=E2=80=AFAM Holger Hoffst=C3=A4tte > > wrote: > > > > > > On 2023-07-06 00:55, Suren Baghdasaryan wrote: > > > > On Wed, Jul 5, 2023 at 3:37=E2=80=AFPM Holger Hoffst=C3=A4tte > > > > wrote: > > > >>> Jiri, Holger, would you be able to try > > > >>> https://lore.kernel.org/all/20230705171213.2843068-2-surenb@googl= e.com/ > > > >>> and see if your issues still exist? > > > >> > > > >> Just in time! Not 2 minutes ago I finished rebuilding 6.4.2 + the = last version of > > > >> your patches on a second machine (old Intel Sandy Bridge workstati= on) to be my > > > >> crash test dummy. I removed the BROKEN dependency in mm/Kconfig, m= anually set > > > >> PER_VMA_LOCK=3Dy and ... it seems to work?! Boots fine, Firefox se= ems to work > > > >> (but no exhaustive tests yet). I will also rerun a few reboot laps= , just to > > > >> exercise this a bit harder and see if something comes up. > > > >> > > > >> Tomorrow I'll also try again on my Zen2 Thinkpad and will report b= ack. > > > >> > > > >> Fingers crossed! > > > > > > > > Thanks! This is promising. > > > > > > Indeed it was, and still is. :) > > > > > > This morning I wrangled 6.4.2 + v4 of the patches into all my machine= s, > > > enabled PER_VMA_LOCK=3Dy, removed BROKEN and so far everything has be= en humming > > > along just fine. One machine has been compiling for several hours wit= hout issue. > > > My Zen2 thinkpad - which was previously really unhappy with enabled P= ER_VMA_LOCK - > > > has booted a few times without hiccup, and Firefox has been happily r= oaming the > > > interwebs for several hours as well. \o/ > > > > This is great! Thanks so much for verifying! > > Andrew, if it's not too late, maybe we can drop the BROKEN dependency > > now that we have this confirmation? > > Liam pointed me to another possible issue with per-VMA locks due to > the recent changes in stack expansion locking rules. So, it's probably > safer to keep it marked BROKEN. I'll post a simple fix for that > shortly. The fix along with another less critical one is posted at https://lore.kernel.org/all/20230707043211.3682710-1-surenb@google.com/ > > > > > > > > > cheers > > > Holger