From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC28CEB64D7 for ; Wed, 21 Jun 2023 07:01:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 217558D0002; Wed, 21 Jun 2023 03:01:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1C6D18D0001; Wed, 21 Jun 2023 03:01:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0909E8D0002; Wed, 21 Jun 2023 03:01:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id ED6E78D0001 for ; Wed, 21 Jun 2023 03:01:56 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id AA13980758 for ; Wed, 21 Jun 2023 07:01:56 +0000 (UTC) X-FDA: 80925860232.17.1927DB6 Received: from mail-yb1-f169.google.com (mail-yb1-f169.google.com [209.85.219.169]) by imf17.hostedemail.com (Postfix) with ESMTP id B71664001A for ; Wed, 21 Jun 2023 07:01:53 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b="a4iI/7HH"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf17.hostedemail.com: domain of surenb@google.com designates 209.85.219.169 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687330913; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PnM3sYZw3GQcW3MdVZ0ugqF6RBJgBdIColQtb9ed96U=; b=YDVGFlZ6KP58F9Dyb0kGfMrxTaf6zyhRNbBbuW06WD1jwYu3S9lDCfqAmxv2glNjaMnfWC Q5VT7T+uAxWaXaJHYeY7QMxJrYuYEabcaVCnOMsZxPgILZKz2CWnlGVdygzSXr64wwmoHh Pweacqs7FMD/ySqD/h6+iOULLWtfnl0= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b="a4iI/7HH"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf17.hostedemail.com: domain of surenb@google.com designates 209.85.219.169 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687330913; a=rsa-sha256; cv=none; b=Zv2xupko1MUF+NvVWrgRiu/2VONACForImkg47Ebpp9M2l9Tjih3MAZB5jFhHM+KmAdn1i 9iyHzsOCPCwsMxvB8MM1JNa6lOpPmp8i9wmGIbwb/oqEVS/HqZ7RE51SMaEuxQTnkyF1dQ hVSlVdOB8/gT00lC688ymuvCd/vxN2g= Received: by mail-yb1-f169.google.com with SMTP id 3f1490d57ef6-bb15165ba06so4389757276.2 for ; Wed, 21 Jun 2023 00:01:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1687330913; x=1689922913; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=PnM3sYZw3GQcW3MdVZ0ugqF6RBJgBdIColQtb9ed96U=; b=a4iI/7HHF7LWkvUxwasul3Oew6a00PDMS+4RRczoEtTu+rn1akG807FhZCMtKt9V33 Z2PPMEixfV4XZEyq7gKkigWK/VmisCkTXu2hnCwMYe5rLG1csEPQcEa6r1ib1p/l0pR8 6v4jOz9tC6E0g53EIYbxaWQlhF9bHX2ggVBNZLrnkJrJifl4xcqJ2xhAc+wh3A2/cTlJ eCRkJc6WiDONnk5ad+3oM6GVBRZsWaIVmcL/koFlqBoAT+hDJTSNtdrWQ0hYkEEmp2+m AGZtTYcRKckzbLixgJt7UA5RPLtt4eXVvSxnBMPaRznjQzApDE48uzkhva80M8spyvzJ jhag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687330913; x=1689922913; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PnM3sYZw3GQcW3MdVZ0ugqF6RBJgBdIColQtb9ed96U=; b=Jp86G7uXd8L0xwO8rGxMPTsDFD/t79Bfh8pA1cSL2Y/1GD5PiZldR7yhrU6U+8wavY yoXWBnHpNMGoaeU6Idy3xM+tnwlhcgVdbaOZH14fnce7kNnsnt2z9iSu7Ccf5WSsj3NX eXVq18YgacZjKKIcpSanMhKLYEdaIcXmCyzMrGsY8amP7maihybHXXl3zaiRxgDq2+ii 6zNcxGowcjrNPDWruz/FXkQcruZWaMJWIRSuQs9wkV+vO+kHZSv1PExfiXrCPLETRBA2 9sdoNisi1IxHJW26Cw2OD6BfIWrz8ymGAJETBsy5FMFAFFrSquTd7QiuWgFGOmIpKREx YaXg== X-Gm-Message-State: AC+VfDzRIdjN/ZdBZ5opBAUPoUH71BJ95MTnbCLaYabOPk/kAZEhNPHT R2i93ZxOOrvQGsqz6Oy/MF91vu0iSfarR10qaSfEJQ== X-Google-Smtp-Source: ACHHUZ7mdnwc40MDjB3o9RSDv/jVj8fi7F6Bg8LeH5WY2hbfqm3Z3rPjfVpRya0+1GDilZrRCM5V09DyYLeDpHfPkMU= X-Received: by 2002:a25:9391:0:b0:bd5:8625:89fc with SMTP id a17-20020a259391000000b00bd5862589fcmr5016173ybm.26.1687330912645; Wed, 21 Jun 2023 00:01:52 -0700 (PDT) MIME-Version: 1.0 References: <20230620235726.3873043-3-surenb@google.com> <202306211007.hQoEsMrP-lkp@intel.com> In-Reply-To: <202306211007.hQoEsMrP-lkp@intel.com> From: Suren Baghdasaryan Date: Wed, 21 Jun 2023 00:01:41 -0700 Message-ID: Subject: Re: [PATCH 3/3] mm: check for VMA being detached before destroying it To: kernel test robot Cc: akpm@linux-foundation.org, oe-kbuild-all@lists.linux.dev, willy@infradead.org, torvalds@linuxfoundation.org, vegard.nossum@oracle.com, mpe@ellerman.id.au, Liam.Howlett@oracle.com, lrh2000@pku.edu.cn, mgorman@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@android.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: B71664001A X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: z4ekpsdtj9xk91hi6d1opahfd7yrfyxu X-HE-Tag: 1687330913-267658 X-HE-Meta: U2FsdGVkX18OBSVGlUaEGHUBRs1pcxKkha/HMKwFOZ5iAu2edY8Dzco5J+prMhbWRKrTpqXSEIBFjZNjqUNMbAnM341LndoBOAvrgw0CRJqgXl8LEaqfoPyz76qA7disSLi8ZaAvNfdVaTRZz2LaDMFgXBcdc97pVCg8EHvQyD1lsCzCTikRJS8HTDtgB9uFFTeONIzCLtJY1k1rd9B1xwkJXIghlErmbjV6cBFhj3+PPS1a3SDbdheSeLfUY59yd1G8iLv08ug5cR08UrJ3wJ4hUKJw2JiFQLp7WRrFPZnfeDMmzXQkNBpuKdQJSkbIg8KoCiP74/EaG2Y+4k8trDv5fKrTM9bSayoIu11uZ9oO8puZpSMD0t44yAPCioEKIZyQpDJg9fwGM4+vTCvYmnkzIG08gJzM1FwJQxjPLdzmvO+EFuMNA+tx2pOmRuNiI7uEvTel3NlcdlStnGjwz2f1RqsevJsgIOk9YFgOPpo3m6dDZlX2LudcQrd71yPGERy8dXdW/xC7L0t1I1NB6/IG/OVDGu4jdLlZH8c1WATgU83Z6dziI2Y5wMXfBx+esEE8p4/77b1UhT9g+S28LbP/u2zt5VHLKSaxVqJ8mG+avFf8aEBW7Z4jr0bQGlibSayZDhBo5BVUtFRl8qRedzhehGh6U0+QoYu49k3+LJvIGc4RtmGrkvqs8DEC7wHyoWF337Pf8JZxXihsq8IsPAtHLWSzGCwTZKnGzvroLpqet2Bcfqf6V4jyg3iE2rYWhKOoof+ElKfLVS/Bj4itPcaPFuK3mGyUOFFzbt3/1ucF6tHSKWy7fRSFi5/RqhDljEPTFrExAsoe3YC1ZRg9/CDw/ikfOJsBcXAdAoY3g5JgdXd5xjs5Ylx0LARlReeddr6MVxBnwanUpIQR0X+dsJppflSgWmTAWD/zp7oNU8Jnumtq3j7WVr4bZT8YfBH82z9FqZRC+VD+hV6tnzk dRggOgGJ YxlWJx3I2aps6rN9Mt8IGVMxRzTKmD9P8SoTYPtOutSBEAFkoBfSq3Tl4RWbk8mhg1YoDVJPqHVbWgVxqBYQIdEK+77MssJyFuHdCCJH9kqeBOB/hrpOqttEq/9VnkvOqsD+A3XCRo7Bh1Ha+CmLAXeWEi03VBYHuUJm86Ja79v05RFIpEY5vGWFodtVY0PZyknKmzfXqXaPoclPvG2QTDkS4MqU3Vsw/QSz69I0OI9qYKJltbZQRvbYOwiM0gLJMjAsCEuAUWHnvGezpG6ueUQt6tKpEIjF8TNLGXIp8QV0u0ppQZzZ/CvL9nzTYPHujtbbg4r6KkrC3ze2JAcNnfhad5QyefRHa1h/Fkkr0DllGnMYVdQxQ3mHF5BS97wPpeqonlWEwFkYM6nL2H1PCO0UCgz+0j6YsPhUz X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 20, 2023 at 7:15=E2=80=AFPM kernel test robot w= rote: > > Hi Suren, > > kernel test robot noticed the following build errors: > > [auto build test ERROR on akpm-mm/mm-everything] > > url: https://github.com/intel-lab-lkp/linux/commits/Suren-Baghdasaryan= /mm-change-vma_start_read-to-fail-to-lock-a-detached-VMA/20230621-075833 > base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-ev= erything > patch link: https://lore.kernel.org/r/20230620235726.3873043-3-surenb%= 40google.com > patch subject: [PATCH 3/3] mm: check for VMA being detached before destro= ying it > config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20230= 621/202306211007.hQoEsMrP-lkp@intel.com/config) > compiler: alpha-linux-gcc (GCC) 12.3.0 > reproduce: (https://download.01.org/0day-ci/archive/20230621/202306211007= .hQoEsMrP-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new vers= ion of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202306211007.hQoEsMrP-lkp= @intel.com/ > > All errors (new ones prefixed by >>): > > scripts/genksyms/parse.y: warning: 9 shift/reduce conflicts [-Wconflic= ts-sr] > scripts/genksyms/parse.y: warning: 5 reduce/reduce conflicts [-Wconfli= cts-rr] > scripts/genksyms/parse.y: note: rerun with option '-Wcounterexamples' = to generate conflict counterexamples > In file included from include/linux/pid_namespace.h:7, > from include/linux/ptrace.h:10, > from arch/alpha/kernel/asm-offsets.c:11: > include/linux/mm.h: In function 'vma_init': > >> include/linux/mm.h:753:12: error: 'struct vm_area_struct' has no membe= r named 'detached' > 753 | vma->detached =3D true; > | ^~ Yep, missed #ifdef CONFIG_PER_VMA_LOCK here. Will fix it in the next version but will wait a bit for possible feedback. > arch/alpha/kernel/asm-offsets.c: At top level: > arch/alpha/kernel/asm-offsets.c:15:6: warning: no previous prototype f= or 'foo' [-Wmissing-prototypes] > 15 | void foo(void) > | ^~~ > make[2]: *** [scripts/Makefile.build:114: arch/alpha/kernel/asm-offset= s.s] Error 1 > make[2]: Target 'prepare' not remade because of errors. > make[1]: *** [Makefile:1287: prepare0] Error 2 > make[1]: Target 'prepare' not remade because of errors. > make: *** [Makefile:226: __sub-make] Error 2 > make: Target 'prepare' not remade because of errors. > > > vim +753 include/linux/mm.h > > 740 > 741 /* > 742 * WARNING: vma_init does not initialize vma->vm_lock. > 743 * Use vm_area_alloc()/vm_area_free() if vma needs locking. > 744 */ > 745 static inline void vma_init(struct vm_area_struct *vma, struct mm= _struct *mm) > 746 { > 747 static const struct vm_operations_struct dummy_vm_ops =3D= {}; > 748 > 749 memset(vma, 0, sizeof(*vma)); > 750 vma->vm_mm =3D mm; > 751 vma->vm_ops =3D &dummy_vm_ops; > 752 INIT_LIST_HEAD(&vma->anon_vma_chain); > > 753 vma->detached =3D true; > 754 vma_numab_state_init(vma); > 755 } > 756 > > -- > 0-DAY CI Kernel Test Service > https://github.com/intel/lkp-tests/wiki