From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A78D8C77B7F for ; Wed, 3 May 2023 18:03:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 412346B0078; Wed, 3 May 2023 14:03:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3C1B86B007B; Wed, 3 May 2023 14:03:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2B10B6B007D; Wed, 3 May 2023 14:03:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from mail-yw1-f179.google.com (mail-yw1-f179.google.com [209.85.128.179]) by kanga.kvack.org (Postfix) with ESMTP id 0ED7C6B0078 for ; Wed, 3 May 2023 14:03:42 -0400 (EDT) Received: by mail-yw1-f179.google.com with SMTP id 00721157ae682-55a829411b5so30758187b3.1 for ; Wed, 03 May 2023 11:03:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1683137021; x=1685729021; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=v9bphnAMm9U7G1bEITi+0ZLO/l3WQ/XqMzpkJeT7kyk=; b=L5MD7LDE53jR/3ptlXQOOTiI++wR1fxND5ifICgXfZ2hIWF0RB5i7Cbf3y8nlEohAG Clh+QMTpMVHznpV/HAd4dl/nTAteOJlo9pbsv1YpgR/WSnTsEaig6E+CihdksMC7+1jq 6Z1XsGfjbwRGEha4Xholgwx49ZNbR3yyNtq3l6EeDu4stoYLEOoSm+lZCgitaF8qHB+G aMVYQbQoJuHDRRMDleBxwSfQuKLPGBerL3yL63wdl8g8U8bu8+X2Cp3t0DvaZ1xR1kyJ azu3inhuljuw1kRnH+qDgCm878e8KG06FyLYG9vQjwOhW5SbMlJY+LCsM4c30rFxv+Mb ZPgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683137021; x=1685729021; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=v9bphnAMm9U7G1bEITi+0ZLO/l3WQ/XqMzpkJeT7kyk=; b=d0nVUn/AidbkX7hfOPXGB+zBdaFyNAxy5xMM/LVY9fjZKp56vzpK/G1aKVeVzpyxsc 64oP9nHIcCTJpoz8fts8w+x1wQlKRoC6LuBxuRYjoc7IhI9TVIU4WAV11Xt1cTheJ/t2 A27VBwLeGOeTRYPOvp587Q58Az05zVL99kAZ7UGgOs14tw0c14/yUXKalq/drr3jZeG4 zTqVcGINmarpDB3lJk8afc+hqtSwu0In1vJgYqS12oXhsyI4+rdWXD0QgiZFe+iXoFf8 /H2An0TRLqUfRZaQdXLI8W02jHLav1mUHGcwKZrexn9GONGePqOZeuA69j3TLHD46lAW fxHQ== X-Gm-Message-State: AC+VfDw1jgikgyHgmvyqBGSogx4hlebVqeCCot2mbdkWgRF4iQMq8or5 bM50JHF8Wh2mScyR0DxO/eftl+eb/Fek6LISOecjQg== X-Google-Smtp-Source: ACHHUZ4lvIgzIVoqBzi+ZqkC84PohxQDTMhCUsBRrb1hVuiEkZ49Yye5mAE/xSMdKBlLzt8OPesXOTpbgWw93u9GuoU= X-Received: by 2002:a25:b18e:0:b0:b9d:b774:3aa2 with SMTP id h14-20020a25b18e000000b00b9db7743aa2mr16215719ybj.9.1683137021290; Wed, 03 May 2023 11:03:41 -0700 (PDT) MIME-Version: 1.0 References: <20230501165450.15352-1-surenb@google.com> <20230501165450.15352-20-surenb@google.com> <20230503122529.44ef2d56@gandalf.local.home> In-Reply-To: <20230503122529.44ef2d56@gandalf.local.home> From: Suren Baghdasaryan Date: Wed, 3 May 2023 11:03:30 -0700 Message-ID: Subject: Re: [PATCH 19/40] change alloc_pages name in dma_map_ops to avoid name conflicts To: Steven Rostedt Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, ldufour@linux.ibm.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, May 3, 2023 at 9:25=E2=80=AFAM Steven Rostedt = wrote: > > On Mon, 1 May 2023 09:54:29 -0700 > Suren Baghdasaryan wrote: > > > After redefining alloc_pages, all uses of that name are being replaced. > > Change the conflicting names to prevent preprocessor from replacing the= m > > when it's not intended. > > Note, every change log should have enough information in it to know why i= t > is being done. This says what the patch does, but does not fully explain > "why". It should never be assumed that one must read other patches to get > the context. A year from now, investigating git history, this may be the > only thing someone sees for why this change occurred. > > The "why" above is simply "prevent preprocessor from replacing them > when it's not intended". What does that mean? Thanks for the feedback, Steve. I'll make appropriate modifications to the description. > > -- Steve > > > > > > Signed-off-by: Suren Baghdasaryan > > -- > To unsubscribe from this group and stop receiving emails from it, send an= email to kernel-team+unsubscribe@android.com. >