From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E426CE7AA8 for ; Fri, 6 Sep 2024 03:32:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 888006B0082; Thu, 5 Sep 2024 23:32:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 810F96B0085; Thu, 5 Sep 2024 23:32:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 68A486B0088; Thu, 5 Sep 2024 23:32:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 47CBF6B0082 for ; Thu, 5 Sep 2024 23:32:38 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id EB8944092C for ; Fri, 6 Sep 2024 03:32:37 +0000 (UTC) X-FDA: 82532891154.20.91D48C7 Received: from mail-qt1-f175.google.com (mail-qt1-f175.google.com [209.85.160.175]) by imf15.hostedemail.com (Postfix) with ESMTP id 39115A0012 for ; Fri, 6 Sep 2024 03:32:36 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=KE1518eS; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf15.hostedemail.com: domain of surenb@google.com designates 209.85.160.175 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725593447; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oGD+kq844RgjIMgaWd689+bfKQO1SfZUcX5ijNslcG4=; b=abacuhKL9H6Qy9N+N/bM9/evwx3pVJEboOjWHvjzv/fhWXitByuL6AY2wGdqV/s6E92RSh xWwWbyf429wpb1HFZTF5yS6sm6nPUp5W4UlWw6nWMRIrUBvjke3VrAERLO3qonmEDS6Oyc XrWsB6d7n3uKSxc4zfbGY5IE1sNEjes= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725593447; a=rsa-sha256; cv=none; b=xxs7Gkz5koLrl4VYUpJ4QomVz/KtzvYu3PDFqhTzVKXvy9X5ZQfZD7po4zmD32k3rQT/l8 7BqO8jmfN/UkJzBD4qm/wv7hXzMwqOwD7ZTwKtpZnAEavAJdur+1o91p+sTtSrBD/IxChM Y8I5ulYdq/v8pKGyK0q99sZj1xt7kj0= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=KE1518eS; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf15.hostedemail.com: domain of surenb@google.com designates 209.85.160.175 as permitted sender) smtp.mailfrom=surenb@google.com Received: by mail-qt1-f175.google.com with SMTP id d75a77b69052e-457c6389a3aso102891cf.1 for ; Thu, 05 Sep 2024 20:32:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1725593555; x=1726198355; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=oGD+kq844RgjIMgaWd689+bfKQO1SfZUcX5ijNslcG4=; b=KE1518eSx/vZnTNhj1VZzoBiP6Hcc3CUQzTQTqwFD0wZLkq+vdEyNyN1j4Icg+Liun QCFaeO/qzkkp1ceLXTIoO6ZPdqPjP0TfeugpLUcsSL7pdh4OOCiqjpCZij0PQMXlQEZg 2e5HLqhTo5t1Il8p8JHhaU9nXIlJ/7gBNgVJVb1BuhqHdch6EJpR3TzRytGZo9O8ULiG Qpw80NN1SnKn6pAmPlgirVPltfmhtBa7ymUB04OSGAkLwyGAnvaksLADlTBjHXV7Z430 xbOJdPeH38DvP6N/5BejPWy/X6rvpzlx89tGQun7XYidIQrV7hZJi1ao8RelfoIvEHIi 3dtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725593555; x=1726198355; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oGD+kq844RgjIMgaWd689+bfKQO1SfZUcX5ijNslcG4=; b=qV0tKV5+zOCnRNxtMeQjTmEeebeGjvrK9mz1accykD2E8rd0BcNn29pdMIsxlHZkIE kNfnaRQo5v+mtDwujF3jb3BV6S2UBvcsMNtEdCuvLWWq+mRXydE24Nm1QISdIGQNjuYn OODhes77JK6HKqAkoEcuhyY7UeOfJCaSuZh1GHodF4Av3jgk/qYHfqOqK8dNoz41hEQM zguvPw0QyS70xyLFtT1MktytWpk2TJJDppWN3I23EkVvXmGUpa0fOctkPxH7ezRqp+KH 9dWK6drlP6YvUZH7D0eo+A6mpzPasFWmTeHKAxIyOcIblhv/iOJpnNvMwfYsIHlswNzX pFpA== X-Forwarded-Encrypted: i=1; AJvYcCVob3RbV5lEvw6fDDx8ZPLPgTlUIk9oVGMZYUvDN540kb2uQiFTXq0y2N8zLN1Uda857NiQS3FZaQ==@kvack.org X-Gm-Message-State: AOJu0YzLJKaWxHViU6cbasiMqI6MMP65zgkGnFlWGEhM8YHhMzGR1FFh CY9M/weFTZHTED9jHld/J4lfaqAKgf6TcK5Ne/H4HSkFauw057WNs91PRoQw481S0k1qQule/5F TFyQ9W8P43V/ZLuEBnVkYl2dlrMHi6PD3I/vPGYmkOZLTzuA8PUme X-Google-Smtp-Source: AGHT+IHXptcIy8FKYGMHmjV6qcqim8ryRJ5KLZrYDWADLTHrX96IQIVT6l7HSHhb5egWqkpNygLZkIqBcszskium9es= X-Received: by 2002:ac8:58c3:0:b0:456:780c:1d3a with SMTP id d75a77b69052e-4580e58bf23mr729901cf.19.1725593554976; Thu, 05 Sep 2024 20:32:34 -0700 (PDT) MIME-Version: 1.0 References: <20240906005337.1220091-1-kent.overstreet@linux.dev> In-Reply-To: <20240906005337.1220091-1-kent.overstreet@linux.dev> From: Suren Baghdasaryan Date: Thu, 5 Sep 2024 20:32:24 -0700 Message-ID: Subject: Re: [PATCH] mm/show_mem.c: report alloc tags in human readable units To: Kent Overstreet Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 39115A0012 X-Stat-Signature: 3y1wskutgqw1b3aiyb3s8d9oz3mp4g1w X-Rspam-User: X-HE-Tag: 1725593556-683353 X-HE-Meta: U2FsdGVkX1/MQGYJ4GQX3AAALtDi1xt+GBIZlDlrYLUnX2iv6+BaDiGMIvM7/OO6uNyNN7Pd8wdRexGhyp0v+iMcCkhZJfxIxUyd8g+a8OUsZyMABD2kNeCZantvyIuQUe583oLjE8ny6/+Bn2xVFHDF234oo58xRNgSHF5mGAArd9vSHKcCQ5n6poeKyUMPwj56Gd/9Mu5JGGFmUVEGtsSkn01cagcJaHMFLbRWNT/L0QIMjMpk7QrbKHK6BoBHKMzGaaTaXwks1yHmw9fLkqw/SFfmKYGaAAt0uuSGHfDu/Ko/7Xe9VT0oidmQMOf3/8d9BM93Hiz7t6HVbB1mLXdVr4DACM6K4zYR4oRC7KTmNPjEq5DqBVYq1nLvvfPYsdKnWZLs2+230RwVV1Jx7ExIjjaS2NUrKltW0WmmINNE0RZqsxpLIfn1IpMwXkhFmIg6moB0KLFllb+w0BobBLOxdxqMO0ziMwtIBlUuHF8DOTzgKlxG4rDEsWYIbEb1S6zdQPoDM3Y8qaObNOo3urdUVSF1JvNrB/y2gwWkO7I/UNIdKbkwaV9PasmYGOEpqXG7iIqlILqMwvL3HrWGgVQLXwttopUBQYFv74M0XmbbFHjvVZG/0ul7dtO3lzmejChn/XoV8HouZ+ySrE1zkC/1g2AS8bYH4olFe8TqMpITL4uwMKselY3msGYeoNeOq7vlPji6E8ZeYAE7eyqRNjIZ1bau4dHibXv6Vq2htZhCATpHK1dv4NXRh7+h52SabIWOEAGh9Fd76L9xNSmlK3MUUqKa6+Ymv8q5a7nIfwaUI2o0Vcbif1fvsdq5u4qlMpgCW0v1mjRqfWjKDZ2TaZKQn5DyL8Yf1m0xZyDCCNNy8sOctohBq0ZKizXVdHfudfDPdKkbj9BA9hVwL6biFHC9qaDh+dKMuhpBJ40++yUDQpBb4IpsTfoIAeEpD1Om8eOGUu3PSGHlnXAwXhF AcB+cYpO O/qABYyxiKbOKYbViMvnIFa2B8SMKLLaSvfp96gPVO4h8PqR8OulZ1+HkcddTQsqwRYP/mlzqEv2IuGGPvPvQf4V5OgoHK2JTQK3WmL2HQCFjoMgbXbErPXddtLCx7zgmpKbyJXmVQPD9UfQWN1LBZABueY2oWpV5A3KBihmE/fsnpER8pdo1hdxPSYrXc8Lcc5gCB8iZ4LVvadx6ZDw1nnADij0W2HPrd5u2l+oHCEyz1VSf56WMJh8zKISwAnUCC2XRdbTEdsRMPCuQ0WisoX/QGzEKyM3a4/Cpu8vWhPLi+rixPaLfQLhFxIrstzuXSGER X-Bogosity: Ham, tests=bogofilter, spamicity=0.209278, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Sep 5, 2024 at 5:53=E2=80=AFPM Kent Overstreet wrote: > > We already do this when reporting slab info - more consistent and more > readable. Hi Kent, I remember we discussed this before and agreed upon Pasha's suggestion that if needed one could do: # sort -g /proc/allocinfo|tail|numfmt --to=3Diec 2.8M 22648 fs/kernfs/dir.c:615 func:__kernfs_new_node 3.8M 953 mm/memory.c:4214 func:alloc_anon_folio 4.0M 1010 drivers/staging/ctagmod/ctagmod.c:20 [ctagmod] func:ctagmod_start 4.1M 4 net/netfilter/nf_conntrack_core.c:2567 func:nf_ct_alloc_hashtable 6.0M 1532 mm/filemap.c:1919 func:__filemap_get_folio 8.8M 2785 kernel/fork.c:307 func:alloc_thread_stack_node 13M 234 block/blk-mq.c:3421 func:blk_mq_alloc_rqs 14M 3520 mm/mm_init.c:2530 func:alloc_large_system_hash 15M 3656 mm/readahead.c:247 func:page_cache_ra_unbounded 55M 4887 mm/slub.c:2259 func:alloc_slab_page 122M 31168 mm/page_ext.c:270 func:alloc_page_ext That's even documented here: https://elixir.bootlin.com/linux/v6.10.8/source/Documentation/mm/allocation= -profiling.rst#L36 Did something change? > > Cc: Suren Baghdasaryan > Signed-off-by: Kent Overstreet > --- > mm/show_mem.c | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/mm/show_mem.c b/mm/show_mem.c > index 691e1b457d04..1b448e1ebd09 100644 > --- a/mm/show_mem.c > +++ b/mm/show_mem.c > @@ -459,15 +459,18 @@ void __show_mem(unsigned int filter, nodemask_t *no= demask, int max_zone_idx) > struct codetag *ct =3D tags[i].ct; > struct alloc_tag *tag =3D ct_to_alloc_tag= (ct); > struct alloc_tag_counters counter =3D all= oc_tag_read(tag); > + char bytes[10]; > + > + string_get_size(counter.bytes, 1, STRING_= UNITS_2, bytes, sizeof(bytes)); > > /* Same as alloc_tag_to_text() but w/o in= termediate buffer */ > if (ct->modname) > - pr_notice("%12lli %8llu %s:%u [%s= ] func:%s\n", > - counter.bytes, counter.= calls, ct->filename, > + pr_notice("%12s %8llu %s:%u [%s] = func:%s\n", > + bytes, counter.calls, c= t->filename, > ct->lineno, ct->modname= , ct->function); > else > - pr_notice("%12lli %8llu %s:%u fun= c:%s\n", > - counter.bytes, counter.= calls, ct->filename, > + pr_notice("%12s %8llu %s:%u func:= %s\n", > + bytes, counter.calls, c= t->filename, > ct->lineno, ct->functio= n); > } > } > -- > 2.45.2 >