From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89EDFD42BB0 for ; Tue, 12 Nov 2024 16:58:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CD8618D0003; Tue, 12 Nov 2024 11:58:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C5E628D0001; Tue, 12 Nov 2024 11:58:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AB1BE8D0003; Tue, 12 Nov 2024 11:58:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 8392A8D0001 for ; Tue, 12 Nov 2024 11:58:20 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 092EA80434 for ; Tue, 12 Nov 2024 16:58:20 +0000 (UTC) X-FDA: 82778049816.21.6CBD3D2 Received: from mail-qt1-f171.google.com (mail-qt1-f171.google.com [209.85.160.171]) by imf20.hostedemail.com (Postfix) with ESMTP id EE3041C000F for ; Tue, 12 Nov 2024 16:57:25 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=086StAc7; spf=pass (imf20.hostedemail.com: domain of surenb@google.com designates 209.85.160.171 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731430524; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6Q349X4O3ThW9mGj94pBdAshyZ9YK6Y/LlQyE9ZF8/4=; b=T/zbo31gRZqN23fg1bC3IPJC1nYYxzbbZwCD6qduJS+p7bsUXFmVNzrZ+EoJo/j5LYsWOd dsZCv4mYeTgSZ+Q/ZT+b4YqjFW8fvyB2nJM74QXRzd2I1dh0b/eNSYrPS5twc+ELPH0137 qr01reGZreIP/v9H8oUvfmGBmCVjnCE= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=086StAc7; spf=pass (imf20.hostedemail.com: domain of surenb@google.com designates 209.85.160.171 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731430524; a=rsa-sha256; cv=none; b=afPXQD/yF1u/e/N6Np2S0GYYWJ5AmenktLb8L0Hs5GiYO6plaiOU8CKhg3lG/aCKCW7l68 uS0e3CpE0yTB/X5tl3atHN+qPvB4xSsuR0ldOGZDNF98vxjfKvM0/UGwgZVaEOMroOop5k 5jc3weMwdcr8WN/r1LdmBuD573DfJu4= Received: by mail-qt1-f171.google.com with SMTP id d75a77b69052e-4608dddaa35so323461cf.0 for ; Tue, 12 Nov 2024 08:58:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1731430697; x=1732035497; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=6Q349X4O3ThW9mGj94pBdAshyZ9YK6Y/LlQyE9ZF8/4=; b=086StAc7dCXSQWLgETxb8HR+qe3LVYUYeDcZpR8DAmNJi9UdNtuF1nfv5/XMbbDvhp NqC4Xt0WqgfayfxJOyuq0xMc6F5AyAYFLqN43XS/7zV/AkxiZPDR/cVEhpCN4J67GDSH KtPvJ7i44hH+9RwVy7BJvMFpcuItTI5DEFBXyGMr19lM/Q4E9eQ34ZaIjKDuGhi1cuh9 0q9gz70CyqkUWzaj+FCzWM2otfGKhVFMVQ2jHwTLQ9bEjLdwHfFpChlo/Bx4WfBKWfR2 l0ijedU9iDoOAVozG+ZRFGCtcyrCMw76lQeOWHwIOa60LYONy6gyV4tXxeXMGUn1HRtZ 6lQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731430697; x=1732035497; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6Q349X4O3ThW9mGj94pBdAshyZ9YK6Y/LlQyE9ZF8/4=; b=UmihY+FjJK/oOve7T4mGOmiSd3hzKMGZwcP4gnFcPsH5invl7ScGiNUerpOFbyX0Xf ht1gwRC90Pmgi2TnKHrYAbzSEEmjb3VDjW86DdntaLxePAqzlx6uo+i+KkOG/XemriJZ 76O4P2ddGz0ZJhm1taGe9Zn4SPVgoEcMsSZr1aIJwlYIikQPpPnJRrTlQ2s24KWgczPs 9aFlkDEYybP26MONNcv389HbJmQW2N+KhAWjgZBZ/fv1ba9JXnLju/UDzswhfdUCKPx/ FsDz2zPPgWLbJHL/VfIRbmEhycJmGJ2SEQjUQwWFVIVhfqxPhcna2WVvk/QKv62mWe+V FTzA== X-Forwarded-Encrypted: i=1; AJvYcCXQQPQfGRRmty360jeny0GwCsfPFsLT2VsZBiHdqKaweGc50C4pgkYe6nQE8gkorEAoDvfSAxj8xA==@kvack.org X-Gm-Message-State: AOJu0YyQoZ9c/05VKMuXBNFTb7qIY2Ps8Qo8pbfNVekTu8FPX4+rYdK+ KRJjO7lAcpE9PdY5/8EI0kTKcHwCEt7HgQdA80xJHXOcops1oJkSbfozAIS9izpDhciE0P4aJ62 WEKo3MFoZqquUHr/7XeKQnIU7q7sbQ4fPL7cs X-Gm-Gg: ASbGncs99tntJjHCSgOSYCzlUjfeKLFa1SSt42xrBADbW2DsmrB7fo4RvqJm7xTLXr5 7TQwxDhiF83JoMwWzTajSCm2tQHAAl2bwUg1mAlnYZEsVyNp3xDID/FlzPpVvhQ== X-Google-Smtp-Source: AGHT+IHXNK6wQ46kS3qqgXDpujV8J8Zp6o5bogO1xLkDGWaaY7Yqk5Zv20VA3J7KtvY5Q0Jucz8mZPryLXDwsX3i80I= X-Received: by 2002:ac8:5d94:0:b0:461:66ea:ea70 with SMTP id d75a77b69052e-46342894062mr2679711cf.15.1731430696665; Tue, 12 Nov 2024 08:58:16 -0800 (PST) MIME-Version: 1.0 References: <20241111205506.3404479-1-surenb@google.com> <20241111205506.3404479-3-surenb@google.com> <07a72c38-22f5-4b99-9d74-0877eaf2bee2@suse.cz> In-Reply-To: From: Suren Baghdasaryan Date: Tue, 12 Nov 2024 08:58:05 -0800 Message-ID: Subject: Re: [PATCH 2/4] mm: move per-vma lock into vm_area_struct To: Vlastimil Babka Cc: akpm@linux-foundation.org, willy@infradead.org, liam.howlett@oracle.com, lorenzo.stoakes@oracle.com, mhocko@suse.com, hannes@cmpxchg.org, mjguzik@gmail.com, oliver.sang@intel.com, mgorman@techsingularity.net, david@redhat.com, peterx@redhat.com, oleg@redhat.com, dave@stgolabs.net, paulmck@kernel.org, brauner@kernel.org, dhowells@redhat.com, hdanton@sina.com, hughd@google.com, minchan@google.com, jannh@google.com, shakeel.butt@linux.dev, souravpanda@google.com, pasha.tatashin@soleen.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@android.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: EE3041C000F X-Stat-Signature: 7176jmsdgk6e6gxo963g7jafdywwfyxk X-Rspam-User: X-HE-Tag: 1731430645-600710 X-HE-Meta: U2FsdGVkX19JOdNepdEA9dC0LMGWiiL4hyjBxIYM6PdnZ4rkTQkpJwu/KPLtYuzo4wtP+U2CclqgR85d8cLhi1Pq2G0Y917FVIYHLznG+g27irwo4Go6TI6L5IhQ3RPRpnyxRkBbpdPTyQRlheNS5TS3Q0TVMqItBWTjbHq33HW8wO+nbXtwgtspvBIVencpvskkEp8zZFXMUPgMJUcVCAYZrCEKoW9AdXqWX6So9RsTZMJPtHpT24V8XGbYRWvkG+WcbiQEV+jCwbuJ6tbBuJ6Pxyca9LHf7HXzVueS25bxbCrjF/nse9xl3byss0BqgB7MoZG7vVvXMs0oHKzYzHNSl2lD/mazUvcJwKHqpcKkUp+/UMcXlBrdbo2t74RnesS9ywWK+rdCfin+ZNJ97XJlK0ZPFxIY4poYhkNbFVBFUdKG68/0UYupIz+rXYMBRcc1VJT2SJc/Xypr5HbV8tuVkXAcjd710IHYjyI+lQd9x6zW20AaH+nSvX2KGgDC1vjJSPpu6DfvCuCEggH/sLdG/u0yagzjQp738JMp3Rt8aUPpGpGxdlk5691nLqIivkbLWN2yOUFBN1ThTpjKmECoYAyCT6R/wxCy8KVxp9/f3CD7eOGqxXy5PYUcY3BucBLySHdVYwuWBGVTiVtoFOap81hSTIEcEyDiy6I0HpTPnoNEeX4xU2lFc+PJC/oqJs3PIjUtA4V5fS4DLXBxGfiPQnKLusF/fNKq3qEHFKzPN478cd3k2HO+NwW+dQdsIj0T8iEB98R5iIVm4Ml7nwZstomRc+NhvJp3jx9YwlCdB95jzxrfY4i0odTVMFR8rC4noWLaBe6Doesahq54TPfS2p1d3ROwTUpqCIFtriiUgFwsG0bGq/yaz1tTWha81+HuyNGx04h+WeNgpuWbW2UCfe0c+3XN0EEWeGVPUZ4A8BVHV4Q9rQyyaDaRm3Ed6Cd/8YNeDjn6ewbVltU bYQBHlh1 yamPxpgw+HV5d7s1v6hhzA6WXyGpLCSBeYF5LerBpo1lyjaFCP2NSAUJHgJIkVmPEGrlKs1SGcBilC5+/QivmiFGF+IOlxvrTX7LjebElTyz+AnNxGmuCdhBeDOZlW4aPabGmScn+/D/C0k1IIjRVGVqCiNpGOBifYIHDIUSVXn2iA+iW4KZgat4ecAZs0arrYq5seDB6ElEml74TKZ1WTXMyQRWSpmMAQZ8Ykt8Fhg71/rDxIpuNP/wxS29cevcGhYyBEwuLAbeFp04= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Nov 12, 2024 at 8:08=E2=80=AFAM Suren Baghdasaryan wrote: > > On Tue, Nov 12, 2024 at 7:57=E2=80=AFAM Vlastimil Babka = wrote: > > > > On 11/11/24 21:55, Suren Baghdasaryan wrote: > > > @@ -511,7 +476,6 @@ void __vm_area_free(struct vm_area_struct *vma) > > > { > > > vma_numab_state_free(vma); > > > free_anon_vma_name(vma); > > > - vma_lock_free(vma); > > > kmem_cache_free(vm_area_cachep, vma); > > > } > > > > Have you investigated if this allows to perform vma_numab_state_free() = and > > free_anon_vma_name() immediately, and only kfree_rcu() the vma itself, > > instead of performing all this in a call_rcu() callback? > > Yes, it should be fine to free them immediately. lock_vma_under_rcu() > does not use neither vma->numab_state, nor vma->anon_name. > > > > > Of course if we succeed converting vma's to SLAB_TYPESAFE_RCU this imme= diate > > freeing of numab state and anon_vma_name would be implied, but maybe it= 's an > > useful intermediate step on its own. > > I'm thinking maybe I should post SLAB_TYPESAFE_RCU conversion before > anything else. It's simple and quite uncontroversial. I will probably > do that today. Uh, I forgot that I can't post SLAB_TYPESAFE_RCU until I eliminate this vma_lock_free() call inside __vm_area_free(). So, I have to bundle moving vm_lock into vm_area_struct with SLAB_TYPESAFE_RCU.