From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 219DAC04A94 for ; Mon, 14 Aug 2023 20:06:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 83E66900004; Mon, 14 Aug 2023 16:06:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7EE768E0001; Mon, 14 Aug 2023 16:06:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6DB84900004; Mon, 14 Aug 2023 16:06:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 5C9E68E0001 for ; Mon, 14 Aug 2023 16:06:58 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 1C51FA099D for ; Mon, 14 Aug 2023 20:06:58 +0000 (UTC) X-FDA: 81123793716.12.5560AA3 Received: from mail-yb1-f180.google.com (mail-yb1-f180.google.com [209.85.219.180]) by imf21.hostedemail.com (Postfix) with ESMTP id 3BCA81C0015 for ; Mon, 14 Aug 2023 20:06:56 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b="imu/s4fy"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf21.hostedemail.com: domain of surenb@google.com designates 209.85.219.180 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692043616; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=t1RQBQR/MAT6mtkRSBLye6IJ4VHPL4IQK3Vm3WdtiNU=; b=esxHs7Bezms9kqaK6aBs7h+bsLo/923TvSC8l6sEh4aEAhi9FpPvNbaI5mdMY4BLpIpOd+ S3ZHES55sLpS+jOqbVPzw/NhCvVNkf5VTtdSR6QFUQaYGyzDCoj7UTEcEoZKkKGptIl7Fj Ai0B1r7ZLif3cPpnJu84iVKQ5m/twJc= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b="imu/s4fy"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf21.hostedemail.com: domain of surenb@google.com designates 209.85.219.180 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692043616; a=rsa-sha256; cv=none; b=ebbsXuzrL034FJBPGxG9nDDqEWoQr3UqOCnw42H87paZgq87G5IPOqxVTCNbOK9xmMLzHy Ry7vwXsamAZcNyeO6AqiBNLZjajvA5F7H3ohg4S7U2M+i7gz4BMWgAPRI1bxDKkHLalEgj T5tb1vfkU9qIBVk5RLwTr5cnfyu37cc= Received: by mail-yb1-f180.google.com with SMTP id 3f1490d57ef6-d62bdd1a97dso4805332276.3 for ; Mon, 14 Aug 2023 13:06:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1692043615; x=1692648415; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=t1RQBQR/MAT6mtkRSBLye6IJ4VHPL4IQK3Vm3WdtiNU=; b=imu/s4fyVMvlWWpKp8piuwCJw3qnyxyzhsyh+A8zI1BeWVRWddA2DC5GebTsvOHTTm /MS3ynNjGPWHtuS5Qk/laq1K6eu13RLOntrXxzz/LKKPwna3qsN8UJak9Faz5ZZbhwAg vA7LUKTKIvH7/PkD02qiU8G8uQBLUER0yKZ4lnWDhLTyew8ZDSwSLdaUj9rwqYV7Miq+ /CnYTwAlI/TF7x5+wRe2fiZQYxl952G0eTLk4yCYV/lIcaPkal+h1M8ATizQQtpJPqU6 djEW6RzdQxUK6EfCOK4bwC+gz4SSA6AsR14zuD6g7BoFoNzAAQnVXrBgVrdT/gqg0s2X PzaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692043615; x=1692648415; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=t1RQBQR/MAT6mtkRSBLye6IJ4VHPL4IQK3Vm3WdtiNU=; b=kPK7YTbwFv84icVl1RYVsyaoeanR+yhx9ZjCpOj6CIfrEZVpOnYxe+lJ/bIejmnb0e XxILs9SPgAYzaVbkmS9ijHlUR0kW4gkOOtkqqOsFZvSAk0FtZuzzyyK9ZwQZdUIKO4x4 nxih2uwbFSl0//CfH6JMwPtzMEVxybgoga/jJr7QOuscjd2UaBXGsfD7ualDidkij5lT TD9rt2UzuH+ZkvJjy6reE/K/N2hoj0OzONDU739VZr8Eu7MJcBpgecebJeXWIOSodIcx 2jyX1q9uM4wORRB5pW23otQurZhKxL33LvMDo3PAscGcnDGDyXAtNZem7iRpKePTfleW GCpw== X-Gm-Message-State: AOJu0YxggCmg5t0v6r4ynqHUsH6Cmrkkq1ZYrXBmo1EsakRlmpFYgZAt Nc6idSGd5uuODtwhP3KL7g2JXh1OtbRKb574obH1lw== X-Google-Smtp-Source: AGHT+IGO4ICTwdePwp+mfoAA0rvSkF+6YukKJ8MuhcGINvMEj4kcA6FIWTcYRe0eyhPM1IlJImGo++yGi+dLw00Oc90= X-Received: by 2002:a25:84d1:0:b0:d12:1094:2036 with SMTP id x17-20020a2584d1000000b00d1210942036mr10534671ybm.43.1692043615117; Mon, 14 Aug 2023 13:06:55 -0700 (PDT) MIME-Version: 1.0 References: <20230804152724.3090321-1-surenb@google.com> <20230804152724.3090321-6-surenb@google.com> <20230814121521.83c2dda21765757d272538b2@linux-foundation.org> In-Reply-To: From: Suren Baghdasaryan Date: Mon, 14 Aug 2023 13:06:44 -0700 Message-ID: Subject: Re: [PATCH v4 5/6] mm: always lock new vma before inserting into vma tree To: Jann Horn Cc: Andrew Morton , torvalds@linux-foundation.org, willy@infradead.org, liam.howlett@oracle.com, david@redhat.com, peterx@redhat.com, ldufour@linux.ibm.com, vbabka@suse.cz, michel@lespinasse.org, jglisse@google.com, mhocko@suse.com, hannes@cmpxchg.org, dave@stgolabs.net, hughd@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel-team@android.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 3BCA81C0015 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: b4e35j4p4kjhh3cjj4en54sy869oymye X-HE-Tag: 1692043616-603323 X-HE-Meta: U2FsdGVkX1+yjw3vzxrx+eWwlWVRaBDD/knxp484OAltcRjaTGJfFqnrPl79OAX28Qx5V5/qhZD6kfFB6leqsiG1uHpVbkDbngX5Q+sgI5IxcxxF++sYjWTBoiLVtmXI4nfLxfO9yXW0zz2kpV2o/6CeyUy2CRO0rYtlptez/fdNwmVLMWg9yXpPX3OF+7nGevtiTGePbGRPazAIemobsAjJin019IvhOqmWMSSMlAn2vXWVbtXxYjXeoZIHH6RFk1ZMj7b6o2MTcuDXTMM05Is0XneUQ8AnmTbKoQcyXHPdso68xF/rT/2KClituGlMqjKSjHKd1SkDA40Xwuqc35vcC6YvEcL00xp2zHHalLtK5kf6iAM3Xvl0C8HAnmfNoRxS5RQMfBiyUj60WnC+QprkWhpupV7N4aBdRJ9O07+ABZzhZzEVw/JQVcZxmMOpqkf049LNl9cO+DOtt2EqohtOqbukDNd1Mnj/OSi6isEHc0WtKknizr087873NX3cyvNqo5aN3gHDkSogqCR0d2MC4DqBgtJo72mMd3pPm37A5vju/2v5xv7SWPVe2DOOLKbbq/T2FtMXmWgbl6MXRzYvJW4ZfkV+z7A9v2vqJWlpgvDqrxm6oWnc1h1PNR9+4fYV+QnPQwx5/qo6D5sYEZ8Y1qSIxAywoPqm3mPrY3xrP3rWQmnGYCenp/7oxVV44+PkIlUZQUEqEP3oa3/vkJRjxer0gMyUhZtB4Ii2ZcRTtVQnWh/WJPWC7RU8CWW6wEW3+TKvboL0LeEwubxKBtRwmJCageFE+v2dXjbc3eTnSVaXibYKbGoZxyv030uGNm14auie4ks/uzDwD75EKKMVn+appPRgVaCpBmv6xNkm6HNA/PtzgUUEcdc1VoVbnqsdcWMt2r9+X0qbVuugwkniFIRAhRkquiIkeDWgBl6DQPztyKkaXDQ/4/xeme1ZuhFE5V+mxXsYWRPKsde mbX7QjfZ xWAurPNEeFlDW25rEPVh8v+c0Muj5u8mNz4GI+RH5yaXLzJGur/iTQnUcMmoZxwQNFEeeCKDaWx358VD7QBJSR8BeIyFF1s23Gc2mdkecmVBya/4JrCnlTMdHRH4LzlexQSOvcrVwApbQEeGgiVrgju/m0B/QnEfC1wtuscyMpLSjW+YOOVbeBqR3r49OtkPvfRcfLFLbhGhYGEb7IjTEyDyePjAJMwR9Xz75VIn+yAvvqB8VoVdclXxDa1t9jGSkX4c3MdOOJWO/ejmXuAvnU7lFcoRT8MXPzwO9/K25M0zFR2VUsrC2f02c+g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 14, 2023 at 1:02=E2=80=AFPM Jann Horn wrote: > > On Mon, Aug 14, 2023 at 9:15=E2=80=AFPM Andrew Morton wrote: > > On Mon, 14 Aug 2023 16:54:01 +0200 Jann Horn wrote: > > > > > > @@ -403,6 +403,8 @@ static int vma_link(struct mm_struct *mm, struc= t vm_area_struct *vma) > > > > > > > > vma_iter_store(&vmi, vma); > > > > > > > > + vma_start_write(vma); > > > > + > > > > if (vma->vm_file) { > > > > mapping =3D vma->vm_file->f_mapping; > > > > i_mmap_lock_write(mapping); > > > > > > The "vma_start_write()" has to be ordered before the > > > "vma_iter_store(&vmi, vma)". > > > > Thanks. This? > > > > > > --- a/mm/mmap.c~mm-always-lock-new-vma-before-inserting-into-vma-tree-f= ix > > +++ a/mm/mmap.c > > @@ -401,10 +401,10 @@ static int vma_link(struct mm_struct *mm > > if (vma_iter_prealloc(&vmi, vma)) > > return -ENOMEM; > > > > - vma_iter_store(&vmi, vma); > > - > > vma_start_write(vma); > > > > + vma_iter_store(&vmi, vma); > > + > > if (vma->vm_file) { > > mapping =3D vma->vm_file->f_mapping; > > i_mmap_lock_write(mapping); > > Yes, thanks, that looks good. Ack. Thanks!