From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93062C433F5 for ; Mon, 16 May 2022 02:46:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 26D596B0073; Sun, 15 May 2022 22:46:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 21CE66B0075; Sun, 15 May 2022 22:46:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0E6A16B0078; Sun, 15 May 2022 22:46:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id F0B2E6B0073 for ; Sun, 15 May 2022 22:46:35 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id C0C6E21828 for ; Mon, 16 May 2022 02:46:35 +0000 (UTC) X-FDA: 79470067950.09.2984B39 Received: from mail-yb1-f177.google.com (mail-yb1-f177.google.com [209.85.219.177]) by imf28.hostedemail.com (Postfix) with ESMTP id 44281C00B8 for ; Mon, 16 May 2022 02:46:11 +0000 (UTC) Received: by mail-yb1-f177.google.com with SMTP id a3so5742183ybg.5 for ; Sun, 15 May 2022 19:46:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Qs6KzmNvqi948FGwp/fLhqN7zczHoIBbeoB+SvqJ72Y=; b=BCnP2xhE6Ob/d+gt4ZTBLwa0Dtcr/c2wsmjwxm8K77+x6RvJkK0jJAT/5eUnmAAQT/ qJAd1Vy7qGoEizlwBmUqFDispatPNG9bMJqKp0AsYWSCLBiqJxA4jyuPz5z4IjxlMCCu DfLpoMaTJe+AwZvcPAMOEVO7r0++WXpzd9hDTQjdQ1BRVnFJsz+ZzJoTJrt4atjSn4Hc O6YOAj3+BfEstQEo3vF/2NcL6Vp+JA4gz0ih6VlvyZ2yK8p/jW+xxEsJlhkvQ25FORLt /nJhTCB5M80sZVl4y1VmSZIE+iM115E5AvyleTP0kkNsZhAy9jR/AUTnrCMdjvb25BDY fDSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Qs6KzmNvqi948FGwp/fLhqN7zczHoIBbeoB+SvqJ72Y=; b=GBpIoc02bC8DC56KWuu00Kz6Ovl3xEsp6tZK6yCmy2sPba6ReqzZWtYlMmEsAx8J1N HWH4iN4yIIj3bnKtMo6Qis91JngezVgrJ8cGvCxh/Q7/cNiWhEnahKHRvO4hmBp/iJ6f HxPy/Pa/aK7zJo390UXrOLrr1iAv/ZOTsn9ksi0SDx3AcX4Y7fhuKqAKi8em2a1X2Sfe XQayIUAmr2SrHDQwBtOXrXAOGdjptD+1P532rLU8Ofc5wYf6NvfsKbOHpPSEnRQTkuZK 4oTJ/6fX1AnlYTyLbrvNlfw6EPh9pMB+VeVUv0AbCl++kmKWDhDMSw/96I3fMU09bYc1 oHQg== X-Gm-Message-State: AOAM5316tTscJdKV6JDLWfPa4Kfd/5k1qvklITBq7HmLGj/m5RrG1eRy /Ib2mu8P1S5v+CYr9gWiexWnHDki3+EuxSXorp5vWg== X-Google-Smtp-Source: ABdhPJwb9h9mJYmHGsuwFhWI1uHb0LK9seKGiF0DwaqJTNtk5nU+naQY4h5vM98rjRAljFgSPt7qzYWx3iBQVaTT1Wg= X-Received: by 2002:a5b:30d:0:b0:64b:4193:7911 with SMTP id j13-20020a5b030d000000b0064b41937911mr14912687ybp.509.1652669194393; Sun, 15 May 2022 19:46:34 -0700 (PDT) MIME-Version: 1.0 References: <20220510030014.3842475-1-surenb@google.com> <20220510030014.3842475-3-surenb@google.com> In-Reply-To: From: Suren Baghdasaryan Date: Sun, 15 May 2022 19:46:23 -0700 Message-ID: Subject: Re: [PATCH 3/3] mm: delete unused MMF_OOM_VICTIM flag To: Michal Hocko Cc: Andrew Morton , David Rientjes , Matthew Wilcox , Johannes Weiner , Roman Gushchin , Minchan Kim , "Kirill A. Shutemov" , Andrea Arcangeli , Christian Brauner , Christoph Hellwig , Oleg Nesterov , David Hildenbrand , Jann Horn , Shakeel Butt , Peter Xu , John Hubbard , shuah@kernel.org, LKML , linux-mm , linux-kselftest@vger.kernel.org, kernel-team Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: 478umotn8uz5mbzcefszq4q9e3xr91nd Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=BCnP2xhE; spf=pass (imf28.hostedemail.com: domain of surenb@google.com designates 209.85.219.177 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 44281C00B8 X-HE-Tag: 1652669171-923083 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 10, 2022 at 6:08 AM Michal Hocko wrote: > > On Mon 09-05-22 20:00:14, Suren Baghdasaryan wrote: > > With the last usage of MMF_OOM_VICTIM in exit_mmap gone, this flag is > > now unused and can be removed. > > > > Signed-off-by: Suren Baghdasaryan > > LGTM > Acked-by: Michal Hocko > > One question below > [...] > > diff --git a/include/linux/sched/coredump.h b/include/linux/sched/coredump.h > > index 4d9e3a656875..746f6cb07a20 100644 > > --- a/include/linux/sched/coredump.h > > +++ b/include/linux/sched/coredump.h > > @@ -70,7 +70,6 @@ static inline int get_dumpable(struct mm_struct *mm) > > #define MMF_UNSTABLE 22 /* mm is unstable for copy_from_user */ > > #define MMF_HUGE_ZERO_PAGE 23 /* mm has ever used the global huge zero page */ > > #define MMF_DISABLE_THP 24 /* disable THP for all VMAs */ > > -#define MMF_OOM_VICTIM 25 /* mm is the oom victim */ > > #define MMF_OOM_REAP_QUEUED 26 /* mm was queued for oom_reaper */ > > #define MMF_MULTIPROCESS 27 /* mm is shared between processes */ > > Have you consider renumbering the follow up flags so that we do not have > holes in there. Nothing really important but it can confuse somebody in > the future. Missed this note until now. I will renumber the constants to avoid confusion. Thanks, Suren. > > -- > Michal Hocko > SUSE Labs