From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6838FC7EE25 for ; Fri, 9 Jun 2023 22:49:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D56D08E0005; Fri, 9 Jun 2023 18:49:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D06628E0002; Fri, 9 Jun 2023 18:49:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BCE988E0005; Fri, 9 Jun 2023 18:49:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A9F998E0002 for ; Fri, 9 Jun 2023 18:49:56 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 7255740382 for ; Fri, 9 Jun 2023 22:49:56 +0000 (UTC) X-FDA: 80884703592.30.A26169A Received: from mail-yb1-f178.google.com (mail-yb1-f178.google.com [209.85.219.178]) by imf07.hostedemail.com (Postfix) with ESMTP id 9C8D940019 for ; Fri, 9 Jun 2023 22:49:54 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=xQzU3Qbe; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf07.hostedemail.com: domain of surenb@google.com designates 209.85.219.178 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686350994; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=I7LcE7DmhrKMXXWImGgQOysWtlJyoq2oM0rOKEdtOQ4=; b=GpEH4CSf5D8crEY3hEUFTwtkCjPzJGqIdmJb4GecwhcBQaWCmLUPF68t6lXa3CGoCEr+Xl BlbOLZV3icrbQtBoGSa9s0+AKqauMH+iSPR9pAxAXfbZnMIzadZ9b87cGhY/URSxOoYnXM VnhPDKx//tbKGhceyJO9bWboFczI38Y= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=xQzU3Qbe; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf07.hostedemail.com: domain of surenb@google.com designates 209.85.219.178 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686350994; a=rsa-sha256; cv=none; b=bu50XoqYkziI7VsUUEiltKyw+x4lveKVaxIOYBA26ad3ZHvkvRLtVr4Z2NhGNFyGvs2AEs s3XasfAQrPGmfk2KLa3LmI0yK0ep/cnjowWFzHAsLDIeFYffp7B75yYrgXuzfc8ar4CfeF cg1iZT+HT4rtCMgCmBtJFR8YrBMWyes= Received: by mail-yb1-f178.google.com with SMTP id 3f1490d57ef6-bb2ffa1e235so2113288276.0 for ; Fri, 09 Jun 2023 15:49:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1686350993; x=1688942993; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=I7LcE7DmhrKMXXWImGgQOysWtlJyoq2oM0rOKEdtOQ4=; b=xQzU3QbeUFY9kXkPMqupSx1mbwmp8HY7Gjsko+d4ljRkOYSFYYoBCKiqBD+K0e64x7 OQKiO89c4ipJHDAp6BE5z5tRd0+y1i6PoWloWqG5zLtk156WXfNOmAeGSS16gnVeaXZi HCUJc1bb7RwdbySv7XPzUiRwmBl0GNX4R25V/qa+CwwsZDp8JYozPrPjRgs090O+QfgS 3LiL3RU5gg97idhpJl7UGwKAl5oyho2VWzaM+Vi5v69BH8bMNabbhTlVxvQzI00rtFZ0 WWzkcOrOZlDH3SqDLxNRZWOGAMdxjG4yJv4eG0r9HwINBwc+4KFunp/Q9sH5ufhdsY2y 6S1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686350993; x=1688942993; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=I7LcE7DmhrKMXXWImGgQOysWtlJyoq2oM0rOKEdtOQ4=; b=Tu37x1x9XTTDOd/ClI/HSlKa19WshQgkkoEiRqEH8yxnqRJKnkMdTFycJmPjK1iGAm eIUoPuep8lWhoZ0HI4MfRPb2X8MV2eTUNmW6KBV1FKWkaqSnTmX9ttiAekUUIWKiLcZJ rp1Pv+BoEoWhMGltNa6BJrLQv/piKtiCHlOIbCRPITxGCPRVrgj6HiSfiMQX2YmzANwb ii0Y5vIY1yNx3QjMIWR5soP75hOpTcedytJKxsoShzXPMis939Pdb/QNl4TD4lMnjKYA 4/r/FPOGtu4JXJiA19wXpURf85gm+dxOJWbKaJhB7yLSZbOHLNpNDyXQePJ0ce/9pgq5 h0Bw== X-Gm-Message-State: AC+VfDx257BCok2wQ29L+HRW6trPaLIvLCjUkpo1wLZGElm2TNkASYzh X9fyNbaWxuCSuZg5J70TccxbSdgzqYP/6hCN6VS4tg== X-Google-Smtp-Source: ACHHUZ6mmiRZ0jv2+d2Uu570QrMziKru6AqEYGX+uEv01g69PSZikjPuqX5se+lF0xNb+xWQlic2XbN4m8dMSmAaOaQ= X-Received: by 2002:a25:df10:0:b0:bac:b478:d215 with SMTP id w16-20020a25df10000000b00bacb478d215mr2433487ybg.9.1686350993473; Fri, 09 Jun 2023 15:49:53 -0700 (PDT) MIME-Version: 1.0 References: <20230609005158.2421285-1-surenb@google.com> <20230609005158.2421285-6-surenb@google.com> In-Reply-To: From: Suren Baghdasaryan Date: Fri, 9 Jun 2023 15:49:42 -0700 Message-ID: Subject: Re: [PATCH v2 5/6] mm: implement folio wait under VMA lock To: Matthew Wilcox Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, mhocko@suse.com, josef@toxicpanda.com, jack@suse.cz, ldufour@linux.ibm.com, laurent.dufour@fr.ibm.com, michel@lespinasse.org, liam.howlett@oracle.com, jglisse@google.com, vbabka@suse.cz, minchan@google.com, dave@stgolabs.net, punit.agrawal@bytedance.com, lstoakes@gmail.com, hdanton@sina.com, apopple@nvidia.com, peterx@redhat.com, ying.huang@intel.com, david@redhat.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, pasha.tatashin@soleen.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: d8jqxr4sy6xhmirnq7onnak769wqogmn X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 9C8D940019 X-HE-Tag: 1686350994-518962 X-HE-Meta: U2FsdGVkX1+k1L3oY1i5vwf6lXEKRrYZzTzstZUlX04ZswGd1f+D6HTUR3cpWYbAX24OTOG0Qb3OZTOJEt5kfF5Uuo9j68i46+BNuanhrBDBQFs17iCwx/VwHt41++PNs6t8g4xVlsumgVSlZQMaqHyEA0EATfwUoHRJ4aC8XvDnSo4De0An8ogOh7lTXLcq6/BYE9+27ZvZK355jpzA3/0Yys3ifZTOx2C+gusE0Ymw4WZuE1qtl2JJhWaphGXwNEFsaQWVdg0lxifqfl+q5xu5oZNE0bqUDZM80BluMRUI3u6sIvQnBppS1+jq2XcMxRumxy7MRWE8ofhzoouPPM2L5WIUGTKXH7i7K9D9YLF65g2yqrwJNI0PEq2SYPVxu0W6g6EUwB6xmLpcrdXNLKqcMOf6o4zYk4s8B31cVootrSAz3ZxNy07VqTeluoNNO3jZ5IyoOIZMONnaWXNc0kZZdVVg+XAs4+FSuDtIFaQH/F6WhkezlwKGRW4R2IL2DO6+4/JljwLm4CoG8zsJWSLdOJxEebV5ssEt0qDUfVhCNM3UuS++zea/4GiZBqj7P3NFq+zbONmbKpwoBQS0nylo9X+IfBxVbSV+KjuF1hQx6EZei1wBcSYK1vS8AI21G60OqWNagWdEgim1VEcH+7GTpY8Gk1spJSmUXhZre/expoOCk+0Z/s+vy0r9FtYY+kA4AwkfjBy/KBgDw1942whDIPntRu0hm73z7nZ00wiFi7yJuwFScWFNw2C/oV0+8nX+i5IIYJw1yP9LnXejpY2eRUxYF6ZrkRX6DBPakUPSjEN+hfX63PzvXTLoxiBcfEVXRnY1r8kEO4/2/ltHE8sGlyS/1RAfxAwjOJZp2eG8+SlzVmCtdqCIHFp2xtARUb43Wm9cKEepDof3YRDnQ5Ded6j5GvuF04TAdpebqa6S2D4hl8wgn6kmrVU70tikKgJkhyAOUQlfo9Fwn68 h9zaB/ij /WwViCM3CVlkuVAvrQa4JWtXAEA6moTqLb/4b2fyGYL/fRr7WgkuFdsbIw2nvTEITLEgGpjMAwqQRNTpacITO4YsO1Pf9EnjcgRh8yuBV051psL3hRRRNU77KI0zJZmHRxgRyNkrRMA6f/rXdfzpBF4AumnGt+J5wl6l0uwfZHjXZtONwQGY8YOXvU7SuONqxrhtyZpV5CHo3NtIdExaKVRcc2k52kcbpc1yMPgp1PRfSg/YFCwxqBhoA2PBcgaCPhlOADqdjSmsOjO2X0R1eFF2xOd8iCH1507n2 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000027, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jun 9, 2023 at 12:37=E2=80=AFPM Matthew Wilcox wrote: > > On Fri, Jun 09, 2023 at 11:55:29AM -0700, Suren Baghdasaryan wrote: > > Oh, after rereading I think you are suggesting to replace > > folio_lock_or_retry()/__folio_lock_or_retry() with > > folio_lock_fault()/__folio_lock_fault(), not to add them. Is that > > right? > > Right. It only has two callers. And I'd do that before adding the > FAULT_VMA_LOCK handling to it. Got it. Will make the changes. Thanks folks for the review!