From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5DB2C4345F for ; Fri, 26 Apr 2024 03:46:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 35C806B0089; Thu, 25 Apr 2024 23:46:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2E7776B008A; Thu, 25 Apr 2024 23:46:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1D5366B009F; Thu, 25 Apr 2024 23:46:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id F02126B0089 for ; Thu, 25 Apr 2024 23:46:29 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B279D16071F for ; Fri, 26 Apr 2024 03:46:29 +0000 (UTC) X-FDA: 82050295698.19.1B4DEC7 Received: from mail-yb1-f176.google.com (mail-yb1-f176.google.com [209.85.219.176]) by imf04.hostedemail.com (Postfix) with ESMTP id ECF0240005 for ; Fri, 26 Apr 2024 03:46:27 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=nNMsyx4B; spf=pass (imf04.hostedemail.com: domain of surenb@google.com designates 209.85.219.176 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714103188; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=e1BiNqNhU+y+tI1tYv0T3j8xw4UhvzM3meLf5Vht+lc=; b=18v9e9UTjd5XidYjuwK7LUqB3zriXGvDD5+xZRjjq7SXFKYkXq0sIOmUmk/TMltFQDHi5v Rs8ES3t4EAj/T8nefFLAF0fQZZSJiJiYcWjVBxcPH0fXnFjBNVCrmBIcjLpXdhhBqo9Ho2 lRZ5omBuFwGz5YcpOJ2WIB9+R3bHoVA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714103188; a=rsa-sha256; cv=none; b=VOBz69WPrNxPaqhMrv1nIHhrNPmD6RG0Aeu4VDz9ZEufna6w+vFLYy0POU5QEqmLOdTHQU d8I3M8Tp/gQjJoK/F1m3YhvA5A/FBsyuQryFih3mBhpZsqZCiOgUAnKJN/72VogaLOjPGx 7lDiM3GDv0nJPZSN0i2CvPfD/ozCV7o= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=nNMsyx4B; spf=pass (imf04.hostedemail.com: domain of surenb@google.com designates 209.85.219.176 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-yb1-f176.google.com with SMTP id 3f1490d57ef6-dc6dcd9124bso1719853276.1 for ; Thu, 25 Apr 2024 20:46:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1714103187; x=1714707987; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=e1BiNqNhU+y+tI1tYv0T3j8xw4UhvzM3meLf5Vht+lc=; b=nNMsyx4BkRClXMsOijCQvCkPtBJoC+TuIScCWzXZZmGXNCZGr3SctWXKXWe7e1r9PF XU1XHK8bYz1GtwxrWJ5bhOn+z3xYvMvN65e0NLSGfYyBAGUp7FBf/DiIyka8IUtJtYRG OvY+HZ0qTtPZeXK8NVRmjCm+d+CsicIeWm8uqNfBBp7iNpf1l2sriq7vfkts2KNJqB6P 2FJ8glxpGkVied3QjmLwv7IQj0Z6bLC2tmcm2w6sY2TCuH7z0h2GBXdijM0JShdCTnCb B7/4aRWP/0zGMrPMnMqlRs/q4gorIYAs35bG1dQTGKqzLc0pcrBXqP77YOIce3kG87B8 VOcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714103187; x=1714707987; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=e1BiNqNhU+y+tI1tYv0T3j8xw4UhvzM3meLf5Vht+lc=; b=wn3NEgWXTiHg9hZhCdNbJSmR/GWQBobCgnHDjhd2PPRMbXye1yO/kFwmqDDrlMqpVI wMyWo4gdDySBUJsU3KEs997WINaaHhGuHjvEaPAXxYIf8Rc1Pk/MdNkliVQk5q+e5bPs 1AUxuQKo9BWVt04lVBUHJZSnepMq82WMJE7iJrHwQiak4wn+VDukcHwQ9QlxpLmgHdnJ J/vjJeC9xa6Ve4mPqogzg2k+QgbvjAaGtuD5eCpIfXq4f28EyOCK7rcVwQiy2EhwAu5w hDDCnvOZo1w6zuO3BEOEMfg4OcdBZ0lELX+Osw3P34MZFK0Jd56fOLiGNQcDQsGFOo5W s8MA== X-Forwarded-Encrypted: i=1; AJvYcCWcLxmmwpwrdObdgL55cAqY9h3uoiX1Sq7J3CIiJvR4giSqcSpIUdC11wRcWZRlLGhzwTaM3ey4pjCigziYI6yorSY= X-Gm-Message-State: AOJu0Yzrn0yfwu+kBrjfxYAYKASkoBxBwce5qVAdWGUWFNhaVKMTLMKB rVOr0QmnRPb//vrt4DHcEfhE0F0LLMN5bQG0wCaQylsIVFWSsMjV3tDt3xpcrVcg64M9aTyx/Z9 W6aK9PjXx0oyy7ptgkxi/AIwTMjKtRMaLLejA X-Google-Smtp-Source: AGHT+IHG8gnB6NwCs1Ig87OYpAz51zhJ6Ahd1omFdRNn0ihKP/xNtsMkS2kZCOMjK8QJbafJTYx+/tOH6dK5Suh45jA= X-Received: by 2002:a25:df48:0:b0:de5:49a4:8a9d with SMTP id w69-20020a25df48000000b00de549a48a9dmr1666176ybg.39.1714103186722; Thu, 25 Apr 2024 20:46:26 -0700 (PDT) MIME-Version: 1.0 References: <20240425205516.work.220-kees@kernel.org> <20240425164917.8c9603387b4cce11121024a8@linux-foundation.org> In-Reply-To: From: Suren Baghdasaryan Date: Thu, 25 Apr 2024 20:46:13 -0700 Message-ID: Subject: Re: [PATCH] mm/slub: Avoid recursive loop with kmemleak To: Kent Overstreet Cc: Andrew Morton , Kees Cook , Catalin Marinas , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: ECF0240005 X-Stat-Signature: 118a3ddg5t5be5k76spsmeb5ydsrbdct X-HE-Tag: 1714103187-627573 X-HE-Meta: U2FsdGVkX19Cf8SYz2QjDbBBBlWckIZSibsIC98VgYNptNSAkJlWfJjZFCGRF9xt5tbdujqP2skldy+ZKr5KATZOG1Kpg/fJqfUpyJZb1WE66gCTU8APSyTOXQtVQQKbgRwkFV/H9HvZTZv8saDjhci0lVpMDwcMCfZ9peZNq44k1RF8LeftsLd7ADMsAAEzDIZnGwdbqNMZ1Gaj7WoER9t1DlS5RCv2bmBCSqcOW8XBCAVoAppG/4HtR1Bq3b9sSIde0KafuKOmMYX1yTFBO/pjzbiHMVNvrptl1QOTjqdcY7cA5YrNaTqmeRXubhPKyWjtAolUPEGtO0+c2JGHJKzW5Ialg+Ca/2HNB6W07nZTxelYaK5QLZpqtmjsZN0tGOxnyVtyqadAFTAaaNcNyKafpNrgjzY5vTvF2C7op2UmRX/JiLUiQwfY6lBsTEEsblxwknnq+pgVGawIZ4vj+TDw+yZNrmCl6lyKcfPmfAzlYkRZpKnyNzWwqvSXQL7cJaKYR476F6Vc9N+38cgO/mV8Wvrji2QPxEs0CVbbHPbAFcLWNBASa7tc4EAmwXZX2MO6KUjA8kWlVpkx1rfit4mHEqpca8Wu95k61HZwNS/8hq0rKWbn4e+uj6n5bwLPIha2oPscVk0waDictF9EByUJ8QUbL1tw/ErLnNBMuTZUcGaDFHYw5q1I/tyoM2f5mfDW1rP7iJxKDJ+a5Mi6Sx667pf9dIwWjnUaVbuQoI4ijOW8ZHTjFZZjnxw0pY379XYUI/YGTeIGJ6bjyEqF8/5SqkhfBRHSDPc7I1F+PW6eGDGhHc+8XU4B41MGrTm1nIpjULOGGU4XES7TM0azK3YNLhDIS4fh7B0xyX6uVYMFAfRlL151QMaaQGR9Scuq+D2L2DFrobWKCM1LkM7i4cEcMBh2OQ+BOFf5ROXpELaDVYGmRJT7q+o+sklg9NZXQc4i21ASujrlK92m1yp sqvD8Ghu ukemz04Pz+OcDgl4YWk9+ON0afag9SS3Pre0mvVq/mQPtbKzVNAYPAz+sUE2rY0V1az93bHAnkmgEHnkD0ls09fan+0leCJch8QUoPhdQ0YXtSvpaOemfJ9hK6krcD3rkUxo67XkmH07/fKI1DAL5i+S1iApoEmwqv7sMvCZS11fm7zG7JmlMvIpG+yAfnE0UbaqUov64y+xjVpE8XwDj4ww45vXDoVlZmd51D/I99A4zEIbV7qdFXGmKDrYQua19LeyNwENh78eVwMGjrGdw9/t93z+2tEOe/LpGEnCtKEIYus51BWT0OFkVg+tIc30NNISE X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 25, 2024 at 5:19=E2=80=AFPM Kent Overstreet wrote: > > On Thu, Apr 25, 2024 at 04:49:17PM -0700, Andrew Morton wrote: > > On Thu, 25 Apr 2024 14:30:55 -0700 Suren Baghdasaryan wrote: > > > > > > > --- a/mm/kmemleak.c > > > > > +++ b/mm/kmemleak.c > > > > > @@ -463,7 +463,7 @@ static struct kmemleak_object *mem_pool_alloc= (gfp_t gfp) > > > > > > > > > > /* try the slab allocator first */ > > > > > if (object_cache) { > > > > > - object =3D kmem_cache_alloc(object_cache, gfp_kmeml= eak_mask(gfp)); > > > > > + object =3D kmem_cache_alloc_noprof(object_cache, gf= p_kmemleak_mask(gfp)); > > > > > > > > What do these get accounted to, or does this now pop a warning with > > > > CONFIG_MEM_ALLOC_PROFILING_DEBUG? > > > > > > Thanks for the fix, Kees! > > > I'll look into this recursion more closely to see if there is a bette= r > > > way to break it. As a stopgap measure seems ok to me. I also think > > > it's unlikely that one would use both tracking mechanisms on the same > > > system. > > > > I'd really like to start building mm-stable without having to route > > around memprofiling. How about I include Kees's patch in that for now? > > Agreed Yes, please. When I figure out a better way, I'll post a separate patch. Th= anks!