From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41950C6FA8E for ; Fri, 3 Mar 2023 01:34:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 63AD76B0071; Thu, 2 Mar 2023 20:34:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5EA826B0072; Thu, 2 Mar 2023 20:34:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 48B016B0073; Thu, 2 Mar 2023 20:34:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 388C36B0071 for ; Thu, 2 Mar 2023 20:34:47 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 02299141199 for ; Fri, 3 Mar 2023 01:34:46 +0000 (UTC) X-FDA: 80525867814.19.D2E08F6 Received: from mail-yw1-f171.google.com (mail-yw1-f171.google.com [209.85.128.171]) by imf20.hostedemail.com (Postfix) with ESMTP id 355801C000F for ; Fri, 3 Mar 2023 01:34:45 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=Fu9U55wx; spf=pass (imf20.hostedemail.com: domain of surenb@google.com designates 209.85.128.171 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677807285; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TciFh9FdyF3mrNIuO70cM61gX9uwhyReNw+Gw2pRUPA=; b=xiGz0hLEygaudPY/h+S/EM2Dg7ZFyZmSOPzCKH6hS06SM0eMBfG9cj7CKXhXuRryFNKXSw 2z6ZbbTVZy31deQqVJvDNYARrq8w7LjcDxAwnqoxvjp6MA1o4RnnvttjMUqNKjLn1wYRpO Fcl58s1MwC9xVxwcCv7F/E31oWuawRo= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=Fu9U55wx; spf=pass (imf20.hostedemail.com: domain of surenb@google.com designates 209.85.128.171 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677807285; a=rsa-sha256; cv=none; b=OZq3pYLtswlE7kg7wjdxH/Cw3aGbJWkCibmI5s4YAsGbuheqdDLvvdUife5kuXOi+yQyPX CQSQiV0H2b0qsEnpBp1naWHXohhM/CBASzaJZS/9iNHQ4838rspa0Q8XfCNDmrsnooeXzW otZZhdSCTKpKwVL/BXCvrj3tlAAMcoE= Received: by mail-yw1-f171.google.com with SMTP id 00721157ae682-53cb9ac9470so15816777b3.10 for ; Thu, 02 Mar 2023 17:34:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1677807284; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=TciFh9FdyF3mrNIuO70cM61gX9uwhyReNw+Gw2pRUPA=; b=Fu9U55wxTCLtEXaKgOYnyEQH6o/knLUeIWIORmIAitVZwfQOux0uTJ7B66Lcq0ckLn DnaiYkrXI1vYlCgghAucupoHiJLokhAsINv3RZQOUyxdPAalX4v/jrQ0u6/kLfDotIq9 fLpMNArb7teZwLpvE7yeMPSDWGi9TR9ae2CG3WWhAqSW7EINvX/f7irqODYobdS+zhBJ a7ooWCbNGLmh3/Gc2gFtAmGd5kUxNiekAbwj6joc0NC1oS5J6bD3OPBdhvO9gsTQ0ite jNjMWQ4waHcWsNugjOXd04kipv5Kdf3uEMBA3Jbr551AWQN/ktqXyvrMm6S4Ke4LZV0c 2yuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677807284; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TciFh9FdyF3mrNIuO70cM61gX9uwhyReNw+Gw2pRUPA=; b=3PzoaOdmM92EIZZkVIO+mKT7iqfGHm7W3QQQXK1/saFNA6B78IbH7OPmrXPd91KWN5 KBxtx93Na7ZlD5x7GsnvLAQnmIVxOhNa74meWgPCZtaciVv4LXE3dMVHwSeJ+Ww4Edxy 9300D0bstnBTgfRprqu0aLaktcMgdq+gxhFj2eovW8Diq92monbrOSkEQ27MZ6XsnEer WK6ozLdRNAXWeMyL3KSd6aQWv1VfqZRGo+8oXz/x5sLvNBoPhgo80z8M/PCxG+3KUn3V MzeNdBz9Jk7WRWWbyX+voqacxa1ka/tI9JxcNNXXwjjLnTtvuh84i1e/uUqydolrhVBX lebg== X-Gm-Message-State: AO0yUKWH5Vt3cl6aLButDkQI/yVPtOt3ihALJxA2hRrwIuQz195LKx0K 7poABvmkMfYdtalwfW2pTA5RRkIjWsLVy7aE6hWIMg== X-Google-Smtp-Source: AK7set8EWcUQluqN8WKHq8/XSmKUp/RVBAW+c+8SuNyz0OuOQxujuvEHXp6QWVS8hEOwj7mZluNQW9cmwuljgEcX14A= X-Received: by 2002:a81:ac51:0:b0:53c:6fda:b469 with SMTP id z17-20020a81ac51000000b0053c6fdab469mr4635252ywj.0.1677807284013; Thu, 02 Mar 2023 17:34:44 -0800 (PST) MIME-Version: 1.0 References: <20230301190457.1498985-1-surenb@google.com> <31a88065-063a-727e-52fd-9fbc7d17fb5c@redhat.com> In-Reply-To: <31a88065-063a-727e-52fd-9fbc7d17fb5c@redhat.com> From: Suren Baghdasaryan Date: Thu, 2 Mar 2023 17:34:33 -0800 Message-ID: Subject: Re: [PATCH 1/1] mm/nommu: remove unnecessary VMA locking To: David Hildenbrand Cc: akpm@linux-foundation.org, michel@lespinasse.org, jglisse@google.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@techsingularity.net, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, peterz@infradead.org, ldufour@linux.ibm.com, paulmck@kernel.org, mingo@redhat.com, will@kernel.org, luto@kernel.org, songliubraving@fb.com, peterx@redhat.com, dhowells@redhat.com, hughd@google.com, bigeasy@linutronix.de, kent.overstreet@linux.dev, punit.agrawal@bytedance.com, lstoakes@gmail.com, peterjung1337@gmail.com, rientjes@google.com, chriscli@google.com, axelrasmussen@google.com, joelaf@google.com, minchan@google.com, rppt@kernel.org, jannh@google.com, shakeelb@google.com, tatashin@google.com, edumazet@google.com, gthelen@google.com, gurua@google.com, arjunroy@google.com, soheil@google.com, leewalsh@google.com, posk@google.com, michalechner92@googlemail.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com, Hyeonggon Yoo <42.hyeyoo@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 355801C000F X-Stat-Signature: 6cs7f887kco13rk3ibj5i13cmk8kwsqz X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1677807285-917401 X-HE-Meta: U2FsdGVkX18HF0l7qlrrqOjJd9HGw9dFR07nkKU0zg5ZuFjJZT8C2AOZoLcA3n6oho9na92cRx8FXlSgtUlx1c4lnKtZPEUcMURicMdf746NsZpw6WuUNjT0pZIzPYFaYJfLLkQjPO7Vm+pDPFzDFAiiA7ZeqJB7WfIuolXrAggNEZfa9yDupObgmGAgHGX7lOEBKTBmT9FLL/G3hwhOvSJvdineRy8F0/sDl1z7GNaFbzPMi3+6qeVn2okBeT4h49i9zwwVCbo+cxQpa3vDq6nahTAUH25UK165FbKZHw+Hr53cnvUK6QpP+VSdzTm+mP4CYhilDkaQKXmA4ucuwHJ48BFZLsF75H1/dW6+bQCG17Zyw7cCZGM+tTZpMA6Rr5uDr5Opl1pVvOaV4l7oN6Q4U3Buu1FsEJRt6kgIRbFzsn2dIw9yDKEeu5sdGDDtxXWWkeB4dGnkjByxrmaoLE6C004/Mnbx6GVR4yHCQT32U6wzeOuVhEw4qLTdTMwqeFXzxBIuya6oh3bqFizhZ82qHEiZ2eDAg+L2B5AssW49NIEKn14kgR1KPweBUg/zdHhsudQ0cDtEZO6/o+vBkMgmvcxxxZOChvPJZ5WVvuTZkjt+uCeD6POYylq/sTtpaR7avlXAjRwcsBqW7LAQHmKHTj0xg+b3WoQYsEf42o90lKTLU819h4jYMmhMTAZ2Y6ZIrSli7QOPSCcQ2rntLwE09doUQfcHidyAj5Wi1gpUHvP1LdLvEtZQbdV0ifhBRLuPg7irkbr1OJmZTkBfWWmN3tKjbo3rGiuvahLPzFw2Vfc1/7/MXPCT/i7Ozlwe+/l2/AV4CoZ784IM2pdq/XoE34aQ4LFaeH2Jo2kL0t+wGEfF6AsdYuc7UESgSyo0xupxWNIzn5BNpBGH/REj2gELYvgAPCENpzgjT3kG9TZ09UNqgSXR+k0xOkUzms5ksxVeKd3jZPTUQYI5Irn owQWoj7u e9+W42equfYGSQ101obne+PYKks0hE3mzzANPyhpPztRRXtB0jfa/2JPMwT0Su5UDkVvJbaaPzg+rM/L80jwWr2S9CBGkk+jGYjiDR374d406gxVMoS0cA9mOdTKHRm0vjGhBu2aaLap2rStgnr4EGLH3gc7uO1mcOZpPD4kvIplO1838GgjpPgTTj8UPNru81H0bgT7eNgURFfQuV53+Ma6CUrNkHRrNoJ7LqxWKcklsmr4KuffA+68EhJ6wfNTbxIrCeoIhmPu4QOJkwt1kNuSdgf+Q7MbAoD8BvrOWOIPMADJK4BU5zTDjogemCyeV1l+6UnJgBX0quHLPfpIopFNo1sZYqrlOLxmoMAyoAO2O4eS2DSOg/DyfFDbitJ5wcJDygvQ7Gj5lDmue0H0hWqFQaCB6zBBy/90v6cBF4SQ22F+xmhVtDn04vUwmtL03ElY4 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 2, 2023 at 1:41=E2=80=AFAM David Hildenbrand = wrote: > > On 01.03.23 20:04, Suren Baghdasaryan wrote: > > Since CONFIG_PER_VMA_LOCK depends on CONFIG_MMU, the changes in nommu > > are not needed. Remove them. > > > > Fixes: bad94decd6a4 ("mm: write-lock VMAs before removing them from VMA= tree") > > Reported-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> > > Link: https://lore.kernel.org/all/Y%2F8CJQGNuMUTdLwP@localhost/ > > Signed-off-by: Suren Baghdasaryan > > --- > > Fix cleanly applies over mm-unstable, SHA in "Fixes" is from that tree. > > > > mm/nommu.c | 5 ----- > > 1 file changed, 5 deletions(-) > > > > diff --git a/mm/nommu.c b/mm/nommu.c > > index 2ab162d773e2..57ba243c6a37 100644 > > --- a/mm/nommu.c > > +++ b/mm/nommu.c > > @@ -588,7 +588,6 @@ static int delete_vma_from_mm(struct vm_area_struct= *vma) > > current->pid); > > return -ENOMEM; > > } > > - vma_start_write(vma); > > cleanup_vma_from_mm(vma); > > > > /* remove from the MM's tree and list */ > > @@ -1520,10 +1519,6 @@ void exit_mmap(struct mm_struct *mm) > > */ > > mmap_write_lock(mm); > > for_each_vma(vmi, vma) { > > - /* > > - * No need to lock VMA because this is the only mm user a= nd no > > - * page fault handled can race with it. > > - */ > > cleanup_vma_from_mm(vma); > > delete_vma(mm, vma); > > cond_resched(); > > So, i assume this should be squashed. Yes, that would be best. > > Reviewed-by: David Hildenbrand Thanks1 > > > Just a general comment: usually, if review of the original series is > still going on, it makes a lot more sense to raise such things in the > original series so the author can fixup while things are still in > mm-unstable. Once the series is in mm-stable, it's a different story. In > that case, it is usually good to have the mail subjects be something > like "[PATCH mm-stable 1/1] ...". Ok... For my education, do you mean the title of this patch should somehow reflect that it should be folded into the original patch? Just trying to understand the actionable item here. How would you change this patch when posting for mm-unstable and for mm-stable? Thanks, Suren. > > -- > Thanks, > > David / dhildenb >