From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE02AC46467 for ; Thu, 5 Jan 2023 02:40:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E6E2D8E0002; Wed, 4 Jan 2023 21:40:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E1C588E0001; Wed, 4 Jan 2023 21:40:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D0B258E0002; Wed, 4 Jan 2023 21:40:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id C28A58E0001 for ; Wed, 4 Jan 2023 21:40:06 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 8BB25C01C9 for ; Thu, 5 Jan 2023 02:40:06 +0000 (UTC) X-FDA: 80319190812.09.8582FA8 Received: from mail-yb1-f173.google.com (mail-yb1-f173.google.com [209.85.219.173]) by imf01.hostedemail.com (Postfix) with ESMTP id 0EF2140004 for ; Thu, 5 Jan 2023 02:40:04 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=ry6suVAF; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf01.hostedemail.com: domain of surenb@google.com designates 209.85.219.173 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672886405; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jivoQc2woQPramQotU+YPnz3UFl237gizCTwDukUUbs=; b=hk+Z/a8sav+pAyMxAumL7+YX/ZGx3agZ9ayKcaw4D7hjOYRnwrjQyGKoXGCdLuTXG1NPG7 zOhgjYHXoaepS16/GcoWRbOvtO/V9GiCRCf7HoG+clasXJDRJSRta4El9DLQMPUzGLNz61 TR8nKp593revoiSlswH9w3Zof+sMyXU= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=ry6suVAF; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf01.hostedemail.com: domain of surenb@google.com designates 209.85.219.173 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672886405; a=rsa-sha256; cv=none; b=FNtJk903Y9lo3HMcn9xB/ibZsbHv1F5fwCtYNd8S+uQB8RMTg18Z/mHZMHhP8ZFo1KsjU/ a22YHMmSDFkL7ADrkO2c0io/MP9Ou+8arDXZHHIWz26DkXu1lAGSg6CUj4jPEwDh3pK6My 2nj6xcqyLoRAHRI5n/YiH4qWJXCQj2I= Received: by mail-yb1-f173.google.com with SMTP id c124so38675523ybb.13 for ; Wed, 04 Jan 2023 18:40:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=jivoQc2woQPramQotU+YPnz3UFl237gizCTwDukUUbs=; b=ry6suVAFcuV/DnG/4idnIZfAPuKPQ814PqIiXu4P9Dc0MqkOjn0AKKk820/uGfrUa4 lYwBTXdKbMtJyJeF8Ansqm8CL+ioyemnqP7I0HIMJDMeNNvW5OkB/7csT/ZisXRX+hSG +xaYAICRVp8lGySMbU1YrmfONyu/oWVeM0g2dEjdj2EJ0vtoWtZ+dBlHHW+ovYV5+A/4 u/+n5dwUWeC7ny6NKjanbvD9uZqm1WFbbKtRzlbOAluksAH8C1eNjA6bkLInkPF4dzur 4P4KjPGT4iFWD4jOYbwIUtKhb5uTakvk3xr0SD9BWQKSxh3lg5fnOsZPBMgMoJii2E4P qTJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jivoQc2woQPramQotU+YPnz3UFl237gizCTwDukUUbs=; b=kshT3XIP+mkqPMKJKHmPYQDVId8Vs9Qep9FhMITaJWyPcMFCa6m6dxkdVJl+ncuqoR W6hA8OaNNQ/HfVlwSvJBFNDpOfa8+vXPdaAa3cLaZtFcEdM09AWxyvxvxq7uYHmhanQh 03UskWj69+rxVTsnOqh4vpCbf9ooyYLT06LF+rqWrJ51Va7ics37b8uqwhn2eUpkJGun hhRxpkQgn0VYpj32oy3DMhrqZX/7HRLPrXQUNzxaRRAW6ice+NY+ZcUjGI5+w2QVmYol EfxKKdU0mDUytr18GxvmNOjwnXwIUSd1u7E/8cd3OsDvuIdydlh/WIoRu2UIA2lFF7R5 F0pA== X-Gm-Message-State: AFqh2kpRCfMZXD8TLZHRt778XH4b6Mg449cuXFfpbk1Vqtxri/VEwTIF zgYWtVcPIEPCnQOvW7VyggRO27avc7bV8XkSzGn/vA== X-Google-Smtp-Source: AMrXdXtGu2OExyoviE5XN80kc7xrpXydmX05/zdQc8IHa1Nqz9/qzpMXh6LqML/0BnJ5IO2liAQbKdowK5tGlGPIrnE= X-Received: by 2002:a25:abb1:0:b0:701:c58:f01e with SMTP id v46-20020a25abb1000000b007010c58f01emr4405036ybi.59.1672886403930; Wed, 04 Jan 2023 18:40:03 -0800 (PST) MIME-Version: 1.0 References: <20230105000241.1450843-1-surenb@google.com> <20230104173855.48e8734a25c08d7d7587d508@linux-foundation.org> In-Reply-To: <20230104173855.48e8734a25c08d7d7587d508@linux-foundation.org> From: Suren Baghdasaryan Date: Wed, 4 Jan 2023 18:39:52 -0800 Message-ID: Subject: Re: [PATCH v2 1/1] mm: fix vma->anon_name memory leak for anonymous shmem VMAs To: Andrew Morton Cc: hughd@google.com, hannes@cmpxchg.org, david@redhat.com, vincent.whitchurch@axis.com, seanjc@google.com, rppt@kernel.org, shy828301@gmail.com, pasha.tatashin@soleen.com, paul.gortmaker@windriver.com, peterx@redhat.com, vbabka@suse.cz, Liam.Howlett@oracle.com, ccross@google.com, willy@infradead.org, arnd@arndb.de, cgel.zte@gmail.com, yuzhao@google.com, bagasdotme@gmail.com, suleiman@google.com, steven@liquorix.net, heftig@archlinux.org, cuigaosheng1@huawei.com, kirill@shutemov.name, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, syzbot+91edf9178386a07d06a7@syzkaller.appspotmail.com Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 0EF2140004 X-Stat-Signature: pqhwh7w8ucd7korx1upxejex9dqeep9u X-HE-Tag: 1672886404-811305 X-HE-Meta: U2FsdGVkX1/lPHlvmIrL7pMX7KLHNHtrGmFBgGnPleJi48m2xA1Hd3qz/dGm1e+3Gm8ksZdf8ImPQ2lRDd30Oh8MeA4A5Cq43QKCHVI8jLWqUzU7+oZ44HdVQiM1gs0tZdI7IAwROslIMTKMNcLWrklay+gTUU+cvLUS3fLmQpqJJSLFA10jTvcUZ5+tPuLINi+RzVjmr9x49Wo2yesGkLJNCNmzoPIXGXLS9Y1jIKWYXNEBBld1fIAXSvYxLk2MpJt3741klM27j0E5WPds0XvAuExGh+sVuZpyQQtogQ4iKMnG5jE46zNv1Y1B/bAqCjpV+7TUNZoowOsFKS7hVDWqoeGygtJ0ByovJGGvupontTPKsSM8EUfBHOmwxq9fBvxpEw9HwqTWVD4tAc6T8S8jSG1ZbUTXEJG+NuzjyLyWKfGoWVlGz7CXxHJgWYkt7lLSZzjDxo+xjdP5HElJAR7kplyobP/JaMrWxA7SdQ87NTgtC/Atv+uK8U2iLk0HnbH/NQJa8G02bZLou5E0MtUX3WJzvN6uNETALHqc4z6IeuzsQmScsCPGxPe69my6eNCVpzAr1o4xn+VWGRGqw8QJA9gUB+Z9K5jhGKny/cFpTTolDJsyWfNeEQ4OCboc2U16BiO8gAYEF2bTGBoKXoamypWdANCCBLl0OGyOXN2fiNvkV4bDlwzqdvOt5TThwNCvsEDIDDtXWjqGuSlkZc4rFFQD0wU8NvNsc9K0cIoXWp6p9eqh55cp2NMMawv6Q2CLmhofmiwQmYMttRcqKTHDzgfiDT2ukAk26Pz0O2C6S8prGv5+hlJ3q6ITlkVc0WxVZSxIUm9JZA/PwdQaEoPRQhdNagHPQrJXWhuUTkCc+DIAbWxXqU3RwMUFtllcW1HSp/XNohDXUYfGRR6aUgF15R1BRx3a4sRAFLL1G7xl2ShWjinSuCJ/RwDgGHAF/QElfdXgD9tgPrrUW+C waPAYZgm tiX5u1XLdLUxW4jLv5ZUQlX0cIhmUBg2AcoWLjt/7DxvQQImCYE944XG0KNDbvzExivyxTR8Lt+CEoGzr9KOPaXwusqpOCFokSwL2D3mPPddRDmRSC0kmfzn1U9NCREQ0NDKhklTU1dgg/bJozTy46jHe9zfm/LcynODO X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jan 4, 2023 at 5:38 PM Andrew Morton wrote: > > On Wed, 4 Jan 2023 16:02:40 -0800 Suren Baghdasaryan wrote: > > > free_anon_vma_name() is missing a check for anonymous shmem VMA which > > leads to a memory leak due to refcount not being dropped. Fix this by > > calling anon_vma_name_put() unconditionally. It will free vma->anon_name > > whenever it's non-NULL. > > > > Fixes: d09e8ca6cb93 ("mm: anonymous shared memory naming") > > A cc:stable is appropriate here, yes? Hmm. The patch we are fixing here was merged in 6.2-rc1. Should I CC stable to fix the previous -rc branch?