From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9185DD15DB2 for ; Mon, 21 Oct 2024 15:41:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C68916B0082; Mon, 21 Oct 2024 11:41:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BF1CE6B0083; Mon, 21 Oct 2024 11:41:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A6B116B0085; Mon, 21 Oct 2024 11:41:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 86DEE6B0082 for ; Mon, 21 Oct 2024 11:41:14 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id EFB3D8058F for ; Mon, 21 Oct 2024 15:41:00 +0000 (UTC) X-FDA: 82698022974.11.104A11E Received: from mail-qt1-f172.google.com (mail-qt1-f172.google.com [209.85.160.172]) by imf10.hostedemail.com (Postfix) with ESMTP id C9F09C0003 for ; Mon, 21 Oct 2024 15:41:05 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=QkSxTM7p; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf10.hostedemail.com: domain of surenb@google.com designates 209.85.160.172 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729525222; a=rsa-sha256; cv=none; b=CMMO2rQCf3/vqHgum/IHwuc+14aS7tADEkU2WfEuAQRftnk2zS+rKzsuznK6YUeTDGcHJN ScYFOPh5i8Pk8SFnYKBqM2bN16YCk8iLSNZ4zIxGsClneIbhQPNO4ZuULISk21nBk69OXd JFlZl3FUux2x9OVkD4I3e8y5Vx7Y9PA= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=QkSxTM7p; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf10.hostedemail.com: domain of surenb@google.com designates 209.85.160.172 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729525222; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QgCvodO46hTTI5gZ6i2TOnJZBpE8dcVMjVLVj2nnCnQ=; b=HVLTb/v6zTnPWC83SM2HfAz/MZmBAF/3A7YcizfO8gEPeaJzswKL8b/DF95Ak/Jx9EZHl1 F6ljCrruVWlldwVZjuXD/tN4aBxISIvCeNkRbKbAz5Nv8CeyuGlgosieZBSWpVfWlb71d1 T51Zy+xbTxFxcGGxyOH8ZXvOTS3+9v0= Received: by mail-qt1-f172.google.com with SMTP id d75a77b69052e-460a8d1a9b7so337181cf.1 for ; Mon, 21 Oct 2024 08:41:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1729525271; x=1730130071; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=QgCvodO46hTTI5gZ6i2TOnJZBpE8dcVMjVLVj2nnCnQ=; b=QkSxTM7px6D9RxJmgCFL3UHnmsqDkrdJuI6pRzfVlmVpQCmCjSX6ZCvLHGPNMd5cyN iOP9UcKGPE5sCnRxZFANnakfR/2cJNF3dPiUlehJLfq+2S2DHYgMGzMT7Feg9OGUgGXz 5Gpu6G8Ikc5QaKgwyEMobp7Y4cnoEIAskxkhgJDjvyM1KyuYHEhIp1yu4gmosUQv34AX gOmeuyxAp0sWSe+NSZju16a81u/mNMEIq5yJSXoyJc/u/itSGCZEJG+lXj75h7v3hSsY 4WgdwVjGgRxdlYWVQE/cz0bqDLEurAeB8tg4rm1K2YjuJCtAsFnA2kLeBY67fNKQgvss kekA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729525271; x=1730130071; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QgCvodO46hTTI5gZ6i2TOnJZBpE8dcVMjVLVj2nnCnQ=; b=ZpKHh7ejFCrDkdAXK5/xrJZWbjgMcWfouZ0HSKDROpSw2YUkD6Y/uJk7IWESi2oS1w 4a5fZEaZc6BPCJfLSwOvPvQEOhxkHdtkvq8G8UhRw8J0yTe7n1sabUlMeWZ5lI7oXNC+ LQuDJ3Nb4xhBd1sBVkWy50mlFRcAzi43HQKmv7aJkn2I0eSvKxlVUZ8h4RiSA4iZ3Wbl KSpOCdBKxGK4vFZzJf2ajJ2BDtHfUzkEneid7x8wD9d8MXX+7Lr9NMfI2LMypeJD4zyW IVtwE4iDrigoCFI7UC2RPUjG6qU5XvCk2M+27utdSUY+eHN4/rSNoGrLoJLO/Cv7l193 BmPg== X-Forwarded-Encrypted: i=1; AJvYcCXqDOpzdnlfpL/E2QOaojuEZaTqH53ZIkdjvHGgGflrxdljfLSpCNOqac1Eyq6YyvwLa4LtwPEAXg==@kvack.org X-Gm-Message-State: AOJu0YztcphFvJPu0LgQwr/SoFip2rrJIsamN/XayjX5Rc3V7v9ubMuk bns5a8t4OpI8+Al8oW9T8Xn6Yc8ESuUFhrj7F1Q1rJKBXT7tp7gsnKJIf3MfmxDLQsnH3u6e1It 13GGX6fqUQIzCX50rd8j0DRuYvortzY4qHeO2 X-Google-Smtp-Source: AGHT+IExtPufc3i1BL5ORPSIurwCGrgj6wuZl2/Fc9n60P6WgQQhEtufE2gQBIUUvs6EKf6872QUIbUZidcdeHoRLZY= X-Received: by 2002:ac8:5742:0:b0:460:900e:d6f2 with SMTP id d75a77b69052e-460be412160mr3854491cf.1.1729525271200; Mon, 21 Oct 2024 08:41:11 -0700 (PDT) MIME-Version: 1.0 References: <9c81a8bb-18e5-4851-9925-769bf8535e46@redhat.com> <62a7eb3f-fb27-43f4-8365-0fa0456c2f01@redhat.com> In-Reply-To: From: Suren Baghdasaryan Date: Mon, 21 Oct 2024 08:41:00 -0700 Message-ID: Subject: Re: [PATCH v3 5/5] alloc_tag: config to store page allocation tag refs in page flags To: Michal Hocko Cc: David Hildenbrand , John Hubbard , Yosry Ahmed , akpm@linux-foundation.org, kent.overstreet@linux.dev, corbet@lwn.net, arnd@arndb.de, mcgrof@kernel.org, rppt@kernel.org, paulmck@kernel.org, thuth@redhat.com, tglx@linutronix.de, bp@alien8.de, xiongwei.song@windriver.com, ardb@kernel.org, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, pasha.tatashin@soleen.com, souravpanda@google.com, keescook@chromium.org, dennis@kernel.org, yuzhao@google.com, vvvvvv@google.com, rostedt@goodmis.org, iamjoonsoo.kim@lge.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kernel-team@android.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: C9F09C0003 X-Rspamd-Server: rspam01 X-Stat-Signature: y7pfzaiskh4q183b8gdcjjasqrbrsxbj X-HE-Tag: 1729525265-591708 X-HE-Meta: U2FsdGVkX1+goVF01ZrQAo41pyyNBslxeeEEUljCdgIidbpmAYww1bOVj+Dt3muXJax8MG/ThR4cvcI2HIrsk4C/kPinE7Rx/6AfzarGBKh4/56JvgzfRiYagtgEbxyNNsiMBu/Tb8UsLzdfiTbMNrKRUhoixDVIs7ouSGhpvUDesjQ6flHVx2RYKIlVxMA6vserOht1JmdFYukgBkeqAI73Ne/pNqCB9oUp3ncnayi8YLEyYaCFjaBQNuaZMcQ8NK3ZrGcB3CKIKlvaZl5ASU/vbAfYcjlDvpeXA2j+whEGYK9JFqqx3HZL7BIDpEy+mJs9QkqTqihb0gUXRP+v7CsFV1ukjfxlyJ7x1G5g7xlgyNGEAnBsFP4j+lQPNUbQh/swourRLuWfqHNZDF3VogD2jUOaYpkV57UMSivvq5Am2hOvj3QDLtDwPdWfZVw/iR/WWnYKTbOuceIZg6Zrj+FnBGRy+RZmE3IwKIHhPhu6PdHo8Qa+W0L+19jOlfkK1JEVkIMIkyKG40YZEBk6a2iSvBjm8HIWPf7ei7PJyKQS3ODzUdbJx67jWQyNdaFee4HQkyHR19BE9RfD2Fa/a4pdhOaSjQ7D40hFOCv8eQJFX3NvRjbNQBr9nrlqwJ5M9XYdwiKx+mE39ACbA2OYkjQUF+4bG+mVcGnvbAH1kjE++noWO0yk7l3RaJCssP0qf4CwnERqkvVXo0PU2TBk/ZjLjIBePhejpyvQmqg6eu/yp1WJeMt+Yr5BvaHg4XCVdlUq4it9+UWfpXPfdYal5jbbVx1T/CN+ona48K+y3fpgH5lxdj1ujVee5fgVpRYhPsgNpqBA5j9LYLd2kuiIpWnmY0HDDugt/WcqmEBy0794mYpj7c/k872PsuorVV4gOh5xHABhqbQWa1L+HgUThmTZYCkKiQ+aPG2S7IzbGApmfnI0mMVoo9l6p6/4WStTXyh3+mT9caGEF4nSiDr iLCcxPAl WQJjlJuleeIcOPpyvcyM2jkDeYXdP6kmeX91QzML4IILpGPxbwqy87f9XGm6xmxRhuNP9MrSEn/KgQpPAfrykgXdzbHsCuOWspMR/z6adgAOCenIC49dh10IWKB/wzukCQkkTXweMNWip4dnKNVBDQ0oigTMbFf2DghIZg9hLOIonJl9Z2RwA6lVUSONTlcDbeCjFvCtlbYKD5t10i7/PpA3nT0S0ScIBDWjPoGpQ3CDqvVhGPGQ46FGXjEBYRV62W9IEVEOuNS6M2XKV30HJZRHQKqX5IDuGQoxrYQyDrFv0NNw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Oct 21, 2024 at 8:34=E2=80=AFAM Michal Hocko wrot= e: > > On Mon 21-10-24 08:05:16, Suren Baghdasaryan wrote: > [...] > > Yeah, I thought about adding new values to "mem_profiling" but it's a > > bit complicated. Today it's a tristate: > > > > mem_profiling=3D0|1|never > > > > 0/1 means we disable/enable memory profiling by default but the user > > can enable it at runtime using a sysctl. This means that we enable > > page_ext at boot even when it's set to 0. > > "never" means we do not enable page_ext, memory profiling is disabled > > and sysctl to enable it will not be exposed. Used when a distribution > > has CONFIG_MEM_ALLOC_PROFILING=3Dy but the user does not use it and doe= s > > not want to waste memory on enabling page_ext. > > > > I can add another option like "pgflags" but then it also needs to > > specify whether we should enable or disable profiling by default > > (similar to 0|1 for page_ext mode). IOW we will need to encode also > > the default state we want. Something like this: > > > > mem_profiling=3D0|1|never|pgflags_on|pgflags_off > > > > Would this be acceptable? > > Isn't this overcomplicating it? Why cannot you simply go with > mem_profiling=3D{0|never|1}[,$YOUR_OPTIONS] > > While $YOUR_OPTIONS could be compress,fallback,ponies and it would apply > or just be ignored if that is not applicable. Oh, you mean having 2 parts in the parameter with supported options being: mem_profiling=3Dnever mem_profiling=3D0 mem_profiling=3D1 mem_profiling=3D0,pgflags mem_profiling=3D1,pgflags Did I understand correctly? If so then yes, this should work. > -- > Michal Hocko > SUSE Labs