From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28EBCC3DA78 for ; Tue, 17 Jan 2023 21:09:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B32D46B0074; Tue, 17 Jan 2023 16:09:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AE3396B0075; Tue, 17 Jan 2023 16:09:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 984CB6B0078; Tue, 17 Jan 2023 16:09:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8B0B56B0074 for ; Tue, 17 Jan 2023 16:09:36 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 5E72D1407C8 for ; Tue, 17 Jan 2023 21:09:36 +0000 (UTC) X-FDA: 80365532352.22.6FAE2B2 Received: from mail-yb1-f179.google.com (mail-yb1-f179.google.com [209.85.219.179]) by imf06.hostedemail.com (Postfix) with ESMTP id B515718001D for ; Tue, 17 Jan 2023 21:09:34 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=mTi6Cm+r; spf=pass (imf06.hostedemail.com: domain of surenb@google.com designates 209.85.219.179 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673989774; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=E1pw3vOO82Ds9w0163Mtmi7QOVEF9Qab6422FSilTSc=; b=ll2MpJ/czrNa+SdBzRtxiRUrB2loH+AXCgoCfXyAmRZUD+H/J79L60RmlrnNEixYn64I5h ms26UtdCoGAvBFCEfMEtXYkrHCZSk618xZeRlN0Znx9x7XnR4/0UazcMYlxlv7Q4KFIKfm cTOyMj9P5quzNiPqaF2tQW4lfRP/06Q= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=mTi6Cm+r; spf=pass (imf06.hostedemail.com: domain of surenb@google.com designates 209.85.219.179 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673989774; a=rsa-sha256; cv=none; b=SMfwhA189/fZK4IBcFlzRwgYRpEh3belqS+B/ZRzUnfYOY8EBW2XZ3gZsqlu9v4ws4wIU/ 9oNX0nzlGjQrDccBCuExlD5aUyKo93+8kmMo3Q/+c9doxlndBmvOsvVsYiNHa4YkG20L6q NpJcm6p84QLt7NUx/YwfZd/3TzcdGgs= Received: by mail-yb1-f179.google.com with SMTP id e202so12350154ybh.11 for ; Tue, 17 Jan 2023 13:09:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=E1pw3vOO82Ds9w0163Mtmi7QOVEF9Qab6422FSilTSc=; b=mTi6Cm+rzRtxi6oZLIJ91mSXwfcEY4a81qq/xNecU7vlrtpUR0JpUZwhomKtKdV/bH yATQfErPbZeyxcdUyrwsBWOSQi8RryHvk++rcz/w37nplP0mXTMxsOfNDarssjFI59pq xr/7egPGkEYgrPd2M84+OJzl0Gvc+HM4EftCB2pHv8VhI8/KQoFHXoj87lciP06arJYR b6NCAoEFSNtxVpc2Xa35GvApYPnqkvaTscxeFceDY0/WXM2I2CsL2bwcuP4vAlthafgX e/k0u6+zh4JdfVmiWfJDx6EnicyeOXe5BqhJwpOAEOaXveBALnLC//9uWtAWOKl1MqIc ZOxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=E1pw3vOO82Ds9w0163Mtmi7QOVEF9Qab6422FSilTSc=; b=J9UzEFejQc2vWRouHaTJ6SGsCeZdq3H+E0qgbawMx3NIhMf272sKPy6oXc56A4yedZ p+PLVE9EJCMmdN7vykLgrQQZo/5rzxh9P9AEJ8v/DHwpBTcbwsNBjx2IYUpPWDoKHMaJ vZTSr60gocbWuKVxcv1F7udZzI5Oe7Z4zhfFSXHRaXAt+58I/MsrlxzyZ8fQ53xmU7+G l4mxcbN2sn1E3t7OPhKb4a23C6ZT8+DGlHdw24oCVurN4i5BNjFG4SihxwFkH3qhcnkQ 03i2+GwhSkLsb8AOcr5mtdkNGIdtBicNfGwkqcObPKKKVbManHBJv725YOv5bknynjju NWvw== X-Gm-Message-State: AFqh2kqbgEydW1Y9nwr+VWhye7qPs5E1qUhx3WFA9t5DkYkHAnD3BpTr GYh/qN4CsTj24T3nWHrOWn4hxecvRsBNjkecH/yczg== X-Google-Smtp-Source: AMrXdXsOr+GEGkBosigfUHXu92KjE9VznkpfG3TQiLvk8vecH24hbrAEBO8q8YfqiqTC9f7Q1FqDZlNhJ6QWePgl6iw= X-Received: by 2002:a05:6902:685:b0:7e9:646d:2da3 with SMTP id i5-20020a056902068500b007e9646d2da3mr667784ybt.340.1673989773689; Tue, 17 Jan 2023 13:09:33 -0800 (PST) MIME-Version: 1.0 References: <20230109205336.3665937-1-surenb@google.com> <20230109205336.3665937-13-surenb@google.com> In-Reply-To: From: Suren Baghdasaryan Date: Tue, 17 Jan 2023 13:09:13 -0800 Message-ID: Subject: Re: [PATCH 12/41] mm: add per-VMA lock and helper functions to control it To: Michal Hocko Cc: akpm@linux-foundation.org, michel@lespinasse.org, jglisse@google.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@techsingularity.net, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, peterz@infradead.org, ldufour@linux.ibm.com, laurent.dufour@fr.ibm.com, paulmck@kernel.org, luto@kernel.org, songliubraving@fb.com, peterx@redhat.com, david@redhat.com, dhowells@redhat.com, hughd@google.com, bigeasy@linutronix.de, kent.overstreet@linux.dev, punit.agrawal@bytedance.com, lstoakes@gmail.com, peterjung1337@gmail.com, rientjes@google.com, axelrasmussen@google.com, joelaf@google.com, minchan@google.com, jannh@google.com, shakeelb@google.com, tatashin@google.com, edumazet@google.com, gthelen@google.com, gurua@google.com, arjunroy@google.com, soheil@google.com, hughlynch@google.com, leewalsh@google.com, posk@google.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: B515718001D X-Stat-Signature: tbxu8m94396mdoytpxsmytekmxasciw5 X-Rspam-User: X-HE-Tag: 1673989774-748507 X-HE-Meta: U2FsdGVkX190JhYBNctl2/8hkkmiuwciCOfqqPkYV+p+MrDmzS/0ngk5SXcjtjL0Ubz7eqyKQNKYAPLoSewqlYZfvA0rxj+Es24lodIHtDutZrMjPREjYgz0H3bWiSUPKe97dsh2g8OB0/i1lmnPHMes4TS5U34alxvsHB1J85PYI1Ewyo4Mv5e1fOL25y9icPC4YBGJJ/9FvKRwEvSqA6A2q1kIqQ4qJ6vrbsO7GPcpzbiMfX2iZ+XWQbm0gNkv4WOfMdb09DQqV6NGpmh3MttNRZVUYQPGqWhTqYKde3mRE+J1CC+1/1d6pNKVvUeJdnkCu5vc2sOH1a/QiMYqQm1uor1pA5v59h13iHrN3XBZ+1IMjTcTU2ZnilR0RtPdWTj3sKHIIA2XVCWBRyr+hwezko/WAjpn7ax52VfrT4TQMePCF2/vDIUJ1tf9C/EjwIQUh7lXPahn77lrDj8kU61VEM1fGMUitnyOtWcKHDLYTHOtxFIIOIvcu0D5DNfwMPkuM5unKTOSiYv3C/vU3RuAskZrC6HigxpQlLw/vc3pQXwObdUGT9w4SOOEy6/ThaCKm+9JxLIegUPbpVZkrchCsgNZOwqSHU7kmzPxrNY/NLx6zzrngoY7TyIH6b1zwA5zIOVlHafcNiXi6/TIgjldkPKkDdCJR8XKMOqLaEzjJowM0QjUZoxwWLw861edmMd1gZXdVQu+eDJqzFY7xGq8zIMDtXqP0OYH0xSPOivZo140GF04tZTVL1nFDboayjFuQmrjSJGq/0hzSZvuDE5X+oSTIHB4P9m2M1/yNBGhBB+vF67Z53hspmvlYVYBddwTQGVziIWmne1dc1e3bURWSiBASvg0IxjqEBncPXF/rZNK+Ine7jWRyAtFZok/+y90toarbhIuyWE/DlUHDmhyD6y1LyK1YTd0bNsFtjYL8d1XbW0KkXSMtMsThZCsSzE9kS5L4JHAj+Raz9k z98z/67P SDjbUS6Cg3mpgczg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 17, 2023 at 7:07 AM Michal Hocko wrote: > > On Mon 09-01-23 12:53:07, Suren Baghdasaryan wrote: > > diff --git a/kernel/fork.c b/kernel/fork.c > > index 5986817f393c..c026d75108b3 100644 > > --- a/kernel/fork.c > > +++ b/kernel/fork.c > > @@ -474,6 +474,7 @@ struct vm_area_struct *vm_area_dup(struct vm_area_struct *orig) > > */ > > *new = data_race(*orig); > > INIT_LIST_HEAD(&new->anon_vma_chain); > > + vma_init_lock(new); > > dup_anon_vma_name(orig, new); > > } > > return new; > > @@ -1145,6 +1146,9 @@ static struct mm_struct *mm_init(struct mm_struct *mm, struct task_struct *p, > > seqcount_init(&mm->write_protect_seq); > > mmap_init_lock(mm); > > INIT_LIST_HEAD(&mm->mmlist); > > +#ifdef CONFIG_PER_VMA_LOCK > > + WRITE_ONCE(mm->mm_lock_seq, 0); > > +#endif > > The mm shouldn't be visible so why WRITE_ONCE? True. Will change to a simple assignment. > > -- > Michal Hocko > SUSE Labs