From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A37BD3E2A0 for ; Mon, 28 Oct 2024 18:51:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D32916B00A0; Mon, 28 Oct 2024 14:51:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CE28A6B00A1; Mon, 28 Oct 2024 14:51:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B831F6B00A2; Mon, 28 Oct 2024 14:51:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 990FC6B00A0 for ; Mon, 28 Oct 2024 14:51:34 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 49E7FABE2C for ; Mon, 28 Oct 2024 18:51:34 +0000 (UTC) X-FDA: 82723903332.13.7D1A55B Received: from mail-qt1-f170.google.com (mail-qt1-f170.google.com [209.85.160.170]) by imf15.hostedemail.com (Postfix) with ESMTP id 7DEA8A0024 for ; Mon, 28 Oct 2024 18:51:08 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=mvFjpGnM; spf=pass (imf15.hostedemail.com: domain of surenb@google.com designates 209.85.160.170 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730141438; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FsGymSckWWFG2M28oSHVo5x5qB69G8wLbxX80Gagvk8=; b=0POTYyNAyCakom6H8LX5PBsKPt5ZuCr+dwbDkK/sZuJvNdzW2iqTX0ACoJqmLioxCcF3oe 4btQolnLA3gfakh0Ax4ynK6xvCISCIPFOnUlDpZ+gtzaCpV2Tq4/nA9EWy58H43G1nuldz +bcwPruCbH6Xm8PnNo8bPVWxIcnlpww= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=mvFjpGnM; spf=pass (imf15.hostedemail.com: domain of surenb@google.com designates 209.85.160.170 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730141438; a=rsa-sha256; cv=none; b=ptEvxCQyStOEFqUtoHgtBxt8k/gETFp9I76XpROqe+NiGRQIWqHmQBUov8KiA/rF63ww+T TCQ/+3MZKWEzNqb7wv6Gjm4vyBtJEM4aidHDZ46Y68Hp9OODUwIPwuNLLiFq6JVZFgwjQ0 I0qumBm5UR0OkXHGugqiyJAPu+oYz88= Received: by mail-qt1-f170.google.com with SMTP id d75a77b69052e-4608dddaa35so52721cf.0 for ; Mon, 28 Oct 2024 11:51:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1730141492; x=1730746292; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=FsGymSckWWFG2M28oSHVo5x5qB69G8wLbxX80Gagvk8=; b=mvFjpGnMjRjp/YmtABNdJNLuXa5vIZKQTlC5FYS7EAw4hCO/72xGD1Es8QokUM6z0x DbgT3d5kDM2M3iBYkB2MrUa2//YSskf3px19ondHNniVkI0YSaNQLHoc/0PnXTH1fBNq kFE0MlEYsndRBqwyvZs5cG+EGk3DoS5ZiXWZxPP7pehUVIcssmVyW/ue6y6kGSsKjhtP DCieO7kMOogIRKWud+Eea82apNbidZ70qQOWiBQeF6JWv8tqymLAt8A7uHF04aoOfHe/ p9zJKai2wv7rhzO7Z4sjyBrjjRSOr8Hbe1b6M3V+ed6aw6AWQgrgN7CNcjz8iSJQemOH DwsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730141492; x=1730746292; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FsGymSckWWFG2M28oSHVo5x5qB69G8wLbxX80Gagvk8=; b=XSB9JVEBL+/nJiNfT8Y0+ScLmHW8EVkeRo8mQ3SQOZoaX6ZzJPUTY8TPkq4FpBOGOT Fmbf2bNRbcijzVHKxz8TVHT50T5jwrGLbLLr0WWh8w2qqwtcmTCunk6uT/CvIOvbgT1Z YxyoVHXAYTi5NXopXuUMmxDjmImwcmY55ejiTOOZqRCX3Pn3DB/io9WyAyfE3YCbo/uK WQqABj39ZAZELfCIRGGj39lakET5fNOlPKjCtl1AKDzLAvkItr6qX/LPfVwne1DS8DHI xv2I0CD0VEuQxoCVvLwuESjmM3P73e9yUXkgsPNWgK/wie1P3V9tVKjKljDWsI4uYvY7 YztQ== X-Forwarded-Encrypted: i=1; AJvYcCUOKvIVA6ZT+xdEkdirKo1Bz5z+Mqp85zjy2XF5Q2LaQ1qEcdeeYDxkR/OjiYAEah2x0AqFJtQfyQ==@kvack.org X-Gm-Message-State: AOJu0YwdQHH9z359XNUgwnvu9QaZdmdDXKjcbIsENTC3WpZhdCdnFG+I lBoyHfvMGDlk8zrupvkLEs+uHlU90LyyMTJ6H7OS7RkCiippq/jiML1ZTHcGDVGX8lfCnSfeRlM e8jGflypgmfIeUbe56+G5djinz7T4sTKGA1Xf X-Google-Smtp-Source: AGHT+IGucYFQpDnR73oHvNPQyEJZmEltS4w0TfwYJTXmq7umtAwzRsH+cXSuxB6sDSKEKyYnjUZozfwTnK+3uzFmGpI= X-Received: by 2002:a05:622a:13d4:b0:461:4898:8614 with SMTP id d75a77b69052e-46165196f77mr312051cf.27.1730141491335; Mon, 28 Oct 2024 11:51:31 -0700 (PDT) MIME-Version: 1.0 References: <20241028141818.622917-1-arnd@kernel.org> In-Reply-To: From: Suren Baghdasaryan Date: Mon, 28 Oct 2024 11:51:20 -0700 Message-ID: Subject: Re: [PATCH] alloc_tag: hide execmem_vmap() on !MMU To: Mike Rapoport Cc: Arnd Bergmann , Andrew Morton , Pasha Tatashin , Arnd Bergmann , Luis Chamberlain , Song Liu , "Masami Hiramatsu (Google)" , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: yhnbgepgi9otbux8qfk7tu1tzpykma8t X-Rspamd-Queue-Id: 7DEA8A0024 X-Rspamd-Server: rspam11 X-HE-Tag: 1730141468-951620 X-HE-Meta: U2FsdGVkX1+8VOnLq/dhBBmHtTTIDW0UigwVl6Z0VHrSZYEMVodGvKYr6koHgrx2/0gtD88EQLZltSKEWppqTfP0J1XxylMqBKhZsGSYu0LktYMfQ8sfqU0q+trcCh34aOKpvCNRAkLfz4Ia2lY3O/m41lDzsbh+kpABa3P8/I2m1KIRyD7/fVUxIvHtuUJGZe0IB0tGKuFDtczVrJKJ45p/F1qImToYdshv7dQ55AWKp8OUunnmQSRz6HtVdLhoMHVSx9/onw0R54BcBYPD6VsNDDmN3LEQIh3jd1dALD8cra6ScT66GydW3BWOOLqtMrf3/ZYEQTMGg0yGDv+36ADPQ+aHEPgV/sWoN06+1V1/LyQn+7/DeRlIi1jBkDds3ZLyDYDqHhz1FIOCmX8YsIMknYwwJLWJU8/tV3vTCQRubENzIQPPKpkv0H/tK/NuuVLWD7cnJCoEzMLIjLdcCQkocutW1rAmBG3NV7uRjV0Wg9OK2gJggZZWFIq+l8cm/Srgx4BT57hpw5pSWPGUSwNvfm2/JL6O8EcZvSkUtAXgdniJ5885BIuKxBjHZSPfCltolZPi7CpCqyfPx2SAdWl1XCQgLoPVUfpI4jOtSBbGEot7T/tXNIecb7N/dvlDy7+8KzdGGPMrvBm2nef46ZeA3WChQznKtnJXw1H7dOZD6N4W57Rmw22lQ/G+2oR35gA/d3oof9vG1ExdT4WPuYEITec2XvLm+rhxmdQFfEmCBJulaTxUIhpXQdSCy2CkvdbNDQFbyhX8TrORCFzKZFYAD0hW8EEhwxSv3TLHxCA2gnBq5aamQ49eQ+QBF+hPk8tXobWGmlIoUa1zr2yHPPTLEjSARz3XMajT3iJxgpKvWQ3Up2S8W7FNYCvO6aGZ3rwbbsNcprPEARHv2LB7NMDE+52kdaWGA42bxrZEa8x9MBgE7/Y7cL3DCIxJrAZrOlhU82O4e/+L07L5mhF 7Ctzz0ar 22FDc10k0VdIbfe9aFc3w/H9j+Rgi3njhXKZy3ofa4pRNb5hBZ1GU2Uy4CPX8zXzDxJWj0fjBN/5ALmQLV2PUasChQznxrWVXvDiRLRHfRxRj4N50pzr+m0sXdMXp2002Rxy4yc4/qntnpQtffFQ+8t+rG3Pu2I1eaXY2kTMHz1FOT4G9OczqEIs4wKocmZQLIDP8N0GRCBfYPExBKUn4g0F/dtIux81Pt+2s5Pqb1oDNEKIb5xWv/TtlXEOtCppeBLOX9SmY+dqsgNrmtibsnSDIxvaOzMBY9heLzHZnIW+GWPdVRkJkR1SYWQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.007990, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Oct 28, 2024 at 7:43=E2=80=AFAM Mike Rapoport wro= te: > > On Mon, Oct 28, 2024 at 02:18:09PM +0000, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > The newly added function fails to link on nommu kernels, but is also > > not needed there: > > > > ld.lld-20: error: undefined symbol: __get_vm_area_node > > >>> referenced by execmem.c > > >>> mm/execmem.o:(execmem_vmap) in archive vmlinux.a > > >>> referenced by execmem.c > > >>> mm/execmem.o:(execmem_vmap) in archive vmlinux.a > > > > Fixes: 57bc3834fb6f ("alloc_tag: populate memory for module tags as nee= ded") > > Signed-off-by: Arnd Bergmann > > --- > > mm/execmem.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/mm/execmem.c b/mm/execmem.c > > index 5c0f9f2d6f83..b04cfece7356 100644 > > --- a/mm/execmem.c > > +++ b/mm/execmem.c > > @@ -368,6 +368,7 @@ void execmem_free(void *ptr) > > vfree(ptr); > > } > > > > +#ifdef CONFIG_MMU > > struct vm_struct *execmem_vmap(size_t size) > > { > > struct execmem_range *range =3D &execmem_info->ranges[EXECMEM_MOD= ULE_DATA]; > > @@ -383,6 +384,7 @@ struct vm_struct *execmem_vmap(size_t size) > > > > return area; > > } > > +#endif > > Nit: there is already #ifdef CONFIG_MMU block in execmem.c, better to mov= e > execmem_vmap() there > > Other than that > > Acked-by: Mike Rapoport (Microsoft) Thanks for the fix but execmem_vmap() is used if CONFIG_MEM_ALLOC_PROFILING=3Dy. Please give me an hour to post a fix dealing with that. > > > void *execmem_update_copy(void *dst, const void *src, size_t size) > > { > > -- > > 2.39.5 > > > > -- > Sincerely yours, > Mike.