From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46A36C4332F for ; Wed, 4 Jan 2023 18:24:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4BDD08E0002; Wed, 4 Jan 2023 13:24:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 446D98E0001; Wed, 4 Jan 2023 13:24:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2C0A78E0002; Wed, 4 Jan 2023 13:24:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 19C308E0001 for ; Wed, 4 Jan 2023 13:24:19 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id E37151A03B2 for ; Wed, 4 Jan 2023 18:24:18 +0000 (UTC) X-FDA: 80317941396.16.A96AD3F Received: from mail-yb1-f178.google.com (mail-yb1-f178.google.com [209.85.219.178]) by imf28.hostedemail.com (Postfix) with ESMTP id 33E78C000C for ; Wed, 4 Jan 2023 18:24:16 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=YJS1LnEx; spf=pass (imf28.hostedemail.com: domain of surenb@google.com designates 209.85.219.178 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672856656; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KxFSAeIQaZ8kk0GXJhXrmy8k/ZlTX7XxQ3u7wqBqzBs=; b=lrlf6NzVl5eGcMkGROw8w6NR+2bCCutwPIBLrY9Ts7vI/Qtcf30F+uLVCkVHIn3yyWwxFy 2L1nMd/yq9xFGRvjG99U/nLv6y6PPwDkjkgLDkavvWmhmu/wwKQ9av00pJy4zsGHLCabuU RVRBMQkibNFXw/afHpN6ac2ihlSrGc8= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=YJS1LnEx; spf=pass (imf28.hostedemail.com: domain of surenb@google.com designates 209.85.219.178 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672856656; a=rsa-sha256; cv=none; b=oOeQG1pS8MNPAV736Hfdw0UrTFWhK+17YdxYt2OqZ7V9819I3FkrJPRj8iF5fO1OSw7DDy TOuVy4BfDnBaR6jN9LH/McJeFZYV/YOF3SFsTe9VuVss8740cEr8TaM915JqpvPwN4KJ22 fuSfPTsupIT2Vrxk/y4VbQiTNKjRKak= Received: by mail-yb1-f178.google.com with SMTP id l139so3223577ybl.12 for ; Wed, 04 Jan 2023 10:24:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=KxFSAeIQaZ8kk0GXJhXrmy8k/ZlTX7XxQ3u7wqBqzBs=; b=YJS1LnExeamCNJAbrtg2PnEtWZU1IrvxBWzYRgGDcjZcQaZC9cjUdy3lbhKZeA2JEA +4mCGuPlCj8XRLGRtawqjnW0kyvJcFKaiRxDwjJOI0h/6YzyHsqk8kBKgcC/L6a1Vuvo 4E8CHjqOl/yXT7MIJOIdf3woNrLCunLBnoz+pBYpvKt9KxwQlVESIYheKTrmdNSN3WWg ZAcdvxNQBLEvUJUpxFk+T/Hs1j6w6k/agMH5J1ugEoRRZYykhFbVyjPdMBa2y2gqgy2C eB7MPF9relmzFoxjlThYd699W4ayeJh2AKdksCUFOOEuT+lJdMckTAhUiSiip67oCfk7 0rGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KxFSAeIQaZ8kk0GXJhXrmy8k/ZlTX7XxQ3u7wqBqzBs=; b=JulQvwad1WlahE9vsMXEs8fqw6bpHRYqUV7uCAforBAzwY97X9NkjDU++0acb5aqNL HDQH/toKJi1gZIAKSGvHrbC1Nrf5+EtPgirfyW8wJTQ2bPERNPaAqvKub7KiPVrlNWYd IskmdCA7NExV1Jpx2zae2PLHPO7NwQg3PfUIwB4V0gou7kEnuLcSZtbc4/FUwmp7t/wo 3XO3R9jZLsUjabtzyLKXSn62X5RCOlT5QXy5KfwxveiGJoxxCHLbQTU8tuTOfQon/B0f H5W3KuOSN4RjzkkzgHrMB0sUiZKhw9RlLnemig0+XySqG0N9zIcvSo6GpY7+AA8A2Kov DlBA== X-Gm-Message-State: AFqh2krTCXd2KWWCINnHaGD9vRjaj9Z33dNVnrtiu6mbtK+GqmXPhaEy dXgECvsglZDbzQNfa+FwR68Gz1oLcUwc8S+kq4zANg== X-Google-Smtp-Source: AMrXdXvUwl8o6DfThWFhqJEq7nM/XEsZYO493gPYNkjXoA33zsGhsbnOVROL9yMdxYEzzmHtfHq4IdxFIxwhkzG4RYk= X-Received: by 2002:a25:a292:0:b0:7b3:7fc6:2d52 with SMTP id c18-20020a25a292000000b007b37fc62d52mr182755ybi.340.1672856655114; Wed, 04 Jan 2023 10:24:15 -0800 (PST) MIME-Version: 1.0 References: <20221228194249.170354-1-surenb@google.com> <6ddb468a-3771-92a1-deb1-b07a954293a3@redhat.com> In-Reply-To: From: Suren Baghdasaryan Date: Wed, 4 Jan 2023 10:24:03 -0800 Message-ID: Subject: Re: [PATCH 1/1] mm: fix vma->anon_name memory leak for anonymous shmem VMAs To: David Hildenbrand Cc: akpm@linux-foundation.org, hughd@google.com, hannes@cmpxchg.org, vincent.whitchurch@axis.com, seanjc@google.com, rppt@kernel.org, shy828301@gmail.com, pasha.tatashin@soleen.com, paul.gortmaker@windriver.com, peterx@redhat.com, vbabka@suse.cz, Liam.Howlett@oracle.com, ccross@google.com, willy@infradead.org, arnd@arndb.de, cgel.zte@gmail.com, yuzhao@google.com, bagasdotme@gmail.com, suleiman@google.com, steven@liquorix.net, heftig@archlinux.org, cuigaosheng1@huawei.com, kirill@shutemov.name, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, syzbot+91edf9178386a07d06a7@syzkaller.appspotmail.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 33E78C000C X-Stat-Signature: xmkxbnckr4ert4gegrdqmrcie5tec5fn X-Rspam-User: X-HE-Tag: 1672856656-566796 X-HE-Meta: U2FsdGVkX1+TU11RZZ8av0abm4eulkFowQn3HzH2sD6nrwXH3CrCVSBwAV7rCqw6JJoSaFyqStP2KQ2WPmXq4NymwYbgl8Db+og6SI6i3eUCt4CW9AYttpyhYIljS/RnkMZOvToQLzpWuK8y5lEkXBm703EaLhWvc6au+RvyQbefslJ7vVX+Mxut7HPyWZAT3j7VoibBVs7uL95eqCQzY8M3qeLU/uHFSYfctpprng0sEvH1QCp3EFr/nfmIxBWYe1pCvnpvglb+zbTJahmcM+45JtOIP0MsSVywZlVwyZb5yFp9bMd91jdxNzNt+6SZ6nUqGZ9djRkGJpEMUmQhFigJyHFGxxfVe3Hzyt6nIF2X4yNy62Kgs1kZQzF59XfBIOajz1Vqxe4bfjuYOoyKZqkm+7c7QN8SfToC+gSwYLwUD2kFw1mXGcZU5FewBovyuM9rbyxnaA45t8QKd0XVyX75CI8tOSFLO3pN433NS4XCOp8W1ILQ6xA2CmS45Dxi4ajMFAnQ0fHWUTbZyrcoTbg5jLSnANdOrx4V/FNjxhZGXC3M/RxsIuuT80DMnr5/qZWu48Co9qhZBG2fIWyMe7iz3qxUSjviWrbnEf0NQuecOeIeNTIMXNhNyOnlaCszyh9HCCWt7sJwgOZ3xbj6rhUy9OK9KAq87a5UguSCc71/VpP5DbfoMtLYS6ztKHz8uesyO6bAm0nFvUU+G/M5CV+jLgl8GNwkSl0ULKGYDuWzg8pJ0F+BHZ4VbkBP3bw2pPPbL5B6TFaa8GijlSNWjsQ/AbLgGk8XMkDyClRPkiU5lW/lzn28a6TOCl5U/XgSJK73ZYWxI3Vwj57lQxAVbCTJ/pWCYe9xqYL7bzmy113YYxMrsUGTJ38ppm6HRt45G5RyLRm0coKSJWkEVig9ZS9LzGnEzRJ0NZIM/S1zSbRu9u7hxNSgoxTnO7+wI6xhhtrGFmyss7ueD9g9kRq vIqNS8Mi DjIHKQGrQXrjlZEBToaCbVNvXVd8KBBWwIG3mNIvi8Of98eOWtXzBPTAs18uoPbgl0LiKMWTw6QkronvrsHbdp1XX+ck3FlWDJ7FY/+RGVUfEDHcxlGs2JTadpwXR9uADVnDpnXcV0FlnfzOpo2BO4UvCmfmGE318y89l X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jan 4, 2023 at 1:04 AM David Hildenbrand wrote: > > On 03.01.23 20:53, Suren Baghdasaryan wrote: > > On Mon, Jan 2, 2023 at 4:00 AM David Hildenbrand wrote: > >> > >> On 28.12.22 20:42, Suren Baghdasaryan wrote: > >>> free_anon_vma_name() is missing a check for anonymous shmem VMA which > >>> leads to a memory leak due to refcount not being dropped. Fix this by > >>> adding the missing check. > >>> > >>> Fixes: d09e8ca6cb93 ("mm: anonymous shared memory naming") > >>> Reported-by: syzbot+91edf9178386a07d06a7@syzkaller.appspotmail.com > >>> Signed-off-by: Suren Baghdasaryan > >>> --- > >>> include/linux/mm_inline.h | 2 +- > >>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>> > >>> diff --git a/include/linux/mm_inline.h b/include/linux/mm_inline.h > >>> index e8ed225d8f7c..d650ca2c5d29 100644 > >>> --- a/include/linux/mm_inline.h > >>> +++ b/include/linux/mm_inline.h > >>> @@ -413,7 +413,7 @@ static inline void free_anon_vma_name(struct vm_area_struct *vma) > >>> * Not using anon_vma_name because it generates a warning if mmap_lock > >>> * is not held, which might be the case here. > >>> */ > >>> - if (!vma->vm_file) > >>> + if (!vma->vm_file || vma_is_anon_shmem(vma)) > >>> anon_vma_name_put(vma->anon_name); > >> > >> Wouldn't it be me more consistent to check for "vma->anon_name"? > >> > >> That's what dup_anon_vma_name() checks. And it's safe now because > >> anon_name is no longer overloaded in vm_area_struct. > > > > Thanks for the suggestion, David. Yes, with the recent change that > > does not overload anon_name, checking for "vma->anon_name" would be > > simpler. I think we can also drop anon_vma_name() function now > > (https://elixir.bootlin.com/linux/v6.2-rc2/source/mm/madvise.c#L94) > > since vma->anon_name does not depend on vma->vm_file anymore, remove > > the last part of this comment: > > https://elixir.bootlin.com/linux/v6.2-rc2/source/include/linux/mm_types.h#L584 > > and use vma->anon_name directly going forward. If all that sounds > > good, I'll post a separate patch implementing all these changes. > > So, for this patch I would suggest keeping it as is because > > functionally it is correct and will change this check along with other > > corrections I mentioned above in a separate patch. Does that sound > > good? > > Works for me. > > Acked-by: David Hildenbrand Thank you! Will post the followup cleanup patch shorly. > > for this one, as it fixes the issue. > > -- > Thanks, > > David / dhildenb >