From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FBA0C48BC4 for ; Fri, 16 Feb 2024 18:42:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C31216B0085; Fri, 16 Feb 2024 13:42:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BDFD16B008C; Fri, 16 Feb 2024 13:42:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A80956B00AB; Fri, 16 Feb 2024 13:42:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 93E9F6B0085 for ; Fri, 16 Feb 2024 13:42:02 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 29D7A120121 for ; Fri, 16 Feb 2024 18:42:02 +0000 (UTC) X-FDA: 81798536484.02.7C876B1 Received: from mail-yw1-f170.google.com (mail-yw1-f170.google.com [209.85.128.170]) by imf29.hostedemail.com (Postfix) with ESMTP id 8EA8312001C for ; Fri, 16 Feb 2024 18:42:00 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=aH3IjRQ0; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf29.hostedemail.com: domain of surenb@google.com designates 209.85.128.170 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708108920; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=faKyGS2bCJ2px0ud+d+mBkv9JBZNScCq7HyfBnLgGJM=; b=SSYcprjp1iYj9sYv4gUkd5oU46DsRTEwLhOMOULDwtooSkZ847AtTpCoJy4PeQmtkcp7CG TrB3efMtvQwgbqTyEQmV2wj9pOv7wbyMud1WzUxCguzBvEGuEJL4Hs4x9bpM98qv5BR+hH uNrez0Agad1na1G2SKQGfSX8LO61uRs= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=aH3IjRQ0; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf29.hostedemail.com: domain of surenb@google.com designates 209.85.128.170 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708108920; a=rsa-sha256; cv=none; b=vFN0alHoSqS0Ga3impSLMHcsYZPPKNvN4A08FlXB39vKhBEJ2QtIrXMu4SMYhPloFOdolM uN8skn5NB0p7l+Rdjl6fKOpsz58xyOJB1RWrQPZdbswjStVFwH4sGHEiiAxNLHLm1Eik9z xXYSamzntpL1EGFQsy7WyAAVE0XQlnM= Received: by mail-yw1-f170.google.com with SMTP id 00721157ae682-6077444cb51so25297547b3.1 for ; Fri, 16 Feb 2024 10:42:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1708108919; x=1708713719; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=faKyGS2bCJ2px0ud+d+mBkv9JBZNScCq7HyfBnLgGJM=; b=aH3IjRQ0JEEt7wTDeYabSjNlncbRqa6Tkf4KrPg7Jy+ZAzn/p2m3KPMpK+drDQlidF hmYDq/C66gZhaYradx5XllMifa/3Sx2KC1ogQ2jUtDGBtkbPzvxPaDn0+blGDH3lIPsB hwc8IEhwycK4Qis1iKvCzcX2xtsvvTFAVlwTQZYN5ii16ryJ476PXeEui6wC7m2Aikc0 lC8KWJhe8LqdtU8l4sphj3FmPunqF5jVV3BOLwKkeLLrfiBLELMKymHn7bz7eP/iwWbn tgRWJHHpMY1OpgOgOvHXIP4cz15JleyZwbyNmf9UsQ2nDUsCODl2hz56dPnQIOsfqkzm kapw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708108919; x=1708713719; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=faKyGS2bCJ2px0ud+d+mBkv9JBZNScCq7HyfBnLgGJM=; b=o40xlMlZNNyR5TRrXsplT/dpkSGovXk41k2bglK+l4b7YnPXF3tX+6Z7gpxEAtkG8q UJDQXkJVq8VDmdxBZIXa5Z0EPRc+gGIXWRTXXWa/ALeSiP7eOD1VFKkRELi7uk+5NuZj K4WHDvBGUtF8Q26shSpWsf2ZZfSCp5TMyJ1v6b/XDcSNhfFmWk1n4Rlih18l9fIfVlVC SlrejvAMpXFBLB5AVWxD6Jcm/vWaeaPOu5CpP7ZhY8r8KwqHNMIpXVM8E0QQjHoYR21O SrqXB/6miMxBqQPo+A6/MlDRtddS0+1dLx/cDKs+QVLBpYkQRYbK3BgosNM1SN4HbHEY ySgg== X-Forwarded-Encrypted: i=1; AJvYcCUFvxG2KMslxGsm3Wdl/7hVuPfKphkjsEymqpNn/AVnw7WmBCSTeNDz6eQCzewBDZo61V883oTrdFDwqWlliYfFSTk= X-Gm-Message-State: AOJu0YwoHh/zLt4j4UFssqTqq9M0xiA0qS947ZO3ledLxlYYsPpcEbef cxT5wR43axSC8ZcNzXBLoDK5xkPbBH2PuCTRBCKBrn7McvcqhiVOnBdXwVbKM/IUkJyJGxKlfRU EU81KIsZ0CFSfbaBbJkeySVKiN4BZ5Y+DP0x+ X-Google-Smtp-Source: AGHT+IEJnWKoDWpauMUL3nyzq5XZmrCjaSg8T+9prk1S1WBz+kj41C07IYkFdioVMXmJnJb7IpOv4ANZWqelmDdrwMM= X-Received: by 2002:a25:fc23:0:b0:dc2:3a05:489 with SMTP id v35-20020a25fc23000000b00dc23a050489mr4194145ybd.14.1708108919211; Fri, 16 Feb 2024 10:41:59 -0800 (PST) MIME-Version: 1.0 References: <20240212213922.783301-1-surenb@google.com> <20240212213922.783301-8-surenb@google.com> In-Reply-To: From: Suren Baghdasaryan Date: Fri, 16 Feb 2024 18:41:46 +0000 Message-ID: Subject: Re: [PATCH v3 07/35] mm/slab: introduce SLAB_NO_OBJ_EXT to avoid obj_ext creation To: Vlastimil Babka Cc: Kent Overstreet , akpm@linux-foundation.org, mhocko@suse.com, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 8EA8312001C X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: xq8xh54kqy1mkrgpurd9xyjrrbwusb6i X-HE-Tag: 1708108920-368788 X-HE-Meta: U2FsdGVkX19STlWQNOWmqrCX/8rRXxyKqTmfuIL5DW7Tg07V/GKTJrCpdPPYhKqy04gc6LRuGoH0rtW6GMy9zLSmPLO7HcH7CrkcDqjE2QJkkyosIdr1wENbhYZ4VbQP9A8wXrhAVt8KvZHokqrXMjzTI8kmd5h82+I5PqkWpqqU1FjTopPI0tnquouVLMb44BB5Z5L/gMftBSJ+V7UFz+3D/ToCes4bp/tX52rqI/I56LN7FpsJxgNMUxZCdxXYCgDiWdDkMhN4urTcgABJlyailT+CX4QGNFN56Kfj3nvo/snMr/fXsR40tgu8K6ZsCyT8HG/NmN9u/GjyGn+UiznItSwToOPKHYdybSBWzgTakF8Hr57mDVo60gGF1sGwuS07mF2+ns8KuQS0D6U3eHAVTZNzpq0wDciG60dlMh+wyVdv9Rwjaf+NvqQRDyPJpBvDO4Li2J7P2+rRBszo+cJx3RDE4fdEzcXixwN+iU23Mo/l5PONPwBjf09Q3DFLmqKIDdLOxYkDqsx+4KLNv7OAKxM1kTOKl2g3qcOxyDQRHB6wwZ3/ukB9+Y+37K670Za30IpYoZA/i46NATXqXVA6aUHjeKPH0QHmuuTWES3/F4UXi6nj8I14D+6tJqQ25tfyYyxlvQBQCznPDeo25tadaDCFJscGeEIGW8ITNrm2D2nzYJ5CyAs6dkwrTouuYXEQ9FuKk8joGXnc9jC1oOSIJczQpJN6I10GS3cmP38gSS4sg460qaHGnJQhs5oUpOhsYg1iyYwE3PL5S4iUXx+tOKW+lPhmpXrua88S0w8WTM5FsT+cw4pu8EfQV0VCK0B0KkEee6FEIcEAdoS0H54bNMtD04kA1Wf//0pF7oFugJleFl9V9uhtffep1Hw72Whk0XmRhF/Tzzpf40/A6TRlhDIGAWeHtXgsvg6rbh59nBR1n6gmI03DHqlMsYJtBz6wfzg0/ZTWvzciCpm Njw8d3e5 yAdieipl9/6fnEDWi8fH0bOQuSOuf/MmpUhdgtGzB31i7aTrvvMIE8UCPdXMGBUqepiinrELjZl+He6oT1rt6eYdzYpDtbQzsYVGnY9RcjsgZ7gyQuQL8QneYUA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 15, 2024 at 10:10=E2=80=AFPM Suren Baghdasaryan wrote: > > On Thu, Feb 15, 2024 at 1:50=E2=80=AFPM Vlastimil Babka = wrote: > > > > On 2/15/24 22:37, Kent Overstreet wrote: > > > On Thu, Feb 15, 2024 at 10:31:06PM +0100, Vlastimil Babka wrote: > > >> On 2/12/24 22:38, Suren Baghdasaryan wrote: > > >> > Slab extension objects can't be allocated before slab infrastructu= re is > > >> > initialized. Some caches, like kmem_cache and kmem_cache_node, are= created > > >> > before slab infrastructure is initialized. Objects from these cach= es can't > > >> > have extension objects. Introduce SLAB_NO_OBJ_EXT slab flag to mar= k these > > >> > caches and avoid creating extensions for objects allocated from th= ese > > >> > slabs. > > >> > > > >> > Signed-off-by: Suren Baghdasaryan > > >> > --- > > >> > include/linux/slab.h | 7 +++++++ > > >> > mm/slub.c | 5 +++-- > > >> > 2 files changed, 10 insertions(+), 2 deletions(-) > > >> > > > >> > diff --git a/include/linux/slab.h b/include/linux/slab.h > > >> > index b5f5ee8308d0..3ac2fc830f0f 100644 > > >> > --- a/include/linux/slab.h > > >> > +++ b/include/linux/slab.h > > >> > @@ -164,6 +164,13 @@ > > >> > #endif > > >> > #define SLAB_TEMPORARY SLAB_RECLAIM_ACCOUNT /* Obje= cts are short-lived */ > > >> > > > >> > +#ifdef CONFIG_SLAB_OBJ_EXT > > >> > +/* Slab created using create_boot_cache */ > > >> > +#define SLAB_NO_OBJ_EXT ((slab_flags_t __force)0x20000000= U) > > >> > > >> There's > > >> #define SLAB_SKIP_KFENCE ((slab_flags_t __force)0x20000000= U) > > >> already, so need some other one? > > Indeed. I somehow missed it. Thanks for noticing, will fix this in the > next version. Apparently the only unused slab flag is 0x00000200U, all others seem to be taken. I'll use it if there are no objections. > > > > > > > What's up with the order of flags in that file? They don't seem to > > > follow any particular ordering. > > > > Seems mostly in increasing order, except commit 4fd0b46e89879 broke it = for > > SLAB_RECLAIM_ACCOUNT? > > > > > Seems like some cleanup is in order, but any history/context we shoul= d > > > know first? > > > > Yeah noted, but no need to sidetrack you.