From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB1D4C433DB for ; Wed, 3 Feb 2021 20:20:16 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id F3EEF64F74 for ; Wed, 3 Feb 2021 20:20:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F3EEF64F74 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 275D66B0005; Wed, 3 Feb 2021 15:20:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 202BA6B006C; Wed, 3 Feb 2021 15:20:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0C90F6B006E; Wed, 3 Feb 2021 15:20:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0208.hostedemail.com [216.40.44.208]) by kanga.kvack.org (Postfix) with ESMTP id E64C26B0005 for ; Wed, 3 Feb 2021 15:20:14 -0500 (EST) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 8FF7A181AEF1E for ; Wed, 3 Feb 2021 20:20:14 +0000 (UTC) X-FDA: 77778073548.29.75B1CCB Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) by imf09.hostedemail.com (Postfix) with ESMTP id 6F1D060001AB for ; Wed, 3 Feb 2021 20:20:13 +0000 (UTC) Received: by mail-wm1-f45.google.com with SMTP id f16so982207wmq.5 for ; Wed, 03 Feb 2021 12:20:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rQ5+s8Uk/H2oUlPmQuXd+AT/EsL+cy8XeHexkKTVc0E=; b=wF/rgZvrmNhkDzljRbPYVIrL/H2wS+pSUpCdb7G7+Fj6i5vSdKQnM37ReU+MD+ArRd 2ghIxhZVuC+i53i9hTJ8wEVOvIr8QzDabNFResmUnO4dR538GmS7MxCX/njpfqRjiyAn aPHUyjusLDv3xbmqBaem/cNiuxjgZBbLr2dk5+fo4uFT3eJnYs1kHI3zxP+u7/URDkuS wosL4PpFkWfj1gWV9QDIoC/0llJ9BBwhR7ZF7y7xRkl3JqtAr55SRhXoWoMqpfYYpFZw OXRadXgMpftHwXMfkhrdj7EdYEV8078wDokZSAlMUQHMljaLnBxMAVzhvS/k2FB+eKEv g85Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rQ5+s8Uk/H2oUlPmQuXd+AT/EsL+cy8XeHexkKTVc0E=; b=jMFZMvhjYVdOWpMrs8mnJJlVd4CPxivIL5Z94ake/3M3eEIMnD9kSsHP3hLxAWZ521 3VcM9QoDGU8mQ8QgN2Jp2kguJeXLhkHqr5de+TBQ7GFqiWv9eymHkw2T5VQ5xVNtjoX/ 05GuJYZZnRCIZsa7Z2RpvHDDgV0HjFxyJR+ZetozeCfzuIHqTFEPq/EMh+JdW5qr5ukN GpmubgWYhqqfx/Z4Na5ESVG3XA1Qxf0TnVz/99xdt4EsQR/Co1yEaMZJxWgnypBqhk/E MLrJUwQlTIafwy/6FdqPBePZVXmNsI17c9LA8XMWZSruIRysEEG+QcPevTM4m/i5x5Vb wDQA== X-Gm-Message-State: AOAM530FAkXxyZIK4fSMKb1GpQWn+RSVtKG+AVUDsSWzyQ7Nebey7HeC SwzHpyV+00YcVX+oXJAKzbWkseyIUCLTg//HiOPk9A== X-Google-Smtp-Source: ABdhPJzotWwFJQ5FuudypJrg8p0gib5+AD54pH90o3lu7MbwZq0qzxIhjvQznVGTMfdsS9bLXHdCY/6M0s0OBT9Olnc= X-Received: by 2002:a1c:4b05:: with SMTP id y5mr4326474wma.37.1612383612621; Wed, 03 Feb 2021 12:20:12 -0800 (PST) MIME-Version: 1.0 References: <20210203003134.2422308-1-surenb@google.com> <20210203015553.GX308988@casper.infradead.org> In-Reply-To: From: Suren Baghdasaryan Date: Wed, 3 Feb 2021 12:20:01 -0800 Message-ID: Subject: Re: [Linaro-mm-sig] [PATCH 1/2] mm: replace BUG_ON in vm_insert_page with a return of an error To: Daniel Vetter Cc: Matthew Wilcox , "moderated list:DMA BUFFER SHARING FRAMEWORK" , Sandeep Patil , =?UTF-8?Q?Christian_K=C3=B6nig?= , Android Kernel Team , James Jones , Linux Kernel Mailing List , Liam Mark , Brian Starkey , Christoph Hellwig , Minchan Kim , Linux MM , John Stultz , dri-devel , Chris Goldsworthy , Hridya Valsaraju , Andrew Morton , Robin Murphy , "open list:DMA BUFFER SHARING FRAMEWORK" Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: 9mj6hkpanamhakm5k4u1zuuhxyd4ixa3 X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 6F1D060001AB Received-SPF: none (google.com>: No applicable sender policy available) receiver=imf09; identity=mailfrom; envelope-from=""; helo=mail-wm1-f45.google.com; client-ip=209.85.128.45 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1612383613-926800 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Feb 3, 2021 at 12:52 AM Daniel Vetter wrote: > > On Wed, Feb 3, 2021 at 2:57 AM Matthew Wilcox wrote: > > > > On Tue, Feb 02, 2021 at 04:31:33PM -0800, Suren Baghdasaryan wrote: > > > Replace BUG_ON(vma->vm_flags & VM_PFNMAP) in vm_insert_page with > > > WARN_ON_ONCE and returning an error. This is to ensure users of the > > > vm_insert_page that set VM_PFNMAP are notified of the wrong flag usage > > > and get an indication of an error without panicing the kernel. > > > This will help identifying drivers that need to clear VM_PFNMAP before > > > using dmabuf system heap which is moving to use vm_insert_page. > > > > NACK. > > > > The system may not _panic_, but it is clearly now _broken_. The device > > doesn't work, and so the system is useless. You haven't really improved > > anything here. Just bloated the kernel with yet another _ONCE variable > > that in a normal system will never ever ever be triggered. > > Also, what the heck are you doing with your drivers? dma-buf mmap must > call dma_buf_mmap(), even for forwarded/redirected mmaps from driver > char nodes. If that doesn't work we have some issues with the calling > contract for that function, not in vm_insert_page. The particular issue I observed (details were posted in https://lore.kernel.org/patchwork/patch/1372409) is that DRM drivers set VM_PFNMAP flag (via a call to drm_gem_mmap_obj) before calling dma_buf_mmap. Some drivers clear that flag but some don't. I could not find the answer to why VM_PFNMAP is required for dmabuf mappings and maybe someone can explain that here? If there is a reason to set this flag other than historical use of carveout memory then we wanted to catch such cases and fix the drivers that moved to using dmabuf heaps. However maybe there are other reasons and if so I would be very grateful if someone could explain them. That would help me to come up with a better solution. > Finally why exactly do we need to make this switch for system heap? > I've recently looked at gup usage by random drivers, and found a lot > of worrying things there. gup on dma-buf is really bad idea in > general. The reason for the switch is to be able to account dmabufs allocated using dmabuf heaps to the processes that map them. The next patch in this series https://lore.kernel.org/patchwork/patch/1374851 implementing the switch contains more details and there is an active discussion there. Would you mind joining that discussion to keep it in one place? Thanks! > -Daniel > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch