From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84624C02180 for ; Mon, 13 Jan 2025 21:16:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0A3DD6B0093; Mon, 13 Jan 2025 16:16:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0539D6B0098; Mon, 13 Jan 2025 16:16:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E5D516B0099; Mon, 13 Jan 2025 16:16:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id C8D216B0093 for ; Mon, 13 Jan 2025 16:16:55 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 73081C0398 for ; Mon, 13 Jan 2025 21:16:55 +0000 (UTC) X-FDA: 83003688390.28.2B9DD4A Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) by imf03.hostedemail.com (Postfix) with ESMTP id 87D1920007 for ; Mon, 13 Jan 2025 21:16:53 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=dkTiXg9i; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf03.hostedemail.com: domain of surenb@google.com designates 209.85.160.169 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736803013; a=rsa-sha256; cv=none; b=LlSTxCcI/eBMc/rfRW4s2A6wGnL/+C/lMyXPfbCeOsvStTwdfJ283KLc1kKtKxMP98V4M7 45XsJjoPHhw5/GG5KlNfCqy7aMzkBx7oYOHzOZSvKzP12kIeW+4SFCzS8bW6TgquJw2IDO EpdA4pANyRASzroZ7hh4V1AYMbBCbcs= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=dkTiXg9i; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf03.hostedemail.com: domain of surenb@google.com designates 209.85.160.169 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736803013; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2zkwFVrYj9jyweB3toBm3nA57LbeU+KqLHYguHYoUC4=; b=kf2aUh6GFp23SWm0Bx1BX/T31wX/gCvdq04NKIOkGs8oAzgMQtEwno9TNltZ1oWoXr/GCk 5i//n7uPBTMtsAU0X6xRrx+6+r7Pn/XxhncsLvRT8lfK+LdbOBUNwvQHDlTUexyC8a93eU zb7wQ6rRUO9ipjFiXsT89f0NPO8cS0w= Received: by mail-qt1-f169.google.com with SMTP id d75a77b69052e-467896541e1so66641cf.0 for ; Mon, 13 Jan 2025 13:16:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1736803013; x=1737407813; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=2zkwFVrYj9jyweB3toBm3nA57LbeU+KqLHYguHYoUC4=; b=dkTiXg9iCZBzq111YT4QYSWxtT9mkX+2YQizA9B7gZ3/hx3aMjhCRPyO0CJdSV960r 42GQkD314rksBLEUMMfW3dKEp2jIxck/Vej4ixL4Ivn0jzPV9BcSl1QdYtgUIjzRPznk 0l2Jx+eG6pdr1BSO2V0BH5cbrsEg/LuLzcYQXtsTgcMwQ/sbMEUi0721PO69Jx4LS1Vy D4cZRkAgfEUrr6HdGxwztT0ipQkj/80qDlvUwNtupJXEupz/Xo7uNbsbFMJv/7iFbew/ DnMljbkSeZaFlbAy5yviS1e5HwR15dORN1nxZts8ipSAZ+SjF2mH7cQHquH2LaKjm6uf jGHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736803013; x=1737407813; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2zkwFVrYj9jyweB3toBm3nA57LbeU+KqLHYguHYoUC4=; b=tGq566oy5R1BOASpL8m7H6qrvmzcaeooAV1bDpjxoztnJn8fNA4ys4FIERDQgcuy65 Mq7s025Gw7G+VYLiJzlLwba+vYtk1tssicB8jx1SyzgXiJNQdUZDFDSDnNx6dSByXF8g CWpgS3TYCq3GvgncZ8RoJ5GzeP9dfpF2gxDMIxoG4pwdg196u6v5i5lC67TqXudhimn4 KJWR+7KUw5VQ9GbrLrJC3wCbRov3aFWdjJraQ2tAh9EtisBpUPts55lsF84mDa6PNphP 15dGkH9GHa7Qe3lsjNh1i4k7UuFy/9O/16JyW2DIY2C5OTOPi6Yeye0jx4UYSCMq9oxQ GyDw== X-Forwarded-Encrypted: i=1; AJvYcCXYjmi8s/ln1RwILku2bSu2Apudap29jXH/Lffyhcxbu+TyuuY+2F9swEekfw/1jKDARw+PtKqUAA==@kvack.org X-Gm-Message-State: AOJu0YzvpbtRvwyw6HakI+Qr7GXRbOe6BxS0qlQG3ER8NoBRxMu6X31t RBeUdUghmJi4llb5oXsBLJLTmj7WHoO8l3Oa7O91cgtEHjJIBiA2uonIBhac3O8dDCMKywRk8iX WipKU5pq0iMTzL8frIsv2WCJpxKP6YOnIcMbq X-Gm-Gg: ASbGncs96Er/b1vbeuqZhg8ecqrnumqWGoosjc+/GH7TT0d5qyCjYT1FtMZTgziVqwq V08wQYbuNbn5OLtZYYflSTyqoEIOaSVOPdDimIQ== X-Google-Smtp-Source: AGHT+IHPS0BKg7I1i00QJvbS2BH5V2KMi1CXbkV2Zo5G5poOTalncPiGKPdW/Nlbriz/tRFqGOPGKlhrMyl9A1/kLvA= X-Received: by 2002:a05:622a:614:b0:467:8070:1573 with SMTP id d75a77b69052e-46de98ab06fmr621241cf.20.1736803012424; Mon, 13 Jan 2025 13:16:52 -0800 (PST) MIME-Version: 1.0 References: <20250111042604.3230628-1-surenb@google.com> <20250111042604.3230628-12-surenb@google.com> <20250113023756.kgu7hdeow7ltsj7m@master> In-Reply-To: <20250113023756.kgu7hdeow7ltsj7m@master> From: Suren Baghdasaryan Date: Mon, 13 Jan 2025 13:16:41 -0800 X-Gm-Features: AbW1kvbiO1aOCsS88NxHtrdu2gU7F7WIaMfeDExViX6HTEzB268kqR95wBANaMM Message-ID: Subject: Re: [PATCH v9 11/17] mm: replace vm_lock and detached flag with a reference count To: Wei Yang Cc: akpm@linux-foundation.org, peterz@infradead.org, willy@infradead.org, liam.howlett@oracle.com, lorenzo.stoakes@oracle.com, david.laight.linux@gmail.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mjguzik@gmail.com, oliver.sang@intel.com, mgorman@techsingularity.net, david@redhat.com, peterx@redhat.com, oleg@redhat.com, dave@stgolabs.net, paulmck@kernel.org, brauner@kernel.org, dhowells@redhat.com, hdanton@sina.com, hughd@google.com, lokeshgidra@google.com, minchan@google.com, jannh@google.com, shakeel.butt@linux.dev, souravpanda@google.com, pasha.tatashin@soleen.com, klarasmodin@gmail.com, corbet@lwn.net, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@android.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 87D1920007 X-Stat-Signature: 6gyotm91sc1zsejkrhdcps7ba81idih8 X-Rspam-User: X-HE-Tag: 1736803013-210921 X-HE-Meta: U2FsdGVkX1+wfNGNmTrBsoM7rkdnsVKhIu3YIVgjYunvm3CYKvdSA5z8ARFRpN95NDd7V1iOTmy+Ez8Xl1oftS2lKoahlQSV7LT5vyraYrtMJ8dMlJ0v4fcQ+ImNxwJ3XwOOCJX4wbdbxlawOOAKGqJi4eqV/cKYhp78SsC/cWMVTZvgOUN1W1GrjloaPK3j75z3jZ7ycWWEStjxPpn6x207viiYq88tHAQ/gxuVn+lPwCgCrQ/vWS+Y9+vzDi1JPraD7iud8pJ9x8INxl6wk8ixBSuEQ5sZ6K5MJ2vkAqEK+TofMB4LT30umFzD5BqpvZ+Qv4BxTh6gxw/9wtiynRdPhpL3cUd9pvlrDnTt3s0TPv5IIzJyQm/ACA98GpxpQFEEHGlfEgVpIN6zYuH7OKdg3sO5m2jHItjArs2zA7jWop5oEg2rka3YlnP2mb66rumupz3x8sqO95Ewlg1hGDdb5f5R9Pwimu8VK2vWWJLsiOwc6rjGORrAHry8ukRhmGwqf2mGLx0W+1hl7fhPNOMOb/H8jCwp9B4BV1IcgJdDm6aA7J05Y0C2LyX45XsMRoxcYG9ISOO9+L9LqCLUHjAa3tyyvrgDysyZiJM7U/4Cplsx8PouUaYt1MzXbOeL5EuBDZL39BCkl0nfSDh7QGYwxSvlb2c9qX1GA1HaeE6Vi7oQl0J8bDeB2tORI87i+Wa+74LhqktRRf0bJjfEzEH1/wGhio8U4in1LGMdOXSLc/0pT7UkE7ESMIbnpLdxIUHoebCwD0yeQ42Z7shdVk3zR3sjIwYeCkYrCVSGirOJNJcXhL/ulk8GxawBLoRchgGZDY56Jp+qe07ts60AGAy7vwEMGV5gCE29xQj3VBW+iTNr1JQY3p+vA0mtgUFP3JfEeTyx462fRH1HqXjkmZ7TEEs9aXIhiYOBIiPd5KfLJ6BPoZNHj/HEbBGm8kTD0Lk/rDdcLQ2nciOnXvW NgiSyYeo SvRxxPeVBDYVB/aZgQgI99QjpHGIvZW+HY/tTninwwR6pY/uxYc1qTXxtUSmkcaybKV41ox1LgigZRGaa3SFzeDWDjl0B+486D9686fFGN6xKFblsWoxnjnfbU+sep82ZxlbZLuoDAC7zY5VPSF6P/kU0afleUjF5JKQH3WYUTmj9hP9T6dZnAqYxDACJwpGTNw8XN8vXVVLVsBulbXK6Oo7Doj4WjffLdAYDtlH48wPdir3gWmjS1Bv9ILr9QV6JFo8Qi7cIoD8sOw6QQmm6clm7zO1UsMTC6SoXNpV7GQprlUeJ0uoapA3eZl0FmZhJiE6/m69FSwqNIbwMeSZPNgblGw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.008634, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Jan 12, 2025 at 6:38=E2=80=AFPM Wei Yang wrote: > > On Fri, Jan 10, 2025 at 08:25:58PM -0800, Suren Baghdasaryan wrote: > > static inline void vma_end_read(struct vm_area_struct *vma) {} > >@@ -908,12 +948,8 @@ static inline void vma_init(struct vm_area_struct *= vma, struct mm_struct *mm) > > vma->vm_mm =3D mm; > > vma->vm_ops =3D &vma_dummy_vm_ops; > > INIT_LIST_HEAD(&vma->anon_vma_chain); > >-#ifdef CONFIG_PER_VMA_LOCK > >- /* vma is not locked, can't use vma_mark_detached() */ > >- vma->detached =3D true; > >-#endif > > vma_numab_state_init(vma); > >- vma_lock_init(vma); > >+ vma_lock_init(vma, false); > > vma_init(vma, mm) > memset(vma, 0, sizeof(*vma)) > ... > vma_lock_init(vma, false); > > It looks the vm_refcnt must be reset. > > BTW, I don't figure out why we want to skip the reset of vm_refcnt. Is th= is > related to SLAB_TYPESAFE_BY_RCU? Earlier memset(vma, 0, sizeof(*vma)) already zeroes the entire structure, so vm_refcnt is already 0 and does not need to be reset again. > > > } > > > > -- > Wei Yang > Help you, Help me