From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4427C282D9 for ; Tue, 4 Mar 2025 18:35:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 433F46B0082; Tue, 4 Mar 2025 13:35:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3E4116B0083; Tue, 4 Mar 2025 13:35:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2ABEC6B0089; Tue, 4 Mar 2025 13:35:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 0DB6D6B0082 for ; Tue, 4 Mar 2025 13:35:27 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id B99C91204C1 for ; Tue, 4 Mar 2025 18:35:26 +0000 (UTC) X-FDA: 83184721452.15.D632BA1 Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) by imf14.hostedemail.com (Postfix) with ESMTP id C8160100008 for ; Tue, 4 Mar 2025 18:35:24 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=OHXkEcCA; spf=pass (imf14.hostedemail.com: domain of surenb@google.com designates 209.85.160.169 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741113324; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sE5nK4GFeJJ6OO4073CP21uOwPN4nuaYHAb6WJCLI3A=; b=BfQMNChzddZ0PJdW0ZMXi4is772k73ZLkLlpf3myKZ8toAzGSRIjn2m5vVc79kfYB6dxE7 A2RkD9Jn89SZktLiwFvdbpqDXwdRfH0WvD+Ci2b7kQcW7l90zhftLOQ3s4G5UkSATmq6TA Tdcbhy/Jom4JCam+s1ZIowXZHm++1Q4= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=OHXkEcCA; spf=pass (imf14.hostedemail.com: domain of surenb@google.com designates 209.85.160.169 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741113324; a=rsa-sha256; cv=none; b=3nvithOIvejHqLlsS5o7RYpV6C2EIVigKXCU98U9vvIsXN/mWzTzgIWKxB8H20CdVB/QP0 x9F180nDjRPhQu8Znm5ZKcEEJMetpEiqrCTUpGyhtAzLx7NKQZb41GKj1+h3qLFJ31sG5L 1iDnN44e+JVPcdDo2HpgGQX2+1qMcGo= Received: by mail-qt1-f169.google.com with SMTP id d75a77b69052e-474fdb3212aso26801cf.0 for ; Tue, 04 Mar 2025 10:35:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1741113324; x=1741718124; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=sE5nK4GFeJJ6OO4073CP21uOwPN4nuaYHAb6WJCLI3A=; b=OHXkEcCAxySAll84nVrgphbUjqu6b/VhryToRXZI/50I4DS7xK+yYFnhTcoBwrqKTN w2cmT66bxE5MaMcn4dONIaMhfPV5chMyWS7PBSERNUvB3VPyAyKfj+u2dRkh8outecfA +o7RN7OtMsRln9jTerLzOxDeqGjOo5jB0Q6L27b0aXBEHhq3h2Hdp20de/GY0VLIa+gd dPWujyrg4y92GFjREKqXkrHBY4LaKTzuYJbVsDtv8atgbrcSGr9AFmvsD5FFaJ8d06yu EB7iioErOVkun1jK3REoSlXFBu3ylTtSLs7eiXGANgIeoFMw90xQ0bDc0KsmHccHn8dZ YoZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741113324; x=1741718124; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sE5nK4GFeJJ6OO4073CP21uOwPN4nuaYHAb6WJCLI3A=; b=C3KME7v8o6IlhLzIucinji4TmVGKWs20IX5EROBu6FJlqu1mleNN6VwVkuUadS6+Q0 4nGJ2wSAZfjLkvY0+2shB8a/DjLnRwmCl+BzNZs3rDdyH90Q7xsSbhFIldFhVow9PGwg +PSW+jLM2ztVq1v/d142RBRYCBmaIJ+bmMcX3JxYlQ62BoBdNsbtuve16Seh8qC0eR6V i52h/ifNzH3IoACAOb2YE3SaRlyKP/GcqmL8FQtK0jbEHH41a+vyFunmYHIyNXiDhtok DE04MtmLUOLKFnoMxiJo83rCkHISg7w5HLNIvoC3hrKh4BoufvJzghi6HzQfmSQWf7E7 PC2Q== X-Forwarded-Encrypted: i=1; AJvYcCVvUKrvsaB3kQ8NCURvSUETrUY1sfVzhZVUPL3ZFAggqFQUShB/qG+OdOH2kD5uRWv4HN2vi4Stnw==@kvack.org X-Gm-Message-State: AOJu0YwjgkamqHpt2cBw3yT6ybks8i1NQjbSG3WILsuIRQ8IP1WkrkBD NEppIfhZbSOxJa8AM4rjPn9mPd9ySEIZKFBZQTLLociAY6z8Gm1SsETj+MhbzRFpdJTpKuO96nu 0+l71bHx2J6wvHTuMO1JO21OP++O2CdE1IE+e X-Gm-Gg: ASbGncvF4VQovr59j7Br4j9YarNXSSm3RBQNHdb3DXfqlh6wE9YFzqg1avnGc7j1JhC R+KjLGAVpzLzSZjo2ePJGphWQbggVuHwqKLNkgJ2P4JhaxTnRbcitNGVGKce+JN71tIC3iUXZnS lqT566HZhU6lVq4hQuYov/4pZqRG2+ymWDzpZHfBZf+PB2PJ6+NHKK/ols X-Google-Smtp-Source: AGHT+IE0ojfFK56Nsc3hks2mutUiZjNncnjFf0jJTwub5pXkrgW/XbWDNcjElNzyhKr+WIvjR4oqHA7Mz9eABlzihIM= X-Received: by 2002:ac8:5e49:0:b0:472:8ac:7d3d with SMTP id d75a77b69052e-4750a596138mr793651cf.29.1741113323385; Tue, 04 Mar 2025 10:35:23 -0800 (PST) MIME-Version: 1.0 References: <20250214-slub-percpu-caches-v2-0-88592ee0966a@suse.cz> <173d4dbe-399d-4330-944c-9689588f18e8@suse.cz> <19df9218-c984-4cbc-8b5d-4e0f7658935f@suse.cz> In-Reply-To: <19df9218-c984-4cbc-8b5d-4e0f7658935f@suse.cz> From: Suren Baghdasaryan Date: Tue, 4 Mar 2025 10:35:12 -0800 X-Gm-Features: AQ5f1JouTAVSQFXAmbLWqUnRspW1HmqjJwV-_XkDFpiV6uDsQZI3IuNVoE7yJ74 Message-ID: Subject: Re: [PATCH RFC v2 00/10] SLUB percpu sheaves To: Vlastimil Babka Cc: Kent Overstreet , "Liam R. Howlett" , Christoph Lameter , David Rientjes , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Uladzislau Rezki , linux-mm@kvack.org, linux-kernel@vger.kernel.org, rcu@vger.kernel.org, maple-tree@lists.infradead.org, Sebastian Andrzej Siewior , Alexei Starovoitov Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: wa4co7gomykpncshdo9e1otf8rmg8q7z X-Rspamd-Queue-Id: C8160100008 X-Rspamd-Server: rspam07 X-HE-Tag: 1741113324-378639 X-HE-Meta: U2FsdGVkX1/CMik9id061ZDxdVs7vVcVQcPkZ9oRv9Rl/r3UQmYHzV8pPqIvSamLJ7aNCyw+fBWcUDcJZWf+pdBJ0I8Y6xThJp7as++4ZTU3abQfYIbeBE4d84CbKMR8mN1Wm25rZQxk/mZpuhTz1D9W1916GGX4u+mRlBAK6wWeFskixPJYTS0B6tOjo8MdRLzCz7bmUjiJyWP29T+gNyLxHdofk9wovEYw/yxc2Ht2ttuUKShuuyPY8RLEqXLcDCXPxaPhIX2tl0vWzSh2If1bVsmMu2KGWl7JGrp/8DWItk3HHAg2JPTwMbZKaGPwOalUtena4FAktaUZEZMO34KWI1c2F+/PodFQpWErVe4gdS3XEHuHTGWl7BUeO0VmfX72atg0kRcJPG5w0MZGlnBGZqHxPG5rTToRBKIt+Et1aSSqaBJSqNWdsLPaLLZe1IXxrBwTnOKtE8Qfv/9UZfcqobiZuDWw+WKWbechJYPsjg15dgJG8k8xRWNI3MrJmonbnqXEB7yxD/pioCSRtbK2bPX70boJGfjCWPkDTeVJ+P6viBHv6mMJe00lkGhU+FkpX9QmE42/0vY+YbXAfDeNBK1uhdGOaHgHybAzFgpvC5NDdJpFz0XlHImIg7Ggb60TGaFuOie/HdvASeTgl9//pkHiTfknZMj0eVbp20TdrhwHPQPnkgqTS+hcsmdJJRfkD82jc7hh+eVqyzBIo4lZlDWAKVzMpKApn++n7+Dq7XjLJJL1RCgEkP4utgRitKIE3cVu7uPZ+lXNqz8exV9HWG1COw1DFgBEWBrclzaJCLy/0wy9UI/g6DLl5eNS44xUB1AzaAaH6wKj1JWwFcQjN4BfTB84cbxW8BSBdbycdiJ1NuA7gavbRXFuSeNQxMV242UhJeB4C4/CD53BRW1jIssFFMxFG3vvlrC4sDMcPWLjyO58JZZ01K1CLfbdOwUfV9gKIA2iMrh3r52 +nmAsfn3 c85TcQK6IRnIyYG7H9Otn+Y/YedaOCAU0m5DQOsgeYu5e3cXWS5kst1uqr7zJMCpO4PZ036/74DxShUYeBG99GWSZflwANEV78WZpHFgtHgMfdUjhZ3j0QDxBXeYwA6cnP59r4gMCwT2MOhPUHXiQ3AGZwhgo9YbNg9IpEGHrN+Ew9Pe0912aZ4dWZlUtIn8CagXFPvFW2J4JPUV0oiGtNgcNKezrNhiU3A+V5keqO4hM+KhAt5SNUEVL7TXj+EMlYrNkXmEAjGucYifSywJk98xb5jlDNbAS6ZBWYpiLLI4kEzBAhF8EJ8ewXw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000041, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 4, 2025 at 2:55=E2=80=AFAM Vlastimil Babka wro= te: > > On 2/25/25 21:26, Suren Baghdasaryan wrote: > > On Mon, Feb 24, 2025 at 1:12=E2=80=AFPM Suren Baghdasaryan wrote: > >> > >> > > >> > > The values represent the total time it took to perform mmap syscal= ls, less is > >> > > better. > >> > > > >> > > (1) baseline control > >> > > Little core 7.58327 6.614939 (-12.77%) > >> > > Medium core 2.125315 1.428702 (-32.78%) > >> > > Big core 0.514673 0.422948 (-17.82%) > >> > > > >> > > (2) baseline control > >> > > Little core 7.58327 5.141478 (-32.20%) > >> > > Medium core 2.125315 0.427692 (-79.88%) > >> > > Big core 0.514673 0.046642 (-90.94%) > >> > > > >> > > (3) baseline control > >> > > Little core 7.58327 4.779624 (-36.97%) > >> > > Medium core 2.125315 0.450368 (-78.81%) > >> > > Big core 0.514673 0.037776 (-92.66%) > > > > (4) baseline control > > Little core 7.58327 4.642977 (-38.77%) > > Medium core 2.125315 0.373692 (-82.42%) > > Big core 0.514673 0.043613 (-91.53%) > > > > I think the difference between (3) and (4) is noise. > > Thanks, > > Suren. > > Hi, as we discussed yesterday, it would be useful to set the baseline to > include everything before sheaves as that's already on the way to 6.15, s= o > we can see more clearly what sheaves do relative to that. So at this poin= t > it's the vma lock conversion including TYPESAFE_BY_RCU (that's not undone= , > thus like in scenario (4)), and benchmark the following: > > - baseline - vma locking conversion with TYPESAFE_BY_RCU > - baseline+maple tree node reduction from mm-unstable (Liam might point o= ut > which patches?) > - the above + this series + sheaves enabled for vm_area_struct cache > - the above + full maple node sheaves conversion [1] > - the above + the top-most patches from [1] that are optimizations with a > tradeoff (not clear win-win) so it would be good to know if they are usef= ul > > [1] currently the 4 commits here: > https://web.git.kernel.org/pub/scm/linux/kernel/git/vbabka/linux.git/log/= ?h=3Dslub-percpu-sheaves-v2-maple > from "maple_tree: Sheaf conversion" to "maple_tree: Clean up sheaf" > but as Liam noted, they won't cherry pick without conflict once maple tre= e > node reduction is backported, but he's working on a rebase > > Thanks in advance! Sure, I'll run the tests and post results sometime later this week. Thanks! > > >> > > > >> > > Results in (3) vs (2) indicate that using sheaves for vm_area_stru= ct > >> > > yields slightly better averages and I noticed that this was mostly= due > >> > > to sheaves results missing occasional spikes that worsened > >> > > TYPESAFE_BY_RCU averages (the results seemed more stable with > >> > > sheaves). > >> > > >> > Thanks a lot, that looks promising! > >> > >> Indeed, that looks better than I expected :) > >> Cheers! > >> > >> > > >> > > [1] https://lore.kernel.org/all/20250213224655.1680278-1-surenb@go= ogle.com/ > >> > > > >> > >