From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3115AC3ABDD for ; Mon, 19 May 2025 18:24:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 260DC6B0098; Mon, 19 May 2025 14:24:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 20ED36B00C2; Mon, 19 May 2025 14:24:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 089126B00D1; Mon, 19 May 2025 14:24:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id DF4956B00CF for ; Mon, 19 May 2025 14:24:38 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id EA281140D03 for ; Mon, 19 May 2025 18:24:38 +0000 (UTC) X-FDA: 83460483036.02.64942BD Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) by imf24.hostedemail.com (Postfix) with ESMTP id 05F1018000C for ; Mon, 19 May 2025 18:24:36 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=ZSrBvgk9; spf=pass (imf24.hostedemail.com: domain of surenb@google.com designates 209.85.160.180 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747679077; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=U8N/ZmrCvQlGj78v+Bsz84+vDvR8DInGIW7D3aPOmK0=; b=VH/T6clkUiUGBOMHD5Q5EAzymu9NOMMrY8WJxHXlc6Pt2pBIs3GLEr1b97yeEZnIBULrqW mzbftb467c8tVW70E2IcPTyUIrZu1SVLAP3aNqgXPJN9fvX/H/g9fND/mgQpg/vyhDFCHv xqneYYypaJ2ZYT5XlqTjKJqrF1WfBD0= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=ZSrBvgk9; spf=pass (imf24.hostedemail.com: domain of surenb@google.com designates 209.85.160.180 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747679077; a=rsa-sha256; cv=none; b=Q028kBFhJpdg0VjPzF9tb6P9Dr3V+m3uSpLkBQs97qmhSfBVtu3MSx7c3y+qaWns24pWIN 15W0Mp03UYMHLWyN6WOmXmVJ/UbdXBG9SgOggg0ID7p3Xy9rgsO2aau6QpgKW5C+p43d8i fARM5L8zpAVX/0RM80LhP8tgAJnLoKo= Received: by mail-qt1-f180.google.com with SMTP id d75a77b69052e-48b7747f881so712051cf.1 for ; Mon, 19 May 2025 11:24:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1747679076; x=1748283876; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=U8N/ZmrCvQlGj78v+Bsz84+vDvR8DInGIW7D3aPOmK0=; b=ZSrBvgk9Zarag9iONwzEmi1CXqHngFQLXrHWnaYVRcTHpcpOSM1OF7tSHoxN11zib3 ddiugpXVuFnDLGWZ/9TUByn6HeidZI0Qm9w1T5f8VuYlkHA/XGo7XMWDV5WP3RpJWghS kq/5esztO55MLgldCe8FgkalZ9QQClAj7mjpNlFXdtDRfeat6JHPdbTCAEHq4FqnZ7ja J8J+3+zU12p2YtGDg64SkAs6cjwn1lLB0lzkGe/tDnsON5UrML21hEebYQqxqCyrPKYn 164vWAE/fRrjfQWyHGBC/TCwff3fHqJtOWZnzLkND2MQ/OceX3kmoK9uCOSvVm/qssv+ zmZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747679076; x=1748283876; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=U8N/ZmrCvQlGj78v+Bsz84+vDvR8DInGIW7D3aPOmK0=; b=JmaYlVhKNnyYui54/Ln+CPU9hB7VNOX0cjr1VLeUwii7SoGvHFZBBDw3bNwMY0HZ+J 60kDflDP6CkbhPXRBk5gRsIm5zwaX38ZEKRnoHxRgq6B9TOtaDtB9U7TmSQiOGSe444S 1yZXE8dEmUsPcQ9cGDdiDFoQlNOGCIr4rKA2KXiBZ2wk9tER9kPPtOeMM3yO/txzx//0 vUzRf+Whjq51PAcQ5737xbnussoR1+2j46Gx6A0m/M6PyrU75F8dBT5EkIvK5YkEdUw2 jVXWdY4Kux7sJzs4kmgh7bdM12M1/dJUrEgkcdOVwW0pAMvelQB+712PuiFzydrASovL VNnQ== X-Forwarded-Encrypted: i=1; AJvYcCUi39GQ44gBR3c65Wdi3//OsPjVOdFJIEz5Gp3Q4YbrP7WEdGA/a3308tib12yki2/d03SJJOESvQ==@kvack.org X-Gm-Message-State: AOJu0YxAcHwqAtVn0/d5ryUozz1rSdmio4PphPrBWayVA7vEBNlqh4++ rGQBOaQ7BaY8yqywuR20jYm+/f9ZMTT2ukiM2uh1OjvTl0IL6Tdd+NoRMo/rSDzVhLBkQbzNa38 5om6emehvJHSvOwMJf65aLXGdbq91E1LQlyGq/8as X-Gm-Gg: ASbGncs7CIeU/GXFx1YmhNk5YXgbfDnS3/2GU7HdTRxtaJROAOEGKk85rHLv52c5rnY Y2CtA/6h/7gkrqdq0JkkPSWMiMA5qHSJyRdc9nrGdLuuehOIzJPoxJW7fOOZs/+AtE4IcnFQf5V vdvsvfjcNlaxrvK+e1iSj7Z4x2dh2bhF4= X-Google-Smtp-Source: AGHT+IHIwW4S8N4Hs8JzNW1vp8ji+sWK/cBVeQ94L+HT63szZ3uJ0oXXxgD6Mk3jYUFyZaXB7R64mUK/kn1b/LPHaEI= X-Received: by 2002:ac8:7f8c:0:b0:47d:9e7:91a4 with SMTP id d75a77b69052e-49601369e4emr6851921cf.27.1747679075710; Mon, 19 May 2025 11:24:35 -0700 (PDT) MIME-Version: 1.0 References: <20250429014754.1479118-1-Liam.Howlett@oracle.com> <056afddf-a933-493f-96ce-d801c5348059@oppo.com> In-Reply-To: <056afddf-a933-493f-96ce-d801c5348059@oppo.com> From: Suren Baghdasaryan Date: Mon, 19 May 2025 11:24:24 -0700 X-Gm-Features: AX0GCFviS3tGpfcEAdt_B7aBQrXvQCNqbL3NH4Q9gjbMuDy0Td-otR2s4oPr5k0 Message-ID: Subject: Re: [RFC PATCH v6.6] maple_tree: Fix MA_STATE_PREALLOC flag in mas_preallocate() To: Hailong Liu Cc: "Liam R. Howlett" , maple-tree@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Zhaoyang Huang , Lorenzo Stoakes , "zhangpeng . 00 @ bytedance . com" , Steve Kang , Matthew Wilcox , Sidhartha Kumar Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 05F1018000C X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: n3bdhb6bk73iosxuycuwg8sfdf6mozhh X-HE-Tag: 1747679076-342057 X-HE-Meta: U2FsdGVkX1+9w4WLolLyY9erSyxxf7/ocP+zuHe1deMlANJQhlpTWshrzqOUfTFzvaAOQPJfx+YcT4JhdCiJR7fUgvq5rNEk9ccvCL9KWmjaNzz4vE3luwvzkdPJy8bLNULawjcF1HPAx8+CZzCe32HZnXuUhd+ewuI+NaHyePTP3a8EHlSlmI4+g893daS6NGGMNlxww42ACI9TcNnTIyLLJxZkqxOL1/nSa0JjINRdzrpDaOTmzovyO2T/d+0/PVQ7eu1AVgL1k9LHFx784lAgKX4+vSDD6X0n4fAy/kKxvWxZlttLUKoBNZbtcBwdk0glvf6QQrG4Qop3gv0M6bWDCjQFmhQZSHit3Mb0LMK8ZlSfUyHtZcL7ewRbCh4WjUdNxiH4rnCQ9AEiEDSeeobj+jS6o7U/3FJ2OCymOCQZfjiQz9Q/LBCQlfz4hKQXXEgtqyz2yKSvulIjc5GmoiIzMgeNcCkHA3a5yqpBZKAJ/cSuiWMroeI3FrFr8lJBXwYBTXmKggGlpvectr+NY12xkCaZLc5raZuKke8N4JH6JDaGfzjlINOtRVmUJr96ISNpvBJ2xY+heJBFLdjceAJHzL0Tq2rXP8UMbEILn7Rif1YaacIVr07zv0q2SGUN25NSSU0M9/YUQkEh/lDUyWVORmtRqfckTfpVpB+6cduMiPehqzJ5gyxBHi9F1Ci0vL8jiFatFVOZ/kafe3fEt6pJsFaSoSydpbhGhQvQbH57YQYx3Jv7tGF04yqbpauc1GoPbk+cuHDR9OD3eDCd7QDVoY1/wOrBkbISuDVtocXtwI0A1mXOBQa2Q/rgcC1DvO1T9dQW32Agkv3rbfLk5Iso+/n5JrwQBC9i23SCsrrXTSfTGAwB/ge6Od6FU47juT5yFFVDrX/q+nkZS9R63OXzReFbuDoDrH1d558tvNrfWseqPBYkfEPzHkMLrTic4ITrSmqB2NlmbEpr6R3 eyUBaFFa AMD4xT2wi6Ij0OyAH6D6gn9DiJ2K3eH7kLTDMhpDXsReS+m9xlmXJIwihsE8222zbh3daN/+MMPGpVIxRPO9rYUmpuoHw9fXZKMTtX4b3fLJsuCOK1FZJeF8SmWOgcf2Edsb8x9dT3EAs2X4Zog4ZImrCMdsr46UQtvFKVcwD8JEhLFa5xamFwN44I0mzdtXkAVWtuwqbsv/JoLGgGqprw5OGDGe5mpsx21/FG8swCOJYpP40OqFTSENIJUv4Me5JNs9dzmZn+ykZTnOOQ4tXSlvUihaa03cHO1TdB0paPHLh0Gv/BFBOqBCoWY2NkkiXNSuZXiMTdbt03LruFdmrl/xBrVvPGxGDt3AuXDiAp0Q+9+IsWeHCQZv3Mcln3gaDyzusdTb3RZGlavviIt8fSGgr3/lwAJr7YfXXwPkDMNDcrlLbocDgsUxzmTIgJJqpog1RQly3RtinXYvjVVZ4kYivHruav7fJcpEP X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, May 18, 2025 at 8:24=E2=80=AFPM Hailong Liu = wrote: > > > > On 5/9/2025 11:27 PM, Suren Baghdasaryan wrote: > > On Wed, May 7, 2025 at 8:50=E2=80=AFAM Liam R. Howlett wrote: > >> > >> * Liam R. Howlett [250428 21:48]: > >>> Temporarily clear the preallocation flag when explicitly requesting > >>> allocations. Pre-existing allocations are already counted against th= e > >>> request through mas_node_count_gfp(), but the allocations will not > >>> happen if the MA_STATE_PREALLOC flag is set. This flag is meant to > >>> avoid re-allocating in bulk allocation mode, and to detect issues wit= h > >>> preallocation calculations. > >>> > >>> The MA_STATE_PREALLOC flag should also always be set on zero allocati= ons > >>> so that detection of underflow allocations will print a WARN_ON() dur= ing > >>> consumption. > >>> > >>> User visible effect of this flaw is a WARN_ON() followed by a null > >>> pointer dereference when subsequent requests for larger number of nod= es > >>> is ignored, such as the vma merge retry in mmap_region() caused by > >>> drivers altering the vma flags. > >>> > >>> Reported-by: Zhaoyang Huang > >>> Reported-by: Hailong Liu > >>> Fixes: 54a611b605901 ("Maple Tree: add new data structure") > >>> Link: https://lore.kernel.org/all/1652f7eb-a51b-4fee-8058-c73af63bacd= 1@oppo.com/ > >>> Link: https://lore.kernel.org/all/20250428184058.1416274-1-Liam.Howle= tt@oracle.com/ > >>> Cc: Lorenzo Stoakes > >>> Cc: Suren Baghdasaryan > >>> Cc: Hailong Liu > >>> Cc: zhangpeng.00@bytedance.com > >>> Cc: Steve Kang > >>> Cc: Matthew Wilcox > >>> Cc: Sidhartha Kumar > >>> Signed-off-by: Liam R. Howlett > >> > >> ... > >> > >> I have a version of this for mm-new and I'd like to send it out. Once > >> this is upstream, it will be backported to the stable kernels with > >> something that looks a lot like what I sent out here. > >> > >> Did this fix the issue in the longer running tests? > > > > - everyone else > > > > Hi Liam, > > I think the delay is due to the holidays in China. I requested an > > update from the partners but they will probably provide it next week. > Sorry for late reply. We applied this patch and verified it fix the issue= . > > Feel free to add > > Tested-by: Hailong Liu Thanks! Once Liam posts the official fix I'll apply it to the Android 6.6 branch. > > Thanks, > Hailong. > > > Thanks, > > Suren. > > > >> > >> Thanks, > >> Liam >