From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD9C3C3DA41 for ; Wed, 10 Jul 2024 16:07:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5C9FE6B0099; Wed, 10 Jul 2024 12:07:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 57A036B009A; Wed, 10 Jul 2024 12:07:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 441606B009B; Wed, 10 Jul 2024 12:07:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 235F86B0099 for ; Wed, 10 Jul 2024 12:07:47 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 8F8E48015F for ; Wed, 10 Jul 2024 16:07:46 +0000 (UTC) X-FDA: 82324323732.06.A2F91D3 Received: from mail-yw1-f174.google.com (mail-yw1-f174.google.com [209.85.128.174]) by imf09.hostedemail.com (Postfix) with ESMTP id B1B70140006 for ; Wed, 10 Jul 2024 16:07:44 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=N9wXA6Qe; spf=pass (imf09.hostedemail.com: domain of surenb@google.com designates 209.85.128.174 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720627649; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6IPWMNSHPG0jt5D2DB0oJLSOfyEu5ju1yz0tYHzAJRc=; b=Fco93qjJti+6c6IPUTAYsYemvlGo2yXZncL9uZdmcOmwLlmKka6cEC45bF4rza/IcN2md1 GLI5TAN8Fd/y6hfljEzYZteqfopgXVI2JJ3Mrm07eDmniQPHYuLi06M2YDbQ1gLKgSEQyZ ytbbCtw/4qQutw3iGziZlCsjcuTGXHQ= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=N9wXA6Qe; spf=pass (imf09.hostedemail.com: domain of surenb@google.com designates 209.85.128.174 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720627649; a=rsa-sha256; cv=none; b=AyifSo/gtjpmu4E/Cxgz+wcC/OSao37JxHw6BWHLw6FXX/PbORgLRlb6UYpFfXcZVDoVkD E4IVjEDIaDggQX59I9Qt6RDvcogiQqo0qUapI8OwkP7O6YD9ng0frR2gYn7KqKeAzHplXB yQcjpwBZUBjH8QPVOQePMq22UwxYfPY= Received: by mail-yw1-f174.google.com with SMTP id 00721157ae682-65240d22f7cso58038487b3.0 for ; Wed, 10 Jul 2024 09:07:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1720627664; x=1721232464; darn=kvack.org; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=6IPWMNSHPG0jt5D2DB0oJLSOfyEu5ju1yz0tYHzAJRc=; b=N9wXA6Qee1mZxLjCCq320ZhNwU1WV6BUeYIVFWbKS6Qm8sFv4rm3VpPEOQJ7TN3Ebk YUwQEJ3I64ymp9Esxym2nrSFtMvl6VjU8p4n2jPfzBXY5CzNDmz09WCvaiVtS+s7/90a 7MJt6AZRySLRgFgUTt3Qeerh6VvGI5PhaX82167nykk/uUsyKBa4wfpStHX3NgD4NE+F UlNAvWj/xlLDKWi08gy7Ljrc5U5D3xp3eNNsEcc1FfNWksA2uXSE//Uo8/14d8C6n/lS 6Ow6L1ohIK8KNLbalppTEZQBa3bP4fOroEfc0Jtipd2TW6kHwd3nLNxsxKOVROFZZyuF kytg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720627664; x=1721232464; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6IPWMNSHPG0jt5D2DB0oJLSOfyEu5ju1yz0tYHzAJRc=; b=q5eUhDVLoM9MtYaRGiHBPf16cRJ0q2CCdd6I1RJrYX9WFnFim1oA2Wh76xH60I/sJg kMB17eLMxkfIv3QXJy/8Q7XPY5Zu4+a3gTeTJG6Lo5omAtALCiFJ0R1mGJ416GAiNvEj 0CspceyMsTjl3RfvzANuGYL72Y2dsKeKK5Ztk18zRro1S6aVTfqUhBj2ZiDGrtsbqAIN zZJ8sG3zySztqOpNX6IvywtK6M385QBRWIN8+M1XRrRoI35/BfE61/DRVuulezpF5cq6 qizFxUT+IPYGTCBF0jUftqsZMPDXa5BMxhJTG7FQYudh8EtOg0StYTi3ZjDwWh4zrAMC jYrA== X-Forwarded-Encrypted: i=1; AJvYcCVOpyMEOlGSeS37F5eDu7gYvY2i1N6gmQ2lVVrkCWdzXJXOaKZw059CaRuwijoo9W1d51ts+hv9zhJDDYS3PmNtxLg= X-Gm-Message-State: AOJu0YyGZK6gxZJ1b1sWryQB4YJhY+Si965qz6m/kPNCNyz2A5EFwNsS NM2Nn640V4s24fpPJjklJsEpRuSmSRdh56FQPlR13mxuiwJHOqPAlyunHoWMB1PFrzgGQ0WT/ud 9w/ZF9z+Ka5PjYYPgFAIbRIix+Vmpj1vLPLkL X-Google-Smtp-Source: AGHT+IG95Ds1vL1Lxc6rxvpgc0LZ9RAvUdPaRPYzzaTXRLygP88EEhWnO7DJ1al0B8Jjc4ePUl7qyTWTQArnO/49JyM= X-Received: by 2002:a05:690c:3688:b0:650:82d0:c12c with SMTP id 00721157ae682-658eed5ea72mr67690917b3.19.1720627663451; Wed, 10 Jul 2024 09:07:43 -0700 (PDT) MIME-Version: 1.0 References: <20240704182718.2653918-1-Liam.Howlett@oracle.com> <20240704182718.2653918-7-Liam.Howlett@oracle.com> In-Reply-To: From: Suren Baghdasaryan Date: Wed, 10 Jul 2024 09:07:32 -0700 Message-ID: Subject: Re: [PATCH v3 06/16] mm/mmap: Change munmap to use vma_munmap_struct() for accounting and surrounding vmas To: "Liam R. Howlett" , Lorenzo Stoakes , linux-mm@kvack.org, Andrew Morton , Suren Baghdasaryan , Vlastimil Babka , Lorenzo Stoakes , Matthew Wilcox , sidhartha.kumar@oracle.com, "Paul E . McKenney" , Bert Karwatzki , Jiri Olsa , linux-kernel@vger.kernel.org, Kees Cook Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: B1B70140006 X-Stat-Signature: uwndghbrsejij3q3srthg8dwto4bujmk X-HE-Tag: 1720627664-184803 X-HE-Meta: U2FsdGVkX1/ziAEkRKBEKwzf+IJt2SUQYjNzsDJW6tiwh5ogQXwof9qrZfEALE1fUs1dvAp0TppCDZx9UEIKkTvTVZwx1GnAFdPneHIFVtSWhvDDHI1MBm4xgu4NJDO6+XB6u4dY+VJepqEX4lM1n7CvCAT2tj1hlPgvUS+4Z54db4dET0wAGPlxf51TC850svzDMn1uyUar8lCsAN0ABuIXrVGsbWWIx4Bsvv12sEn+2BqqdsL5G8QBXu49rdHR3Yad/H0m3eri1cXPBx23aPOoisGwxilElsZt+7NHPMFVU42dWdw8BtspbUl3xE8ONH/lFNw9uxyvz2/UkdoOU517MJk6VmPhKydynQ8UGBvHqA4dMtgOM5CXqSz46DsWqQX98+XKXVGK+wDu3Sn2aLQua2SGqxpEm3amwaSGHEW76NVe3pOLcn51FtioobZ8fuUHA+OcuRRtbvevaFt9VrBZi85qt+RH8T3uVGj4WSZf74+w9v41VSAzLpSd9tgBhcnNzvW+ZtscjCpGl93VlD2ZzDaOBPjfMahvTVbeSjyjVHSd6cpjpOdFSJOFRDcEUdHB/65JS+y0C7sfku3qkjF0Mq9xd+gD/2+7jdPNpGg+N50tH4UEhDodsIF79Zk68leuppTGxt86odMyU8YpSSjZKcesuc1mZA7O1TFU6O7p+hegEkpMNodMAtt6WSet//jL8jPwqYop+nE3uyZtpv+maZpS/0AYCLUiQix8sBESrTg/TA1U/0alm+PXP3oKNP5T+IsaPf4re72t8tHv4xf9LBLrETBXp1ISDmOlP03cB5AVitJHa5oW18BAesw7r/NnwuPT/WrZT7nEvv86WZ3KObl8xXsNKSLs/IFoXsFZtwV1X/4rYiUQ/Sn5/Ajg4mei5FYYsP5ZpxdnA8gmhgw2ZMNzOymf0Z/ycaBR2EFvizdVEhxSoKwcQx7sszOC1PHwe0FuYuTD7IJvxDr Lghn6wfM oyayDSSbDMp44RIGtQwHrmt5lB7xoZHTQEXLZVFxxll/lF///CdAvza1k3tGenjHAc3xiGVUKjH14Jv7z5faaoA/eq/0hmoXaknmusuVMkgPvu2VKLdyC3WJRTxVLl63sDHd6mqpn77fABTsLchSnq1zariRS96kknlVxPmk2ew188ItOHArw8UxksXKUwaSt6MxmCwysaJ4kjCy/XwBcxWwJc2MM3vqTwv+abqfN+xMoD2RIAUtv6/CHaphMjjw/DIJ9wnrh55JUOZk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jul 5, 2024 at 12:59=E2=80=AFPM Liam R. Howlett wrote: > > * Lorenzo Stoakes [240705 15:27]: > > On Thu, Jul 04, 2024 at 02:27:08PM GMT, Liam R. Howlett wrote: > > > Clean up the code by changing the munmap operation to use a structure > > > for the accounting and munmap variables. > > > > > > Since remove_mt() is only called in one location and the contents wil= l > > > be reduce to almost nothing. The remains of the function can be adde= d > > > to vms_complete_munmap_vmas(). > > > > > > Signed-off-by: Liam R. Howlett > > > --- > > > mm/internal.h | 6 ++++ > > > mm/mmap.c | 81 ++++++++++++++++++++++++++-----------------------= -- > > > 2 files changed, 47 insertions(+), 40 deletions(-) > > > > > > diff --git a/mm/internal.h b/mm/internal.h > > > index f1e6dea2efcf..8cbbbe7d40f3 100644 > > > --- a/mm/internal.h > > > +++ b/mm/internal.h > > > @@ -1488,12 +1488,18 @@ struct vma_munmap_struct { > > > struct vma_iterator *vmi; > > > struct mm_struct *mm; > > > struct vm_area_struct *vma; /* The first vma to munmap */ > > > + struct vm_area_struct *next; /* vma after the munmap area */ > > > + struct vm_area_struct *prev; /* vma before the munmap area */ > > > > I mean this is about as pedantic as it gets, and, admittedly an annoyin= g > > comment to make, but the ordering... can't we at least put prev before > > next? ;) > > I can do that, no problem. > ... > > > > > This is a big improvement overall, very fiddly code. > > > > Reviewed-by: Lorenzo Stoakes Reviewed-by: Suren Baghdasaryan > > Thanks!