From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 154ABC47DD9 for ; Wed, 27 Mar 2024 05:49:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7563E6B0089; Wed, 27 Mar 2024 01:49:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6E0396B008A; Wed, 27 Mar 2024 01:49:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 57FE06B0092; Wed, 27 Mar 2024 01:49:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 484486B0089 for ; Wed, 27 Mar 2024 01:49:25 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id DCA5B140664 for ; Wed, 27 Mar 2024 05:49:24 +0000 (UTC) X-FDA: 81941741448.12.56B1DC4 Received: from mail-yb1-f173.google.com (mail-yb1-f173.google.com [209.85.219.173]) by imf27.hostedemail.com (Postfix) with ESMTP id 3A9044001C for ; Wed, 27 Mar 2024 05:49:23 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=VOS1bepk; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf27.hostedemail.com: domain of surenb@google.com designates 209.85.219.173 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711518563; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=a8J0ZnV1oTFcgfb1JjEJGSxAfSvbJA4SNmT1mCPOXDA=; b=xiGhRjpFZJUWSKVQkiF2oqKgtQnujdzuCHdXCzTPtYNIwTLDVfNwfMh1fLFnbyHFRwR8Vq MaCrcqqjNVe5i8oXWyvnVSg8p+fblPIrfkRuFD38aekw0ITHjgpSfZYsDL//GOrrp3iz+s qCjUbV2t95L3IyAAMln2TnBfkmiD+AA= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=VOS1bepk; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf27.hostedemail.com: domain of surenb@google.com designates 209.85.219.173 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711518563; a=rsa-sha256; cv=none; b=lzNydLtX1bFFKsx9VX7hjI99SYAG+FSYZw7uBVOyf6RvLxCiYhah8zrIu3MmblfSYwFgRO ulINuPO/dnRGJeZRWYsQrT1n0SMf1VEuaUNG81ulvLMywz94ZCdRsj3vAJJ+otsV7d/VMy caipwo4vNbjdjsH5V4XkzG5ZGXn5AXs= Received: by mail-yb1-f173.google.com with SMTP id 3f1490d57ef6-dcd9e34430cso6560993276.1 for ; Tue, 26 Mar 2024 22:49:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1711518562; x=1712123362; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=a8J0ZnV1oTFcgfb1JjEJGSxAfSvbJA4SNmT1mCPOXDA=; b=VOS1bepk5cdr9X8cMLcIHLOmjphoDSrkSwzcmUv8eday77iEnwyCjDLPFNmMxJ5GGx fHfCP7sI+KW2sLUxVYAwsYb5bL6xAm3dOynJbKhgHNiskkzpn57byKs7TW8hj3wrcscp y0C156NRBijBoman9UPNf6B5WcYmU4OIyjhKM074JY2S7EmeBWHpVd3/NyJfzjcEPgQo sWNAz41MF0Mzdu+74Brrn+dJ66fkjA6No7GDtEnOVqiFvzxz/LbbwUQDJI6FpU0wvsGH Kc+xzg7PCe/fecSAov8YuusY1NGkhjNQQl+WARdE1C7WMQMKdu3jlyj//KAzaK/coXnc uKaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711518562; x=1712123362; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=a8J0ZnV1oTFcgfb1JjEJGSxAfSvbJA4SNmT1mCPOXDA=; b=bkJdEYD9hTbms8VTN0wN+kB6tIBPrHKNPVUiEwjgZQrIp8KHZZECcAtlT8g/X3du2e KspQ4UDpzccmUF3E+nca05mGhf1bNVN2V3r9J31dGS12nt7t07mAb8K+M2jIpvXmBav3 uwzdWy7ybc8kNqU53zNXMO93c1/KCdeUtS3rr9raGd9Y4WeBwsPynx5OfXJuUEM6PyO+ QTdCOyfufzkJG/IsUzgjj0ZInkJ6Qq3PgWjwM40Byrfx9/tRRYwKfpomYNrFqF7kPhiv rKUYtZy09iX3nFPfl0vBR/U2GObDP0EnKVJIBlfU5wS4dO9jJn0WpnzR3cSoO8EWRnHV DgCQ== X-Forwarded-Encrypted: i=1; AJvYcCVqbM3UaHDnrKX9fRmNP5SjlZ+IbpWsFLoWVEVKx/VvfyGNq0GF6oY3B1S6O8Ak7qZq/XVYn9ifROchL8Rrqv+m7sI= X-Gm-Message-State: AOJu0Yz/q6RHFCvjgfDNwpProMdC8kWQ65l6522vubsXFsTr3j8zgtPV YBdLfDR60yDpFHaif0pK1kqftMGV7UQle3Cthw0gM6vRW+QvL8zaCSaAC457YHqrAZ0GHaR8R3n Ix3+1yjgV3eibGebIcyINXqj6P+A4He7sgJIJ X-Google-Smtp-Source: AGHT+IHBhcynCtTcObE/TVj3lUWoUi2qzRWC8rT1WtVFzE4nYTXms+I4mGspk1m0zT4DQKpuscVRZupkC5QaFwvHxVs= X-Received: by 2002:a25:9388:0:b0:dc6:238e:d766 with SMTP id a8-20020a259388000000b00dc6238ed766mr2797003ybm.2.1711518562148; Tue, 26 Mar 2024 22:49:22 -0700 (PDT) MIME-Version: 1.0 References: <20240327044649.9199-1-rdunlap@infradead.org> In-Reply-To: <20240327044649.9199-1-rdunlap@infradead.org> From: Suren Baghdasaryan Date: Tue, 26 Mar 2024 22:49:11 -0700 Message-ID: Subject: Re: [PATCH] mm/slab: fix kcalloc() kernel-doc warnings To: Randy Dunlap Cc: linux-kernel@vger.kernel.org, Stephen Rothwell , Kent Overstreet , Vlastimil Babka , Andrew Morton , linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 3A9044001C X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: xgu9t8my55qje536swdczxag5uwwekq1 X-HE-Tag: 1711518563-352008 X-HE-Meta: U2FsdGVkX19nOgdw3CE9WAZBZwvYZfmF901SmyxItVZ48zhlMlTNSyrc4zt22tKUnafCMnjykOIemdWK+kmx2YDB9M+TLNbYDG/G4ePoEBEnXMTYshH+8W/8TiL7Pxf6LAZwxIk9a2CemWYVdkUVNohmJMK5yNfu26zfgVHBpDdlwhgLF0Kvo3z/JodUcbEdXLfjwdgX1b5WRdOntU6OyJldjV+A45mFc1V5+cIrPPCcoYkCyN0nbXyzdbJ36+S1OZeY2c9cJzeIH2wUbBYg66OE10BesT+lzzyFI+BXmUFYj4I57tToa2WTa4y9OwoVpUX92E4acGbWbFoSppZcJLJ7LiXwSKic9EZzHtrpCo+hTg6go7XHRgAn532Oxo7FTy4V0naaJ27x7ofQx3QV66y+E4u5YsqUakkkM8k/3QgEqQNk+EFdIjuKopUPWNwemeqlOIoJoHJFUk4mwJRH1qNTJn7ruS7mDJylY4VA/CFpxzYcAIjV2MC20aRlFYI1jJQQ7d2CPlNdHP+wK7+mxgBkxGwIrHKyDvoStYBNV5kaph9xgz3zHwVFexHfnRB5O/irekvIjTASzYETP57j3l39Hg8CaTe6pRhv4qcFqkKNuYWsROqPbeniw7Kzk9QIRxAH6tZa5crR8aLReeev7H0HZY0/JRzkSsrk+WNIPC+3d8RfjTQQjfJ07PtspusDYMfLKVTE+R25ZYjiP41aIDfcm2wxkglgFeFQE9NMbb2r+o+HjXY6w4YVEvxshAsXZOUZ8BfxrihMGN7S5kZ4acC/5ThDEzPGx+7nio9Vk5QsYmSAJFjpEK0Jz0Upc0aR69S2tlYjLliPDc5zi17YnJ6CQhijmE2jagFAa4Jk1bSkUUP607idPbvlvftVVRSUfyTJETqCQr6oUG32eNtoOQZBv7R5XIGlYReV8CflTvKP22buL8VghagXfcoZ8gkUwPMPLuW5wONZ8bEhHTR u+Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 26, 2024 at 9:46=E2=80=AFPM Randy Dunlap wrote: > > Fix the parameter names for kcalloc() in slab.h to prevent kernel-doc > warnings: > > include/linux/slab.h:730: warning: Function parameter or struct member '_= n' not described in 'kcalloc' > include/linux/slab.h:730: warning: Function parameter or struct member '_= size' not described in 'kcalloc' > include/linux/slab.h:730: warning: Function parameter or struct member '_= flags' not described in 'kcalloc' > include/linux/slab.h:730: warning: Excess function parameter 'n' descript= ion in 'kcalloc' > include/linux/slab.h:730: warning: Excess function parameter 'size' descr= iption in 'kcalloc' > include/linux/slab.h:730: warning: Excess function parameter 'flags' desc= ription in 'kcalloc' > > Fixes: bc7b83f5e4bf ("mm/slab: enable slab allocation tagging for kmalloc= and friends") > Signed-off-by: Randy Dunlap > Reported-by: Stephen Rothwell > Link: https://lore.kernel.org/linux-next/20240325123603.1bdd6588@canb.auu= g.org.au/ > Cc: Suren Baghdasaryan > Cc: Kent Overstreet > Cc: Vlastimil Babka > Cc: Andrew Morton > Cc: linux-mm@kvack.org Doh! I noticed these warnings but completely forgot to fix them in my fixup patchset :( Thanks for the fix! Tested-by: Suren Baghdasaryan > --- > include/linux/slab.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff -- a/include/linux/slab.h b/include/linux/slab.h > --- a/include/linux/slab.h > +++ b/include/linux/slab.h > @@ -727,7 +727,7 @@ static inline __realloc_size(2, 3) void > * @size: element size. > * @flags: the type of memory to allocate (see kmalloc). > */ > -#define kcalloc(_n, _size, _flags) kmalloc_array(_n, _size, = (_flags) | __GFP_ZERO) > +#define kcalloc(n, size, flags) kmalloc_array(n, size, (f= lags) | __GFP_ZERO) > > void *kmalloc_node_track_caller_noprof(size_t size, gfp_t flags, int nod= e, > unsigned long caller) __alloc_size(1);