From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B518CE77197 for ; Tue, 7 Jan 2025 17:14:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4D683900002; Tue, 7 Jan 2025 12:14:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4861A8D0001; Tue, 7 Jan 2025 12:14:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 377A8900002; Tue, 7 Jan 2025 12:14:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 19F8A8D0001 for ; Tue, 7 Jan 2025 12:14:05 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id C35681A0AA4 for ; Tue, 7 Jan 2025 17:14:04 +0000 (UTC) X-FDA: 82981303608.06.11EC459 Received: from mail-qt1-f175.google.com (mail-qt1-f175.google.com [209.85.160.175]) by imf13.hostedemail.com (Postfix) with ESMTP id E223C20002 for ; Tue, 7 Jan 2025 17:14:02 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=YJtbseUV; spf=pass (imf13.hostedemail.com: domain of surenb@google.com designates 209.85.160.175 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736270042; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yQAOTrU4VpoJco4k8RE54/hb5Tu2/1vtaB9nhBxcNBQ=; b=79eJ/L/e0gwSNNoVLGGgOdwn15b11eiyKwD3HKVCaDXWhqvMWqFtWRvP8Os8Y6Ibrg8A5w k9MMavgs8LNwTgVR98QMTRzzbS/cF/GHjFM5l8Gh8Kps2bQ0qTkoUzCiBZFliGumiNrQrx 6tTC8U36Qa4JqI1XUQSfEqMknX0OIDM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736270042; a=rsa-sha256; cv=none; b=LX1wd86Qf4GvV3hIV3lXVTeIJcYS9zxpvnPswZ1XJihxhlfwUbPXTZZrwnXanOnFuuzGjO Wp2hDZyecu4og/XVAl+WCjKNJikJX61H5bUgWyi8Hec7jJBXfLY+Fu/hj3Skz5iT4W8smX 2uKLBynxAlJ1f0UoC2ErE+4NT12/6hc= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=YJtbseUV; spf=pass (imf13.hostedemail.com: domain of surenb@google.com designates 209.85.160.175 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-qt1-f175.google.com with SMTP id d75a77b69052e-467896541e1so310001cf.0 for ; Tue, 07 Jan 2025 09:14:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1736270042; x=1736874842; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=yQAOTrU4VpoJco4k8RE54/hb5Tu2/1vtaB9nhBxcNBQ=; b=YJtbseUVxH25ajOM5QCasiDGpUpghXnp8vAcexCrt3akAjRH3v2ovf3IM0y7xAcMLZ 0iQH4gpPkrhGb92EyzgR+c8eBVyQ2FKEWzdDgKPt5MJ6/aDvftLov8HWG3wt0Kd+d1nM b2ynkmwnmCiE9lGGvk14m502d1iihL2Ee/7/Cn+tztU2ZepLT+IK7B1+wT64yE3ce4Cj 5kD6iOZbmki3kHTEZgbKoSGLtM5lpJiLjdDXBsdudRxFZm8GFvcN6BxZNNPrdIaDP2wp bDkXfOEfniujDcqoDKtMJLhkYdyByUqmN2Nz4+yn71tNsl+UsYKAVVqxjfipVqw0wrUn V9Uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736270042; x=1736874842; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yQAOTrU4VpoJco4k8RE54/hb5Tu2/1vtaB9nhBxcNBQ=; b=bOgaf/2oe1TlESIaJvBTJXyVw2IGvE/IKogwpOrZGfZVKvrSX9deysm9tusVdTA7ZC CUZOZH0ZvGDXnzYp3uSiv2Sb7Et3xfxA3aPhQC1kneXtvSXSiuceVjrI+V1l2IGsekP0 RVxp2NrR/O3taZKtcWBWXAYcfkVo8KbobVbqQ98yLK2Ko4n6v4m1Fsq83yfXWB4P/CSd pst8jl9Hb5GtLu+YsAUBzi7hKxYn8n4jAaJug772WJiXDd/on3Qq6SJ/8hFt2TMF4vaU fLh1lrh4fup2hwgjstTCb/J0jS5rOhi9JT7suQxNvI2YpTgROXZSSSBNBCFTBvWaBh/q PnoA== X-Forwarded-Encrypted: i=1; AJvYcCU4Ug0tQP/4PwTSDUNo/khbiMXfTr3IX2s6vnY/a47LS8NYP3Q3YBIcvDCTKWcsdsmFCTA+3ylirg==@kvack.org X-Gm-Message-State: AOJu0YxXVfGKM5yNXa6OFsOLonzU+hZknKzZ2biwi+ecNepw4NeR8bwc XbPX7dJ5ztqpZ86tmzLQ5Iu/MdGJ8CCsnpUAofjovuDS3QeshcH06Z8impUk5LG6JTODYRgGGZZ gvhnNVTUTHL5F9uIj0FvD/euNc16xSJZK/fim X-Gm-Gg: ASbGncvlyMKeCWLxUH9iUci6qUnBGsaQ3w9ieGmQWFsEjVyXhJoJoxMeXCaQ6OOcPfV mM9Gspe9NZrqIqjiSQ14uNEsrDzcWYe2CyMuKdjS0oQHCpK3ZrlkSA1kFklYc1JxE85VD X-Google-Smtp-Source: AGHT+IHqKp00BEUH8wMejBp+7U2R3Ste7wgeW3qNXS/trd4DacSk0s31gBWUyGKguqjnKqLZ6TbVFVuXstE7swYZeTM= X-Received: by 2002:a05:622a:413:b0:467:7c30:3446 with SMTP id d75a77b69052e-46b3c829c93mr3776531cf.25.1736270041673; Tue, 07 Jan 2025 09:14:01 -0800 (PST) MIME-Version: 1.0 References: <20241226170710.1159679-1-surenb@google.com> <20241226170710.1159679-6-surenb@google.com> <08a0d865-991b-48d1-adcc-f9184d708ff1@suse.cz> In-Reply-To: <08a0d865-991b-48d1-adcc-f9184d708ff1@suse.cz> From: Suren Baghdasaryan Date: Tue, 7 Jan 2025 09:13:49 -0800 X-Gm-Features: AbW1kvZj_yj1fsEGq_JzLlHHxGmKe4UXSUML8jbgll8VawTN1JL0_8tQzOg1esg Message-ID: Subject: Re: [PATCH v7 05/17] mm: mark vmas detached upon exit To: Vlastimil Babka Cc: akpm@linux-foundation.org, peterz@infradead.org, willy@infradead.org, liam.howlett@oracle.com, lorenzo.stoakes@oracle.com, mhocko@suse.com, hannes@cmpxchg.org, mjguzik@gmail.com, oliver.sang@intel.com, mgorman@techsingularity.net, david@redhat.com, peterx@redhat.com, oleg@redhat.com, dave@stgolabs.net, paulmck@kernel.org, brauner@kernel.org, dhowells@redhat.com, hdanton@sina.com, hughd@google.com, lokeshgidra@google.com, minchan@google.com, jannh@google.com, shakeel.butt@linux.dev, souravpanda@google.com, pasha.tatashin@soleen.com, klarasmodin@gmail.com, corbet@lwn.net, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@android.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: E223C20002 X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: x1dhs38rpi9wm4pduojrjx945gjp4ydp X-HE-Tag: 1736270042-413718 X-HE-Meta: U2FsdGVkX19CIBp/ZuZd5EcGbk6OoPHTsnvV7Jqm/iZQisG0p/Ajm4ySnPI3wX4+EHrTjz1DOmCMHj4Xq8vVYRMKgMLNOiUk/v9N5wGEr6ru3NjUEzilusYk+UA/QZ90lFIHnGFWpmCZmWS4OWqho7TiVRC8nSZoA4ozDhCi/Dewj9e8Q5Nz5UnCLnu/uLfWYy0Rkvx6WzaawjTr3CZhdlkcQ7wPDJFOdTn4Sa0K3c8RYO7IpMIlZ2bXgTrHr1odQPw/I3CrxZB2Ux6SD+2Eu122+wBcVGpi0cHnlv1FQRQh8rlN7M8lDHKJmzvOksc2lRYLL6wkEWiYNfRM5hloH/VofRHeYSHCsDbqjsw9f8L7QFrAc3YFSfGriJp2v4NdZD8h808VaCEc9hkFPRiIRy3aN0lDBRr27jge+bV0VLTjUuydhmDGHdj13UlSKhdb4f3D4n96IdVezrNMiBQ0NLfbqjC3W1E/lSyJgriwF73TDKxV4CO50ROzfVNKSPVWOMaRc88/6MYfXXzFqhCP7eza8B5eT7j5ktmuQkwrNzojLvf7h0qSd7j6WSWKrUODqsMWvcr8rVVzXf16xK5tu44ypcMn/LvNrPLL1Ajk/DmKJ7tFaQ97iYvT2iHTEJXdr9bMBdfkQliOjuQTbJbOmxfpT/ya0C31GC+egVUwfd4qhiFyja9zvysWd52qMKW0C9GIv0MjC8Sa/kHH4MhnVdGUykUt/o3lJWrCqwcoP3YSfXUhHpLU8TeF524oxiRpTwa9wKycigH+Bmf1ffRj6BJ3j5wUV5RnxkJa7/fnwCakmjFRIbjZ7J8kpmLsMOabr6JUd+D4Y/98UBhr3+pLBlP5qw1d6wr8vM3yF7KOTrTgEyyZuOuW3QdDGQQq4tRCrSqKR3Vmksanl/zMUiqR8uSWBaN42X7Rt5cCIeq1tkrDiTdw2TEwbrikEei51sacxv2KwyEnHLIAYEmenuJ NVln3ItQ cpf7ZHPz1GCPwxr/ni3Z92W0SrXAxGT9EYWTY4fSQ5x4RUqvQt9CmAiB8jfmSmKtKBhUi9YyyKFf7IGIIJX7njgq+IszjhMi36LVC/+JBMhLlEokIdjWKt/23oYmBm9F5g3gXIrNYJO2KzkbgwDxtvgSTpFj8ls2E7axXJF9QyDf+THGrEAbhfSb/5/1xL7FnPJBq7DQ6N1jLtuROjYs99SrU0+iEiHTHk37J X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jan 7, 2025 at 9:08=E2=80=AFAM Vlastimil Babka wro= te: > > On 12/26/24 18:06, Suren Baghdasaryan wrote: > > When exit_mmap() removes vmas belonging to an exiting task, it does not > > mark them as detached since they can't be reached by other tasks and th= ey > > will be freed shortly. Once we introduce vma reuse, all vmas will have = to > > be in detached state before they are freed to ensure vma when reused is > > in a consistent state. Add missing vma_mark_detached() before freeing t= he > > vma. > > > > Signed-off-by: Suren Baghdasaryan > > Reviewed-by: Vlastimil Babka > > > --- > > mm/vma.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/mm/vma.c b/mm/vma.c > > index ce113dd8c471..4a3deb6f9662 100644 > > --- a/mm/vma.c > > +++ b/mm/vma.c > > @@ -413,9 +413,10 @@ void remove_vma(struct vm_area_struct *vma, bool u= nreachable) > > if (vma->vm_file) > > fput(vma->vm_file); > > mpol_put(vma_policy(vma)); > > - if (unreachable) > > + if (unreachable) { > > + vma_mark_detached(vma); > > __vm_area_free(vma); > > - else > > + } else > > vm_area_free(vma); > > Nit: per style this should be { } too now. Thanks. Will fix it in the next version since I have to respin the series anyway. > > > } > > >