From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51751D5B149 for ; Mon, 28 Oct 2024 20:31:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D322E6B0096; Mon, 28 Oct 2024 16:31:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CE1E36B009D; Mon, 28 Oct 2024 16:31:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B5A906B00A2; Mon, 28 Oct 2024 16:31:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 8F0826B0096 for ; Mon, 28 Oct 2024 16:31:35 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 3A5F91A027A for ; Mon, 28 Oct 2024 20:31:35 +0000 (UTC) X-FDA: 82724155500.08.A366639 Received: from mail-qt1-f178.google.com (mail-qt1-f178.google.com [209.85.160.178]) by imf20.hostedemail.com (Postfix) with ESMTP id 035A71C0028 for ; Mon, 28 Oct 2024 20:31:03 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=oda8NUoP; spf=pass (imf20.hostedemail.com: domain of surenb@google.com designates 209.85.160.178 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730147413; a=rsa-sha256; cv=none; b=IsTkyi8DAz0V4WM+Vx64YD/yRoNOhswK+QW9s5dShojsyz0IEslhlxCQFwSj3WCHSZKoHs oTcKC0rXr3Vp0PrxjINUv96Enul3zpgg9ZHfWZJErkSje3Qwp+f6i5BuCDsI//1ag49NlA M9pMuwjoC9uIC0iuCmj1UhPGQTeqNQg= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=oda8NUoP; spf=pass (imf20.hostedemail.com: domain of surenb@google.com designates 209.85.160.178 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730147413; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GF9szpIXKk0pyaUuLvU1W3Er0NYdTC6TQkwxbtHT3qA=; b=KyQxtg1yVwFlNrea6rDHQ0O2gVJTCqPeEamPteQmITulcRevgvOssLSIc8y+VfQvlveDmt 4DnqANJn8k2K5UY+OG94R6/Lmzr3Y9knoyWLWFmkDzHf18G3VFGc1SUpjfyHUd01bQCpvE H2TkqnMcgMRen9SR/F0kaqCH30C7aq8= Received: by mail-qt1-f178.google.com with SMTP id d75a77b69052e-460b295b9eeso11101cf.1 for ; Mon, 28 Oct 2024 13:31:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1730147492; x=1730752292; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=GF9szpIXKk0pyaUuLvU1W3Er0NYdTC6TQkwxbtHT3qA=; b=oda8NUoPzTi22eJSeK+43KS/tyaDzuZpVIbMiTXRA1dvnkjgVJsPQOA/iAlM+VuO7M EC+S8fpdqe15fxdBVB6wvi+7V8oQ1K6gA2qOJKzxuG+xUTc0Je2wIDNcvJXaOg/UIZ+U uoJpX5nosBXjEnAz5Y7uONYFvKH2nLo7uO+xrVfbp0peUHU+TFrGZiDpHJ7GRRNGRVLa YOmmU4kJMkpBiyTimGR47jgVkjrgkPgLJTBmm7OQzQ1kSgIx7n/3BiZXw9F5xcc9d9/i 504k9sAdpCr8EvpaVDgUfvjvEAhfwY8/KCsHH5JaJHiIb0D5RUXC4KKe0E2Z7Mq65LtZ YBKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730147492; x=1730752292; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GF9szpIXKk0pyaUuLvU1W3Er0NYdTC6TQkwxbtHT3qA=; b=IinfafQ8KztWHzMcAi26Ru+4lVRBtjXTjj93l+Sb14lUDkd59PqugdyQLoX/ijCqeR HcTXcWPZNSCPF4J5qSdFXt3bGyYm0QZ8qLqhSk5rchAo/RHYXU3qMvRryIfkTnIF/7c4 TXaHVp+auySs90hLW5BE4zEEEWIMC+s6kv1WJySFm1DeSw0fljpoKe1n0ReGuSOk9ePh xAvCyIxZE2GVo+ED7YditlC9qusyDN0Y9oFYtKVzN5IFvOtGtG6DyMBu85py8AYDBnFe KvJnivOggSjSyVa0GqDsjgMu6LLF10N2Tz9IYeC0F5eAZktiesr+OK0Jj5/zjfMTqMhu 3p+w== X-Forwarded-Encrypted: i=1; AJvYcCWinj77+noGQ4uJY2E5BxL0WeZGR5tOd2wdTScOPixVzUC+qznE4LQMybTseOEEi+qG/N/904df2w==@kvack.org X-Gm-Message-State: AOJu0YytlNyGhrv0DG3ITIhib4KE6mH3ngY4qwqmIF5vDOXh5wPK6ezu 579Mj/eCpIuFzBjcvJtvOMrxfL3cPXEJ0hdTCoK5WOHAalrOoDjlWXGREXjzdVwV5tLZN2w7cVd DVgVONWnzH03XnViioqfpIfJdQ1rTzQd9X1KJ X-Google-Smtp-Source: AGHT+IH6yxdE5IoaMRqlwrn/esRQWarNZbvXXwHdwnnJHhhuSxHtnyb3KLF9645D/axo9a50SE4ORUKnduqqGEtVX+M= X-Received: by 2002:ac8:5f8e:0:b0:461:4467:14c7 with SMTP id d75a77b69052e-46164d96892mr897831cf.0.1730147492009; Mon, 28 Oct 2024 13:31:32 -0700 (PDT) MIME-Version: 1.0 References: <20241028150355.2574425-1-arnd@kernel.org> In-Reply-To: From: Suren Baghdasaryan Date: Mon, 28 Oct 2024 13:31:19 -0700 Message-ID: Subject: Re: [PATCH] [v2] alloc_tag: hide execmem_vmap() on !MMU To: Arnd Bergmann Cc: Andrew Morton , Pasha Tatashin , Arnd Bergmann , Mike Rapoport , Luis Chamberlain , Song Liu , "Masami Hiramatsu (Google)" , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: ru6g7m4umitnzmo6wxh645p6ozj9igbi X-Rspamd-Queue-Id: 035A71C0028 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1730147463-980820 X-HE-Meta: U2FsdGVkX19StWjqGMogWmqDYPCUIdzexYJSpKuAYrQbsQGsSbbYT/rR2RiQP0F3A88ItmHOjeEgWhBYvCTeWDGMfQuGSBf0siRS06lVEfceS3g+gzuBQDZgMMVLR8eoWJlJSVEjaYPzZYduMdyUEEIH8c2s28wRx8uKQWUdwZ0FVLtlD8hHxrj/vV1QiNCxnaARbqDDTtXHLCZMsn0GrPokF6ggGBdf6CA3AZ2EbMsdl8lGIH7vuXpIy79/pOy+ieVRIHWjgCsYRrDCcuzhdOmFz5UPUeJDRb1NtlQofMab2NgaPQRvrSquxO4usOu7yFS6APstjEAdCFnkNd93MFPenrJOTFgj6tt4w7Ht2/drw8F/STFJLzEbAHCbuMnpbFtEBLgrjOeqj0i+Rg6lkPHraE7rvG9t6Jy3XxbbBd+ph/d4Tj/N8jtu7s2n8UJzDQQ8lzgaopEURQ56FCxZ3fhOUwkXFXSR4lm4jjTo/Rmzx203Z1tsNdrVyO0IFTxYebGBMiHtySeLAYceTDdqaoTTA1x7mUPuthhx3rvb12Wxje/FNh4Qqxf6QmnP5RZoLx7G9k3xKSHYZIAQDThPvpgu74wxkAF0N33fUAWHGbACW9mgULHvkHAVsCZ9MA6s5lPLLtoPKzT3DO1gSLdsZCGP59e4lCdPsOwzpmhd5cqQdm+zqS505gaojST6TS0gIZx81kYNd2gZFSbe9voRHwj0mBVd2yEbBOrqpwgy1BWe4YQRmi8a8nk51tfYYebl80tll3QSFfPW8zkEU7I//0scTC4lEbaEcVzlgPvpckuBtIEfMMpC/bqq97J+bbLXXQav1Wf0ajdqr7g4t6bU2e1C5Yfz7nbp5waOTSS2yH3GCJcpmwovn++Sr2JFFv6zTFazvCNdFM4My/VssustsyWvt4h750+LaU7MhnxrknVx8p/7AD+CZXJzwmUr8ktZEbUZ2hdrA9Tj0Z1UcFg nEEpPIcI XpN3XD3tBTENUbSk1z1mQoDughLxW08QaWkjbM4END2PfpDtoyBLu8zye9+WNi3RrigY84XnG6ic0FmZr37E6TABcq0gO3JxzJM2Mm6WxY6jxjMX0ZyEJ5bqq/9L9KRm4275da4mx9rlxzjlywbv6JQf2SqLDCreNRPM1wLC8VnXxjgcrQp6E9axR73cFpZAAwWbnEdJBEcx5Fm2uCwB1be76u21jjOI3wfjomcSclXhOG5hit3DpGbRkXIoIXmtw/DJHfkbU04kpFCTBUDncK3h9JtYEb4noFQyYJAM8l++uKV1kgMppbJEtdvdap0FBrO4G4z67TV7k4Gs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.024934, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Oct 28, 2024 at 11:53=E2=80=AFAM Suren Baghdasaryan wrote: > > On Mon, Oct 28, 2024 at 8:04=E2=80=AFAM Arnd Bergmann w= rote: > > > > From: Arnd Bergmann > > > > The newly added function fails to link on nommu kernels, but is also > > not needed there: > > > > ld.lld-20: error: undefined symbol: __get_vm_area_node > > >>> referenced by execmem.c > > >>> mm/execmem.o:(execmem_vmap) in archive vmlinux.a > > >>> referenced by execmem.c > > >>> mm/execmem.o:(execmem_vmap) in archive vmlinux.a > > > > Move it into the #ifdef block along with execmem_vmalloc(). > > > > Fixes: 57bc3834fb6f ("alloc_tag: populate memory for module tags as nee= ded") > > Acked-by: Mike Rapoport (Microsoft) > > Signed-off-by: Arnd Bergmann > > Sorry, replied to your older version. Copying here: > > Thanks for the fix but execmem_vmap() is used if > CONFIG_MEM_ALLOC_PROFILING=3Dy. Please give me an hour to post a fix > dealing with that. The fix that will work with CONFIG_MEM_ALLOC_PROFILING is posted at https://lore.kernel.org/all/20241028202935.1047017-1-surenb@google.com/ > > > --- > > mm/execmem.c | 32 ++++++++++++++++---------------- > > 1 file changed, 16 insertions(+), 16 deletions(-) > > > > diff --git a/mm/execmem.c b/mm/execmem.c > > index 5c0f9f2d6f83..317b6a8d35be 100644 > > --- a/mm/execmem.c > > +++ b/mm/execmem.c > > @@ -64,6 +64,22 @@ static void *execmem_vmalloc(struct execmem_range *r= ange, size_t size, > > > > return p; > > } > > + > > +struct vm_struct *execmem_vmap(size_t size) > > +{ > > + struct execmem_range *range =3D &execmem_info->ranges[EXECMEM_M= ODULE_DATA]; > > + struct vm_struct *area; > > + > > + area =3D __get_vm_area_node(size, range->alignment, PAGE_SHIFT,= VM_ALLOC, > > + range->start, range->end, NUMA_NO_NOD= E, > > + GFP_KERNEL, __builtin_return_address(= 0)); > > + if (!area && range->fallback_start) > > + area =3D __get_vm_area_node(size, range->alignment, PAG= E_SHIFT, VM_ALLOC, > > + range->fallback_start, range-= >fallback_end, > > + NUMA_NO_NODE, GFP_KERNEL, __b= uiltin_return_address(0)); > > + > > + return area; > > +} > > #else > > static void *execmem_vmalloc(struct execmem_range *range, size_t size, > > pgprot_t pgprot, unsigned long vm_flags) > > @@ -368,22 +384,6 @@ void execmem_free(void *ptr) > > vfree(ptr); > > } > > > > -struct vm_struct *execmem_vmap(size_t size) > > -{ > > - struct execmem_range *range =3D &execmem_info->ranges[EXECMEM_M= ODULE_DATA]; > > - struct vm_struct *area; > > - > > - area =3D __get_vm_area_node(size, range->alignment, PAGE_SHIFT,= VM_ALLOC, > > - range->start, range->end, NUMA_NO_NOD= E, > > - GFP_KERNEL, __builtin_return_address(= 0)); > > - if (!area && range->fallback_start) > > - area =3D __get_vm_area_node(size, range->alignment, PAG= E_SHIFT, VM_ALLOC, > > - range->fallback_start, range-= >fallback_end, > > - NUMA_NO_NODE, GFP_KERNEL, __b= uiltin_return_address(0)); > > - > > - return area; > > -} > > - > > void *execmem_update_copy(void *dst, const void *src, size_t size) > > { > > return text_poke_copy(dst, src, size); > > -- > > 2.39.5 > >